Skip to contentSkip to conversation

mmc: android-goldfish: remove unnecessary platform_set_drvdata()

PATCH In review Jingoo Han 2 participants 2 messages May 6, 2013 – May 26, 2013 MMC, SD and SDIO

lore
Share & tools
lore

Jingoo Han

author
#0 lore raw

PATCH 1/22 mmc: android-goldfish: remove unnecessary platform_set_drvdata()

The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.

Signed-off-by Jingoo Han <[email protected]>
---
 drivers/mmc/host/android-goldfish.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
drivers/mmc/host/android-goldfish.c +0 -2
index 7780c14..8b4e20a 100644
@@ -546,8 +546,6 @@ static int goldfish_mmc_remove(struct platform_device *pdev)
 {
 	struct goldfish_mmc_host *host = platform_get_drvdata(pdev);
 
-	platform_set_drvdata(pdev, NULL);
-
 	BUG_ON(host == NULL);
 
 	mmc_remove_host(host->mmc);
Signature · 1 line
1.7.2.5
#1 lore raw

Hi Jingoo,

Quoted 15 lines · Jingoo Han

The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.

Signed-off-by Jingoo Han <[email protected]>
---
 drivers/mmc/host/android-goldfish.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
drivers/mmc/host/android-goldfish.c +0 -0
index 7780c14..8b4e20a 100644

drivers/mmc/host/android-goldfish.c static int goldfish_mmc_remove(struct platform_device *pdev) · line 551

Quoted 8 lines
drivers/mmc/host/android-goldfish.c +0 -2
@@ -546,8 +546,6 @@ static int goldfish_mmc_remove(struct platform_device *pdev)
 {
 	struct goldfish_mmc_host *host = platform_get_drvdata(pdev);
 
-	platform_set_drvdata(pdev, NULL);
-
 	BUG_ON(host == NULL);
 
 	mmc_remove_host(host->mmc);

Thanks. I squashed everything down into one patch, collated the ACKs and added them, and pushed it to mmc-next for 3.11.

- Chris.

Signature · 2 lines
Chris Ball   <[email protected]>   <http://printf.net/>
One Laptop Per Child