Skip to contentSkip to conversation

Microblaze - board ml401 - 3

U-Boot-Users Michal Simek 2 participants 2 messages Jun 15, 2006 – Oct 8, 2006

lore
Share & tools
lore
#1 lore raw

[U-Boot-Users] Microblaze - board ml401 - 1...13

Dear Michal,

I've tried to add your patches, but failed because they contain corrupted data. I'm sorry, but I have to reject your patches; please clean up and resubmit. The main reason for this reject is corrupted patches in "Microblaze - board ml401 - 7": this announces a new file of 46 lines:

	--- u-boot-2006-05-10-1800/cpu/microblaze/microblaze_disable_interrupts.S 1970-01-01 01:00:00.000000000 +0100
	+++ u-boot-2006-05-10-1800-microblaze/cpu/microblaze/microblaze_disable_interrupts.S 2006-06-15 21:05:41.000000000 +0200
	@@ -0,0 +1,46 @@
	...

but then has only 38 lines of data. Patch part # 9 is broken, too.

Please clean up and resubmit.

Please also re-check all your code; I spotted at least the following places that seem wrong to me:

Patch part # 3:

Quoted 2 lines

CHANGELOG:
* Added board info for Microblaze

I think that should be

#elif defined(CONFIG_MICROBLAZE)

instead of just MICROBLAZE.

Also, the code is too verbose and does not compile (code before declarations).

Patch part # 4:

Quoted 2 lines

CHANGELOG:
* Added treatment exception for Microblaze

I think the exception handling is broken. It will always complain about unaligned accesses even if this seems not to be the case. Please check (and fix) the code!

Patch part # 7:

Quoted 2 lines

CHANGELOG:
* Added low level interrupt handler rutine for Microblaze

Patch corrupted.

Patch # 9:

Quoted 2 lines

CHANGELOG:
* Added support for ml401 to Makefile, Makefile for Microblaze cpu

Patch cannot be applied to your own cpu/microblaze/Makefile file

Please also clean up Coding Style violations (trailing white space, C++ comments, indentation not by TAB etc.).

Best regards,

Wolfgang Denk

Signature · 3 lines
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
God made the integers; all else is the work of Man.       - Kronecker