Skip to contentSkip to conversation

ARM: S5PV210: Add Torbreck board support

PATCH New Kyuho Choi 3 participants 7 messages Sep 26, 2010 – Sep 28, 2010

Subsystems (3)
lore
Share & tools
lore

Kyuho Choi

author
#0 lore raw

PATCH 1/1 ARM: S5PV210: Add Torbreck board support

This patch adds to support Torbreck board of aESOP community using Samsung S5PV210 SoC.

---
 arch/arm/mach-s5pv210/Kconfig         |   18 +++++
 arch/arm/mach-s5pv210/Makefile        |    1 +
 arch/arm/mach-s5pv210/mach-torbreck.c |  133 +++++++++++++++++++++++++++++++++
 3 files changed, 152 insertions(+), 0 deletions(-)
 create mode 100644 arch/arm/mach-s5pv210/mach-torbreck.c
arch/arm/mach-s5pv210/Kconfig +18 -0
index d3a3895..c5ec466 100644
@@ -139,6 +139,24 @@ config MACH_SMDKV210
 	help
 	  Machine support for Samsung SMDKV210
 
+config MACH_TORBRECK
+	bool "Torbreck"
+	select CPU_S5PV210
+	select ARCH_SPARSEMEM_ENABLE
+	select S3C_DEV_HSMMC
+	select S3C_DEV_HSMMC1
+	select S3C_DEV_HSMMC2
+	select S3C_DEV_HSMMC3
+	select S3C_DEV_I2C1
+	select S3C_DEV_I2C2
+	select S3C_DEV_RTC
+	select S3C_DEV_WDT
+	select S5PV210_SETUP_I2C1
+	select S5PV210_SETUP_I2C2
+	select S5PV210_SETUP_SDHCI
+	help
+	  Machine support for aESOP Torbreck
+
 endmenu
 
 endif
arch/arm/mach-s5pv210/Makefile +1 -0
index 05048c5..927c2b7 100644
@@ -21,6 +21,7 @@ obj-$(CONFIG_MACH_AQUILA)	+= mach-aquila.o
 obj-$(CONFIG_MACH_SMDKV210)	+= mach-smdkv210.o
 obj-$(CONFIG_MACH_SMDKC110)	+= mach-smdkc110.o
 obj-$(CONFIG_MACH_GONI)		+= mach-goni.o
+obj-$(CONFIG_MACH_TORBRECK)	+= mach-torbreck.o
 
 # device support
 
arch/arm/mach-s5pv210/mach-torbreck.c new file +133 -0

133 lines not on this page · raw message

Signature · 1 line
1.5.6.3
#1 lore raw

PATCH 1/1 ARM: S5PV210: Add Torbreck board support

Hi,

Looks good to me except minor fixup.

Quoted 29 lines · Kyuho Choi

This patch adds to support Torbreck board of aESOP community using Samsung S5PV210 SoC.

---

?arch/arm/mach-s5pv210/Kconfig ? ? ? ? | ? 18 +++++
?arch/arm/mach-s5pv210/Makefile ? ? ? ?| ? ?1 +
?arch/arm/mach-s5pv210/mach-torbreck.c | ?133 +++++++++++++++++++++++++++++++++

?3 files changed, 152 insertions(+), 0 deletions(-) ?create mode 100644 arch/arm/mach-s5pv210/mach-torbreck.c

arch/arm/mach-s5pv210/Kconfig +0 -0
index d3a3895..c5ec466 100644
@@ -139,6 +139,24 @@ config MACH_SMDKV210

? ? ? ?help
? ? ? ? ?Machine support for Samsung SMDKV210

+config MACH_TORBRECK
+ ? ? ? bool "Torbreck"
+ ? ? ? select CPU_S5PV210
+ ? ? ? select ARCH_SPARSEMEM_ENABLE
+ ? ? ? select S3C_DEV_HSMMC
+ ? ? ? select S3C_DEV_HSMMC1
+ ? ? ? select S3C_DEV_HSMMC2
+ ? ? ? select S3C_DEV_HSMMC3
+ ? ? ? select S3C_DEV_I2C1

Quoted 8 lines

+ ? ? ? select S3C_DEV_I2C2
+ ? ? ? select S3C_DEV_RTC
+ ? ? ? select S3C_DEV_WDT
+ ? ? ? select S5PV210_SETUP_I2C1
+ ? ? ? select S5PV210_SETUP_I2C2
+ ? ? ? select S5PV210_SETUP_SDHCI
+ ? ? ? help
+ ? ? ? ? Machine support for aESOP Torbreck

Just question. Does it TDROID board?

Quoted 55 lines

+
?endmenu

?endif

arch/arm/mach-s5pv210/Makefile +0 -0
index 05048c5..927c2b7 100644
@@ -21,6 +21,7 @@ obj-$(CONFIG_MACH_AQUILA) ? ? += mach-aquila.o

?obj-$(CONFIG_MACH_SMDKV210) ? ?+= mach-smdkv210.o ?obj-$(CONFIG_MACH_SMDKC110) ? ?+= mach-smdkc110.o ?obj-$(CONFIG_MACH_GONI) ? ? ? ? ? ? ? ?+= mach-goni.o +obj-$(CONFIG_MACH_TORBRECK) ? ?+= mach-torbreck.o

?# device support

arch/arm/mach-s5pv210/mach-torbreck.c new file +33 -0
new file mode 100644
index 0000000..3142250
@@ -0,0 +1,133 @@
+/* linux/arch/arm/mach-s5pv210/mach-torbreck.c
+ *
+ * Copyright (c) 2010 aESOP Community
+ * ? ? ? ? ? ? http://www.aesop.or.kr/
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+*/
+
+#include <linux/kernel.h>
+#include <linux/types.h>
+#include <linux/i2c.h>
+#include <linux/init.h>
+#include <linux/serial_core.h>
+
+#include <asm/mach/arch.h>
+#include <asm/mach/map.h>
+#include <asm/setup.h>
+#include <asm/mach-types.h>
+
+#include <mach/map.h>
+#include <mach/regs-clock.h>
+
+#include <plat/regs-serial.h>
+#include <plat/s5pv210.h>
+#include <plat/devs.h>
+#include <plat/cpu.h>
+#include <plat/iic.h>
+
+/* Following are default values for UCON, ULCON and UFCON UART registers */
+#define TORBRECK_UCON_DEFAULT ?(S3C2410_UCON_TXILEVEL | ? ? ? ?\
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?S3C2410_UCON_RXILEVEL | ? ? ? ?\

arch/arm/mach-s5pv210/mach-torbreck.c line 43

Quoted 10 lines
arch/arm/mach-s5pv210/mach-torbreck.c new file +10 -0
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?S3C2410_UCON_TXIRQMODE | ? ? ? \
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?S3C2410_UCON_RXIRQMODE | ? ? ? \
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?S3C2410_UCON_RXFIFO_TOI | ? ? ?\
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?S3C2443_UCON_RXERR_IRQEN)
+
+#define TORBRECK_ULCON_DEFAULT S3C2410_LCON_CS8
+
+#define TORBRECK_UFCON_DEFAULT (S3C2410_UFCON_FIFOMODE | ? ? ? \
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?S5PV210_UFCON_TXTRIG4 | ? ? ? ?\
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?S5PV210_UFCON_RXTRIG4)

Any reason to use TRIG4? just use the full trigger e.g., 256.

arch/arm/mach-s5pv210/mach-torbreck.c line 48

Quoted 5 lines
arch/arm/mach-s5pv210/mach-torbreck.c new file +5 -0
+
+static struct s3c2410_uartcfg torbreck_uartcfgs[] __initdata = {
+ ? ? ? [0] = {
+ ? ? ? ? ? ? ? .hwport ? ? ? ? = 0,
+ ? ? ? ? ? ? ? .flags ? ? ? ? ?= 0,

There's no code for flags, please remove it all.

Quoted 93 lines
arch/arm/mach-s5pv210/mach-torbreck.c new file +85 -1
+ ? ? ? ? ? ? ? .ucon ? ? ? ? ? = TORBRECK_UCON_DEFAULT,
+ ? ? ? ? ? ? ? .ulcon ? ? ? ? ?= TORBRECK_ULCON_DEFAULT,
+ ? ? ? ? ? ? ? .ufcon ? ? ? ? ?= TORBRECK_UFCON_DEFAULT,
+ ? ? ? },
+ ? ? ? [1] = {
+ ? ? ? ? ? ? ? .hwport ? ? ? ? = 1,
+ ? ? ? ? ? ? ? .flags ? ? ? ? ?= 0,
+ ? ? ? ? ? ? ? .ucon ? ? ? ? ? = TORBRECK_UCON_DEFAULT,
+ ? ? ? ? ? ? ? .ulcon ? ? ? ? ?= TORBRECK_ULCON_DEFAULT,
+ ? ? ? ? ? ? ? .ufcon ? ? ? ? ?= TORBRECK_UFCON_DEFAULT,
+ ? ? ? },
+ ? ? ? [2] = {
+ ? ? ? ? ? ? ? .hwport ? ? ? ? = 2,
+ ? ? ? ? ? ? ? .flags ? ? ? ? ?= 0,
+ ? ? ? ? ? ? ? .ucon ? ? ? ? ? = TORBRECK_UCON_DEFAULT,
+ ? ? ? ? ? ? ? .ulcon ? ? ? ? ?= TORBRECK_ULCON_DEFAULT,
+ ? ? ? ? ? ? ? .ufcon ? ? ? ? ?= TORBRECK_UFCON_DEFAULT,
+ ? ? ? },
+ ? ? ? [3] = {
+ ? ? ? ? ? ? ? .hwport ? ? ? ? = 3,
+ ? ? ? ? ? ? ? .flags ? ? ? ? ?= 0,
+ ? ? ? ? ? ? ? .ucon ? ? ? ? ? = TORBRECK_UCON_DEFAULT,
+ ? ? ? ? ? ? ? .ulcon ? ? ? ? ?= TORBRECK_ULCON_DEFAULT,
+ ? ? ? ? ? ? ? .ufcon ? ? ? ? ?= TORBRECK_UFCON_DEFAULT,
+ ? ? ? },
+};
+
+static struct platform_device *torbreck_devices[] __initdata = {
+ ? ? ? &s5pv210_device_iis0,
+ ? ? ? &s3c_device_cfcon,
+ ? ? ? &s3c_device_hsmmc0,
+ ? ? ? &s3c_device_hsmmc1,
+ ? ? ? &s3c_device_hsmmc2,
+ ? ? ? &s3c_device_hsmmc3,
+ ? ? ? &s3c_device_i2c0,
+ ? ? ? &s3c_device_i2c1,
+ ? ? ? &s3c_device_i2c2,
+ ? ? ? &s3c_device_rtc,
+ ? ? ? &s3c_device_wdt,
+};
+
+static struct i2c_board_info torbreck_i2c_devs0[] __initdata = {
+ ? ? ? /* To Be Updated */
+};
+
+static struct i2c_board_info torbreck_i2c_devs1[] __initdata = {
+ ? ? ? /* To Be Updated */
+};
+
+static struct i2c_board_info torbreck_i2c_devs2[] __initdata = {
+ ? ? ? /* To Be Updated */
+};
+
+static void __init torbreck_map_io(void)
+{
+ ? ? ? s5p_init_io(NULL, 0, S5P_VA_CHIPID);
+ ? ? ? s3c24xx_init_clocks(24000000);
+ ? ? ? s3c24xx_init_uarts(torbreck_uartcfgs, ARRAY_SIZE(torbreck_uartcfgs));
+}
+
+static void __init torbreck_machine_init(void)
+{
+ ? ? ? s3c_i2c0_set_platdata(NULL);
+ ? ? ? s3c_i2c1_set_platdata(NULL);
+ ? ? ? s3c_i2c2_set_platdata(NULL);
+ ? ? ? i2c_register_board_info(0, torbreck_i2c_devs0,
+ ? ? ? ? ? ? ? ? ? ? ? ARRAY_SIZE(torbreck_i2c_devs0));
+ ? ? ? i2c_register_board_info(1, torbreck_i2c_devs1,
+ ? ? ? ? ? ? ? ? ? ? ? ARRAY_SIZE(torbreck_i2c_devs1));
+ ? ? ? i2c_register_board_info(2, torbreck_i2c_devs2,
+ ? ? ? ? ? ? ? ? ? ? ? ARRAY_SIZE(torbreck_i2c_devs2));
+
+ ? ? ? platform_add_devices(torbreck_devices, ARRAY_SIZE(torbreck_devices));
+}
+
+MACHINE_START(TORBRECK, "TORBRECK")
+ ? ? ? /* Maintainer: Hyunchul Ko <[email protected]> */
+ ? ? ? .phys_io ? ? ? ?= S3C_PA_UART & 0xfff00000,
+ ? ? ? .io_pg_offst ? ?= (((u32)S3C_VA_UART) >> 18) & 0xfffc,
+ ? ? ? .boot_params ? ?= S5P_PA_SDRAM + 0x100,
+ ? ? ? .init_irq ? ? ? = s5pv210_init_irq,
+ ? ? ? .map_io ? ? ? ? = torbreck_map_io,
+ ? ? ? .init_machine ? = torbreck_machine_init,
+ ? ? ? .timer ? ? ? ? ?= &s3c24xx_timer,
+MACHINE_END
--

1.5.6.3

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo at vger.kernel.org
More majordomo info at ?http://vger.kernel.org/majordomo-info.html

author
#2 lore raw

PATCH 1/1 ARM: S5PV210: Add Torbreck board support

Hi,
Thank you for your interesting.

Quoted 39 lines · Kyungmin Park

Hi,

Looks good to me except minor fixup.

Quoted 9 lines · Kyuho Choi

This patch adds to support Torbreck board of aESOP community using Samsung S5PV210 SoC.

---
 arch/arm/mach-s5pv210/Kconfig         |   18 +++++
 arch/arm/mach-s5pv210/Makefile        |    1 +
 arch/arm/mach-s5pv210/mach-torbreck.c |  133

+++++++++++++++++++++++++++++++++

Review

Quoted 4 lines
 3 files changed, 152 insertions(+), 0 deletions(-)
 create mode 100644 arch/arm/mach-s5pv210/mach-torbreck.c
(quoted diff) +0 -0

b/arch/arm/mach-s5pv210/Kconfig

Quoted 17 lines

index d3a3895..c5ec466 100644

arch/arm/mach-s5pv210/Kconfig +10 -0
@@ -139,6 +139,24 @@ config MACH_SMDKV210
       help
         Machine support for Samsung SMDKV210
 
+config MACH_TORBRECK
+       bool "Torbreck"
+       select CPU_S5PV210
+       select ARCH_SPARSEMEM_ENABLE
+       select S3C_DEV_HSMMC
+       select S3C_DEV_HSMMC1
+       select S3C_DEV_HSMMC2
+       select S3C_DEV_HSMMC3
+       select S3C_DEV_I2C1
+       select S3C_DEV_I2C2
Quoted 9 lines

arch/arm/mach-s5pv210/Kconfig config MACH_SMDKV210 · line 158

Quoted 7 lines
arch/arm/mach-s5pv210/Kconfig +7 -0
+       select S3C_DEV_RTC
+       select S3C_DEV_WDT
+       select S5PV210_SETUP_I2C1
+       select S5PV210_SETUP_I2C2
+       select S5PV210_SETUP_SDHCI
+       help
+         Machine support for aESOP Torbreck

Just question. Does it TDROID board?

No, Torbreck is aESOP community's co-work board. It's not TDORID.

Quoted 56 lines

Review

Quoted 5 lines
arch/arm/mach-s5pv210/Kconfig +1 -0
+
 endmenu
 
 endif
(quoted diff) +0 -0

b/arch/arm/mach-s5pv210/Makefile

Review

Quoted 12 lines

index 05048c5..927c2b7 100644

arch/arm/mach-s5pv210/Makefile +1 -0
@@ -21,6 +21,7 @@ obj-$(CONFIG_MACH_AQUILA)     += mach-aquila.o
 obj-$(CONFIG_MACH_SMDKV210)    += mach-smdkv210.o
 obj-$(CONFIG_MACH_SMDKC110)    += mach-smdkc110.o
 obj-$(CONFIG_MACH_GONI)                += mach-goni.o
+obj-$(CONFIG_MACH_TORBRECK)    += mach-torbreck.o
 
 # device support
 
(quoted diff) +0 -0

b/arch/arm/mach-s5pv210/mach-torbreck.c

Quoted 26 lines

new file mode 100644
index 0000000..3142250

arch/arm/mach-s5pv210/mach-torbreck.c new file +21 -0
@@ -0,0 +1,133 @@
+/* linux/arch/arm/mach-s5pv210/mach-torbreck.c
+ *
+ * Copyright (c) 2010 aESOP Community
+ *             http://www.aesop.or.kr/
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+*/
+
+#include <linux/kernel.h>
+#include <linux/types.h>
+#include <linux/i2c.h>
+#include <linux/init.h>
+#include <linux/serial_core.h>
+
+#include <asm/mach/arch.h>
+#include <asm/mach/map.h>
+#include <asm/setup.h>
+#include <asm/mach-types.h>
+

arch/arm/mach-s5pv210/mach-torbreck.c line 31

Quoted 10 lines
arch/arm/mach-s5pv210/mach-torbreck.c new file +10 -0
+#include <mach/map.h>
+#include <mach/regs-clock.h>
+
+#include <plat/regs-serial.h>
+#include <plat/s5pv210.h>
+#include <plat/devs.h>
+#include <plat/cpu.h>
+#include <plat/iic.h>
+
+/* Following are default values for UCON, ULCON and UFCON UART registers

*/

Quoted 15 lines

arch/arm/mach-s5pv210/mach-torbreck.c line 43

Quoted 12 lines
arch/arm/mach-s5pv210/mach-torbreck.c new file +12 -0
+#define TORBRECK_UCON_DEFAULT  (S3C2410_UCON_TXILEVEL |        \
+                                S3C2410_UCON_RXILEVEL |        \
+                                S3C2410_UCON_TXIRQMODE |       \
+                                S3C2410_UCON_RXIRQMODE |       \
+                                S3C2410_UCON_RXFIFO_TOI |      \
+                                S3C2443_UCON_RXERR_IRQEN)
+
+#define TORBRECK_ULCON_DEFAULT S3C2410_LCON_CS8
+
+#define TORBRECK_UFCON_DEFAULT (S3C2410_UFCON_FIFOMODE |       \
+                                S5PV210_UFCON_TXTRIG4 |        \
+                                S5PV210_UFCON_RXTRIG4)

Any reason to use TRIG4? just use the full trigger e.g., 256.

Okay, I'll fix it.

Quoted 7 lines

arch/arm/mach-s5pv210/mach-torbreck.c line 48

Quoted 5 lines
arch/arm/mach-s5pv210/mach-torbreck.c new file +5 -0
+
+static struct s3c2410_uartcfg torbreck_uartcfgs[] __initdata = {
+       [0] = {
+               .hwport         = 0,
+               .flags          = 0,

There's no code for flags, please remove it all.

Okay, I'll remove it.

Quoted 90 lines
Quoted 48 lines
arch/arm/mach-s5pv210/mach-torbreck.c new file +48 -0
+               .ucon           = TORBRECK_UCON_DEFAULT,
+               .ulcon          = TORBRECK_ULCON_DEFAULT,
+               .ufcon          = TORBRECK_UFCON_DEFAULT,
+       },
+       [1] = {
+               .hwport         = 1,
+               .flags          = 0,
+               .ucon           = TORBRECK_UCON_DEFAULT,
+               .ulcon          = TORBRECK_ULCON_DEFAULT,
+               .ufcon          = TORBRECK_UFCON_DEFAULT,
+       },
+       [2] = {
+               .hwport         = 2,
+               .flags          = 0,
+               .ucon           = TORBRECK_UCON_DEFAULT,
+               .ulcon          = TORBRECK_ULCON_DEFAULT,
+               .ufcon          = TORBRECK_UFCON_DEFAULT,
+       },
+       [3] = {
+               .hwport         = 3,
+               .flags          = 0,
+               .ucon           = TORBRECK_UCON_DEFAULT,
+               .ulcon          = TORBRECK_ULCON_DEFAULT,
+               .ufcon          = TORBRECK_UFCON_DEFAULT,
+       },
+};
+
+static struct platform_device *torbreck_devices[] __initdata = {
+       &s5pv210_device_iis0,
+       &s3c_device_cfcon,
+       &s3c_device_hsmmc0,
+       &s3c_device_hsmmc1,
+       &s3c_device_hsmmc2,
+       &s3c_device_hsmmc3,
+       &s3c_device_i2c0,
+       &s3c_device_i2c1,
+       &s3c_device_i2c2,
+       &s3c_device_rtc,
+       &s3c_device_wdt,
+};
+
+static struct i2c_board_info torbreck_i2c_devs0[] __initdata = {
+       /* To Be Updated */
+};
+
+static struct i2c_board_info torbreck_i2c_devs1[] __initdata = {
+       /* To Be Updated */
+};

arch/arm/mach-s5pv210/mach-torbreck.c

Quoted 10 lines
arch/arm/mach-s5pv210/mach-torbreck.c new file +10 -0
+
+static struct i2c_board_info torbreck_i2c_devs2[] __initdata = {
+       /* To Be Updated */
+};
+
+static void __init torbreck_map_io(void)
+{
+       s5p_init_io(NULL, 0, S5P_VA_CHIPID);
+       s3c24xx_init_clocks(24000000);
+       s3c24xx_init_uarts(torbreck_uartcfgs,

ARRAY_SIZE(torbreck_uartcfgs));

Quoted 5 lines
arch/arm/mach-s5pv210/mach-torbreck.c new file +5 -0
+}
+
+static void __init torbreck_machine_init(void)
+{
+       s3c_i2c0_set_platdata(NULL);

arch/arm/mach-s5pv210/mach-torbreck.c

Quoted 10 lines
arch/arm/mach-s5pv210/mach-torbreck.c new file +10 -0
+       s3c_i2c1_set_platdata(NULL);
+       s3c_i2c2_set_platdata(NULL);
+       i2c_register_board_info(0, torbreck_i2c_devs0,
+                       ARRAY_SIZE(torbreck_i2c_devs0));
+       i2c_register_board_info(1, torbreck_i2c_devs1,
+                       ARRAY_SIZE(torbreck_i2c_devs1));
+       i2c_register_board_info(2, torbreck_i2c_devs2,
+                       ARRAY_SIZE(torbreck_i2c_devs2));
+
+       platform_add_devices(torbreck_devices,

ARRAY_SIZE(torbreck_devices));

Quoted 15 lines
arch/arm/mach-s5pv210/mach-torbreck.c new file +12 -1
+}
+
+MACHINE_START(TORBRECK, "TORBRECK")
+       /* Maintainer: Hyunchul Ko <[email protected]> */
+       .phys_io        = S3C_PA_UART & 0xfff00000,
+       .io_pg_offst    = (((u32)S3C_VA_UART) >> 18) & 0xfffc,
+       .boot_params    = S5P_PA_SDRAM + 0x100,
+       .init_irq       = s5pv210_init_irq,
+       .map_io         = torbreck_map_io,
+       .init_machine   = torbreck_machine_init,
+       .timer          = &s3c24xx_timer,
+MACHINE_END
--

1.5.6.3

Quoted 7 lines
Quoted 2 lines

--
To unsubscribe from this list: send the line "unsubscribe

linux-samsung-soc" in

Quoted 3 lines

the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Thanks,
Kyuho Choi
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20100927/f6649004/attachment-0001.html>

#3 lore raw

PATCH 1/1 ARM: S5PV210: Add Torbreck board support

Quoted 55 lines · ???

Hi,
Thank you for your interesting.

Quoted 40 lines · Kyungmin Park

Hi,

Looks good to me except minor fixup.

Quoted 32 lines · Kyuho Choi

This patch adds to support Torbreck board of aESOP community using Samsung S5PV210 SoC.

---

?arch/arm/mach-s5pv210/Kconfig ? ? ? ? | ? 18 +++++
?arch/arm/mach-s5pv210/Makefile ? ? ? ?| ? ?1 +
?arch/arm/mach-s5pv210/mach-torbreck.c | ?133

+++++++++++++++++++++++++++++++++
?3 files changed, 152 insertions(+), 0 deletions(-) ?create mode 100644 arch/arm/mach-s5pv210/mach-torbreck.c

arch/arm/mach-s5pv210/Kconfig +0 -0
index d3a3895..c5ec466 100644
@@ -139,6 +139,24 @@ config MACH_SMDKV210

? ? ? ?help
? ? ? ? ?Machine support for Samsung SMDKV210

+config MACH_TORBRECK
+ ? ? ? bool "Torbreck"
+ ? ? ? select CPU_S5PV210
+ ? ? ? select ARCH_SPARSEMEM_ENABLE
+ ? ? ? select S3C_DEV_HSMMC
+ ? ? ? select S3C_DEV_HSMMC1
+ ? ? ? select S3C_DEV_HSMMC2
+ ? ? ? select S3C_DEV_HSMMC3
+ ? ? ? select S3C_DEV_I2C1
+ ? ? ? select S3C_DEV_I2C2

Quoted 8 lines
Quoted 7 lines

+ ? ? ? select S3C_DEV_RTC
+ ? ? ? select S3C_DEV_WDT
+ ? ? ? select S5PV210_SETUP_I2C1
+ ? ? ? select S5PV210_SETUP_I2C2
+ ? ? ? select S5PV210_SETUP_SDHCI
+ ? ? ? help
+ ? ? ? ? Machine support for aESOP Torbreck

Just question. Does it TDROID board?

Quoted 1 line

No, Torbreck is aESOP community's co-work board. It's not?TDORID.

Then can I get the schematics or information for this board? e.g., LCD resolution. SD/MMC configuration USB, and so on.

Thank you,
Kyungmin Park

Quoted 187 lines
Quoted 64 lines
Quoted 64 lines

+
?endmenu

?endif

arch/arm/mach-s5pv210/Makefile +0 -0
index 05048c5..927c2b7 100644
@@ -21,6 +21,7 @@ obj-$(CONFIG_MACH_AQUILA) ? ? += mach-aquila.o

?obj-$(CONFIG_MACH_SMDKV210) ? ?+= mach-smdkv210.o ?obj-$(CONFIG_MACH_SMDKC110) ? ?+= mach-smdkc110.o ?obj-$(CONFIG_MACH_GONI) ? ? ? ? ? ? ? ?+= mach-goni.o +obj-$(CONFIG_MACH_TORBRECK) ? ?+= mach-torbreck.o

?# device support

arch/arm/mach-s5pv210/mach-torbreck.c new file +31 -0
new file mode 100644
index 0000000..3142250
@@ -0,0 +1,133 @@
+/* linux/arch/arm/mach-s5pv210/mach-torbreck.c
+ *
+ * Copyright (c) 2010 aESOP Community
+ * ? ? ? ? ? ? http://www.aesop.or.kr/
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+*/
+
+#include <linux/kernel.h>
+#include <linux/types.h>
+#include <linux/i2c.h>
+#include <linux/init.h>
+#include <linux/serial_core.h>
+
+#include <asm/mach/arch.h>
+#include <asm/mach/map.h>
+#include <asm/setup.h>
+#include <asm/mach-types.h>
+
+#include <mach/map.h>
+#include <mach/regs-clock.h>
+
+#include <plat/regs-serial.h>
+#include <plat/s5pv210.h>
+#include <plat/devs.h>
+#include <plat/cpu.h>
+#include <plat/iic.h>
+
+/* Following are default values for UCON, ULCON and UFCON UART

registers */
+#define TORBRECK_UCON_DEFAULT ?(S3C2410_UCON_TXILEVEL | ? ? ? ?\
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?S3C2410_UCON_RXILEVEL | ? ? ? ?\
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?S3C2410_UCON_TXIRQMODE | ? ? ? \
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?S3C2410_UCON_RXIRQMODE | ? ? ? \
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?S3C2410_UCON_RXFIFO_TOI | ? ? ?\
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?S3C2443_UCON_RXERR_IRQEN)

Quoted 8 lines

arch/arm/mach-s5pv210/mach-torbreck.c

Quoted 6 lines
arch/arm/mach-s5pv210/mach-torbreck.c new file +6 -0
+
+#define TORBRECK_ULCON_DEFAULT S3C2410_LCON_CS8
+
+#define TORBRECK_UFCON_DEFAULT (S3C2410_UFCON_FIFOMODE | ? ? ? \
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?S5PV210_UFCON_TXTRIG4 | ? ? ? ?\
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?S5PV210_UFCON_RXTRIG4)

Any reason to use TRIG4? just use the full trigger e.g., 256.

Okay, I'll fix it.

Quoted 7 lines

arch/arm/mach-s5pv210/mach-torbreck.c

Quoted 6 lines
arch/arm/mach-s5pv210/mach-torbreck.c new file +5 -0
+
+static struct s3c2410_uartcfg torbreck_uartcfgs[] __initdata = {
+ ? ? ? [0] = {
+ ? ? ? ? ? ? ? .hwport ? ? ? ? = 0,
+ ? ? ? ? ? ? ? .flags ? ? ? ? ?= 0,

There's no code for flags, please remove it all.

Okay, I'll remove it.

Quoted 91 lines
Quoted 91 lines

+ ? ? ? ? ? ? ? .ucon ? ? ? ? ? = TORBRECK_UCON_DEFAULT,
+ ? ? ? ? ? ? ? .ulcon ? ? ? ? ?= TORBRECK_ULCON_DEFAULT,
+ ? ? ? ? ? ? ? .ufcon ? ? ? ? ?= TORBRECK_UFCON_DEFAULT,
+ ? ? ? },
+ ? ? ? [1] = {
+ ? ? ? ? ? ? ? .hwport ? ? ? ? = 1,
+ ? ? ? ? ? ? ? .flags ? ? ? ? ?= 0,
+ ? ? ? ? ? ? ? .ucon ? ? ? ? ? = TORBRECK_UCON_DEFAULT,
+ ? ? ? ? ? ? ? .ulcon ? ? ? ? ?= TORBRECK_ULCON_DEFAULT,
+ ? ? ? ? ? ? ? .ufcon ? ? ? ? ?= TORBRECK_UFCON_DEFAULT,
+ ? ? ? },
+ ? ? ? [2] = {
+ ? ? ? ? ? ? ? .hwport ? ? ? ? = 2,
+ ? ? ? ? ? ? ? .flags ? ? ? ? ?= 0,
+ ? ? ? ? ? ? ? .ucon ? ? ? ? ? = TORBRECK_UCON_DEFAULT,
+ ? ? ? ? ? ? ? .ulcon ? ? ? ? ?= TORBRECK_ULCON_DEFAULT,
+ ? ? ? ? ? ? ? .ufcon ? ? ? ? ?= TORBRECK_UFCON_DEFAULT,
+ ? ? ? },
+ ? ? ? [3] = {
+ ? ? ? ? ? ? ? .hwport ? ? ? ? = 3,
+ ? ? ? ? ? ? ? .flags ? ? ? ? ?= 0,
+ ? ? ? ? ? ? ? .ucon ? ? ? ? ? = TORBRECK_UCON_DEFAULT,
+ ? ? ? ? ? ? ? .ulcon ? ? ? ? ?= TORBRECK_ULCON_DEFAULT,
+ ? ? ? ? ? ? ? .ufcon ? ? ? ? ?= TORBRECK_UFCON_DEFAULT,
+ ? ? ? },

arch/arm/mach-s5pv210/mach-torbreck.c new file +33 -0
+};
+
+static struct platform_device *torbreck_devices[] __initdata = {
+ ? ? ? &s5pv210_device_iis0,
+ ? ? ? &s3c_device_cfcon,
+ ? ? ? &s3c_device_hsmmc0,
+ ? ? ? &s3c_device_hsmmc1,
+ ? ? ? &s3c_device_hsmmc2,
+ ? ? ? &s3c_device_hsmmc3,
+ ? ? ? &s3c_device_i2c0,
+ ? ? ? &s3c_device_i2c1,
+ ? ? ? &s3c_device_i2c2,
+ ? ? ? &s3c_device_rtc,
+ ? ? ? &s3c_device_wdt,
+};
+
+static struct i2c_board_info torbreck_i2c_devs0[] __initdata = {
+ ? ? ? /* To Be Updated */
+};
+
+static struct i2c_board_info torbreck_i2c_devs1[] __initdata = {
+ ? ? ? /* To Be Updated */
+};
+
+static struct i2c_board_info torbreck_i2c_devs2[] __initdata = {
+ ? ? ? /* To Be Updated */
+};
+
+static void __init torbreck_map_io(void)
+{
+ ? ? ? s5p_init_io(NULL, 0, S5P_VA_CHIPID);
+ ? ? ? s3c24xx_init_clocks(24000000);
+ ? ? ? s3c24xx_init_uarts(torbreck_uartcfgs,

ARRAY_SIZE(torbreck_uartcfgs));

arch/arm/mach-s5pv210/mach-torbreck.c new file +15 -0
+}
+
+static void __init torbreck_machine_init(void)
+{
+ ? ? ? s3c_i2c0_set_platdata(NULL);
+ ? ? ? s3c_i2c1_set_platdata(NULL);
+ ? ? ? s3c_i2c2_set_platdata(NULL);
+ ? ? ? i2c_register_board_info(0, torbreck_i2c_devs0,
+ ? ? ? ? ? ? ? ? ? ? ? ARRAY_SIZE(torbreck_i2c_devs0));
+ ? ? ? i2c_register_board_info(1, torbreck_i2c_devs1,
+ ? ? ? ? ? ? ? ? ? ? ? ARRAY_SIZE(torbreck_i2c_devs1));
+ ? ? ? i2c_register_board_info(2, torbreck_i2c_devs2,
+ ? ? ? ? ? ? ? ? ? ? ? ARRAY_SIZE(torbreck_i2c_devs2));
+
+ ? ? ? platform_add_devices(torbreck_devices,

ARRAY_SIZE(torbreck_devices));

arch/arm/mach-s5pv210/mach-torbreck.c new file +12 -1
+}
+
+MACHINE_START(TORBRECK, "TORBRECK")
+ ? ? ? /* Maintainer: Hyunchul Ko <[email protected]> */
+ ? ? ? .phys_io ? ? ? ?= S3C_PA_UART & 0xfff00000,
+ ? ? ? .io_pg_offst ? ?= (((u32)S3C_VA_UART) >> 18) & 0xfffc,
+ ? ? ? .boot_params ? ?= S5P_PA_SDRAM + 0x100,
+ ? ? ? .init_irq ? ? ? = s5pv210_init_irq,
+ ? ? ? .map_io ? ? ? ? = torbreck_map_io,
+ ? ? ? .init_machine ? = torbreck_machine_init,
+ ? ? ? .timer ? ? ? ? ?= &s3c24xx_timer,
+MACHINE_END
--

1.5.6.3

Quoted 6 lines
Quoted 6 lines

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo at vger.kernel.org More majordomo info at ?http://vger.kernel.org/majordomo-info.html

Thanks,
Kyuho Choi

#4 lore raw

PATCH 1/1 ARM: S5PV210: Add Torbreck board support

In reply to 최규호

최규호 wrote:
Hi,

Welcome to Linux mainline ;-)
I have some comments about your patches.

Firstly could you please use English character in the representing name in e-mail client not Korean character :-) And make sure it's text type.

Quoted 3 lines

Hi,
Thank you for your interesting.
On Mon, Sep 27, 2010 at 11:58 AM, Kyungmin Park <[email protected]> wrote:

(snip)

Quoted 7 lines

arch/arm/mach-s5pv210/mach-torbreck.c line 43

Quoted 3 lines
arch/arm/mach-s5pv210/mach-torbreck.c new file +3 -0
+#define TORBRECK_UFCON_DEFAULT (S3C2410_UFCON_FIFOMODE |       \
+                                S5PV210_UFCON_TXTRIG4 |        \
+                                S5PV210_UFCON_RXTRIG4)

Any reason to use TRIG4? just use the full trigger e.g., 256.

Okay, I'll fix it.

Hmm...Kyungmin, any reason to use full trigger here?

It depends on board...so it doesn't matter TRIG4 or anything else if there is no problem on your board. It means the maximum value is not best condition...only depends on your situation/condition.

Quoted 9 lines

arch/arm/mach-s5pv210/mach-torbreck.c line 48

Quoted 5 lines
arch/arm/mach-s5pv210/mach-torbreck.c new file +5 -0
+
+static struct s3c2410_uartcfg torbreck_uartcfgs[] __initdata = {
+       [0] = {
+               .hwport         = 0,
+               .flags          = 0,

There's no code for flags, please remove it all.

Okay, I'll remove it.

I think no need to modify it.
Actually I said many times about this...

And as Ben Dooks said in other patch, the format will be changed soon.

Quoted 27 lines
Quoted 27 lines
arch/arm/mach-s5pv210/mach-torbreck.c new file +27 -0
+               .ucon           = TORBRECK_UCON_DEFAULT,
+               .ulcon          = TORBRECK_ULCON_DEFAULT,
+               .ufcon          = TORBRECK_UFCON_DEFAULT,
+       },
+       [1] = {
+               .hwport         = 1,
+               .flags          = 0,
+               .ucon           = TORBRECK_UCON_DEFAULT,
+               .ulcon          = TORBRECK_ULCON_DEFAULT,
+               .ufcon          = TORBRECK_UFCON_DEFAULT,
+       },
+       [2] = {
+               .hwport         = 2,
+               .flags          = 0,
+               .ucon           = TORBRECK_UCON_DEFAULT,
+               .ulcon          = TORBRECK_ULCON_DEFAULT,
+               .ufcon          = TORBRECK_UFCON_DEFAULT,
+       },
+       [3] = {
+               .hwport         = 3,
+               .flags          = 0,
+               .ucon           = TORBRECK_UCON_DEFAULT,
+               .ulcon          = TORBRECK_ULCON_DEFAULT,
+               .ufcon          = TORBRECK_UFCON_DEFAULT,
+       },
+};
+

(snip)

Quoted 3 lines
Quoted 3 lines

--
1.5.6.3

If possible, please use later version git.
It doesn't mean latest git is best...
This is just private opinion. :-)

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.

#5 lore raw

PATCH 1/1 ARM: S5PV210: Add Torbreck board support

Quoted 18 lines · Kukjin Kim

??? wrote:
Hi,

Welcome to Linux mainline ;-)
I have some comments about your patches.

Firstly could you please use English character in the representing name in e-mail client not Korean character :-) And make sure it's text type.

Quoted 3 lines

Hi,
Thank you for your interesting.
On Mon, Sep 27, 2010 at 11:58 AM, Kyungmin Park <[email protected]> wrote:

(snip)

Quoted 3 lines
Quoted 3 lines

+#define TORBRECK_UFCON_DEFAULT (S3C2410_UFCON_FIFOMODE | ? ? ? \
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?S5PV210_UFCON_TXTRIG4 | ? ? ? ?\
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?S5PV210_UFCON_RXTRIG4)

Quoted 8 lines
Quoted 4 lines

Any reason to use TRIG4? just use the full trigger e.g., 256.

Okay, I'll fix it.

Hmm...Kyungmin, any reason to use full trigger here?

It depends on board...so it doesn't matter TRIG4 or anything else if there is no problem on your board. It means the maximum value is not best condition...only depends on your situation/condition.

So I ask ANY REASON to use TRIG4?
And my opinions,
First. it's not true for all UARTs. it's only valid on UART0. Second, "the maximum value is not best condition" then why Spec said "increase the FIFO size for performance".

Quoted 8 lines
Quoted 8 lines

Review

Quoted 6 lines
(quoted diff) +5 -0
+
+static struct s3c2410_uartcfg torbreck_uartcfgs[] __initdata = {
+ ? ? ? [0] = {
+ ? ? ? ? ? ? ? .hwport ? ? ? ? = 0,
+ ? ? ? ? ? ? ? .flags ? ? ? ? ?= 0,

There's no code for flags, please remove it all.

Quoted 6 lines
Quoted 2 lines

Okay, I'll remove it.

I think no need to modify it.
Actually I said many times about this...

And as Ben Dooks said in other patch, the format will be changed soon.

I always listen "will be changed" so until that time use the correct code. Don't add the meaningless codes.

Thank you,
Kyungmin Park

Quoted 51 lines
Quoted 28 lines
Quoted 28 lines

+ ? ? ? ? ? ? ? .ucon ? ? ? ? ? = TORBRECK_UCON_DEFAULT,
+ ? ? ? ? ? ? ? .ulcon ? ? ? ? ?= TORBRECK_ULCON_DEFAULT,
+ ? ? ? ? ? ? ? .ufcon ? ? ? ? ?= TORBRECK_UFCON_DEFAULT,
+ ? ? ? },
+ ? ? ? [1] = {
+ ? ? ? ? ? ? ? .hwport ? ? ? ? = 1,
+ ? ? ? ? ? ? ? .flags ? ? ? ? ?= 0,
+ ? ? ? ? ? ? ? .ucon ? ? ? ? ? = TORBRECK_UCON_DEFAULT,
+ ? ? ? ? ? ? ? .ulcon ? ? ? ? ?= TORBRECK_ULCON_DEFAULT,
+ ? ? ? ? ? ? ? .ufcon ? ? ? ? ?= TORBRECK_UFCON_DEFAULT,
+ ? ? ? },
+ ? ? ? [2] = {
+ ? ? ? ? ? ? ? .hwport ? ? ? ? = 2,
+ ? ? ? ? ? ? ? .flags ? ? ? ? ?= 0,
+ ? ? ? ? ? ? ? .ucon ? ? ? ? ? = TORBRECK_UCON_DEFAULT,
+ ? ? ? ? ? ? ? .ulcon ? ? ? ? ?= TORBRECK_ULCON_DEFAULT,
+ ? ? ? ? ? ? ? .ufcon ? ? ? ? ?= TORBRECK_UFCON_DEFAULT,
+ ? ? ? },
+ ? ? ? [3] = {
+ ? ? ? ? ? ? ? .hwport ? ? ? ? = 3,
+ ? ? ? ? ? ? ? .flags ? ? ? ? ?= 0,
+ ? ? ? ? ? ? ? .ucon ? ? ? ? ? = TORBRECK_UCON_DEFAULT,
+ ? ? ? ? ? ? ? .ulcon ? ? ? ? ?= TORBRECK_ULCON_DEFAULT,
+ ? ? ? ? ? ? ? .ufcon ? ? ? ? ?= TORBRECK_UFCON_DEFAULT,
+ ? ? ? },

(quoted diff) +2 -0
+};
+

(snip)

Quoted 3 lines
Quoted 3 lines

--
1.5.6.3

If possible, please use later version git.
It doesn't mean latest git is best...
This is just private opinion. :-)

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo at vger.kernel.org
More majordomo info at ?http://vger.kernel.org/majordomo-info.html

author
#6 lore raw

PATCH 1/1 ARM: S5PV210: Add Torbreck board support

In reply to Kukjin Kim
Quoted 19 lines · Kukjin Kim

??? wrote:
Hi,

Welcome to Linux mainline ;-)
I have some comments about your patches.

Firstly could you please use English character in the representing name in e-mail client not Korean character :-) And make sure it's text type.

Quoted 3 lines

Hi,
Thank you for your interesting.
On Mon, Sep 27, 2010 at 11:58 AM, Kyungmin Park <[email protected]> wrote:

(snip)

Quoted 3 lines
Quoted 3 lines

+#define TORBRECK_UFCON_DEFAULT (S3C2410_UFCON_FIFOMODE | ? ? ? \
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?S5PV210_UFCON_TXTRIG4 | ? ? ? ?\
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?S5PV210_UFCON_RXTRIG4)

Quoted 9 lines
Quoted 4 lines

Any reason to use TRIG4? just use the full trigger e.g., 256.

Okay, I'll fix it.

Hmm...Kyungmin, any reason to use full trigger here?

It depends on board...so it doesn't matter TRIG4 or anything else if there is no problem on your board. It means the maximum value is not best condition...only depends on your situation/condition.

Okay, if this is not a mandatory, I want to keep this original, I had no problem with this setting when I tested.

Quoted 7 lines
Quoted 7 lines

Review

Quoted 5 lines
(quoted diff) +5 -0
+
+static struct s3c2410_uartcfg torbreck_uartcfgs[] __initdata = {
+ ? ? ? [0] = {
+ ? ? ? ? ? ? ? .hwport ? ? ? ? = 0,
+ ? ? ? ? ? ? ? .flags ? ? ? ? ?= 0,

There's no code for flags, please remove it all.

Quoted 7 lines
Quoted 2 lines

Okay, I'll remove it.

I think no need to modify it.
Actually I said many times about this...

And as Ben Dooks said in other patch, the format will be changed soon.

This also, I don't want to take _unknown_ side effects to modify this alone. :( Actually, others(smdks, aquilla, goni) are also set this field. So, I hope this also modify with Ben's other patch that you mentioned.

Quoted 30 lines
Quoted 27 lines
Quoted 27 lines

+ ? ? ? ? ? ? ? .ucon ? ? ? ? ? = TORBRECK_UCON_DEFAULT,
+ ? ? ? ? ? ? ? .ulcon ? ? ? ? ?= TORBRECK_ULCON_DEFAULT,
+ ? ? ? ? ? ? ? .ufcon ? ? ? ? ?= TORBRECK_UFCON_DEFAULT,
+ ? ? ? },
+ ? ? ? [1] = {
+ ? ? ? ? ? ? ? .hwport ? ? ? ? = 1,
+ ? ? ? ? ? ? ? .flags ? ? ? ? ?= 0,
+ ? ? ? ? ? ? ? .ucon ? ? ? ? ? = TORBRECK_UCON_DEFAULT,
+ ? ? ? ? ? ? ? .ulcon ? ? ? ? ?= TORBRECK_ULCON_DEFAULT,
+ ? ? ? ? ? ? ? .ufcon ? ? ? ? ?= TORBRECK_UFCON_DEFAULT,
+ ? ? ? },
+ ? ? ? [2] = {
+ ? ? ? ? ? ? ? .hwport ? ? ? ? = 2,
+ ? ? ? ? ? ? ? .flags ? ? ? ? ?= 0,
+ ? ? ? ? ? ? ? .ucon ? ? ? ? ? = TORBRECK_UCON_DEFAULT,
+ ? ? ? ? ? ? ? .ulcon ? ? ? ? ?= TORBRECK_ULCON_DEFAULT,
+ ? ? ? ? ? ? ? .ufcon ? ? ? ? ?= TORBRECK_UFCON_DEFAULT,
+ ? ? ? },
+ ? ? ? [3] = {
+ ? ? ? ? ? ? ? .hwport ? ? ? ? = 3,
+ ? ? ? ? ? ? ? .flags ? ? ? ? ?= 0,
+ ? ? ? ? ? ? ? .ucon ? ? ? ? ? = TORBRECK_UCON_DEFAULT,
+ ? ? ? ? ? ? ? .ulcon ? ? ? ? ?= TORBRECK_ULCON_DEFAULT,
+ ? ? ? ? ? ? ? .ufcon ? ? ? ? ?= TORBRECK_UFCON_DEFAULT,
+ ? ? ? },

(quoted diff) +2 -0
+};
+

(snip)

Quoted 6 lines
Quoted 3 lines
Quoted 3 lines

--
1.5.6.3

If possible, please use later version git.
It doesn't mean latest git is best...
This is just private opinion. :-)

Yes. :-)

Thanks,
Kyuho Choi