Skip to contentSkip to conversation

rtc: rtc-ab8500: remove unnecessary platform_set_drvdata()

PATCH In review Jingoo Han 2 participants 3 messages May 3, 2013

Subsystems (2)
lore
Share & tools
lore

Jingoo Han

author
#0 lore raw

PATCH 4/42 rtc: rtc-ab8500: remove unnecessary platform_set_drvdata()

The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.

---
 drivers/rtc/rtc-ab8500.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
drivers/rtc/rtc-ab8500.c +0 -2
index 63cfa31..c5b62d4 100644
@@ -451,8 +451,6 @@ static int ab8500_rtc_remove(struct platform_device *pdev)
 {
 	ab8500_sysfs_rtc_unregister(&pdev->dev);
 
-	platform_set_drvdata(pdev, NULL);
-
 	return 0;
 }
 
Signature · 1 line
1.7.2.5
Acked-by on v1 4/42
#1 lore raw
Quoted 15 lines · Jingoo Han

The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.

---
 drivers/rtc/rtc-ab8500.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
drivers/rtc/rtc-ab8500.c +0 -0
index 63cfa31..c5b62d4 100644

drivers/rtc/rtc-ab8500.c static int ab8500_rtc_remove(struct platform_device *pdev) · line 455

Quoted 7 lines
drivers/rtc/rtc-ab8500.c +0 -2
@@ -451,8 +451,6 @@ static int ab8500_rtc_remove(struct platform_device *pdev)
 {
 	ab8500_sysfs_rtc_unregister(&pdev->dev);
 
-	platform_set_drvdata(pdev, NULL);
-
 	return 0;
 }

Ok, thanks. Hope you have taken care for the ab3100 too...

regards/srinidhi

author
#2 lore raw
Quoted 19 lines · Srinidhi Kasagar
Quoted 18 lines · Jingoo Han

The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.

---
 drivers/rtc/rtc-ab8500.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
drivers/rtc/rtc-ab8500.c +0 -0
index 63cfa31..c5b62d4 100644
@@ -451,8 +451,6 @@ static int ab8500_rtc_remove(struct platform_device *pdev)
 {
 	ab8500_sysfs_rtc_unregister(&pdev->dev);
 
Quoted 7 lines

drivers/rtc/rtc-ab8500.c static int ab8500_rtc_remove(struct platform_device *pdev) · line 455

Quoted 4 lines
drivers/rtc/rtc-ab8500.c +0 -2
-	platform_set_drvdata(pdev, NULL);
-
 	return 0;
 }

Ok, thanks. Hope you have taken care for the ab3100 too...

Hi Srinidhi Kasagar,

I have already modified the ab3100 RTC driver as below:
(http://www.mail-archive.com/[email protected]/msg428126.html)

Thank you for your Acked-by. :)

Best regards,
Jingoo Han

Quoted 2 lines

regards/srinidhi