mmc: bfin_sdh: remove unnecessary platform_set_drvdata()

PATCH In review Jingoo Han 2 participants 3 messages May 6, 2013 MMC, SD and SDIO

Share & tools

Jingoo Han

author

2013-05-06 06:11 UTC #0 lore raw

PATCH 4/22 mmc: bfin_sdh: remove unnecessary platform_set_drvdata()

The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.

Signed-off-by Jingoo Han <[email protected]>

---
 drivers/mmc/host/bfin_sdh.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

drivers/mmc/host/bfin_sdh.c +0 -2

index fb4348c..94fae2f 100644
@@ -621,8 +621,6 @@ static int sdh_remove(struct platform_device *pdev)
 {
 	struct mmc_host *mmc = platform_get_drvdata(pdev);
 
-	platform_set_drvdata(pdev, NULL);
-
 	if (mmc) {
 		struct sdh_host *host = mmc_priv(mmc);

Signature · 1 line

1.7.2.5

Zhang, Sonic

Acked-by on v1 4/22

2013-05-06 06:22 UTC #1 lore raw

Acked-by Sonic Zhang <[email protected]>

Quoted 34 lines

-----Original Message-----
From: Jingoo Han [mailto:[email protected]]
Sent: Monday, May 06, 2013 2:12 PM
To: 'Chris Ball'
Cc: [email protected]; Jingoo Han; Zhang, Sonic
Subject: [PATCH 04/22] mmc: bfin_sdh: remove unnecessary platform_set_drvdata()
The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.
Signed-off-by Jingoo Han <[email protected]>
---
drivers/mmc/host/bfin_sdh.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
drivers/mmc/host/bfin_sdh.c index renamed from drivers/mmc/host/bfin_sdh.c +0 -0
fb4348c..94fae2f 100644
drivers/mmc/host/bfin_sdh.c +0 -3
@@ -621,8 +621,6 @@ static int sdh_remove(struct platform_device *pdev)  {
      struct mmc_host *mmc = platform_get_drvdata(pdev);
 
-      platform_set_drvdata(pdev, NULL);
-
      if (mmc) {
              struct sdh_host *host = mmc_priv(mmc);
 
--
1.7.2.5

Jingoo Han

author

2013-05-06 06:48 UTC #2 lore raw

Quoted 2 lines · Sonic

Acked-by Sonic Zhang <[email protected]>

Thank you for your Acked-by. :)

Best regards,
Jingoo Han

Quoted 35 lines

Quoted 35 lines
-----Original Message-----
From: Jingoo Han [mailto:[email protected]]
Sent: Monday, May 06, 2013 2:12 PM
To: 'Chris Ball'
Cc: [email protected]; Jingoo Han; Zhang, Sonic
Subject: [PATCH 04/22] mmc: bfin_sdh: remove unnecessary platform_set_drvdata()
The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.
Signed-off-by Jingoo Han <[email protected]>
---
drivers/mmc/host/bfin_sdh.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
drivers/mmc/host/bfin_sdh.c index renamed from drivers/mmc/host/bfin_sdh.c +0 -0
fb4348c..94fae2f 100644
drivers/mmc/host/bfin_sdh.c +0 -3
@@ -621,8 +621,6 @@ static int sdh_remove(struct platform_device *pdev)  {
      struct mmc_host *mmc = platform_get_drvdata(pdev);
 
-      platform_set_drvdata(pdev, NULL);
-
      if (mmc) {
              struct sdh_host *host = mmc_priv(mmc);
 
--
1.7.2.5