Skip to contentSkip to conversation

xen: platform-pci: use DEFINE_PCI_DEVICE_TABLE macro

PATCH In review Jingoo Han 1 participant 2 messages Nov 28, 2013 Xen hypervisor interface

lore
Share & tools
lore

Jingoo Han

author
#0 lore raw

PATCH 1/1 xen: platform-pci: use DEFINE_PCI_DEVICE_TABLE macro

This macro is used to create a struct pci_device_id array.

---
 drivers/xen/platform-pci.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/xen/platform-pci.c +1 -1
index 2f3528e..7ab5e81 100644
@@ -170,7 +170,7 @@ pci_out:
 	return ret;
 }
 
-static struct pci_device_id platform_pci_tbl[] = {
+static DEFINE_PCI_DEVICE_TABLE(platform_pci_tbl) = {
 	{PCI_VENDOR_ID_XEN, PCI_DEVICE_ID_XEN_PLATFORM,
 		PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
 	{0,}
Signature · 1 line
1.7.10.4
author
#1 lore raw
Quoted 4 lines · Jingoo Han

This macro is used to create a struct pci_device_id array.

Please, ignore this patch.
According to the Greg Kroah-Hartman,

"Yeah, and it's a horrid macro that deserves to be removed, please don't use it in more places.

Actually, if you could just remove it, that would be best, sorry, I'm not going to take these patches."

So, I will send the patch to remove 'DEFINE_PCI_DEVICE_TABLE' instead. Sorry for annoying. :-)

Best regards,
Jingoo Han

Quoted 19 lines
---
 drivers/xen/platform-pci.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/xen/platform-pci.c +1 -2
index 2f3528e..7ab5e81 100644
@@ -170,7 +170,7 @@ pci_out:
 	return ret;
 }
 
-static struct pci_device_id platform_pci_tbl[] = {
+static DEFINE_PCI_DEVICE_TABLE(platform_pci_tbl) = {
 	{PCI_VENDOR_ID_XEN, PCI_DEVICE_ID_XEN_PLATFORM,
 		PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
 	{0,}
--

1.7.10.4