Skip to contentSkip to conversation

Fix the bug of the temp-files removing

PATCH In review Jungsoo Son 2 participants 2 messages Jul 16, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix the bug of the temp-files removing

The shell command to remove all the temp-files created had a bug that try to remove /dev/null. If the ltp is run with root permission the /dev/null will be removed.

---
 testscripts/test_robind.sh |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
testscripts/test_robind.sh +1 -1
index 142678a..4c01f4e 100755
@@ -193,7 +193,7 @@ function testdir
         echo >> $PASSLOG
     fi
     # Remove all the temp-files created.
-    eval rm -rf ${TMPDIR}/${dir}/* > /dev/null 2>&1 /dev/null || true
+    eval rm -rf ${TMPDIR}/${dir}/* > /dev/null 2>&1 || true
     unset TDIRECTORY
     popd
 }
Signature · 13 lines
1.7.9.5


------------------------------------------------------------------------------
See everything from the browser to the database with AppDynamics
Get end-to-end visibility with application monitoring from AppDynamics
Isolate bottlenecks and diagnose root cause in seconds.
Start your free trial of AppDynamics Pro today!
http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list
#1 lore raw

Hi!

Quoted 3 lines

The shell command to remove all the temp-files created had a bug that try to remove /dev/null. If the ltp is run with root permission the /dev/null will be removed.

Good catch, applied.

Signature · 13 lines
Cyril Hrubis
[email protected]

------------------------------------------------------------------------------
See everything from the browser to the database with AppDynamics
Get end-to-end visibility with application monitoring from AppDynamics
Isolate bottlenecks and diagnose root cause in seconds.
Start your free trial of AppDynamics Pro today!
http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list