Getting A Patch Into The Kernel
Hello,
My name is Craig Lyons and I am the marketing manager at Promise Technology. We have a question and are hoping you can point us in the right direction. In the 2.4 kernel there is support for some of our products (Ultra 66, Ultra 100, etc.). As you may or may not know, our Ultra family of controllers (which are just standard IDE controllers and do not have RAID) use the same ASIC on them as our FastTrak RAID controllers do. The 2.4 kernel will recognize our Ultra family of controllers, but there is a problem in that a FastTrak will not be recognized as a FastTrak, but as an Ultra. Consequently, the array on the FastTrak is not recognized as an array, but instead each disk is seen individually, and the users data cannot be properly accessed. We have a patch that fixes this and are wondering if it is possible to get this patch into the kernel, and if so, how this would be done?
I apologize if this is the incorrect e-mail to be making this request to. If this is not the correct address to be posting this message, any assistance as to where it should be directed would be greatly appreciated.
Regards,
Craig
Craig Lyons
Marketing Manager
Promise Technology
1460 Koll Circle
San Jose, CA 95112
USA
Voice - 408-452-0948 ext. 241
Fax - 408-452-1534
[email protected]
http:\\www.promise.com
Hi, this is the correct forum. You can submit the patch here. Merely paste the patch output inline into your email, and make your subject "[PATCH] 2.4.5 FastTrak RAID Whatever Fix" and explain in the email.
Note your code must become GPL licensed.
I would suggest making the patch against the latest kernel, 2.4.5 -- or even better, 2.4.5-ac13 or 2.4.6-pre2.
I suggest reading linux/Documentation/SubmittingPatches for coding standards, etc.
It is good to see manufactures supporting their products in Linux, thank you!
Signature · 3 lines
Robert M. Love [email protected] [email protected]
Quoted 23 lines · Craig Lyons
Hello,
My name is Craig Lyons and I am the marketing manager at Promise Technology. We have a question and are hoping you can point us in the right direction. In the 2.4 kernel there is support for some of our products (Ultra 66, Ultra 100, etc.). As you may or may not know, our Ultra family of controllers (which are just standard IDE controllers and do not have RAID) use the same ASIC on them as our FastTrak RAID controllers do. The 2.4 kernel will recognize our Ultra family of controllers, but there is a problem in that a FastTrak will not be recognized as a FastTrak, but as an Ultra. Consequently, the array on the FastTrak is not recognized as an array, but instead each disk is seen individually, and the users data cannot be properly accessed. We have a patch that fixes this and are wondering if it is possible to get this patch into the kernel, and if so, how this would be done?
I apologize if this is the incorrect e-mail to be making this request to. If this is not the correct address to be posting this message, any assistance as to where it should be directed would be greatly appreciated.
Regards,
Craig
Quoted 3 lines · Craig Lyons
We have a patch that fixes this and are wondering if it
is possible to get this patch into the kernel, and if so, how this would be done?
Well, you start by reading this:
http://www.linuxhq.com/kernel/v2.4/doc/SubmittingPatches.html
Which basically says that you post it here, with a title along the lines of:
"[PATCH] promise IDE raid support".
Start the body of your email with a brief description of the patch (the above is fine, mentioning that this is an official patch from promise is nice), and then include the patch itself at the end of the email in plain text. (Linus won't read Mime attachments, although others sometimes do and forward them to him. Sometimes.)
You do know how to make a unified diff using "diff -u", right? (I'm assuming you have an includeable patch already prepared?)
Also, try to use an email program that doesn't mangle whitespace. (It's a nit-pick, but it's good hygiene.) The difference between spaces and tabs is generally considered to be a good thing to maintain.
Rob
Quoted 3 lines · Craig Lyons
My name is Craig Lyons and I am the marketing manager at Promise Technology. We have a question and are hoping you can point us in the right direction.
I think most, if not all, of the things you want to know are described in the following two documents in the Documentation/ directory of the Linux kernel source ;)
linux/Documentation/SubmittingDrivers
linux/Documentation/SubmittingPatches
regards,
Rik
--
Virtual memory is like a game you can't win; However, without VM there's truly nothing to lose...
http://www.surriel.com/ http://distro.conectiva.com/
Send all your spam to [email protected] (spam digging piggy)
Quoted 5 lines
ASIC on them as our FastTrak RAID controllers do. The 2.4 kernel will recognize our Ultra family of controllers, but there is a problem in that a FastTrak will not be recognized as a FastTrak, but as an Ultra. Consequently, the array on the FastTrak is not recognized as an array, but instead each disk is seen individually, and the users data cannot be
This is not true in 2.4.5-ac. Arjan van de Ven resolved this one.
Quoted 3 lines
properly accessed. We have a patch that fixes this and are wondering if it is possible to get this patch into the kernel, and if so, how this would be done?
Im sure Arjan would love to have an official patch rather than deducing your disk format by hand