extcon: Remove casting the return value which is a void pointer
PATCH 1/1 extcon: Remove casting the return value which is a void pointer
Casting the return value which is a void pointer is redundant. The conversion from void pointer to any other pointer type is guaranteed by the C programming language.
Signed-off-by Jingoo Han <[email protected]>
--- drivers/extcon/extcon-class.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/extcon/extcon-class.c +4 -4
@@ -105,7 +105,7 @@ static ssize_t state_show(struct device *dev, struct device_attribute *attr, char *buf) {int i, count =0 ; -struct extcon_dev *edev = (struct extcon_dev *)dev_get_drvdata (dev); +struct extcon_dev *edev =dev_get_drvdata (dev);if (edev->print_state) {int ret = edev->print_state (edev, buf);
@@ -135,7 +135,7 @@ static ssize_t state_store(struct device *dev, struct device_attribute *attr, {u32 state;ssize_t ret =0 ; -struct extcon_dev *edev = (struct extcon_dev *)dev_get_drvdata (dev); +struct extcon_dev *edev =dev_get_drvdata (dev); ret =sscanf (buf,"0x%x" , &state);if (ret ==0 )
@@ -153,7 +153,7 @@ static DEVICE_ATTR_RW(state);static ssize_t name_show (struct device *dev,struct device_attribute *attr,char *buf) { -struct extcon_dev *edev = (struct extcon_dev *)dev_get_drvdata (dev); +struct extcon_dev *edev =dev_get_drvdata (dev);/* Optional callback given by the user */ if (edev->print_name) {
@@ -470,7 +470,7 @@ int extcon_register_interest(struct extcon_specific_cable_nb *obj,return -ENODEV ;class_dev_iter_init (&iter, extcon_class,NULL ,NULL );while ((dev =class_dev_iter_next (&iter))) { - extd = (struct extcon_dev *)dev_get_drvdata (dev); + extd =dev_get_drvdata (dev);if (extcon_find_cable_index (extd, cable_name) <0 )continue ;
Signature · 1 line
1.7.10.4
Hi Jingoo,
Quoted 9 lines · Jingoo Han
Casting the return value which is a void pointer is redundant. The conversion from void pointer to any other pointer type is guaranteed by the C programming language.
Signed-off-by Jingoo Han <[email protected]>--- drivers/extcon/extcon-class.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
Applied it on extcon-linus branch.
Thanks,
Chanwoo Choi