mfd: pm8921: remove unnecessary platform_set_drvdata()

PATCH In review Jingoo Han 1 participant 1 message Aug 20, 2013 Multifunction devices (MFD)

Share & tools

Jingoo Han

author

2013-08-20 07:02 UTC #0 lore raw

PATCH 2/3 mfd: pm8921: remove unnecessary platform_set_drvdata()

The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.

Signed-off-by Jingoo Han <[email protected]>

---
 drivers/mfd/pm8921-core.c |    2 --
 1 file changed, 2 deletions(-)

drivers/mfd/pm8921-core.c +0 -2

index bd4b37c..9a7c991 100644
@@ -160,7 +160,6 @@ static int pm8921_probe(struct platform_device *pdev)
 
 err:
 	mfd_remove_devices(pmic->dev);
-	platform_set_drvdata(pdev, NULL);
 err_read_rev:
 	kfree(pmic);
 	return rc;

@@ -180,7 +179,6 @@ static int pm8921_remove(struct platform_device *pdev)
 		pm8xxx_irq_exit(pmic->irq_chip);
 		pmic->irq_chip = NULL;
 	}
-	platform_set_drvdata(pdev, NULL);
 	kfree(pmic);
 
 	return 0;

Signature · 1 line

1.7.10.4