mtd: nand: lpc32xx: remove unnecessary platform_set_drvdata()
Subsystems (3)
PATCH 17/26 mtd: nand: lpc32xx: remove unnecessary platform_set_drvdata()
The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.
Signed-off-by Jingoo Han <[email protected]>
--- drivers/mtd/nand/lpc32xx_mlc.c | 2 -- drivers/mtd/nand/lpc32xx_slc.c | 2 -- 2 files changed, 0 insertions(+), 4 deletions(-)
drivers/mtd/nand/lpc32xx_mlc.c +0 -2
@@ -833,7 +833,6 @@ err_exit3: err_exit2:clk_disable (host->clk);clk_put (host->clk); -platform_set_drvdata (pdev,NULL ); err_exit1:lpc32xx_wp_enable (host);gpio_free (host->ncfg->wp_gpio);
@@ -856,7 +855,6 @@ static int lpc32xx_nand_remove(struct platform_device *pdev)clk_disable (host->clk);clk_put (host->clk); -platform_set_drvdata (pdev,NULL );lpc32xx_wp_enable (host);gpio_free (host->ncfg->wp_gpio);
drivers/mtd/nand/lpc32xx_slc.c +0 -2
@@ -936,7 +936,6 @@ err_exit3: err_exit2:clk_disable (host->clk);clk_put (host->clk); -platform_set_drvdata (pdev,NULL ); err_exit1:lpc32xx_wp_enable (host);gpio_free (host->ncfg->wp_gpio);
@@ -963,7 +962,6 @@ static int lpc32xx_nand_remove(struct platform_device *pdev)clk_disable (host->clk);clk_put (host->clk); -platform_set_drvdata (pdev,NULL );lpc32xx_wp_enable (host);gpio_free (host->ncfg->wp_gpio);
Signature · 1 line
1.7.2.5
Quoted 6 lines · Jingoo Han
The driver core clears the driver data to NULL after
device_releaseor on probe failure, since commit0998d0631001288a5974afc0b2a5f568bcdecb4d(device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.Signed-off-by Jingoo Han <[email protected]>
Tested-by Roland Stigge <[email protected]>
Acked-by Roland Stigge <[email protected]>
Quoted 45 lines
--- drivers/mtd/nand/lpc32xx_mlc.c | 2 -- drivers/mtd/nand/lpc32xx_slc.c | 2 -- 2 files changed, 0 insertions(+), 4 deletions(-)drivers/mtd/nand/lpc32xx_mlc.c +0
-2@@ -833,7 +833,6 @@ err_exit3: err_exit2:clk_disable (host->clk);clk_put (host->clk); -platform_set_drvdata (pdev,NULL ); err_exit1:lpc32xx_wp_enable (host);gpio_free (host->ncfg->wp_gpio);@@ -856,7 +855,6 @@ static int lpc32xx_nand_remove(struct platform_device *pdev)clk_disable (host->clk);clk_put (host->clk); -platform_set_drvdata (pdev,NULL );lpc32xx_wp_enable (host);gpio_free (host->ncfg->wp_gpio);drivers/mtd/nand/lpc32xx_slc.c +0
-2@@ -936,7 +936,6 @@ err_exit3: err_exit2:clk_disable (host->clk);clk_put (host->clk); -platform_set_drvdata (pdev,NULL ); err_exit1:lpc32xx_wp_enable (host);gpio_free (host->ncfg->wp_gpio);@@ -963,7 +962,6 @@ static int lpc32xx_nand_remove(struct platform_device *pdev)clk_disable (host->clk);clk_put (host->clk); -platform_set_drvdata (pdev,NULL );lpc32xx_wp_enable (host);gpio_free (host->ncfg->wp_gpio);