Skip to contentSkip to conversation

mmc: sdhci-pxa: remove unnecessary platform_set_drvdata()

PATCH In review Jingoo Han 2 participants 2 messages May 6, 2013 – May 7, 2013

Subsystems (2)
MMC, SD and SDIO Secure digital host controller interface (SDHCI) driver
lore
Share & tools
lore

Jingoo Han

author
#0 lore raw

PATCH 17/22 mmc: sdhci-pxa: remove unnecessary platform_set_drvdata()

The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.

Signed-off-by Jingoo Han <[email protected]>
---
 drivers/mmc/host/sdhci-pxav2.c |    2 --
 drivers/mmc/host/sdhci-pxav3.c |    2 --
 2 files changed, 0 insertions(+), 4 deletions(-)
drivers/mmc/host/sdhci-pxav2.c +0 -2
index 6a3f702..98b5145 100644
@@ -253,8 +253,6 @@ static int sdhci_pxav2_remove(struct platform_device *pdev)
 	sdhci_pltfm_free(pdev);
 	kfree(pxa);
 
-	platform_set_drvdata(pdev, NULL);
-
 	return 0;
 }
drivers/mmc/host/sdhci-pxav3.c +0 -2
index 1ae358e..90ee262 100644
@@ -339,8 +339,6 @@ static int sdhci_pxav3_remove(struct platform_device *pdev)
 	sdhci_pltfm_free(pdev);
 	kfree(pxa);
 
-	platform_set_drvdata(pdev, NULL);
-
 	return 0;
 }
Signature · 1 line
1.7.2.5
Acked-by on v1 17/22
#1 lore raw
Quoted 11 lines · Jingoo Han

The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.

Signed-off-by Jingoo Han <[email protected]>
---
 drivers/mmc/host/sdhci-pxav2.c |    2 --
 drivers/mmc/host/sdhci-pxav3.c |    2 --
 2 files changed, 0 insertions(+), 4 deletions(-)
Acked-by Haojian Zhuang <[email protected]>