Skip to contentSkip to conversation

arm: qcom: Update ipq5424-rdp466-u-boot.dtsi for v7.1-dts changes

PATCH In review Tom Rini 2 participants 3 messages Jul 7 – Jul 29 Arm (32-bit)

lore
Share & tools
lore

Tom Rini

author
#0 lore raw

PATCH 1/1 arm: qcom: Update ipq5424-rdp466-u-boot.dtsi for v7.1-dts changes

Once we move to the v7.0-dts tag, we get a failure to build of:
dts/upstream/src/arm64/qcom/ipq5424.dtsi:556.21-573.5: ERROR (phandle_references): /soc@0/mmc@7804000: Reference to non-existent node or label "sdc_default_state"

also defined at arch/arm/dts/ipq5424-rdp466-u-boot.dtsi:20.8-39.4
ERROR: Input tree has errors, aborting (use -f to force output)

Looking over the changes, this appears to be what's required to keep the platform functioning as expected.

---
This file isn't covered by MAINTAINERS directly, so can someone please follow-up and correct that? And, based on looking at the changes between v7.0-dts and v7.1-dts, this would appear to be the right change, but I don't know the platform.

Cc Gurumoorthy Santhakumar <[email protected]>
CC Casey Connolly <[email protected]>
---
 arch/arm/dts/ipq5424-rdp466-u-boot.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/dts/ipq5424-rdp466-u-boot.dtsi +1 -1
index 36640f31d616..56677cd6f6da 100644
@@ -24,7 +24,7 @@
 		mmc-hs200-1_8v;
 		max-frequency = <192000000>;
 		bus-width = <4>;
-		pinctrl-0 = <&sdc_default_state>;
+		pinctrl-0 = <&qpic_snand_default_state>;
 		pinctrl-names = "default";
 		non-removable;
 
Signature · 1 line
2.43.0
Acked-by on v1 1/1
#1 lore raw

Can someone confirm this?

Quoted 10 lines · Tom Rini

Once we move to the v7.0-dts tag, we get a failure to build of:
dts/upstream/src/arm64/qcom/ipq5424.dtsi:556.21-573.5: ERROR (phandle_references): /soc@0/mmc@7804000: Reference to non-existent node or label "sdc_default_state"

   also defined at arch/arm/dts/ipq5424-rdp466-u-boot.dtsi:20.8-39.4

ERROR: Input tree has errors, aborting (use -f to force output)

Looking over the changes, this appears to be what's required to keep the platform functioning as expected.

Quoted 25 lines

---
This file isn't covered by MAINTAINERS directly, so can someone please follow-up and correct that? And, based on looking at the changes between v7.0-dts and v7.1-dts, this would appear to be the right change, but I don't know the platform.

Cc Gurumoorthy Santhakumar <[email protected]>
CC Casey Connolly <[email protected]>
---
  arch/arm/dts/ipq5424-rdp466-u-boot.dtsi | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/dts/ipq5424-rdp466-u-boot.dtsi +1 -1
index 36640f31d616..56677cd6f6da 100644
@@ -24,7 +24,7 @@
  		mmc-hs200-1_8v;
  		max-frequency = <192000000>;
  		bus-width = <4>;
-		pinctrl-0 = <&sdc_default_state>;
+		pinctrl-0 = <&qpic_snand_default_state>;
  		pinctrl-names = "default";
  		non-removable;
 
author
#2 lore raw
In reply to Tom Rini
Quoted 10 lines · Tom Rini

Once we move to the v7.0-dts tag, we get a failure to build of:
dts/upstream/src/arm64/qcom/ipq5424.dtsi:556.21-573.5: ERROR (phandle_references): /soc@0/mmc@7804000: Reference to non-existent node or label "sdc_default_state"

also defined at arch/arm/dts/ipq5424-rdp466-u-boot.dtsi:20.8-39.4
ERROR: Input tree has errors, aborting (use -f to force output)

Looking over the changes, this appears to be what's required to keep the platform functioning as expected.

[...]

Applied to u-boot/main, thanks!

[1/1] arm: qcom: Update ipq5424-rdp466-u-boot.dtsi for v7.1-dts changes

      commit: b9b104e8ddaa81c887872ed078ab17fb39d3465e
Signature · 1 line
Tom