Skip to contentSkip to conversation

serial: ioc4_serial: Staticize ioc4_serial_attach_one()

PATCH In review Jingoo Han 1 participant 1 message Aug 8, 2013 TTY layer and serial drivers

lore
Share & tools
lore

Jingoo Han

author
#0 lore raw

PATCH 6/10 serial: ioc4_serial: Staticize ioc4_serial_attach_one()

ioc4_serial_attach_one() is used only in this file. Also, ioc4_serial is not used; it can be removed. Fix the following sparse warnings:

drivers/tty/serial/ioc4_serial.c:300:3: warning: symbol 'ioc4_serial' was not declared. Should it be static? drivers/tty/serial/ioc4_serial.c:2771:1: warning: symbol 'ioc4_serial_attach_one' was not declared. Should it be static?

---
 drivers/tty/serial/ioc4_serial.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/tty/serial/ioc4_serial.c +2 -2
index e2520ab..1274499 100644
@@ -297,7 +297,7 @@ struct ioc4_serial {
 	struct ioc4_uartregs uart_1;
 	struct ioc4_uartregs uart_2;
 	struct ioc4_uartregs uart_3;
-} ioc4_serial;
+};
 
 /* UART clock speed */
 #define IOC4_SER_XIN_CLK_66     66666667
@@ -2767,7 +2767,7 @@ ioc4_serial_core_attach(struct pci_dev *pdev, int port_type)
  *		called per card found from IOC4 master module.
  * @idd: Master module data for this IOC4
  */
-int
+static int
 ioc4_serial_attach_one(struct ioc4_driver_data *idd)
 {
 	unsigned long tmp_addr1;
Signature · 1 line
1.7.10.4