Skip to contentSkip to conversation

[2.5.7] compilation problem

DISCUSSION Witek Kręcicki 3 participants 4 messages Mar 18, 2002 – Mar 21, 2002

Subsystems (2)
Networking Kbuild
lore
Share & tools
lore

Witek Kręcicki

author
#0 lore raw

make[3]: Entering `/home/users/adasi/rpm/BUILD/linux-2.5.7/net/core' egcs -D__KERNEL__ -I/home/users/adasi/rpm/BUILD/linux-2.5.7/include -Wall -W strict-prototypes -Wno-trigraphs -O2 -fomit-frame-pointer -fno-strict-aliasi
ng -fno-common -pipe -march=i686 -DKBUILD_BASENAME=dev -c -o dev.o dev.c
dev.c: In function `netif_receive_skb':
dev.c:1465: void value not ignored as it ought to be

Part of .config:
<cite>
#
# Networking options
#
CONFIG_PACKET=m
CONFIG_PACKET_MMAP=y
CONFIG_NETLINK_DEV=y
CONFIG_NETFILTER=y
# CONFIG_NETFILTER_DEBUG is not set
CONFIG_FILTER=y
CONFIG_UNIX=m
CONFIG_INET=y
CONFIG_IP_MULTICAST=y
CONFIG_IP_ADVANCED_ROUTER=y
CONFIG_IP_MULTIPLE_TABLES=y
CONFIG_IP_ROUTE_FWMARK=y
CONFIG_IP_ROUTE_NAT=y
CONFIG_IP_ROUTE_MULTIPATH=y
CONFIG_IP_ROUTE_TOS=y
CONFIG_IP_ROUTE_VERBOSE=y
CONFIG_IP_ROUTE_LARGE_TABLES=y
# CONFIG_IP_PNP is not set
CONFIG_NET_IPIP=m
CONFIG_NET_IPGRE=m
CONFIG_NET_IPGRE_BROADCAST=y
CONFIG_IP_MROUTE=y
CONFIG_IP_PIMSM_V1=y
CONFIG_IP_PIMSM_V2=y
# CONFIG_ARPD is not set
# CONFIG_INET_ECN is not set
CONFIG_SYN_COOKIES=y
</cite>

How to fix it?
--
Witek Krecicki
[email protected]

#1 lore raw

Hi,

Quoted 4 lines · Witek Krêcicki

make[3]: Entering `/home/users/adasi/rpm/BUILD/linux-2.5.7/net/core' egcs -D__KERNEL__ -I/home/users/adasi/rpm/BUILD/linux-2.5.7/include -Wall -W strict-prototypes -Wno-trigraphs -O2 -fomit-frame-pointer -fno-strict-aliasi
ng -fno-common -pipe -march=i686 -DKBUILD_BASENAME=dev -c -o dev.o dev.c

Quoted 8 lines

dev.c: In function `netif_receive_skb':
dev.c:1465: void value not ignored as it ought to be Part of .config:
<cite>
#
# Networking options
#
CONFIG_PACKET=m

[removed unimportant part]

Quoted 4 lines

CONFIG_IP_PIMSM_V2=y
# CONFIG_ARPD is not set
# CONFIG_INET_ECN is not set
CONFIG_SYN_COOKIES=y

You forgot to post the important rest: CONFIG_NET_DIVERT=y

Quoted 1 line

How to fix it?

usr/src/linux-2.5.7/net/core/dev.c renamed from net/core/dev.c +0 -1
@@ -1462,7 +1462,7 @@
 
 #ifdef CONFIG_NET_DIVERT
 	if (skb->dev->divert && skb->dev->divert->divert)
- 

	ret = handle_diverter(skb);
+ 
	handle_diverter(skb);

#endif /* CONFIG_NET_DIVERT */

#if defined(CONFIG_BRIDGE) || defined(CONFIG_BRIDGE_MODULE)

I don't know why this has been changed since it doesn't differ much from the 2.4.x code in its invariant (CONFIG_NET_DIVERT) handling. Maybe DaveM had a bad day ;)

Cheers,
Roberto Nibali, ratz

#2 lore raw
Quoted 46 lines · On Tue, 19 Mar 2002 01:00:50 +0100 Roberto Nibali <[email protected]> wrote:

Hi,

Quoted 4 lines

make[3]: Entering `/home/users/adasi/rpm/BUILD/linux-2.5.7/net/core' egcs -D__KERNEL__ -I/home/users/adasi/rpm/BUILD/linux-2.5.7/include -Wall -W strict-prototypes -Wno-trigraphs -O2 -fomit-frame-pointer -fno-strict-aliasi
ng -fno-common -pipe -march=i686 -DKBUILD_BASENAME=dev -c -o dev.o dev.c

Quoted 8 lines

dev.c: In function `netif_receive_skb':
dev.c:1465: void value not ignored as it ought to be Part of .config:
<cite>
#
# Networking options
#
CONFIG_PACKET=m

[removed unimportant part]

Quoted 4 lines

CONFIG_IP_PIMSM_V2=y
# CONFIG_ARPD is not set
# CONFIG_INET_ECN is not set
CONFIG_SYN_COOKIES=y

You forgot to post the important rest: CONFIG_NET_DIVERT=y

Quoted 1 line

How to fix it?

usr/src/linux-2.5.7/net/core/dev.c renamed from net/core/dev.c +1 -1
@@ -1462,7 +1462,7 @@
 
  #ifdef CONFIG_NET_DIVERT
  	if (skb->dev->divert && skb->dev->divert->divert)
- 
 	ret = handle_diverter(skb);
+ 
 	handle_diverter(skb);
  #endif /* CONFIG_NET_DIVERT */

  	 
	
  #if defined(CONFIG_BRIDGE) || defined(CONFIG_BRIDGE_MODULE)

I don't know why this has been changed since it doesn't differ much from the 2.4.x code in its invariant (CONFIG_NET_DIVERT) handling. Maybe DaveM had a bad day ;)

Quoted 8 lines

Cheers,
Roberto Nibali, ratz

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Today I download the latest patch, And I patch it into the 2.5.6 tree, But it do't have that problem.? I chech dev.c , that is right.

Signature · 10 lines
thanks with regards!
hugang.

***********************************
Beijing Soul Technology Co.,Ltd.
Tel:010-68425741/42/43/44
Fax:010-68425745
email:[email protected]
web:http://www.soul.com.cn
***********************************
#3 lore raw
In reply to Witek Kręcicki

Hi,

Quoted 3 lines

Today I download the latest patch, And I patch it into the 2.5.6 tree, But it do't have that problem.? I chech dev.c , that is right.

Funny, the patches (from 2.5.6 to 2.5.7 and from 2.5.7-pre2 to 2.5.7) I downloaded from ftp.kernel.org do contain following patch:

laphish:/usr/src/patches # grep handle_diverter * patch-2.5.7:-

			handle_diverter(skb);
patch-2.5.7:+ 
	ret = handle_diverter(skb);
patch-2.5.7-pre2:- 
			handle_diverter(skb);
patch-2.5.7-pre2:+ 
	ret = handle_diverter(skb);

laphish:/usr/src/patches #

My patch reverts this but since you mention that for you it was correct I wonder if we're really talking about the same patch so I just downloaded them again and I can verify that the problem is really present:

ratz@laphish:~ > md5sum patch-2.5.7.* f89d55b1e94fbd974d8b3f4625a86a2a patch-2.5.7.bz2 0f5dec319d693dfe6c528a76e10cd1d1 patch-2.5.7.gz ratz@laphish:~ > bunzip2 patch-2.5.7.bz2 ratz@laphish:~ > grep handle_diverter patch-2.5.7 -

			handle_diverter(skb);
+ 
	ret = handle_diverter(skb);

ratz@laphish:~ > rm patch-2.5.7 ratz@laphish:~ > gunzip patch-2.5.7.gz ratz@laphish:~ > grep handle_diverter patch-2.5.7 -

			handle_diverter(skb);
+ 
	ret = handle_diverter(skb);

ratz@laphish:~ > rm patch-2.5.7 ratz@laphish:~ >

Cheers,
Roberto Nibali, ratz