Skip to contentSkip to conversation

m68k: q40: add missing spaces around '='

PATCH In review [email protected] 2 participants 2 messages Jul 20, 2023 – Jul 24, 2023 1 message not in the archive m68k architecture

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 1/1 m68k: q40: add missing spaces around '='

add missing spaces to clear checkpatch errors.

ERROR: spaces required around that '=' (ctx:VxV)

---
 arch/m68k/q40/q40ints.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
arch/m68k/q40/q40ints.c +5 -5
index 127d7ecdbd49..fdd6e48f4fe3 100644
@@ -132,10 +132,10 @@ static irqreturn_t q40_timer_int(int irq, void *dev_id)
 {
 	ql_ticks = ql_ticks ? 0 : 1;
 	if (sound_ticks) {
-		unsigned char sval=(sound_ticks & 1) ? 128-SVOL : 128+SVOL;
+		unsigned char sval = (sound_ticks & 1) ? 128-SVOL : 128+SVOL;
 		sound_ticks--;
-		*DAC_LEFT=sval;
-		*DAC_RIGHT=sval;
+		*DAC_LEFT = sval;
+		*DAC_RIGHT = sval;
 	}
 
 	if (!ql_ticks) {
@@ -171,7 +171,7 @@ void q40_sched_init (void)
 
 struct IRQ_TABLE{ unsigned mask; int irq ;};
 #if 0
-static struct IRQ_TABLE iirqs[]={
+static struct IRQ_TABLE iirqs[] = {
   {Q40_IRQ_FRAME_MASK,Q40_IRQ_FRAME},
   {Q40_IRQ_KEYB_MASK,Q40_IRQ_KEYBOARD},
   {0,0}};
@@ -189,7 +189,7 @@ static struct IRQ_TABLE eirqs[] = {
 };
 
 /* complain only this many times about spurious ints : */
-static int ccleirq=60;    /* ISA dev IRQs*/
+static int ccleirq = 60;    /* ISA dev IRQs*/
 /*static int cclirq=60;*/     /* internal */
 
 /* FIXME: add shared ints,mask,unmask,probing.... */
#2 lore raw

Hi Ran,

Quoted 5 lines · On Thu, Jul 20, 2023 at 5:54 AM <[email protected]> wrote:

add missing spaces to clear checkpatch errors.

ERROR: spaces required around that '=' (ctx:VxV)

WARNING: From:/Signed-off-by: email name mismatch: 'From:
[email protected]' != 'Signed-off-by: Ran Sun <[email protected]>'

Quoted 33 lines
---
  arch/m68k/q40/q40ints.c | 10 +++++-----
  1 file changed, 5 insertions(+), 5 deletions(-)
arch/m68k/q40/q40ints.c +3 -3
index 127d7ecdbd49..fdd6e48f4fe3 100644
@@ -132,10 +132,10 @@ static irqreturn_t q40_timer_int(int irq, void
 *dev_id)
  {
        ql_ticks = ql_ticks ? 0 : 1;
        if (sound_ticks) {
-               unsigned char sval=(sound_ticks & 1) ? 128-SVOL : 128+SVOL;
+               unsigned char sval = (sound_ticks & 1) ? 128-SVOL : 128+SVOL;
                sound_ticks--;
-               *DAC_LEFT=sval;
-               *DAC_RIGHT=sval;
+               *DAC_LEFT = sval;
+               *DAC_RIGHT = sval;
        }
 
        if (!ql_ticks) {
arch/m68k/q40/q40ints.c +1 -1
@@ -171,7 +171,7 @@ void q40_sched_init (void)
 
  struct IRQ_TABLE{ unsigned mask; int irq ;};
  #if 0
-static struct IRQ_TABLE iirqs[]={
+static struct IRQ_TABLE iirqs[] = {
    {Q40_IRQ_FRAME_MASK,Q40_IRQ_FRAME},
    {Q40_IRQ_KEYB_MASK,Q40_IRQ_KEYBOARD},
    {0,0}};

arch/m68k/q40/q40ints.c static struct IRQ_TABLE eirqs[] = { · line 195

Quoted 8 lines
arch/m68k/q40/q40ints.c +1 -1
@@ -189,7 +189,7 @@ static struct IRQ_TABLE eirqs[] = {
  };
 
  /* complain only this many times about spurious ints : */
-static int ccleirq=60;    /* ISA dev IRQs*/
+static int ccleirq = 60;    /* ISA dev IRQs*/
  /*static int cclirq=60;*/     /* internal */
 
  /* FIXME: add shared ints,mask,unmask,probing.... */

This patch is whitespace-damaged, so it fails to apply.

These problems are present in all your patches, so something is wrong in your workflow. Please test your patches by running scripts/checkpatch.pl, emailing them to yourself, and trying to apply them.

Thanks!

Gr{oetje,eeting}s,

Geert

Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds