next/master bisection: baseline.bootrr.mscc_felix-probed on kontron-kbox-a-230-ls

* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * *

* This automated bisection report was sent to you on the basis  *
* that you may be involved with the breaking commit it has      *
* found.  No manual investigation has been done to verify it,   *
* and the root cause of the problem may be somewhere else.      *
*                                                               *
* If you do send a fix, please include this trailer:            *
*   Reported-by: "kernelci.org bot" <[email protected]>          *
*                                                               *
* Hope this helps!                                              *

* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * *

next/master bisection: baseline.bootrr.mscc_felix-probed on kontron-kbox-a-230-ls

Summary:

  Start:      9d9019bcea1a Add linux-next specific files for 20230215
  Plain log:  https://storage.kernelci.org/next/master/next-20230215/arm64/defconfig+debug/gcc-10/lab-kontron/baseline-kontron-kbox-a-230-ls.txt
  HTML log:   https://storage.kernelci.org/next/master/next-20230215/arm64/defconfig+debug/gcc-10/lab-kontron/baseline-kontron-kbox-a-230-ls.html
  Result:     b203e6f1e833 arm64: dts: ls1028a: sl28: get MAC addresses from VPD

Checks:
revert: PASS
verify: PASS

Parameters:

  Tree:       next
  URL:        https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
  Branch:     master
  Target:     kontron-kbox-a-230-ls
  CPU arch:   arm64
  Lab:        lab-kontron
  Compiler:   gcc-10
  Config:     defconfig+debug
  Test case:  baseline.bootrr.mscc_felix-probed

Breaking commit found:

-------------------------------------------------------------------------------
commit b203e6f1e8336659878b6b604abd2a5fda0d8767

Author: Michael Walle <[email protected]>
Date:   Thu Jan 5 16:22:30 2023 +0100

arm64: dts: ls1028a: sl28: get MAC addresses from VPD

Now that it is finally possible to get the MAC addresses from the OTP memory, use it to set the addresses of the network devices.

There are 8 reserved MAC addresses in total per board. Distribute them as follows:

+----------+------+------+------+------+------+
| | var1 | var2 | var3 | var4 | kbox |
+----------+------+------+------+------+------+
| enetc #0 | +0 | | | +0 | +0 |
| enetc #1 | | | +0 | +1 | +1 |
| enetc #2 | | +2 | | | +2 |
| enetc #3 | | +3 | | | +3 |
| felix p0 | | +0 | | | +4 |
| felix p1 | | +1 | | | +5 |
| felix p2 | | | | | +6 |
| felix p3 | | | | | +7 |
| felix p4 | | | | | |
| felix p5 | | | | | |
+----------+------+------+------+------+------+

An empty cell means, the port is not available and thus doesn't need an ethernet address.

Signed-off-by Michael Walle <[email protected]>

Signed-off-by Shawn Guo <[email protected]>

arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-kbox-a-230-ls.dts +12 -0

index 73eb6061c73e..af9194eca556 100644
@@ -56,10 +56,14 @@ qsgmii_phy3: ethernet-phy@10 {
 };
 
 &enetc_port2 {
+	nvmem-cells = <&base_mac_address 2>;
+	nvmem-cell-names = "mac-address";
 	status = "okay";
 };
 
 &enetc_port3 {
+	nvmem-cells = <&base_mac_address 3>;
+	nvmem-cell-names = "mac-address";
 	status = "okay";
 };
 

@@ -80,6 +84,8 @@ &mscc_felix_port0 {
 	managed = "in-band-status";
 	phy-handle = <&qsgmii_phy0>;
 	phy-mode = "qsgmii";
+	nvmem-cells = <&base_mac_address 4>;
+	nvmem-cell-names = "mac-address";
 	status = "okay";
 };
 

@@ -88,6 +94,8 @@ &mscc_felix_port1 {
 	managed = "in-band-status";
 	phy-handle = <&qsgmii_phy1>;
 	phy-mode = "qsgmii";
+	nvmem-cells = <&base_mac_address 5>;
+	nvmem-cell-names = "mac-address";
 	status = "okay";
 };
 

@@ -96,6 +104,8 @@ &mscc_felix_port2 {
 	managed = "in-band-status";
 	phy-handle = <&qsgmii_phy2>;
 	phy-mode = "qsgmii";
+	nvmem-cells = <&base_mac_address 6>;
+	nvmem-cell-names = "mac-address";
 	status = "okay";
 };
 

@@ -104,6 +114,8 @@ &mscc_felix_port3 {
 	managed = "in-band-status";
 	phy-handle = <&qsgmii_phy3>;
 	phy-mode = "qsgmii";
+	nvmem-cells = <&base_mac_address 7>;
+	nvmem-cell-names = "mac-address";
 	status = "okay";
 };
 

arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var1.dts +2 -0

index 7cd29ab970d9..1f34c7553459 100644
@@ -55,5 +55,7 @@ &enetc_port0 {
 &enetc_port1 {
 	phy-handle = <&phy0>;
 	phy-mode = "rgmii-id";
+	nvmem-cells = <&base_mac_address 0>;
+	nvmem-cell-names = "mac-address";
 	status = "okay";
 };

arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var2.dts +8 -0

index 113b1df74bf8..aac41192caa1 100644
@@ -36,10 +36,14 @@ &enetc_port0 {
 };
 
 &enetc_port2 {
+	nvmem-cells = <&base_mac_address 2>;
+	nvmem-cell-names = "mac-address";
 	status = "okay";
 };
 
 &enetc_port3 {
+	nvmem-cells = <&base_mac_address 3>;
+	nvmem-cell-names = "mac-address";
 	status = "okay";
 };
 

@@ -52,6 +56,8 @@ &mscc_felix_port0 {
 	managed = "in-band-status";
 	phy-handle = <&phy0>;
 	phy-mode = "sgmii";
+	nvmem-cells = <&base_mac_address 0>;
+	nvmem-cell-names = "mac-address";
 	status = "okay";
 };
 

@@ -60,6 +66,8 @@ &mscc_felix_port1 {
 	managed = "in-band-status";
 	phy-handle = <&phy1>;
 	phy-mode = "sgmii";
+	nvmem-cells = <&base_mac_address 1>;
+	nvmem-cell-names = "mac-address";
 	status = "okay";
 };
 

arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var4.dts +2 -0

index 9b5e92fb753e..a4421db3784e 100644
@@ -43,5 +43,7 @@ vddh: vddh-regulator {
 &enetc_port1 {
 	phy-handle = <&phy1>;
 	phy-mode = "rgmii-id";
+	nvmem-cells = <&base_mac_address 1>;
+	nvmem-cell-names = "mac-address";
 	status = "okay";
 };

arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts +17 -1

index 4ab17b984b03..8b65af4a7147 100644
@@ -92,6 +92,8 @@ &enetc_port0 {
 	phy-handle = <&phy0>;
 	phy-mode = "sgmii";
 	managed = "in-band-status";
+	nvmem-cells = <&base_mac_address 0>;
+	nvmem-cell-names = "mac-address";
 	status = "okay";
 };
 

@@ -154,6 +156,21 @@ partition@3e0000 {
 				label = "bootloader environment";
 			};
 		};
+
+		otp-1 {
+			compatible = "user-otp";
+
+			nvmem-layout {
+				compatible = "kontron,sl28-vpd";
+
+				serial_number: serial-number {
+				};
+
+				base_mac_address: base-mac-address {
+					#nvmem-cell-cells = <1>;
+				};
+			};
+		};
 	};
 };
-------------------------------------------------------------------------------

Git bisection log:

-------------------------------------------------------------------------------
git bisect start
# good: [d5a1224aa68c8b124a4c5c390186e571815ed390] drm/i915/gen11: Wa_1408615072/Wa_1407596294 should be on GT list
git bisect good d5a1224aa68c8b124a4c5c390186e571815ed390
# bad: [9d9019bcea1aac7eed64a1a4966282b6b7b141c8] Add linux-next specific files for 20230215
git bisect bad 9d9019bcea1aac7eed64a1a4966282b6b7b141c8
# bad: [e8b85852ecfd21f4aca6456423c7e7eebd4de095] Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git
git bisect bad e8b85852ecfd21f4aca6456423c7e7eebd4de095
# bad: [230c2111794b1c5547149a9378fede8407a5f585] Merge branch 'nfsd-next' of git://git.kernel.org/pub/scm/linux/kernel/git/cel/linux
git bisect bad 230c2111794b1c5547149a9378fede8407a5f585
# bad: [954ca45433dc0ba3a6a8cd0d4150c76fa170d6b9] Merge branch 'soc/drivers' into for-next
git bisect bad 954ca45433dc0ba3a6a8cd0d4150c76fa170d6b9
# bad: [551413fe938808c78287c855f8076a612f9e9f50] Merge tag 'amlogic-arm-dt-for-v6.3' of https://git.kernel.org/pub/scm/linux/kernel/git/amlogic/linux into arm/dt git bisect bad 551413fe938808c78287c855f8076a612f9e9f50
# good: [a63a420d050d47a6afb5e2198181dadd08e71f97] arm64: dts: qcom: sc7280: Add a carveout for modem metadata
git bisect good a63a420d050d47a6afb5e2198181dadd08e71f97
# good: [d18eff504da5cb3e03fc0a38fce671ee7087be85] Merge tag 'arm-soc/for-6.3/devicetree-arm64' of https://github.com/Broadcom/stblinux into arm/dt git bisect good d18eff504da5cb3e03fc0a38fce671ee7087be85
# good: [739a7c29a704ed6bc2297865a469431becb664ba] Merge tag 'imx-dt-6.3' of git://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux into arm/dt git bisect good 739a7c29a704ed6bc2297865a469431becb664ba
# bad: [46e828026cc8daf29b251efca27b93eaaf906081] arm64: ls1046ardb: Use in-band-status for SFP module
git bisect bad 46e828026cc8daf29b251efca27b93eaaf906081
# good: [e9b751ca254458afc379138160aa4a498bae6063] arm64: dts: imx8mp: Add Hantro G1, G2 DT nodes
git bisect good e9b751ca254458afc379138160aa4a498bae6063
# bad: [bae293e9e7a14cc5c6b6976865cec6ee41ed370d] arm64: dts: imx8mp: Reorder clock to match fsl,imx6q-pcie.yaml
git bisect bad bae293e9e7a14cc5c6b6976865cec6ee41ed370d
# good: [94e6197dadc9c1f01c6704e9a097e48863036c61] arm64: dts: imx8mp: Add LCDIF2 & LDB nodes
git bisect good 94e6197dadc9c1f01c6704e9a097e48863036c61
# bad: [7e5f78c7de3247b3e25f35557530bcf0593014cd] arm64: dts: verdin-imx8mp: unify gpio-key node name
git bisect bad 7e5f78c7de3247b3e25f35557530bcf0593014cd
# bad: [b203e6f1e8336659878b6b604abd2a5fda0d8767] arm64: dts: ls1028a: sl28: get MAC addresses from VPD
git bisect bad b203e6f1e8336659878b6b604abd2a5fda0d8767
# good: [304feb6b9092a0efff25d0adc0bcdcf482bb8849] arm64: dts: freescale: Add LVDS overlay for TQMa8MPxL
git bisect good 304feb6b9092a0efff25d0adc0bcdcf482bb8849

# first bad commit: [b203e6f1e8336659878b6b604abd2a5fda0d8767] arm64: dts: ls1028a: sl28: get MAC addresses from VPD
-------------------------------------------------------------------------------

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group. View/Reply Online (#38389): https://groups.io/g/kernelci-results/message/38389
Mute This Topic: https://groups.io/mt/97062641/1131744
Group Owner: [email protected]
Unsubscribe: https://groups.io/g/kernelci-results/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

The KernelCI bisection bot bisected a failure to probe the mscc_felix in -next on kontron-kbox-a-230-ls to commit b203e6f1e8336659878b6 ("arm64:
dts: ls1028a: sl28: get MAC addresses from VPD"). The logging indicates that we're trying to probe the device:

<6>[   20.956081] mscc_felix 0000:00:00.5: Adding to iommu group 14
<6>[   20.972109] mscc_felix 0000:00:00.5: enabling device (0400 -> 0402)

but it seems it defers probe with:

0000:00:00.5 mscc_felix: Failed to register DSA switch