Skip to contentSkip to conversation

ceph: add support for python3.9

PATCH In review Xu, Yanfei 2 participants 3 messages Nov 11, 2020 – Nov 16, 2020

lore
Share & tools
lore

Xu, Yanfei

author
#0 lore raw

PATCH v2 1/1 ceph: add support for python3.9

From: Yanfei Xu <[email protected]>

Add support for python3.9, or it will do_configure failed.

---
v1->v2: Change the patch's Upstream-Status to 'Pending'.

 ...0001-cmake-add-support-for-python3.9.patch | 30 +++++++++++++++++++
 recipes-extended/ceph/ceph_15.2.0.bb          |  1 +
 2 files changed, 31 insertions(+)
 create mode 100644 recipes-extended/ceph/ceph/0001-cmake-add-support-for-python3.9.patch
recipes-extended/ceph/ceph/0001-cmake-add-support-for-python3.9.patch new file +30 -0
new file mode 100644
index 0000000..d9116c4
@@ -0,0 +1,30 @@
+From 1060f2e4362ebd6db23870d442dcd158d219ee92 Mon Sep 17 00:00:00 2001
+From: Yanfei Xu <[email protected]>
+Date: Tue, 10 Nov 2020 17:17:30 +0800
+Subject: [PATCH] cmake: add support for python3.9
+
+add support for python3.9.
+
+Upstream-Status: Pending
+
+Signed-off-by: Yanfei Xu <[email protected]>
+---
+ cmake/modules/FindPython/Support.cmake | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/cmake/modules/FindPython/Support.cmake b/cmake/modules/FindPython/Support.cmake
+index 6584699b79..c05bbe3306 100644
+--- a/cmake/modules/FindPython/Support.cmake
++++ b/cmake/modules/FindPython/Support.cmake
+@@ -17,7 +17,7 @@ if (NOT DEFINED _${_PYTHON_PREFIX}_REQUIRED_VERSION_MAJOR)
+   message (FATAL_ERROR "FindPython: INTERNAL ERROR")
+ endif()
+ if (_${_PYTHON_PREFIX}_REQUIRED_VERSION_MAJOR EQUAL 3)
+-  set(_${_PYTHON_PREFIX}_VERSIONS 3.8 3.7 3.6 3.5 3.4 3.3 3.2 3.1 3.0)
++  set(_${_PYTHON_PREFIX}_VERSIONS 3.9 3.8 3.7 3.6 3.5 3.4 3.3 3.2 3.1 3.0)
+ elseif (_${_PYTHON_PREFIX}_REQUIRED_VERSION_MAJOR EQUAL 2)
+   set(_${_PYTHON_PREFIX}_VERSIONS 2.7 2.6 2.5 2.4 2.3 2.2 2.1 2.0)
+ else()
+-- 
+2.18.2
+
recipes-extended/ceph/ceph_15.2.0.bb +1 -0
index bdc794f..8454a20 100644
@@ -21,6 +21,7 @@ SRC_URI = "http://download.ceph.com/tarballs/ceph-${PV}.tar.gz \
            file://0002-mon-enforce-caps-for-pre-octopus-client-tell-command.patch \
            file://0003-PendingReleaseNotes-note-about-security-fix.patch \
            file://0001-add-missing-include-for-atomic-bool.patch \
+           file://0001-cmake-add-support-for-python3.9.patch \
 "
 
 SRC_URI[md5sum] = "1f9af648b4c6d19975aab2583ab99710"
Signature · 1 line
2.18.2
#1 lore raw

You have a patch in your SRC_URI, that I don't have in master ..

So I checked the mailing list and found a submission from August.

I applied that patch first, and then yours.

As a general rule though, you should be sure that you are on upstream master, not a local branch when sending a patch. You would have noticed that I missed the patch and could have pinged / asked about it.

Cheers,

Bruce

In message: [meta-virtualization] [PATCH v2] ceph: add support for python3.9

Quoted 68 lines · Yanfei

From: Yanfei Xu <[email protected]>

Add support for python3.9, or it will do_configure failed.

---
v1->v2: Change the patch's Upstream-Status to 'Pending'.

 ...0001-cmake-add-support-for-python3.9.patch | 30 +++++++++++++++++++
 recipes-extended/ceph/ceph_15.2.0.bb          |  1 +
 2 files changed, 31 insertions(+)
 create mode 100644 recipes-extended/ceph/ceph/0001-cmake-add-support-for-python3.9.patch
recipes-extended/ceph/ceph/0001-cmake-add-support-for-python3.9.patch new file +30 -0
new file mode 100644
index 0000000..d9116c4
@@ -0,0 +1,30 @@
+From 1060f2e4362ebd6db23870d442dcd158d219ee92 Mon Sep 17 00:00:00 2001
+From: Yanfei Xu <[email protected]>
+Date: Tue, 10 Nov 2020 17:17:30 +0800
+Subject: [PATCH] cmake: add support for python3.9
+
+add support for python3.9.
+
+Upstream-Status: Pending
+
+Signed-off-by: Yanfei Xu <[email protected]>
+---
+ cmake/modules/FindPython/Support.cmake | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/cmake/modules/FindPython/Support.cmake b/cmake/modules/FindPython/Support.cmake
+index 6584699b79..c05bbe3306 100644
+--- a/cmake/modules/FindPython/Support.cmake
++++ b/cmake/modules/FindPython/Support.cmake
+@@ -17,7 +17,7 @@ if (NOT DEFINED _${_PYTHON_PREFIX}_REQUIRED_VERSION_MAJOR)
+   message (FATAL_ERROR "FindPython: INTERNAL ERROR")
+ endif()
+ if (_${_PYTHON_PREFIX}_REQUIRED_VERSION_MAJOR EQUAL 3)
+-  set(_${_PYTHON_PREFIX}_VERSIONS 3.8 3.7 3.6 3.5 3.4 3.3 3.2 3.1 3.0)
++  set(_${_PYTHON_PREFIX}_VERSIONS 3.9 3.8 3.7 3.6 3.5 3.4 3.3 3.2 3.1 3.0)
+ elseif (_${_PYTHON_PREFIX}_REQUIRED_VERSION_MAJOR EQUAL 2)
+   set(_${_PYTHON_PREFIX}_VERSIONS 2.7 2.6 2.5 2.4 2.3 2.2 2.1 2.0)
+ else()
+-- 
+2.18.2
+
recipes-extended/ceph/ceph_15.2.0.bb +1 -0
index bdc794f..8454a20 100644
@@ -21,6 +21,7 @@ SRC_URI = "http://download.ceph.com/tarballs/ceph-${PV}.tar.gz \
            file://0002-mon-enforce-caps-for-pre-octopus-client-tell-command.patch \
            file://0003-PendingReleaseNotes-note-about-security-fix.patch \
            file://0001-add-missing-include-for-atomic-bool.patch \
+           file://0001-cmake-add-support-for-python3.9.patch \
 "
 
 SRC_URI[md5sum] = "1f9af648b4c6d19975aab2583ab99710"
Signature · 1 line
2.18.2
author
#2 lore raw
Quoted 4 lines · Bruce Ashfield

[Please note this e-mail is from an EXTERNAL e-mail address]

You have a patch in your SRC_URI, that I don't have in master ..

Quoted 9 lines

So I checked the mailing list and found a submission from August.

I applied that patch first, and then yours.

As a general rule though, you should be sure that you are on upstream master, not a local branch when sending a patch. You would have noticed that I missed the patch and could have pinged / asked about it.

Sorry. I wrongly thought my local meta-virt layer was same with upstream master. Thank you and I will do that as you said next time.

Cheers,

Yanfei

Quoted 76 lines

Cheers,

Bruce

In message: [meta-virtualization] [PATCH v2] ceph: add support for python3.9

Quoted 68 lines · Yanfei

From: Yanfei Xu <[email protected]>

Add support for python3.9, or it will do_configure failed.

---
v1->v2: Change the patch's Upstream-Status to 'Pending'.

  ...0001-cmake-add-support-for-python3.9.patch | 30 +++++++++++++++++++
  recipes-extended/ceph/ceph_15.2.0.bb          |  1 +
  2 files changed, 31 insertions(+)

create mode 100644 recipes-extended/ceph/ceph/0001-cmake-add-support-for-python3.9.patch

recipes-extended/ceph/ceph/0001-cmake-add-support-for-python3.9.patch new file +30 -0
new file mode 100644
index 0000000..d9116c4
@@ -0,0 +1,30 @@
+From 1060f2e4362ebd6db23870d442dcd158d219ee92 Mon Sep 17 00:00:00 2001
+From: Yanfei Xu <[email protected]>
+Date: Tue, 10 Nov 2020 17:17:30 +0800
+Subject: [PATCH] cmake: add support for python3.9
+
+add support for python3.9.
+
+Upstream-Status: Pending
+
+Signed-off-by: Yanfei Xu <[email protected]>
+---
+ cmake/modules/FindPython/Support.cmake | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/cmake/modules/FindPython/Support.cmake b/cmake/modules/FindPython/Support.cmake
+index 6584699b79..c05bbe3306 100644
+--- a/cmake/modules/FindPython/Support.cmake
++++ b/cmake/modules/FindPython/Support.cmake
+@@ -17,7 +17,7 @@ if (NOT DEFINED _${_PYTHON_PREFIX}_REQUIRED_VERSION_MAJOR)
+   message (FATAL_ERROR "FindPython: INTERNAL ERROR")
+ endif()
+ if (_${_PYTHON_PREFIX}_REQUIRED_VERSION_MAJOR EQUAL 3)
+-  set(_${_PYTHON_PREFIX}_VERSIONS 3.8 3.7 3.6 3.5 3.4 3.3 3.2 3.1 3.0)
++  set(_${_PYTHON_PREFIX}_VERSIONS 3.9 3.8 3.7 3.6 3.5 3.4 3.3 3.2 3.1 3.0)
+ elseif (_${_PYTHON_PREFIX}_REQUIRED_VERSION_MAJOR EQUAL 2)
+   set(_${_PYTHON_PREFIX}_VERSIONS 2.7 2.6 2.5 2.4 2.3 2.2 2.1 2.0)
+ else()
+--
+2.18.2
+
recipes-extended/ceph/ceph_15.2.0.bb +1 -1
index bdc794f..8454a20 100644
@@ -21,6 +21,7 @@ SRC_URI = "http://download.ceph.com/tarballs/ceph-${PV}.tar.gz \
             file://0002-mon-enforce-caps-for-pre-octopus-client-tell-command.patch \
             file://0003-PendingReleaseNotes-note-about-security-fix.patch \
             file://0001-add-missing-include-for-atomic-bool.patch \
+           file://0001-cmake-add-support-for-python3.9.patch \
  "
 
  SRC_URI[md5sum] = "1f9af648b4c6d19975aab2583ab99710"
--

2.18.2