Skip to contentSkip to conversation

serial: sirf: Staticize local symbols

PATCH In review Jingoo Han 2 participants 2 messages Aug 8, 2013 – Aug 12, 2013 TTY layer and serial drivers

lore
Share & tools
lore

Jingoo Han

author
#0 lore raw

PATCH 10/10 serial: sirf: Staticize local symbols

Quoted 1 line

From 0170294084877d365fbd1b369cd4dedfc3749ee5 Mon Sep 17 00:00:00 2001

From: Jingoo Han <[email protected]>
Date: Thu, 8 Aug 2013 17:24:38 +0900
Subject: [PATCH 10/10] serial: sirf: Staticize local symbols

These local symbols are used only in this file.
Fix the following sparse warnings:

drivers/tty/serial/sirfsoc_uart.c:147:6: warning: symbol 'sirfsoc_uart_start_tx' was not declared. Should it be static? drivers/tty/serial/sirfsoc_uart.c:636:5: warning: symbol 'sirfsoc_uart_probe' was not declared. Should it be static?

---
 drivers/tty/serial/sirfsoc_uart.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/tty/serial/sirfsoc_uart.c +2 -2
index 67a0d1b..3b38137 100644
@@ -144,7 +144,7 @@ static void sirfsoc_uart_stop_tx(struct uart_port *port)
 	wr_regl(port, SIRFUART_INT_EN, regv & ~SIRFUART_TX_INT_EN);
 }
 
-void sirfsoc_uart_start_tx(struct uart_port *port)
+static void sirfsoc_uart_start_tx(struct uart_port *port)
 {
 	struct sirfsoc_uart_port *sirfport = to_sirfport(port);
 	unsigned long regv;
@@ -633,7 +633,7 @@ static struct uart_driver sirfsoc_uart_drv = {
 #endif
 };
 
-int sirfsoc_uart_probe(struct platform_device *pdev)
+static int sirfsoc_uart_probe(struct platform_device *pdev)
 {
 	struct sirfsoc_uart_port *sirfport;
 	struct uart_port *port;
Signature · 1 line
1.7.10.4
Acked-by on v1 10/10
#1 lore raw

2013/8/8 Jingoo Han <[email protected]>:

Quoted 5 lines

From 0170294084877d365fbd1b369cd4dedfc3749ee5 Mon Sep 17 00:00:00 2001
From: Jingoo Han <[email protected]>
Date: Thu, 8 Aug 2013 17:24:38 +0900
Subject: [PATCH 10/10] serial: sirf: Staticize local symbols

Quoted 8 lines

These local symbols are used only in this file.
Fix the following sparse warnings:

drivers/tty/serial/sirfsoc_uart.c:147:6: warning: symbol 'sirfsoc_uart_start_tx' was not declared. Should it be static? drivers/tty/serial/sirfsoc_uart.c:636:5: warning: symbol 'sirfsoc_uart_probe' was not declared. Should it be static?

---

Quoted 28 lines
 drivers/tty/serial/sirfsoc_uart.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/tty/serial/sirfsoc_uart.c +2 -3
index 67a0d1b..3b38137 100644
@@ -144,7 +144,7 @@ static void sirfsoc_uart_stop_tx(struct uart_port *port)
        wr_regl(port, SIRFUART_INT_EN, regv & ~SIRFUART_TX_INT_EN);
 }
 
-void sirfsoc_uart_start_tx(struct uart_port *port)
+static void sirfsoc_uart_start_tx(struct uart_port *port)
 {
        struct sirfsoc_uart_port *sirfport = to_sirfport(port);
        unsigned long regv;
@@ -633,7 +633,7 @@ static struct uart_driver sirfsoc_uart_drv = {
 #endif
 };
 
-int sirfsoc_uart_probe(struct platform_device *pdev)
+static int sirfsoc_uart_probe(struct platform_device *pdev)
 {
        struct sirfsoc_uart_port *sirfport;
        struct uart_port *port;
--

1.7.10.4