Makefile: Disable parallel build for $(CRITICAL_MAKEFILES)

This patch fixes parallel build error. When use parallel build

with -j16 or -j8, $(CRITICAL_MAKEFILES) are created as empty file

because generate-makefiles is called several times. So need to

disable parallel build.

The following code can guarantee sequencial building.

.NOTPARALLEL: $(CRITICAL_MAKEFILES)

Signed-off-by jungsoo.son <[email protected]>

---

testcases/open_posix_testsuite/Makefile | 2 ++

1 file changed, 2 insertions(+)

testcases/open_posix_testsuite/Makefile +0 -0

index 9c61fa4..bce5cf3 100644

--- a/testcases/open_posix_testsuite/Makefile

+++ b/testcases/open_posix_testsuite/Makefile

testcases/open_posix_testsuite/Makefile +2 -0

@@ -110,5 +110,7 @@ $(CRITICAL_MAKEFILES): \
 
     $(top_srcdir)/LDLIBS
 
         @$(MAKE) generate-makefiles
 
+.NOTPARALLEL: $(CRITICAL_MAKEFILES)
 
+

#tests-pretty:

# $(MAKE) all | column -t -s:

Signature · 17 lines

1.7.9.5



------------------------------------------------------------------------------
Try New Relic Now & We'll Send You this Cool Shirt
New Relic is the only SaaS-based application performance monitoring service 
that delivers powerful full stack analytics. Optimize and monitor your
browser, app, & servers with just a few lines of code. Try New Relic
and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_may



_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

This patch fixes parallel build error. When use parallel build

with -j16 or -j8, $(CRITICAL_MAKEFILES) are created as empty file

because generate-makefiles is called several times. So need to

disable parallel build.

The following code can guarantee sequencial building.

.NOTPARALLEL: $(CRITICAL_MAKEFILES)

Quoted 10 lines

This patch fixes parallel build error. When use parallel build

with -j16 or -j8, $(CRITICAL_MAKEFILES) are created as empty file

because generate-makefiles is called several times. So need to

disable parallel build.

The following code can guarantee sequencial building.

Quoted 1 line

.NOTPARALLEL: $(CRITICAL_MAKEFILES)

The problem is that Open Posix Testsuite should stuck with POSIX make. At least we promise that we will not break it actively. Now the 2008 POSIX make still does not support the idea of parallel build. I will have a look what will other than GNU make implementations do with such rule. If it would be ignored then we are fine adding it, if not we will have to figure out how to detect GNU make and add the line accordingly.

Quoted 8 lines

I got a an idea how to fix this in portable fashion. The key is the order of filenames the make looks for.

The gnu make tries GNUmakefile first, then makefile or Makefile.

So if we create GNUmakefile, which would include the Makefile and adds the .NOTPARALLEL: target it should work both with both GNU make and any other POSIX conforming make out there.

I think your idea is good.
But I think that the code to distinguish GNU make and other POSIX will makes the Makefile to be more complex.
I do not wish to complicate the Makefile more than is necessary. How about using '-j1' without '.NOTPARALLEL:' option as follows.

Quoted 9 lines

Quoted 8 lines

I got a an idea how to fix this in portable fashion. The key is the order of filenames the make looks for.

The gnu make tries GNUmakefile first, then makefile or Makefile.

So if we create GNUmakefile, which would include the Makefile and adds the .NOTPARALLEL: target it should work both with both GNU make and any other POSIX conforming make out there.

Quoted 5 lines

I think your idea is good.
But I think that the code to distinguish GNU make and other POSIX will makes the Makefile to be more complex.
I do not wish to complicate the Makefile more than is necessary. How about using '-j1' without '.NOTPARALLEL:' option as follows.

Again the same problem as previously. The POSIX specification does not require the -j option to exist as the standard does not take parallel build into the account at all. And for the Open Posix part of LTP we need to stick to the POSIX.

And looking at the POSIX spec again, the POSIX make does not even support including files. So the only way how to fix this is to copy the top level Makefile to GNUmakefile and add the line. :(