Skip to contentSkip to conversation

serial: altera: remove unnecessary platform_set_drvdata()

PATCH In review Jingoo Han 2 participants 2 messages May 7, 2013 – May 14, 2013

Subsystems (2)
lore
Share & tools
lore

Jingoo Han

author
#0 lore raw

PATCH 1/15 serial: altera: remove unnecessary platform_set_drvdata()

The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.

---
 drivers/tty/serial/altera_uart.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
drivers/tty/serial/altera_uart.c +0 -1
index 13471dd..1d46966 100644
@@ -604,7 +604,6 @@ static int altera_uart_remove(struct platform_device *pdev)
 
 	if (port) {
 		uart_remove_one_port(&altera_uart_driver, port);
-		platform_set_drvdata(pdev, NULL);
 		port->mapbase = 0;
 	}
 
Signature · 1 line
1.7.2.5
maintainer Acked-by on v1 1/15
#1 lore raw
Quoted 6 lines · Jingoo Han

The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.

Thanks a lot