Skip to contentSkip to conversation

add new Samsung SXGbE driver

PATCH Superseded Byungho An 2 participants 3 messages Mar 13, 2014 – Mar 16, 2014

Subsystems (3)

v2 of 14 Superseded Latest is v14 →

lore
Share & tools
lore

Byungho An

author
#0 lore raw

v2 cover add new Samsung SXGbE driver

Hi all,

This is 2nd posting for Samsung SXGbE driver and just re-sending because of line wrapping in previous posting.

Changes since v1:
- changed name of driver to SXGbE as per Ben's comment
- squashed Joe's neatening for many stuff in original patches

Byungho An (1):
MAINTAINERS: add maintainer for Samsung sxgbe driver

Girish K S (2):
net: sxgbe: add EEE(Energy Efficient Ethernet) for Samsung sxgbe
net: sxgbe: add WOL(Wakeup-On-Lan)support for Samsung sxgbe

Siva Reddy (1):
net: sxgbe: add basic framework for Samsung 10Gb ethernet driver

Vipul Pandya (3):
net: sxgbe: add TSO support for Samsung sxgbe
net: sxgbe: add Checksum offload support for Samsung sxgbe
net: sxgbe: add ethtool related functions support Samsung sxgbe

 .../devicetree/bindings/net/samsung-sxgbe.txt      |   39 +
 MAINTAINERS                                        |    9 +
 drivers/net/ethernet/Kconfig                       |    1 +
 drivers/net/ethernet/Makefile                      |    1 +
 drivers/net/ethernet/samsung/Kconfig               |    7 +
 drivers/net/ethernet/samsung/Makefile              |    4 +
 drivers/net/ethernet/samsung/sxgbe_common.h        |  571 +++++
 drivers/net/ethernet/samsung/sxgbe_core.c          |  290 +++
 drivers/net/ethernet/samsung/sxgbe_desc.c          |  515 ++++
 drivers/net/ethernet/samsung/sxgbe_desc.h          |  298 +++
 drivers/net/ethernet/samsung/sxgbe_dma.c           |  381 +++
 drivers/net/ethernet/samsung/sxgbe_dma.h           |   51 +
 drivers/net/ethernet/samsung/sxgbe_ethtool.c       |  628 +++++
 drivers/net/ethernet/samsung/sxgbe_main.c          | 2447
++++++++++++++++++++
 drivers/net/ethernet/samsung/sxgbe_mdio.c          |  274 +++
 drivers/net/ethernet/samsung/sxgbe_mtl.c           |  279 +++
 drivers/net/ethernet/samsung/sxgbe_mtl.h           |  108 +
 drivers/net/ethernet/samsung/sxgbe_platform.c      |  272 +++
 drivers/net/ethernet/samsung/sxgbe_reg.h           |  491 ++++
 drivers/net/ethernet/samsung/sxgbe_xpcs.c          |   92 +
 drivers/net/ethernet/samsung/sxgbe_xpcs.h          |   38 +
 include/linux/sxgbe_platform.h                     |   54 +
 22 files changed, 6850 insertions(+)

Thanks,
Byungho An

maintainer
#1 lore raw

From: Byungho An <[email protected]>
Date: Thu, 13 Mar 2014 15:55:28 +0900

Quoted 6 lines

This is 2nd posting for Samsung SXGbE driver and just re-sending because of line wrapping in previous posting.

Changes since v1:
- changed name of driver to SXGbE as per Ben's comment
- squashed Joe's neatening for many stuff in original patches

I'm mostly happy with this driver, but all of those module parameters have to be removed except for 'debug'.

They duplicate functionality provided by ethtool.

Module parameters are strongly, if not completely, discouraged. A suitable generic configuration mechanism, such as ethtool, should always be used instead.

author
#2 lore raw
Quoted 5 lines · David Miller

From: Byungho An <[email protected]>
Date: Thu, 13 Mar 2014 15:55:28 +0900

Quoted 1 line

This is 2nd posting for Samsung SXGbE driver and just re-sending because

of

Quoted 8 lines
Quoted 5 lines

line wrapping in previous posting.

Changes since v1:
- changed name of driver to SXGbE as per Ben's comment
- squashed Joe's neatening for many stuff in original patches

I'm mostly happy with this driver, but all of those module parameters have to be removed except for 'debug'.

OK, I'll remove them.

Quoted 2 lines

They duplicate functionality provided by ethtool.

OK.

Quoted 4 lines

Module parameters are strongly, if not completely, discouraged. A suitable generic configuration mechanism, such as ethtool, should always be used instead.

OK. I'll repost soon.

Thanks

Quoted 4 lines

--
To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html