Skip to contentSkip to conversation

mfd: intel_msic: remove unnecessary platform_set_drvdata()

PATCH In review Jingoo Han 4 participants 5 messages May 6, 2013 – May 16, 2013 Multifunction devices (MFD)

lore
Share & tools
lore

Jingoo Han

author
#0 lore raw

PATCH 1/8 mfd: intel_msic: remove unnecessary platform_set_drvdata()

The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.

---
 drivers/mfd/intel_msic.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
drivers/mfd/intel_msic.c +0 -1
index 5be3b5e..977506e 100644
@@ -443,7 +443,6 @@ static int intel_msic_remove(struct platform_device *pdev)
 	struct intel_msic *msic = platform_get_drvdata(pdev);
 
 	intel_msic_remove_devices(msic);
-	platform_set_drvdata(pdev, NULL);
 
 	return 0;
 }
Signature · 1 line
1.7.2.5
Acked-by on v1 1/8
#1 lore raw
Quoted 6 lines · Jingoo Han

The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.

author
#2 lore raw
Quoted 9 lines · Mika Westerberg
Quoted 6 lines · Jingoo Han

The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.

Hi Mika Westerberg,

Thank you for your Acked-by. :)
It is very helpuful.

Best regards,
Jingoo Han

Acked-by on v1 1/8
#3 lore raw
In reply to Jingoo Han
Quoted 15 lines · Jingoo Han

The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.

---
 drivers/mfd/intel_msic.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
drivers/mfd/intel_msic.c +0 -0
index 5be3b5e..977506e 100644

drivers/mfd/intel_msic.c static int intel_msic_remove(struct platform_device *pdev) · line 448

Quoted 7 lines
drivers/mfd/intel_msic.c +0 -1
@@ -443,7 +443,6 @@ static int intel_msic_remove(struct platform_device *pdev)
 	struct intel_msic *msic = platform_get_drvdata(pdev);
 
 	intel_msic_remove_devices(msic);
-	platform_set_drvdata(pdev, NULL);
 
 	return 0;
 }

For the set:

Signature · 4 lines
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
#4 lore raw
In reply to Jingoo Han

Hi Jingoo,

Quoted 9 lines · Jingoo Han

The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.

---
 drivers/mfd/intel_msic.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

All 8 patches applied to mfd-next.

Cheers,
Samuel.

Signature · 2 lines
Intel Open Source Technology Centre
http://oss.intel.com/