mfd: intel_msic: remove unnecessary platform_set_drvdata()
PATCH 1/8 mfd: intel_msic: remove unnecessary platform_set_drvdata()
The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.
--- drivers/mfd/intel_msic.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)
drivers/mfd/intel_msic.c +0 -1
@@ -443,7 +443,6 @@ static int intel_msic_remove(struct platform_device *pdev)struct intel_msic *msic =platform_get_drvdata (pdev);intel_msic_remove_devices (msic); -platform_set_drvdata (pdev,NULL );return 0 ; }
Signature · 1 line
1.7.2.5
Quoted 6 lines · Jingoo Han
The driver core clears the driver data to NULL after
device_releaseor on probe failure, since commit0998d0631001288a5974afc0b2a5f568bcdecb4d(device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.Signed-off-by Jingoo Han <[email protected]>
Quoted 9 lines · Mika Westerberg
Quoted 6 lines · Jingoo Han
The driver core clears the driver data to NULL after
device_releaseor on probe failure, since commit0998d0631001288a5974afc0b2a5f568bcdecb4d(device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.Signed-off-by Jingoo Han <[email protected]>Acked-by Mika Westerberg <[email protected]>
Hi Mika Westerberg,
Thank you for your Acked-by. :)
It is very helpuful.
Best regards,
Jingoo Han
Quoted 15 lines · Jingoo Han
The driver core clears the driver data to NULL after
device_releaseor on probe failure, since commit0998d0631001288a5974afc0b2a5f568bcdecb4d(device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.Signed-off-by Jingoo Han <[email protected]>--- drivers/mfd/intel_msic.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)drivers/mfd/intel_msic.c +0
-0
drivers/mfd/intel_msic.c static int intel_msic_remove(struct platform_device *pdev) · line 448
Quoted 7 lines
drivers/mfd/intel_msic.c +0
-1@@ -443,7 +443,6 @@ static int intel_msic_remove(struct platform_device *pdev)struct intel_msic *msic =platform_get_drvdata (pdev);intel_msic_remove_devices (msic); -platform_set_drvdata (pdev,NULL );return 0 ; }
For the set:
Signature · 4 lines
Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
Hi Jingoo,
Quoted 9 lines · Jingoo Han
The driver core clears the driver data to NULL after
device_releaseor on probe failure, since commit0998d0631001288a5974afc0b2a5f568bcdecb4d(device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.Signed-off-by Jingoo Han <[email protected]>--- drivers/mfd/intel_msic.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)
All 8 patches applied to mfd-next.
Cheers,
Samuel.
Signature · 2 lines
Intel Open Source Technology Centre http://oss.intel.com/