mail_tests.sh : a small mistake

LTP Yuki Yao 2 participants 2 messages Mar 8, 2010

lore

Share & tools

lore

Yuki Yao

author

2010-03-08 08:30 UTC #0 lore raw

Hi,

I found a small mistake about "mail" test.

When mail reception error occurred in "Test #3", this test displays "Test #2" not "Test #3".

Signed-off-by Yuki Yao<[email protected]>

Index: ./testcases/commands/mail/mail_tests.sh
==============================
--- ./testcases/commands/mail/mail_tests.sh.orig 2010-03-08
16:00:56.000000000 +0900
+++ ./testcases/commands/mail/mail_tests.sh 2010-03-08
16:01:34.000000000 +0900
@@ -257,7 +257,7 @@

     if [ -z "$RC1" -a -z "$RC2" -a -z "$RC3" ]
     then
         $LTPBIN/tst_res TFAIL $LTPTMP/tst_mail.res \
-        "Test #2: No new mail for root. Reason:"
+        "Test #3: No new mail for root. Reason:"
         TFAILCNT=$(( $TFAILCNT+1 ))
     else
         if [ $RC1 -ne 0 -a $RC2 -ne 0 ] || [ $RC1 -ne 0 -a $RC3 -ne 0 ]

Thanks,
-Yuki Yao

------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Garrett Cooper

2010-03-08 15:49 UTC #1 lore raw

Quoted 16 lines · Yuki Yao

Hi,
I found a small mistake about "mail" test.
When mail reception error occurred in "Test #3", this test displays "Test #2" not "Test #3".
Signed-off-by Yuki Yao<[email protected]>
Index: ./testcases/commands/mail/mail_tests.sh
==============================
--- ./testcases/commands/mail/mail_tests.sh.orig 2010-03-08 16:00:56.000000000 +0900
+++ ./testcases/commands/mail/mail_tests.sh 2010-03-08 16:01:34.000000000 +0900
(quoted diff) +0 -0
@@ -257,7 +257,7 @@

Quoted 8 lines

if [ -z "$RC1" -a -z "$RC2" -a -z "$RC3" ]
then
$LTPBIN/tst_res TFAIL $LTPTMP/tst_mail.res \
- "Test #2: No new mail for root. Reason:"
+ "Test #3: No new mail for root. Reason:" TFAILCNT=$(( $TFAILCNT+1 ))
else
if [ $RC1 -ne 0 -a $RC2 -ne 0 ] || [ $RC1 -ne 0 -a $RC3 -ne 0 ]

This was already fixed on git head.
Thanks,
-Garrett