gpiolib: add gpiod_multi_set_value_cansleep
Subsystems (13)
David Lechner
reviewerv3 cover gpiolib: add gpiod_multi_set_value_cansleep
This series was inspired by some minor annoyance I have experienced a few times in recent reviews.
Calling gpiod_set_array_value_cansleep() can be quite verbose due to having so many parameters. In most cases, we already have a struct gpio_descs that contains the first 3 parameters so we end up with 3 (or often even 6) pointer indirections at each call site. Also, people have a tendency to want to hard-code the first argument instead of using struct gpio_descs.ndescs, often without checking that ndescs >= the hard-coded value.
So I'm proposing that we add a gpiod_multi_set_value_cansleep() function that is a wrapper around gpiod_set_array_value_cansleep() that has struct gpio_descs as the first parameter to make it a bit easier to read the code and avoid the hard-coding temptation.
I've just done gpiod_multi_set_value_cansleep() for now since there were over 10 callers of this one. There aren't as many callers of the get and atomic variants, but we can add those too if this seems like a useful thing to do.
Maintainers, if you prefer to have this go through the gpio tree, please give your Acked-by:. Several maintainers have also requested an immutable branch, so I expect that will be made available. And if there is anything leftover after the next kernel release, I will resend it.
---
Changes in v3:
- Added IS_ERR_OR_NULL() check to gpiod_multi_set_value_cansleep()
- Added new patches to clean up accessing bitmap directly (ts-nbus, ad2s1210).
- Added function prefix for max3191x.
- Removed unnecessary braces in ad7606 patch.
- Picked up additional trailers.
- Link to v2: https://lore.kernel.org/r/[email protected]
Changes in v2:
- Renamed new function from gpiods_multi_set_value_cansleep() to gpiod_multi_set_value_cansleep()
- Fixed typo in name of replaced function in all commit messages.
- Picked up trailers.
- Link to v1: https://lore.kernel.org/r/[email protected]
---
David Lechner (15):
gpiolib: add gpiod_multi_set_value_cansleep()
auxdisplay: seg-led-gpio: use gpiod_multi_set_value_cansleep
bus: ts-nbus: validate ts,data-gpios array size
bus: ts-nbus: use gpiod_multi_set_value_cansleep
bus: ts-nbus: use bitmap_get_value8()
gpio: max3191x: use gpiod_multi_set_value_cansleep
iio: adc: ad7606: use gpiod_multi_set_value_cansleep
iio: amplifiers: hmc425a: use gpiod_multi_set_value_cansleep
iio: resolver: ad2s1210: use gpiod_multi_set_value_cansleep
iio: resolver: ad2s1210: use bitmap_write
mmc: pwrseq_simple: use gpiod_multi_set_value_cansleep
mux: gpio: use gpiod_multi_set_value_cansleep
net: mdio: mux-gpio: use gpiod_multi_set_value_cansleep
phy: mapphone-mdm6600: use gpiod_multi_set_value_cansleep
ASoC: adau1701: use gpiod_multi_set_value_cansleep
drivers/auxdisplay/seg-led-gpio.c | 3 +-- drivers/bus/ts-nbus.c | 15 +++++++++------ drivers/gpio/gpio-max3191x.c | 18 +++++++----------- drivers/iio/adc/ad7606.c | 3 +-- drivers/iio/adc/ad7606_spi.c | 7 +++---- drivers/iio/amplifiers/hmc425a.c | 3 +-- drivers/iio/resolver/ad2s1210.c | 13 +++++-------- drivers/mmc/core/pwrseq_simple.c | 3 +-- drivers/mux/gpio.c | 4 +--- drivers/net/mdio/mdio-mux-gpio.c | 3 +-- drivers/phy/motorola/phy-mapphone-mdm6600.c | 4 +--- include/linux/gpio/consumer.h | 11 +++++++++++ sound/soc/codecs/adau1701.c | 4 +--- 13 files changed, 43 insertions(+), 48 deletions(-)
---
base-commit: df4b2bbff898227db0c14264ac7edd634e79f755
change-id: 20250131-gpio-set-array-helper-bd4a328370d3
Best regards,
Signature · 1 line
David Lechner <[email protected]>
David Lechner
reviewerPATCH v3 1/15 gpiolib: add gpiod_multi_set_value_cansleep()
Add a new gpiod_multi_set_value_cansleep() helper function with fewer parameters than gpiod_set_array_value_cansleep().
Calling gpiod_set_array_value_cansleep() can get quite verbose. In many cases, the first arguments all come from the same struct gpio_descs, so having a separate function where we can just pass that cuts down on the boilerplate.
---
FYI, I dropped Linus' Reviewed-by: tag since adding the IS_ERR_OR_NULL() check isn't exactly trivial.
--- include/linux/gpio/consumer.h | 11 +++++++++++ 1 file changed, 11 insertions(+)
include/linux/gpio/consumer.h +11 -0
@@ -3,6 +3,7 @@#define __LINUX_GPIO_CONSUMER_H#include <linux/bits.h> +#include <linux/err.h> #include <linux/types.h> struct acpi_device ;
@@ -655,4 +656,14 @@ static inline void gpiod_unexport(struct gpio_desc *desc)#endif /* CONFIG_GPIOLIB && CONFIG_GPIO_SYSFS */ +static inline int gpiod_multi_set_value_cansleep (struct gpio_descs *descs, +unsigned long *value_bitmap) +{ +if (IS_ERR_OR_NULL (descs)) +return PTR_ERR_OR_ZERO (descs); + +return gpiod_set_array_value_cansleep (descs->ndescs, descs->desc, + descs->info, value_bitmap); +} +#endif
Signature · 1 line
2.43.0
Re: [PATCH v3 01/15] gpiolib: add gpiod_multi_set_value_cansleep()
Quoted 9 lines · David Lechner
Add a new
gpiod_multi_set_value_cansleep()helper function with fewer parameters thangpiod_set_array_value_cansleep().Calling
gpiod_set_array_value_cansleep()can get quite verbose. In many cases, the first arguments all come from the same structgpio_descs, so having a separate function where we can just pass that cuts down on the boilerplate.Signed-off-by David Lechner <[email protected]>
Gr{oetje,eeting}s,
Geert
Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected] In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Re: [PATCH v3 01/15] gpiolib: add gpiod_multi_set_value_cansleep()
In reply to David LechnerQuoted 7 lines · David Lechner
Add a new
gpiod_multi_set_value_cansleep()helper function with fewer parameters thangpiod_set_array_value_cansleep().Calling
gpiod_set_array_value_cansleep()can get quite verbose. In many cases, the first arguments all come from the same structgpio_descs, so having a separate function where we can just pass that cuts down on the boilerplate.
LGTM now,
Signature · 2 lines
With Best Regards, Andy Shevchenko
Re: [PATCH v3 01/15] gpiolib: add gpiod_multi_set_value_cansleep()
In reply to David LechnerQuoted 9 lines · David Lechner
Add a new
gpiod_multi_set_value_cansleep()helper function with fewer parameters thangpiod_set_array_value_cansleep().Calling
gpiod_set_array_value_cansleep()can get quite verbose. In many cases, the first arguments all come from the same structgpio_descs, so having a separate function where we can just pass that cuts down on the boilerplate.Signed-off-by David Lechner <[email protected]>
Yours,
Linus Walleij
David Lechner
reviewerPATCH v3 2/15 auxdisplay: seg-led-gpio: use gpiod_multi_set_value_cansleep
In reply to David LechnerReduce verbosity by using gpiod_multi_set_value_cansleep() instead of gpiod_set_array_value_cansleep().
--- drivers/auxdisplay/seg-led-gpio.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/auxdisplay/seg-led-gpio.c +1 -2
@@ -36,8 +36,7 @@ static void seg_led_update(struct work_struct *work)bitmap_set_value8 (values,map_to_seg7 (&map->map.seg7, linedisp->buf[0 ]),0 ); -gpiod_set_array_value_cansleep (priv->segment_gpios->ndescs, priv->segment_gpios->desc, - priv->segment_gpios->info, values); +gpiod_multi_set_value_cansleep (priv->segment_gpios, values); }static int seg_led_linedisp_get_map_type (struct linedisp *linedisp)
Signature · 1 line
2.43.0
Andy Shevchenko
maintainerRe: [PATCH v3 02/15] auxdisplay: seg-led-gpio: use gpiod_multi_set_value_cansleep
Quoted 2 lines · David Lechner
Reduce verbosity by using
gpiod_multi_set_value_cansleep()instead ofgpiod_set_array_value_cansleep().
Pushed to my review and testing queue, thanks!
Signature · 2 lines
With Best Regards, Andy Shevchenko
David Lechner
reviewerPATCH v3 3/15 bus: ts-nbus: validate ts,data-gpios array size
In reply to David LechnerAdd validation of ts,data-gpios array size during probe. The driver later hard-codes 8 as the size of the array when using it, so we should be validating that the array is actually that big to prevent possible out of bounds accesses.
--- drivers/bus/ts-nbus.c | 4 ++++ 1 file changed, 4 insertions(+)
drivers/bus/ts-nbus.c +4 -0
@@ -48,6 +48,10 @@ static int ts_nbus_init_pdata(struct platform_device *pdev,return dev_err_probe (&pdev->dev,PTR_ERR (ts_nbus->data),"failed to retrieve ts,data-gpio from dts\n" ); +if (ts_nbus->data->ndescs !=8 ) +return dev_err_probe (&pdev->dev, -EINVAL , +"invalid number of ts,data-gpios\n" ); + ts_nbus->csn =devm_gpiod_get (&pdev->dev,"ts,csn" ,GPIOD_OUT_HIGH );if (IS_ERR (ts_nbus->csn)) return dev_err_probe(&pdev->dev, PTR_ERR(ts_nbus->csn),
Signature · 1 line
2.43.0
David Lechner
reviewerPATCH v3 4/15 bus: ts-nbus: use gpiod_multi_set_value_cansleep
In reply to David LechnerReduce verbosity by using gpiod_multi_set_value_cansleep() instead of gpiod_set_array_value_cansleep().
ts_nbus->data->ndescs is validated to be 8 during probe, so will have the same value as the hard-coded 8 that is removed by this change.
--- drivers/bus/ts-nbus.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/bus/ts-nbus.c +2 -4
@@ -109,8 +109,7 @@ static void ts_nbus_reset_bus(struct ts_nbus *ts_nbus) values[0 ] =0 ; -gpiod_set_array_value_cansleep (8 , ts_nbus->data->desc, - ts_nbus->data->info, values); +gpiod_multi_set_value_cansleep (ts_nbus->data, values);gpiod_set_value_cansleep (ts_nbus->csn,0 );gpiod_set_value_cansleep (ts_nbus->strobe,0 );gpiod_set_value_cansleep (ts_nbus->ale,0 );
@@ -150,12 +149,11 @@ static int ts_nbus_read_byte(struct ts_nbus *ts_nbus, u8 *val)*/ static void ts_nbus_write_byte (struct ts_nbus *ts_nbus,u8 byte) { -struct gpio_descs *gpios = ts_nbus->data;DECLARE_BITMAP (values,8 ); values[0 ] = byte; -gpiod_set_array_value_cansleep (8 , gpios->desc, gpios->info, values); +gpiod_multi_set_value_cansleep (ts_nbus->data, values); }/*
Signature · 1 line
2.43.0
David Lechner
reviewerPATCH v3 5/15 bus: ts-nbus: use bitmap_get_value8()
In reply to David LechnerUse bitmap_get_value8() instead of accessing the bitmap directly.
Accessing the bitmap directly is not considered good practice. We now have a helper function that can be used instead, so let's use it.
--- drivers/bus/ts-nbus.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/bus/ts-nbus.c +3 -2
@@ -10,6 +10,7 @@* TS-4600 SoM. */ +#include <linux/bitmap.h> #include <linux/bitops.h> #include <linux/gpio/consumer.h> #include <linux/kernel.h>
@@ -107,7 +108,7 @@ static void ts_nbus_reset_bus(struct ts_nbus *ts_nbus) {DECLARE_BITMAP (values,8 ); - values[0 ] =0 ; +bitmap_set_value8 (values, byte,0 );gpiod_multi_set_value_cansleep (ts_nbus->data, values);gpiod_set_value_cansleep (ts_nbus->csn,0 );
@@ -151,7 +152,7 @@ static void ts_nbus_write_byte(struct ts_nbus *ts_nbus, u8 byte) {DECLARE_BITMAP (values,8 ); - values[0 ] = byte; +bitmap_set_value8 (values, byte,8 );gpiod_multi_set_value_cansleep (ts_nbus->data, values); }
Signature · 1 line
2.43.0
Re: [PATCH v3 05/15] bus: ts-nbus: use bitmap_get_value8()
Quoted 4 lines · David Lechner
Use
bitmap_get_value8()instead of accessing the bitmap directly.Accessing the bitmap directly is not considered good practice. We now have a helper function that can be used instead, so let's use it.
Thank you, LGTM (one minor thing you may address, or keep it as in the current variant of the patch),
...
Quoted 2 lines
+#include <
linux/bitmap.h>
#include <linux/bitops.h>
bitmap.h implies bitops.h
Signature · 2 lines
With Best Regards, Andy Shevchenko
Simon Horman
reviewerRe: [PATCH v3 05/15] bus: ts-nbus: use bitmap_get_value8()
In reply to David LechnerQuoted 6 lines · David Lechner
Use
bitmap_get_value8()instead of accessing the bitmap directly.Accessing the bitmap directly is not considered good practice. We now have a helper function that can be used instead, so let's use it.
Suggested-by Andy Shevchenko <[email protected]>
u> Signed-off-by: David Lechner <[email protected]>
Quoted 17 lines
--- drivers/bus/ts-nbus.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)drivers/bus/ts-nbus.c +1
-0@@ -10,6 +10,7 @@* TS-4600 SoM. */ +#include <linux/bitmap.h> #include <linux/bitops.h> #include <linux/gpio/consumer.h> #include <linux/kernel.h>
drivers/bus/ts-nbus.c static void ts_nbus_reset_bus(struct ts_nbus *ts_nbus) · line 111
Quoted 5 lines
drivers/bus/ts-nbus.c +1
-1@@ -107,7 +108,7 @@ static void ts_nbus_reset_bus(struct ts_nbus *ts_nbus) {DECLARE_BITMAP (values,8 ); - values[0 ] =0 ; +bitmap_set_value8 (values, byte,0 );
Hi David,
byte doesn't appear to exist in the scope of this function.
I tried this:
bitmap_set_value8(values, 0, 8);
But when compiling with GCC 14.2.0 I see warnings that values is used uninitialised - bitmap_set_value8() appears to rely on it being so.
CC drivers/bus/ts-nbus.o
In file included from drivers/bus/ts-nbus.c:13:
In function ‘bitmap_write’,
inlined from ‘ts_nbus_reset_bus’ at drivers/bus/ts-nbus.c:111:2:./include/linux/bitmap.h:818:12: error: ‘values’ is used uninitialized [-Werror=uninitialized]
818 | map[index] &= (fit ? (~(mask << offset)) : ~BITMAP_FIRST_WORD_MASK(start));
| ~~~^~~~~~~
In file included from ./include/linux/kasan-checks.h:5,
from ./include/asm-generic/rwonce.h:26,
from ./arch/x86/include/generated/asm/rwonce.h:1,
from ./include/linux/compiler.h:344,
from ./include/linux/build_bug.h:5,
from ./include/linux/bits.h:22,
from ./include/linux/bitops.h:6,
from ./include/linux/bitmap.h:8:drivers/bus/ts-nbus.c: In function ‘ts_nbus_reset_bus’:drivers/bus/ts-nbus.c:109:24: note: ‘values’ declared here
109 | DECLARE_BITMAP(values, 8);
| ^~~~~~./include/linux/types.h:11:23: note: in definition of macro ‘DECLARE_BITMAP’
11 | unsigned long name[BITS_TO_LONGS(bits)]
| ^~~~
Quoted 16 lines
drivers/bus/ts-nbus.c +1
-1gpiod_multi_set_value_cansleep (ts_nbus->data, values);gpiod_set_value_cansleep (ts_nbus->csn,0 );@@ -151,7 +152,7 @@ static void ts_nbus_write_byte(struct ts_nbus *ts_nbus, u8 byte) {DECLARE_BITMAP (values,8 ); - values[0 ] = byte; +bitmap_set_value8 (values, byte,8 );gpiod_multi_set_value_cansleep (ts_nbus->data, values); }Signature · 2 lines
-- 2.43.0
Re: [PATCH v3 05/15] bus: ts-nbus: use bitmap_get_value8()
Quoted 1 line · Simon Horman
On Mon, Feb 10, 2025 at 04:33:31PM -0600, David Lechner wrote:
...
Quoted 10 lines
But when compiling with GCC 14.2.0 I see warnings that values is used uninitialised -
bitmap_set_value8()appears to rely on it being so.In file included from
drivers/bus/ts-nbus.c:13:
In function ‘bitmap_write’,
inlined from ‘ts_nbus_reset_bus’ atdrivers/bus/ts-nbus.c:111:2:./include/linux/bitmap.h:818:12: error: ‘values’ is used uninitialized [-Werror=uninitialized]818 | map[index] &= (fit ? (~(mask << offset)) : ~BITMAP_FIRST_WORD_MASK(start)); | ~~~^~~~~~~
Heh, the compiler is dumb. Even if it's not initialised we do not care.
...
Wondering if the bitmap_write() will work better...
Signature · 2 lines
With Best Regards, Andy Shevchenko
David Lechner
reviewerRe: [PATCH v3 05/15] bus: ts-nbus: use bitmap_get_value8()
Quoted 16 lines · Andy Shevchenko
Quoted 1 line · Simon Horman
On Mon, Feb 10, 2025 at 04:33:31PM -0600, David Lechner wrote:
...
Quoted 10 lines
But when compiling with GCC 14.2.0 I see warnings that values is used uninitialised -
bitmap_set_value8()appears to rely on it being so.In file included from
drivers/bus/ts-nbus.c:13:
In function ‘bitmap_write’,
inlined from ‘ts_nbus_reset_bus’ atdrivers/bus/ts-nbus.c:111:2:./include/linux/bitmap.h:818:12: error: ‘values’ is used uninitialized [-Werror=uninitialized]818 | map[index] &= (fit ? (~(mask << offset)) : ~BITMAP_FIRST_WORD_MASK(start)); | ~~~^~~~~~~
Quoted 6 lines
Heh, the compiler is dumb. Even if it's not initialised we do not care.
...
Wondering if the
bitmap_write()will work better...
It is already using that:
#define bitmap_set_value8(map, value, start) \
bitmap_write(map, value, start, BITS_PER_BYTE)
David Lechner
reviewerRe: [PATCH v3 05/15] bus: ts-nbus: use bitmap_get_value8()
In reply to Simon HormanQuoted 35 lines · Simon Horman
Quoted 6 lines · David Lechner
Use
bitmap_get_value8()instead of accessing the bitmap directly.Accessing the bitmap directly is not considered good practice. We now have a helper function that can be used instead, so let's use it.
Suggested-by Andy Shevchenko <[email protected]>u> Signed-off-by: David Lechner <[email protected]>
Quoted 17 lines
--- drivers/bus/ts-nbus.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)drivers/bus/ts-nbus.c +1
-0@@ -10,6 +10,7 @@* TS-4600 SoM. */ +#include <linux/bitmap.h> #include <linux/bitops.h> #include <linux/gpio/consumer.h> #include <linux/kernel.h> drivers/bus/ts-nbus.c static void ts_nbus_reset_bus(struct ts_nbus *ts_nbus) · line 111
Quoted 5 lines
drivers/bus/ts-nbus.c +1
-1@@ -107,7 +108,7 @@ static void ts_nbus_reset_bus(struct ts_nbus *ts_nbus) {DECLARE_BITMAP (values,8 ); - values[0 ] =0 ; +bitmap_set_value8 (values, byte,0 );Hi David,
byte doesn't appear to exist in the scope of this function.
Quoted 7 lines
I tried this:
bitmap_set_value8(values, 0, 8);But when compiling with GCC 14.2.0 I see warnings that values is used uninitialised -
bitmap_set_value8()appears to rely on it being so.
Ah yes, I see the problem (I don't think this driver compiles with allmodconfig so the compiler didn't catch it for me).
Quoted 26 lines
CC
drivers/bus/ts-nbus.o
In file included fromdrivers/bus/ts-nbus.c:13:
In function ‘bitmap_write’,
inlined from ‘ts_nbus_reset_bus’ atdrivers/bus/ts-nbus.c:111:2:./include/linux/bitmap.h:818:12: error: ‘values’ is used uninitialized [-Werror=uninitialized]818 | map[index] &= (fit ? (~(mask << offset)) : ~BITMAP_FIRST_WORD_MASK(start)); | ~~~^~~~~~~ In file included from ./include/linux/kasan-checks.h:5, from ./include/asm-generic/rwonce.h:26, from ./arch/x86/include/generated/asm/rwonce.h:1, from ./include/linux/compiler.h:344, from ./include/linux/build_bug.h:5, from ./include/linux/bits.h:22, from ./include/linux/bitops.h:6, from ./include/linux/bitmap.h:8:
drivers/bus/ts-nbus.c: In function ‘ts_nbus_reset_bus’:drivers/bus/ts-nbus.c:109:24: note: ‘values’ declared here
109 |DECLARE_BITMAP(values, 8);
| ^~~~~~./include/linux/types.h:11:23: note: in definition of macro ‘DECLARE_BITMAP’
11 | unsigned long name[BITS_TO_LONGS(bits)]
| ^~~~Quoted 1 line
Quoted 5 lines
drivers/bus/ts-nbus.c static void ts_nbus_write_byte(struct ts_nbus *ts_nbus, u8 byte) · line 153
Quoted 5 lines
drivers/bus/ts-nbus.c +0
-0gpiod_multi_set_value_cansleep (ts_nbus->data, values);gpiod_set_value_cansleep (ts_nbus->csn,0 );@@ -151,7 +152,7 @@ static void ts_nbus_write_byte(struct ts_nbus *ts_nbus, u8 byte) {DECLARE_BITMAP (values,8 );
We can fix by zero-initialing the bitmap.
DECLARE_BITMAP(values, 8) = { };Would you like me to send a new version of the patch?
Quoted 10 lines
Quoted 10 lines
drivers/bus/ts-nbus.c +1
-1- values[0 ] = byte; +bitmap_set_value8 (values, byte,8 );gpiod_multi_set_value_cansleep (ts_nbus->data, values); }Signature · 1 line
2.43.0
Simon Horman
reviewerRe: [PATCH v3 05/15] bus: ts-nbus: use bitmap_get_value8()
Quoted 38 lines · David Lechner
Quoted 37 lines · Simon Horman
Quoted 6 lines · David Lechner
Use
bitmap_get_value8()instead of accessing the bitmap directly.Accessing the bitmap directly is not considered good practice. We now have a helper function that can be used instead, so let's use it.
Suggested-by Andy Shevchenko <[email protected]>u> Signed-off-by: David Lechner <[email protected]>
Quoted 17 lines
--- drivers/bus/ts-nbus.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)drivers/bus/ts-nbus.c +1
-0@@ -10,6 +10,7 @@* TS-4600 SoM. */ +#include <linux/bitmap.h> #include <linux/bitops.h> #include <linux/gpio/consumer.h> #include <linux/kernel.h> drivers/bus/ts-nbus.c static void ts_nbus_reset_bus(struct ts_nbus *ts_nbus) · line 111
Quoted 5 lines
drivers/bus/ts-nbus.c +1
-1@@ -107,7 +108,7 @@ static void ts_nbus_reset_bus(struct ts_nbus *ts_nbus) {DECLARE_BITMAP (values,8 ); - values[0 ] =0 ; +bitmap_set_value8 (values, byte,0 );Hi David,
byte doesn't appear to exist in the scope of this function.
I tried this:
Quoted 8 lines
Quoted 5 lines
bitmap_set_value8(values, 0, 8);But when compiling with GCC 14.2.0 I see warnings that values is used uninitialised -
bitmap_set_value8()appears to rely on it being so.Ah yes, I see the problem (I don't think this driver compiles with allmodconfig so the compiler didn't catch it for me).
Thanks, that would explain things.
FWIIW, I think you can exercise this with allmodconfig by simply running:
make drivers/bus/ts-nbus.o
Quoted 35 lines
Quoted 27 lines
CC
drivers/bus/ts-nbus.o
In file included fromdrivers/bus/ts-nbus.c:13:
In function ‘bitmap_write’,
inlined from ‘ts_nbus_reset_bus’ atdrivers/bus/ts-nbus.c:111:2:./include/linux/bitmap.h:818:12: error: ‘values’ is used uninitialized [-Werror=uninitialized]818 | map[index] &= (fit ? (~(mask << offset)) : ~BITMAP_FIRST_WORD_MASK(start)); | ~~~^~~~~~~ In file included from ./include/linux/kasan-checks.h:5, from ./include/asm-generic/rwonce.h:26, from ./arch/x86/include/generated/asm/rwonce.h:1, from ./include/linux/compiler.h:344, from ./include/linux/build_bug.h:5, from ./include/linux/bits.h:22, from ./include/linux/bitops.h:6, from ./include/linux/bitmap.h:8:
drivers/bus/ts-nbus.c: In function ‘ts_nbus_reset_bus’:drivers/bus/ts-nbus.c:109:24: note: ‘values’ declared here
109 |DECLARE_BITMAP(values, 8);
| ^~~~~~./include/linux/types.h:11:23: note: in definition of macro ‘DECLARE_BITMAP’
11 | unsigned long name[BITS_TO_LONGS(bits)]
| ^~~~Quoted 1 line
Quoted 5 lines
drivers/bus/ts-nbus.c static void ts_nbus_write_byte(struct ts_nbus *ts_nbus, u8 byte) · line 153
Quoted 5 lines
drivers/bus/ts-nbus.c +0
-0gpiod_multi_set_value_cansleep (ts_nbus->data, values);gpiod_set_value_cansleep (ts_nbus->csn,0 );@@ -151,7 +152,7 @@ static void ts_nbus_write_byte(struct ts_nbus *ts_nbus, u8 byte) {DECLARE_BITMAP (values,8 );We can fix by zero-initialing the bitmap.
Quoted 1 line
DECLARE_BITMAP(values, 8) = { };Thanks, I confirmed that adding that to ts_nbus_reset_bus() makes the compiler happy. And it seems sensible to me.
I guess that theoretically it should also be added to ts_nbus_write_byte(), although GCC has nothing to say about that either way.
Quoted 1 line
Would you like me to send a new version of the patch?
It's not really my call. But I would expect that is a good next step.
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
drivers/bus/ts-nbus.c +1
-1- values[0 ] = byte; +bitmap_set_value8 (values, byte,8 );gpiod_multi_set_value_cansleep (ts_nbus->data, values); }
David Lechner
reviewerPATCH v3 6/15 gpio: max3191x: use gpiod_multi_set_value_cansleep
In reply to David LechnerReduce verbosity by using gpiod_multi_set_value_cansleep() instead of gpiod_set_array_value_cansleep().
Also add max3191x_ namespace prefix to the driver's helper function since we are changing the function signature anyway.
--- drivers/gpio/gpio-max3191x.c | 18 +++++++----------- 1 file changed, 7 insertions(+), 11 deletions(-)
drivers/gpio/gpio-max3191x.c +7 -11
@@ -309,23 +309,21 @@ static int max3191x_set_config(struct gpio_chip *gpio, unsigned int offset,return 0 ; } -static void gpiod_set_array_single_value_cansleep (unsigned int ndescs, -struct gpio_desc **desc, -struct gpio_array *info, +static void max3191x_gpiod_multi_set_single_value (struct gpio_descs *descs,int value) {unsigned long *values; - values =bitmap_alloc (ndescs,GFP_KERNEL ); + values =bitmap_alloc (descs->ndescs,GFP_KERNEL );if (!values)return ;if (value) -bitmap_fill (values, ndescs); +bitmap_fill (values, descs->ndescs);else -bitmap_zero (values, ndescs); +bitmap_zero (values, descs->ndescs); -gpiod_set_array_value_cansleep (ndescs, desc, info, values); +gpiod_multi_set_value_cansleep (descs, values);bitmap_free (values); }
@@ -396,10 +394,8 @@ static int max3191x_probe(struct spi_device *spi) max3191x->mode =device_property_read_bool (dev,"maxim,modesel-8bit" ) ?STATUS_BYTE_DISABLED :STATUS_BYTE_ENABLED ;if (max3191x->modesel_pins) -gpiod_set_array_single_value_cansleep ( - max3191x->modesel_pins->ndescs, - max3191x->modesel_pins->desc, - max3191x->modesel_pins->info, max3191x->mode); +max3191x_gpiod_multi_set_single_value (max3191x->modesel_pins, + max3191x->mode); max3191x->ignore_uv =device_property_read_bool (dev,"maxim,ignore-undervoltage" );
Signature · 1 line
2.43.0
Re: [PATCH v3 06/15] gpio: max3191x: use gpiod_multi_set_value_cansleep
Quoted 5 lines · David Lechner
Reduce verbosity by using
gpiod_multi_set_value_cansleep()instead ofgpiod_set_array_value_cansleep().Also add
max3191x_namespace prefix to the driver's helper function since we are changing the function signature anyway.
With renamed function looks much better, thanks,
Signature · 2 lines
With Best Regards, Andy Shevchenko
David Lechner
reviewerPATCH v3 7/15 iio: adc: ad7606: use gpiod_multi_set_value_cansleep
In reply to David LechnerReduce verbosity by using gpiod_multi_set_value_cansleep() instead of gpiod_set_array_value().
These are not called in an atomic context, so changing to the cansleep variant is fine.
Also drop unnecessary braces while we are at it.
--- drivers/iio/adc/ad7606.c | 3 +-- drivers/iio/adc/ad7606_spi.c | 7 +++---- 2 files changed, 4 insertions(+), 6 deletions(-)
drivers/iio/adc/ad7606.c +1 -2
@@ -818,8 +818,7 @@ static int ad7606_write_os_hw(struct iio_dev *indio_dev, int val) values[0 ] = val &GENMASK (2 ,0 ); -gpiod_set_array_value (st->gpio_os->ndescs, st->gpio_os->desc, - st->gpio_os->info, values); +gpiod_multi_set_value_cansleep (st->gpio_os, values);/* AD7616 requires a reset to update value */ if (st->chip_info->os_req_reset)
drivers/iio/adc/ad7606_spi.c +3 -4
@@ -296,10 +296,9 @@ static int ad7606B_sw_mode_config(struct iio_dev *indio_dev)* in the device tree, then they need to be set to high, * otherwise, they must be hardwired to VDD */ -if (st->gpio_os) { -gpiod_set_array_value (st->gpio_os->ndescs, - st->gpio_os->desc, st->gpio_os->info, os); - } +if (st->gpio_os) +gpiod_multi_set_value_cansleep (st->gpio_os, os); +/* OS of 128 and 256 are available only in software mode */ st->oversampling_avail = ad7606B_oversampling_avail; st->num_os_ratios =ARRAY_SIZE (ad7606B_oversampling_avail);
Signature · 1 line
2.43.0
Jonathan Cameron
maintainerRe: [PATCH v3 07/15] iio: adc: ad7606: use gpiod_multi_set_value_cansleep
Quoted 11 lines · On Mon, 10 Feb 2025 16:33:33 -0600 David Lechner <[email protected]> wrote:
Reduce verbosity by using
gpiod_multi_set_value_cansleep()instead ofgpiod_set_array_value().These are not called in an atomic context, so changing to the cansleep variant is fine.
Also drop unnecessary braces while we are at it.
Reviewed-by Linus Walleij <[email protected]>Acked-by Jonathan Cameron <[email protected]>Signed-off-by David Lechner <[email protected]>
I've applied this to the IIO tree now but won't push out as anything other than testing until Bartosz has dropped it. (thanks for doing that btw!)
Due to code movement it ends up being all in ad7606.c
drivers/iio/adc/ad7606.c +4 -6
@@ -828,8 +828,7 @@ static int ad7606_write_os_hw(struct iio_dev *indio_dev, int val) values[0 ] = val &GENMASK (2 ,0 ); -gpiod_set_array_value (st->gpio_os->ndescs, st->gpio_os->desc, - st->gpio_os->info, values); +gpiod_multi_set_value_cansleep (st->gpio_os, values);/* AD7616 requires a reset to update value */ if (st->chip_info->os_req_reset)
@@ -1260,10 +1259,9 @@ static int ad7606b_sw_mode_setup(struct iio_dev *indio_dev)* in the device tree, then they need to be set to high, * otherwise, they must be hardwired to VDD */ -if (st->gpio_os) { -gpiod_set_array_value (st->gpio_os->ndescs, st->gpio_os->desc, - st->gpio_os->info, os); - } +if (st->gpio_os) +gpiod_multi_set_value_cansleep (st->gpio_os, os); +/* OS of 128 and 256 are available only in software mode */ st->oversampling_avail = ad7606b_oversampling_avail; st->num_os_ratios =ARRAY_SIZE (ad7606b_oversampling_avail);
Quoted 38 lines
--- drivers/iio/adc/ad7606.c | 3 +-- drivers/iio/adc/ad7606_spi.c | 7 +++---- 2 files changed, 4 insertions(+), 6 deletions(-)drivers/iio/adc/ad7606.c +1
-2@@ -818,8 +818,7 @@ static int ad7606_write_os_hw(struct iio_dev *indio_dev, int val) values[0 ] = val &GENMASK (2 ,0 ); -gpiod_set_array_value (st->gpio_os->ndescs, st->gpio_os->desc, - st->gpio_os->info, values); +gpiod_multi_set_value_cansleep (st->gpio_os, values);/* AD7616 requires a reset to update value */ if (st->chip_info->os_req_reset)drivers/iio/adc/ad7606_spi.c +3
-4@@ -296,10 +296,9 @@ static int ad7606B_sw_mode_config(struct iio_dev *indio_dev)* in the device tree, then they need to be set to high, * otherwise, they must be hardwired to VDD */ -if (st->gpio_os) { -gpiod_set_array_value (st->gpio_os->ndescs, - st->gpio_os->desc, st->gpio_os->info, os); - } +if (st->gpio_os) +gpiod_multi_set_value_cansleep (st->gpio_os, os); +/* OS of 128 and 256 are available only in software mode */ st->oversampling_avail = ad7606B_oversampling_avail; st->num_os_ratios =ARRAY_SIZE (ad7606B_oversampling_avail);
David Lechner
reviewerPATCH v3 8/15 iio: amplifiers: hmc425a: use gpiod_multi_set_value_cansleep
In reply to David LechnerReduce verbosity by using gpiod_multi_set_value_cansleep() instead of gpiod_set_array_value_cansleep().
Passing NULL as the 3rd argument to gpiod_set_array_value_cansleep() only needs to be done if the array was constructed manually, which is not the case here. This change effectively replaces that argument with st->gpios->array_info. The possible side effect of this change is that it could make setting the GPIOs more efficient.
--- drivers/iio/amplifiers/hmc425a.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/iio/amplifiers/hmc425a.c +1 -2
@@ -161,8 +161,7 @@ static int hmc425a_write(struct iio_dev *indio_dev, u32 value) values[0 ] = value; -gpiod_set_array_value_cansleep (st->gpios->ndescs, st->gpios->desc, -NULL , values); +gpiod_multi_set_value_cansleep (st->gpios, values);return 0 ; }
Signature · 1 line
2.43.0
David Lechner
reviewerPATCH v3 9/15 iio: resolver: ad2s1210: use gpiod_multi_set_value_cansleep
In reply to David LechnerReduce verbosity by using gpiod_multi_set_value_cansleep() instead of gpiod_set_array_value().
These are not called in an atomic context, so changing to the cansleep variant is fine.
--- drivers/iio/resolver/ad2s1210.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-)
drivers/iio/resolver/ad2s1210.c +2 -6
@@ -182,8 +182,7 @@ static int ad2s1210_set_mode(struct ad2s1210_state *st, enum ad2s1210_mode mode) bitmap[0 ] = mode; -return gpiod_set_array_value (gpios->ndescs, gpios->desc, gpios->info, - bitmap); +return gpiod_multi_set_value_cansleep (gpios, bitmap); }/*
@@ -1473,10 +1472,7 @@ static int ad2s1210_setup_gpios(struct ad2s1210_state *st) bitmap[0 ] = st->resolution; - ret =gpiod_set_array_value (resolution_gpios->ndescs, - resolution_gpios->desc, - resolution_gpios->info, - bitmap); + ret =gpiod_multi_set_value_cansleep (resolution_gpios, bitmap);if (ret <0 )return dev_err_probe (dev, ret,"failed to set resolution gpios\n" );
Signature · 1 line
2.43.0
David Lechner
reviewerPATCH v3 10/15 iio: resolver: ad2s1210: use bitmap_write
In reply to David LechnerReplace bitmap array access with bitmap_write.
Accessing the bitmap array directly is not recommended and now there is a helper function that can be used.
--- drivers/iio/resolver/ad2s1210.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/iio/resolver/ad2s1210.c +3 -2
@@ -46,6 +46,7 @@*/ #include <linux/bitfield.h> +#include <linux/bitmap.h> #include <linux/bits.h> #include <linux/cleanup.h> #include <linux/clk.h>
@@ -180,7 +181,7 @@ static int ad2s1210_set_mode(struct ad2s1210_state *st, enum ad2s1210_mode mode)if (!gpios)return mode == st->fixed_mode ?0 : -EOPNOTSUPP ; - bitmap[0 ] = mode; +bitmap_write (bitmap, mode,0 ,2 );return gpiod_multi_set_value_cansleep (gpios, bitmap); }
@@ -1470,7 +1471,7 @@ static int ad2s1210_setup_gpios(struct ad2s1210_state *st)return dev_err_probe (dev, -EINVAL ,"requires exactly 2 resolution-gpios\n" ); - bitmap[0 ] = st->resolution; +bitmap_write (bitmap, st->resolution,0 ,2 ); ret =gpiod_multi_set_value_cansleep (resolution_gpios, bitmap);if (ret <0 )
Signature · 1 line
2.43.0
Re: [PATCH v3 10/15] iio: resolver: ad2s1210: use bitmap_write
Quoted 7 lines · On Mon, 10 Feb 2025 16:33:36 -0600 David Lechner <[email protected]> wrote:
Replace bitmap array access with
bitmap_write.Accessing the bitmap array directly is not recommended and now there is a helper function that can be used.
Reviewed-by Linus Walleij <[email protected]>Signed-off-by David Lechner <[email protected]>
Quoted 35 lines
--- drivers/iio/resolver/ad2s1210.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)drivers/iio/resolver/ad2s1210.c +3
-2@@ -46,6 +46,7 @@*/ #include <linux/bitfield.h> +#include <linux/bitmap.h> #include <linux/bits.h> #include <linux/cleanup.h> #include <linux/clk.h> @@ -180,7 +181,7 @@ static int ad2s1210_set_mode(struct ad2s1210_state *st, enum ad2s1210_mode mode)if (!gpios)return mode == st->fixed_mode ?0 : -EOPNOTSUPP ; - bitmap[0 ] = mode; +bitmap_write (bitmap, mode,0 ,2 );return gpiod_multi_set_value_cansleep (gpios, bitmap); }@@ -1470,7 +1471,7 @@ static int ad2s1210_setup_gpios(struct ad2s1210_state *st)return dev_err_probe (dev, -EINVAL ,"requires exactly 2 resolution-gpios\n" ); - bitmap[0 ] = st->resolution; +bitmap_write (bitmap, st->resolution,0 ,2 ); ret =gpiod_multi_set_value_cansleep (resolution_gpios, bitmap);if (ret <0 )
David Lechner
reviewerRe: [PATCH v3 10/15] iio: resolver: ad2s1210: use bitmap_write
In reply to David LechnerQuoted 34 lines · David Lechner
Replace bitmap array access with
bitmap_write.Accessing the bitmap array directly is not recommended and now there is a helper function that can be used.
Reviewed-by Linus Walleij <[email protected]>Signed-off-by David Lechner <[email protected]>--- drivers/iio/resolver/ad2s1210.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)drivers/iio/resolver/ad2s1210.c +2
-1@@ -46,6 +46,7 @@*/ #include <linux/bitfield.h> +#include <linux/bitmap.h> #include <linux/bits.h> #include <linux/cleanup.h> #include <linux/clk.h> @@ -180,7 +181,7 @@ static int ad2s1210_set_mode(struct ad2s1210_state *st, enum ad2s1210_mode mode)if (!gpios)return mode == st->fixed_mode ?0 : -EOPNOTSUPP ; - bitmap[0 ] = mode; +bitmap_write (bitmap, mode,0 ,2 );return gpiod_multi_set_value_cansleep (gpios, bitmap); }
drivers/iio/resolver/ad2s1210.c static int ad2s1210_setup_gpios(struct ad2s1210_state *st) · line 1477
Quoted 8 lines
drivers/iio/resolver/ad2s1210.c +1
-1@@ -1470,7 +1471,7 @@ static int ad2s1210_setup_gpios(struct ad2s1210_state *st)return dev_err_probe (dev, -EINVAL ,"requires exactly 2 resolution-gpios\n" ); - bitmap[0 ] = st->resolution; +bitmap_write (bitmap, st->resolution,0 ,2 ); ret =gpiod_multi_set_value_cansleep (resolution_gpios, bitmap);if (ret <0 )
There is actually a bug here pointed out in a similar patch. bitmap_write() only modifies the bitmap, so this introduces an unintialized use bug. [1] Here, we only use the bits that we set, so runtime behavior would not actually be buggy but still best to fully initialize the memory.
I'm a bit surprised that my local compiler and iio/testing both didn't catch that since GCC 14 caught it in the other driver.
The fix is simple, we can zero-initialize the bitmap.
drivers/iio/resolver/ad2s1210.c +2 -2
@@ -176,7 +176,7 @@ struct ad2s1210_state {static int ad2s1210_set_mode (struct ad2s1210_state *st,enum ad2s1210_mode mode) {struct gpio_descs *gpios = st->mode_gpios; -DECLARE_BITMAP (bitmap,2 ); + DECLARE_BITMAP(bitmap, 2) = { };if (!gpios)return mode == st->fixed_mode ?0 : -EOPNOTSUPP ;
@@ -1427,7 +1427,7 @@ static int ad2s1210_setup_gpios(struct ad2s1210_state *st)struct device *dev = &st->sdev->dev;struct gpio_descs *resolution_gpios;struct gpio_desc *reset_gpio; -DECLARE_BITMAP (bitmap,2 ); + DECLARE_BITMAP(bitmap, 2) = { };int ret;/* should not be sampling on startup */
Jonathan Cameron
maintainerRe: [PATCH v3 10/15] iio: resolver: ad2s1210: use bitmap_write
Quoted 49 lines · On Thu, 20 Feb 2025 14:54:53 -0600 David Lechner <[email protected]> wrote:
Quoted 34 lines · David Lechner
Replace bitmap array access with
bitmap_write.Accessing the bitmap array directly is not recommended and now there is a helper function that can be used.
Reviewed-by Linus Walleij <[email protected]>Signed-off-by David Lechner <[email protected]>--- drivers/iio/resolver/ad2s1210.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)drivers/iio/resolver/ad2s1210.c +2
-1@@ -46,6 +46,7 @@*/ #include <linux/bitfield.h> +#include <linux/bitmap.h> #include <linux/bits.h> #include <linux/cleanup.h> #include <linux/clk.h> @@ -180,7 +181,7 @@ static int ad2s1210_set_mode(struct ad2s1210_state *st, enum ad2s1210_mode mode)if (!gpios)return mode == st->fixed_mode ?0 : -EOPNOTSUPP ; - bitmap[0 ] = mode; +bitmap_write (bitmap, mode,0 ,2 );return gpiod_multi_set_value_cansleep (gpios, bitmap); }drivers/iio/resolver/ad2s1210.c static int ad2s1210_setup_gpios(struct ad2s1210_state *st) · line 1477
Quoted 8 lines
drivers/iio/resolver/ad2s1210.c +1
-1@@ -1470,7 +1471,7 @@ static int ad2s1210_setup_gpios(struct ad2s1210_state *st)return dev_err_probe (dev, -EINVAL ,"requires exactly 2 resolution-gpios\n" ); - bitmap[0 ] = st->resolution; +bitmap_write (bitmap, st->resolution,0 ,2 ); ret =gpiod_multi_set_value_cansleep (resolution_gpios, bitmap);if (ret <0 )There is actually a bug here pointed out in a similar patch.
bitmap_write()only modifies the bitmap, so this introduces an unintialized use bug. [1] Here, we only use the bits that we set, so runtime behavior would not actually be buggy but still best to fully initialize the memory.
Quoted 6 lines
I'm a bit surprised that my local compiler and iio/testing both didn't catch that since GCC 14 caught it in the other driver.
The fix is simple, we can zero-initialize the bitmap.
Please send this as a fix patch on top as I'd rather not unwind my tree for just this and the patch is already pushed out on what is mostly a non rebasing branch.
Quoted 24 lines
drivers/iio/resolver/ad2s1210.c +2
-2@@ -176,7 +176,7 @@ struct ad2s1210_state {static int ad2s1210_set_mode (struct ad2s1210_state *st,enum ad2s1210_mode mode) {struct gpio_descs *gpios = st->mode_gpios; -DECLARE_BITMAP (bitmap,2 ); + DECLARE_BITMAP(bitmap, 2) = { };if (!gpios)return mode == st->fixed_mode ?0 : -EOPNOTSUPP ;@@ -1427,7 +1427,7 @@ static int ad2s1210_setup_gpios(struct ad2s1210_state *st)struct device *dev = &st->sdev->dev;struct gpio_descs *resolution_gpios;struct gpio_desc *reset_gpio; -DECLARE_BITMAP (bitmap,2 ); + DECLARE_BITMAP(bitmap, 2) = { };int ret;/* should not be sampling on startup */
Jonathan Cameron
maintainerRe: [PATCH v3 10/15] iio: resolver: ad2s1210: use bitmap_write
In reply to David LechnerQuoted 49 lines · On Thu, 20 Feb 2025 14:54:53 -0600 David Lechner <[email protected]> wrote:
Quoted 34 lines · David Lechner
Replace bitmap array access with
bitmap_write.Accessing the bitmap array directly is not recommended and now there is a helper function that can be used.
Reviewed-by Linus Walleij <[email protected]>Signed-off-by David Lechner <[email protected]>--- drivers/iio/resolver/ad2s1210.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)drivers/iio/resolver/ad2s1210.c +2
-1@@ -46,6 +46,7 @@*/ #include <linux/bitfield.h> +#include <linux/bitmap.h> #include <linux/bits.h> #include <linux/cleanup.h> #include <linux/clk.h> @@ -180,7 +181,7 @@ static int ad2s1210_set_mode(struct ad2s1210_state *st, enum ad2s1210_mode mode)if (!gpios)return mode == st->fixed_mode ?0 : -EOPNOTSUPP ; - bitmap[0 ] = mode; +bitmap_write (bitmap, mode,0 ,2 );return gpiod_multi_set_value_cansleep (gpios, bitmap); }drivers/iio/resolver/ad2s1210.c static int ad2s1210_setup_gpios(struct ad2s1210_state *st) · line 1477
Quoted 8 lines
drivers/iio/resolver/ad2s1210.c +1
-1@@ -1470,7 +1471,7 @@ static int ad2s1210_setup_gpios(struct ad2s1210_state *st)return dev_err_probe (dev, -EINVAL ,"requires exactly 2 resolution-gpios\n" ); - bitmap[0 ] = st->resolution; +bitmap_write (bitmap, st->resolution,0 ,2 ); ret =gpiod_multi_set_value_cansleep (resolution_gpios, bitmap);if (ret <0 )There is actually a bug here pointed out in a similar patch.
bitmap_write()only modifies the bitmap, so this introduces an unintialized use bug. [1] Here, we only use the bits that we set, so runtime behavior would not actually be buggy but still best to fully initialize the memory.
Quoted 6 lines
I'm a bit surprised that my local compiler and iio/testing both didn't catch that since GCC 14 caught it in the other driver.
The fix is simple, we can zero-initialize the bitmap.
Ignore previous. I'm looking at wrong branch. I can tweak this just fine. Done so and tree pushed out.
Quoted 24 lines
drivers/iio/resolver/ad2s1210.c +2
-2@@ -176,7 +176,7 @@ struct ad2s1210_state {static int ad2s1210_set_mode (struct ad2s1210_state *st,enum ad2s1210_mode mode) {struct gpio_descs *gpios = st->mode_gpios; -DECLARE_BITMAP (bitmap,2 ); + DECLARE_BITMAP(bitmap, 2) = { };if (!gpios)return mode == st->fixed_mode ?0 : -EOPNOTSUPP ;@@ -1427,7 +1427,7 @@ static int ad2s1210_setup_gpios(struct ad2s1210_state *st)struct device *dev = &st->sdev->dev;struct gpio_descs *resolution_gpios;struct gpio_desc *reset_gpio; -DECLARE_BITMAP (bitmap,2 ); + DECLARE_BITMAP(bitmap, 2) = { };int ret;/* should not be sampling on startup */
David Lechner
reviewerPATCH v3 11/15 mmc: pwrseq_simple: use gpiod_multi_set_value_cansleep
In reply to David LechnerReduce verbosity by using gpiod_multi_set_value_cansleep() instead of gpiod_set_array_value_cansleep().
--- drivers/mmc/core/pwrseq_simple.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/mmc/core/pwrseq_simple.c +1 -2
@@ -54,8 +54,7 @@ static void mmc_pwrseq_simple_set_gpios_value(struct mmc_pwrseq_simple *pwrseq,else bitmap_zero (values, nvalues); -gpiod_set_array_value_cansleep (nvalues, reset_gpios->desc, - reset_gpios->info, values); +gpiod_multi_set_value_cansleep (reset_gpios, values);bitmap_free (values); }
Signature · 1 line
2.43.0
David Lechner
reviewerPATCH v3 12/15 mux: gpio: use gpiod_multi_set_value_cansleep
In reply to David LechnerReduce verbosity by using gpiod_multi_set_value_cansleep() instead of gpiod_set_array_value_cansleep().
--- drivers/mux/gpio.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/mux/gpio.c +1 -3
@@ -28,9 +28,7 @@ static int mux_gpio_set(struct mux_control *mux, int state)bitmap_from_arr32 (values, &value,BITS_PER_TYPE (value)); -gpiod_set_array_value_cansleep (mux_gpio->gpios->ndescs, - mux_gpio->gpios->desc, - mux_gpio->gpios->info, values); +gpiod_multi_set_value_cansleep (mux_gpio->gpios, values);return 0 ; }
Signature · 1 line
2.43.0
David Lechner
reviewerPATCH v3 13/15 net: mdio: mux-gpio: use gpiod_multi_set_value_cansleep
In reply to David LechnerReduce verbosity by using gpiod_multi_set_value_cansleep() instead of gpiod_set_array_value_cansleep().
--- drivers/net/mdio/mdio-mux-gpio.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/net/mdio/mdio-mux-gpio.c +1 -2
@@ -30,8 +30,7 @@ static int mdio_mux_gpio_switch_fn(int current_child, int desired_child, values[0 ] = desired_child; -gpiod_set_array_value_cansleep (s->gpios->ndescs, s->gpios->desc, - s->gpios->info, values); +gpiod_multi_set_value_cansleep (s->gpios, values);return 0 ; }
Signature · 1 line
2.43.0
David Lechner
reviewerPATCH v3 14/15 phy: mapphone-mdm6600: use gpiod_multi_set_value_cansleep
In reply to David LechnerReduce verbosity by using gpiod_multi_set_value_cansleep() instead of gpiod_set_array_value_cansleep().
ddata->cmd_gpios->ndescs is validated to be equal to PHY_MDM6600_NR_CMD_LINES during driver probe, so it will have the same value as the previously hard-coded argument.
--- drivers/phy/motorola/phy-mapphone-mdm6600.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/phy/motorola/phy-mapphone-mdm6600.c +1 -3
@@ -177,9 +177,7 @@ static void phy_mdm6600_cmd(struct phy_mdm6600 *ddata, int val) values[0 ] = val; -gpiod_set_array_value_cansleep (PHY_MDM6600_NR_CMD_LINES , - ddata->cmd_gpios->desc, - ddata->cmd_gpios->info, values); +gpiod_multi_set_value_cansleep (ddata->cmd_gpios, values); }/**
Signature · 1 line
2.43.0
Re: [PATCH v3 14/15] phy: mapphone-mdm6600: use gpiod_multi_set_value_cansleep
Quoted 6 lines · David Lechner
Reduce verbosity by using
gpiod_multi_set_value_cansleep()instead ofgpiod_set_array_value_cansleep().
ddata->cmd_gpios->ndescsis validated to be equal toPHY_MDM6600_NR_CMD_LINESduring driver probe, so it will have the same value as the previously hard-coded argument.
Signature · 1 line
~Vinod
David Lechner
reviewerPATCH v3 15/15 ASoC: adau1701: use gpiod_multi_set_value_cansleep
In reply to David LechnerReduce verbosity by using gpiod_multi_set_value_cansleep() instead of gpiod_set_array_value_cansleep().
--- sound/soc/codecs/adau1701.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
sound/soc/codecs/adau1701.c +1 -3
@@ -325,9 +325,7 @@ static int adau1701_reset(struct snd_soc_component *component, unsigned int clkd__assign_bit (1 , values,1 );break ; } -gpiod_set_array_value_cansleep (adau1701->gpio_pll_mode->ndescs, - adau1701->gpio_pll_mode->desc, adau1701->gpio_pll_mode->info, - values); +gpiod_multi_set_value_cansleep (adau1701->gpio_pll_mode, values); } adau1701->pll_clkdiv = clkdiv;
Signature · 1 line
2.43.0
Bartosz Golaszewski
AppliedRe: (subset) [PATCH v3 00/15] gpiolib: add gpiod_multi_set_value_cansleep
In reply to David LechnerFrom: Bartosz Golaszewski <[email protected]>
Quoted 11 lines · David Lechner
This series was inspired by some minor annoyance I have experienced a few times in recent reviews.
Calling
gpiod_set_array_value_cansleep()can be quite verbose due to having so many parameters. In most cases, we already have a structgpio_descsthat contains the first 3 parameters so we end up with 3 (or often even 6) pointer indirections at each call site. Also, people have a tendency to want to hard-code the first argument instead of using struct gpio_descs.ndescs, often without checking that ndescs >= the hard-coded value.
Quoted 1 line
[...]
Applied, thanks!
[01/15] gpiolib: add gpiod_multi_set_value_cansleep()
commit: 91931af18bd22437e08e2471f5484d6fbdd8ab93
Best regards,
Signature · 1 line
Bartosz Golaszewski <[email protected]>
Bartosz Golaszewski
AppliedRe: (subset) [PATCH v3 00/15] gpiolib: add gpiod_multi_set_value_cansleep
In reply to David LechnerFrom: Bartosz Golaszewski <[email protected]>
Quoted 11 lines · David Lechner
This series was inspired by some minor annoyance I have experienced a few times in recent reviews.
Calling
gpiod_set_array_value_cansleep()can be quite verbose due to having so many parameters. In most cases, we already have a structgpio_descsthat contains the first 3 parameters so we end up with 3 (or often even 6) pointer indirections at each call site. Also, people have a tendency to want to hard-code the first argument instead of using struct gpio_descs.ndescs, often without checking that ndescs >= the hard-coded value.
Quoted 1 line
[...]
Applied, thanks!
[06/15] gpio: max3191x: use gpiod_multi_set_value_cansleep
commit: eb2e9c308d2882d9d364af048eb3d8336d41c4bb
Best regards,
Signature · 1 line
Bartosz Golaszewski <[email protected]>
David Lechner
reviewerRe: (subset) [PATCH v3 00/15] gpiolib: add gpiod_multi_set_value_cansleep
Quoted 15 lines · Bartosz Golaszewski
From: Bartosz Golaszewski <[email protected]>
Quoted 11 lines · David Lechner
This series was inspired by some minor annoyance I have experienced a few times in recent reviews.
Calling
gpiod_set_array_value_cansleep()can be quite verbose due to having so many parameters. In most cases, we already have a structgpio_descsthat contains the first 3 parameters so we end up with 3 (or often even 6) pointer indirections at each call site. Also, people have a tendency to want to hard-code the first argument instead of using struct gpio_descs.ndescs, often without checking that ndescs >= the hard-coded value.
Quoted 8 lines
Quoted 1 line
[...]
Applied, thanks!
[06/15] gpio: max3191x: use
gpiod_multi_set_value_cansleepcommit: eb2e9c308d2882d9d364af048eb3d8336d41c4bbBest regards,
Hi Bartosz,
Do you plan to pick up the other patches that have been acked as well? It seems like most folks were OK with everything going though the gpio tree since the changes are small.
Andy Shevchenko
maintainerRe: (subset) [PATCH v3 00/15] gpiolib: add gpiod_multi_set_value_cansleep
Quoted 2 lines · David Lechner
Quoted 1 line · Bartosz Golaszewski
From: Bartosz Golaszewski <[email protected]>
[...]
Quoted 8 lines
Quoted 4 lines
Applied, thanks!
[06/15] gpio: max3191x: use
gpiod_multi_set_value_cansleepcommit: eb2e9c308d2882d9d364af048eb3d8336d41c4bbDo you plan to pick up the other patches that have been acked as well? It seems like most folks were OK with everything going though the gpio tree since the changes are small.
FWIW, I took auxdisplay one via the respective tree. But please tell me, if you are going to take them all, I will drop that in my tree.
Signature · 2 lines
With Best Regards, Andy Shevchenko
Re: (subset) [PATCH v3 00/15] gpiolib: add gpiod_multi_set_value_cansleep
In reply to David LechnerQuoted 24 lines · David Lechner
Quoted 22 lines · Bartosz Golaszewski
From: Bartosz Golaszewski <[email protected]>
Quoted 11 lines · David Lechner
This series was inspired by some minor annoyance I have experienced a few times in recent reviews.
Calling
gpiod_set_array_value_cansleep()can be quite verbose due to having so many parameters. In most cases, we already have a structgpio_descsthat contains the first 3 parameters so we end up with 3 (or often even 6) pointer indirections at each call site. Also, people have a tendency to want to hard-code the first argument instead of using struct gpio_descs.ndescs, often without checking that ndescs >= the hard-coded value.Quoted 1 line
[...]
Applied, thanks!
[06/15] gpio: max3191x: use
gpiod_multi_set_value_cansleepcommit: eb2e9c308d2882d9d364af048eb3d8336d41c4bb
Quoted 8 lines
Quoted 1 line
Best regards,
Hi Bartosz,
Do you plan to pick up the other patches that have been acked as well? It seems like most folks were OK with everything going though the gpio tree since the changes are small.
Jonathan requested a branch so I made one and sent out a PR. I figured people would just pick the relevant patches into their respective trees? For patches that won't be in next by rc5 - I will take them if Acked - just remind me.
Bart
Mark Brown
maintainerRe: (subset) [PATCH v3 00/15] gpiolib: add gpiod_multi_set_value_cansleep
Quoted 10 lines · Bartosz Golaszewski
Quoted 3 lines · David Lechner
Do you plan to pick up the other patches that have been acked as well? It seems like most folks were OK with everything going though the gpio tree since the changes are small.
Jonathan requested a branch so I made one and sent out a PR. I figured people would just pick the relevant patches into their respective trees? For patches that won't be in next by rc5 - I will take them if Acked - just remind me.
If people are acking things that generally means they're expecting them to go along with the rest of the series. When you didn't apply the ASoC patch I did actually put into CI but it was a bit surprising that you seemed to be expecting that.
Re: (subset) [PATCH v3 00/15] gpiolib: add gpiod_multi_set_value_cansleep
Quoted 13 lines · Mark Brown
Quoted 10 lines · Bartosz Golaszewski
Quoted 3 lines · David Lechner
Do you plan to pick up the other patches that have been acked as well? It seems like most folks were OK with everything going though the gpio tree since the changes are small.
Jonathan requested a branch so I made one and sent out a PR. I figured people would just pick the relevant patches into their respective trees? For patches that won't be in next by rc5 - I will take them if Acked - just remind me.
Quoted 4 lines
If people are acking things that generally means they're expecting them to go along with the rest of the series. When you didn't apply the ASoC patch I did actually put into CI but it was a bit surprising that you seemed to be expecting that.
There was no clear consensus. Some patches are still not acked.
No worries, I will take the acked ones. I didn't see any b4 notifications from your side yet, so I assume the patches are still pending?
Bart
Mark Brown
maintainerRe: (subset) [PATCH v3 00/15] gpiolib: add gpiod_multi_set_value_cansleep
Quoted 8 lines · Bartosz Golaszewski
Quoted 4 lines · Mark Brown
If people are acking things that generally means they're expecting them to go along with the rest of the series. When you didn't apply the ASoC patch I did actually put into CI but it was a bit surprising that you seemed to be expecting that.
There was no clear consensus. Some patches are still not acked.
What I would do in that situation is apply the patches that were acked and leave the rest.
Quoted 3 lines
No worries, I will take the acked ones. I didn't see any b4 notifications from your side yet, so I assume the patches are still pending?
Yes, like I say they're in CI.
Mark Brown
maintainerRe: (subset) [PATCH v3 00/15] gpiolib: add gpiod_multi_set_value_cansleep
In reply to David LechnerQuoted 11 lines · David Lechner
This series was inspired by some minor annoyance I have experienced a few times in recent reviews.
Calling
gpiod_set_array_value_cansleep()can be quite verbose due to having so many parameters. In most cases, we already have a structgpio_descsthat contains the first 3 parameters so we end up with 3 (or often even 6) pointer indirections at each call site. Also, people have a tendency to want to hard-code the first argument instead of using struct gpio_descs.ndescs, often without checking that ndescs >= the hard-coded value.
Quoted 1 line
[...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[15/15] ASoC: adau1701: use gpiod_multi_set_value_cansleep
commit: ad0fbcebb5f6e093d433a0873758a2778d747eb8
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark
Bartosz Golaszewski
AppliedRe: (subset) [PATCH v3 00/15] gpiolib: add gpiod_multi_set_value_cansleep
In reply to David LechnerFrom: Bartosz Golaszewski <[email protected]>
Quoted 11 lines · David Lechner
This series was inspired by some minor annoyance I have experienced a few times in recent reviews.
Calling
gpiod_set_array_value_cansleep()can be quite verbose due to having so many parameters. In most cases, we already have a structgpio_descsthat contains the first 3 parameters so we end up with 3 (or often even 6) pointer indirections at each call site. Also, people have a tendency to want to hard-code the first argument instead of using struct gpio_descs.ndescs, often without checking that ndescs >= the hard-coded value.
Quoted 1 line
[...]
Applied, thanks!
[07/15] iio: adc: ad7606: use gpiod_multi_set_value_cansleep
commit: 8203bc81f025a3fb084357a3d8a6eb3053bc613a
[08/15] iio: amplifiers: hmc425a: use gpiod_multi_set_value_cansleep
commit: e18d359b0a132eb6619836d1bf701f5b3b53299b
[09/15] iio: resolver: ad2s1210: use gpiod_multi_set_value_cansleep
commit: 7920df29f0dd3aae3acd8a7115d5a25414eed68f
[10/15] iio: resolver: ad2s1210: use bitmap_write
commit: a67e45055ea90048372066811da7c7fe2d91f9aa
[11/15] mmc: pwrseq_simple: use gpiod_multi_set_value_cansleep
commit: 2a5920429897201f75ba026c8aa3488c792b3bd7
[12/15] mux: gpio: use gpiod_multi_set_value_cansleep
commit: 47a7c4f58e1f9967eb0ea6c1cb2c29e0ad2edb1a
[14/15] phy: mapphone-mdm6600: use gpiod_multi_set_value_cansleep
commit: c88aa68297390695b16fd9b7a33612257d8ef548Best regards,
Signature · 1 line
Bartosz Golaszewski <[email protected]>
Re: (subset) [PATCH v3 00/15] gpiolib: add gpiod_multi_set_value_cansleep
Quoted 3 lines · Bartosz Golaszewski
Quoted 2 lines · David Lechner
This series was inspired by some minor annoyance I have experienced a few times in recent reviews.
...
Quoted 8 lines
[07/15] iio: adc: ad7606: use
gpiod_multi_set_value_cansleepcommit: 8203bc81f025a3fb084357a3d8a6eb3053bc613a [08/15] iio: amplifiers: hmc425a: use gpiod_multi_set_value_cansleep commit: e18d359b0a132eb6619836d1bf701f5b3b53299b [09/15] iio: resolver: ad2s1210: use gpiod_multi_set_value_cansleep commit: 7920df29f0dd3aae3acd8a7115d5a25414eed68f [10/15] iio: resolver: ad2s1210: use bitmap_write commit: a67e45055ea90048372066811da7c7fe2d91f9aa
FWIW, Jonathan usually takes care of patch queue on weekends. But whatever, it's not my business after all :-)
Signature · 2 lines
With Best Regards, Andy Shevchenko
Re: (subset) [PATCH v3 00/15] gpiolib: add gpiod_multi_set_value_cansleep
Quoted 17 lines · Andy Shevchenko
Quoted 3 lines · Bartosz Golaszewski
Quoted 2 lines · David Lechner
This series was inspired by some minor annoyance I have experienced a few times in recent reviews.
...
Quoted 8 lines
[07/15] iio: adc: ad7606: use
gpiod_multi_set_value_cansleepcommit: 8203bc81f025a3fb084357a3d8a6eb3053bc613a [08/15] iio: amplifiers: hmc425a: use gpiod_multi_set_value_cansleep commit: e18d359b0a132eb6619836d1bf701f5b3b53299b [09/15] iio: resolver: ad2s1210: use gpiod_multi_set_value_cansleep commit: 7920df29f0dd3aae3acd8a7115d5a25414eed68f [10/15] iio: resolver: ad2s1210: use bitmap_write commit: a67e45055ea90048372066811da7c7fe2d91f9aa
Quoted 3 lines
FWIW, Jonathan usually takes care of patch queue on weekends. But whatever, it's not my business after all :-)
Too many conflicting suggestions. I just picked up all Acked patches. ¯\_(ツ)_/¯
Bart
Jonathan Cameron
maintainerRe: (subset) [PATCH v3 00/15] gpiolib: add gpiod_multi_set_value_cansleep
Quoted 19 lines · On Fri, 14 Feb 2025 15:37:48 +0100 Bartosz Golaszewski <[email protected]> wrote:
Quoted 17 lines · Andy Shevchenko
Quoted 3 lines · Bartosz Golaszewski
Quoted 2 lines · David Lechner
This series was inspired by some minor annoyance I have experienced a few times in recent reviews.
...
Quoted 8 lines
[07/15] iio: adc: ad7606: use
gpiod_multi_set_value_cansleepcommit: 8203bc81f025a3fb084357a3d8a6eb3053bc613a [08/15] iio: amplifiers: hmc425a: use gpiod_multi_set_value_cansleep commit: e18d359b0a132eb6619836d1bf701f5b3b53299b [09/15] iio: resolver: ad2s1210: use gpiod_multi_set_value_cansleep commit: 7920df29f0dd3aae3acd8a7115d5a25414eed68f [10/15] iio: resolver: ad2s1210: use bitmap_write commit: a67e45055ea90048372066811da7c7fe2d91f9aa
Quoted 5 lines
Quoted 3 lines
FWIW, Jonathan usually takes care of patch queue on weekends. But whatever, it's not my business after all :-)
Too many conflicting suggestions. I just picked up all Acked patches. ¯\_(ツ)_/¯
Resolution of any issues 'should' be easy enough. Let's keep an eye on how it goes as other series hit Linux next. Might be a little work to be done there and by Linus in next merge window.
Jonathan
Quoted 2 lines
Bart
Re: (subset) [PATCH v3 00/15] gpiolib: add gpiod_multi_set_value_cansleep
Quoted 27 lines · Jonathan Cameron
Quoted 23 lines · On Fri, 14 Feb 2025 15:37:48 +0100 Bartosz Golaszewski <[email protected]> wrote:
Quoted 20 lines · Andy Shevchenko
Quoted 3 lines · Bartosz Golaszewski
Quoted 2 lines · David Lechner
This series was inspired by some minor annoyance I have experienced a few times in recent reviews.
...
Quoted 8 lines
[07/15] iio: adc: ad7606: use
gpiod_multi_set_value_cansleepcommit: 8203bc81f025a3fb084357a3d8a6eb3053bc613a [08/15] iio: amplifiers: hmc425a: use gpiod_multi_set_value_cansleep commit: e18d359b0a132eb6619836d1bf701f5b3b53299b [09/15] iio: resolver: ad2s1210: use gpiod_multi_set_value_cansleep commit: 7920df29f0dd3aae3acd8a7115d5a25414eed68f [10/15] iio: resolver: ad2s1210: use bitmap_write commit: a67e45055ea90048372066811da7c7fe2d91f9aaFWIW, Jonathan usually takes care of patch queue on weekends. But whatever, it's not my business after all :-)
Quoted 8 lines
Quoted 1 line
Too many conflicting suggestions. I just picked up all Acked patches. ¯\_(ツ)_/¯
Resolution of any issues 'should' be easy enough. Let's keep an eye on how it goes as other series hit Linux next. Might be a little work to be done there and by Linus in next merge window.
Jonathan
I'm totally fine with removing the iio commits from my queue if you prefer to take them.
Bartosz
Jonathan Cameron
maintainerRe: (subset) [PATCH v3 00/15] gpiolib: add gpiod_multi_set_value_cansleep
Quoted 34 lines · On Sun, 16 Feb 2025 16:55:04 +0100 Bartosz Golaszewski <[email protected]> wrote:
Quoted 33 lines · Jonathan Cameron
Quoted 19 lines · On Fri, 14 Feb 2025 15:37:48 +0100 Bartosz Golaszewski <[email protected]> wrote:
Quoted 17 lines · Andy Shevchenko
Quoted 3 lines · Bartosz Golaszewski
Quoted 2 lines · David Lechner
This series was inspired by some minor annoyance I have experienced a few times in recent reviews.
...
Quoted 8 lines
[07/15] iio: adc: ad7606: use
gpiod_multi_set_value_cansleepcommit: 8203bc81f025a3fb084357a3d8a6eb3053bc613a [08/15] iio: amplifiers: hmc425a: use gpiod_multi_set_value_cansleep commit: e18d359b0a132eb6619836d1bf701f5b3b53299b [09/15] iio: resolver: ad2s1210: use gpiod_multi_set_value_cansleep commit: 7920df29f0dd3aae3acd8a7115d5a25414eed68f [10/15] iio: resolver: ad2s1210: use bitmap_write commit: a67e45055ea90048372066811da7c7fe2d91f9aaQuoted 5 lines
Quoted 3 lines
FWIW, Jonathan usually takes care of patch queue on weekends. But whatever, it's not my business after all :-)
Too many conflicting suggestions. I just picked up all Acked patches. ¯\_(ツ)_/¯
Resolution of any issues 'should' be easy enough. Let's keep an eye on how it goes as other series hit Linux next. Might be a little work to be done there and by Linus in next merge window.
Quoted 6 lines
Quoted 2 lines
Jonathan
I'm totally fine with removing the iio commits from my queue if you prefer to take them.
Hi Bartosz,
That's probably going to prove slightly less painful, so please do. I'll merge in that immutable tag and pick them up once you've dropped them.
Jonathan
Quoted 1 line
Bartosz
Re: (subset) [PATCH v3 00/15] gpiolib: add gpiod_multi_set_value_cansleep
Quoted 41 lines · Jonathan Cameron
Quoted 37 lines · On Sun, 16 Feb 2025 16:55:04 +0100 Bartosz Golaszewski <[email protected]> wrote:
Quoted 35 lines · Jonathan Cameron
Quoted 19 lines · On Fri, 14 Feb 2025 15:37:48 +0100 Bartosz Golaszewski <[email protected]> wrote:
Quoted 17 lines · Andy Shevchenko
Quoted 3 lines · Bartosz Golaszewski
Quoted 2 lines · David Lechner
This series was inspired by some minor annoyance I have experienced a few times in recent reviews.
...
Quoted 8 lines
[07/15] iio: adc: ad7606: use
gpiod_multi_set_value_cansleepcommit: 8203bc81f025a3fb084357a3d8a6eb3053bc613a [08/15] iio: amplifiers: hmc425a: use gpiod_multi_set_value_cansleep commit: e18d359b0a132eb6619836d1bf701f5b3b53299b [09/15] iio: resolver: ad2s1210: use gpiod_multi_set_value_cansleep commit: 7920df29f0dd3aae3acd8a7115d5a25414eed68f [10/15] iio: resolver: ad2s1210: use bitmap_write commit: a67e45055ea90048372066811da7c7fe2d91f9aaQuoted 5 lines
Quoted 3 lines
FWIW, Jonathan usually takes care of patch queue on weekends. But whatever, it's not my business after all :-)
Too many conflicting suggestions. I just picked up all Acked patches. ¯\_(ツ)_/¯
Resolution of any issues 'should' be easy enough. Let's keep an eye on how it goes as other series hit Linux next. Might be a little work to be done there and by Linus in next merge window.
Jonathan
Quoted 8 lines
Quoted 3 lines
I'm totally fine with removing the iio commits from my queue if you prefer to take them.
Hi Bartosz,
That's probably going to prove slightly less painful, so please do. I'll merge in that immutable tag and pick them up once you've dropped them.
Done, you can push your branch out and the next "next" should be ok now.
Bart
Jonathan Cameron
maintainerQuoted 21 lines · On Mon, 10 Feb 2025 16:33:26 -0600 David Lechner <[email protected]> wrote:
This series was inspired by some minor annoyance I have experienced a few times in recent reviews.
Calling
gpiod_set_array_value_cansleep()can be quite verbose due to having so many parameters. In most cases, we already have a structgpio_descsthat contains the first 3 parameters so we end up with 3 (or often even 6) pointer indirections at each call site. Also, people have a tendency to want to hard-code the first argument instead of using struct gpio_descs.ndescs, often without checking that ndescs >= the hard-coded value.So I'm proposing that we add a
gpiod_multi_set_value_cansleep()function that is a wrapper aroundgpiod_set_array_value_cansleep()that has structgpio_descsas the first parameter to make it a bit easier to read the code and avoid the hard-coding temptation.I've just done
gpiod_multi_set_value_cansleep()for now since there were over 10 callers of this one. There aren't as many callers of the get and atomic variants, but we can add those too if this seems like a useful thing to do.
Quoted 4 lines
Maintainers, if you prefer to have this go through the gpio tree, please give your Acked-by:. Several maintainers have also requested an immutable branch, so I expect that will be made available. And if there is anything leftover after the next kernel release, I will resend it.
I've applied 7-10 to the IIO tree after merging the immutable tag with patch 1.
Jonathan
Quoted 54 lines
---
Changes in v3:
- AddedIS_ERR_OR_NULL()check togpiod_multi_set_value_cansleep()
- Added new patches to clean up accessing bitmap directly (ts-nbus, ad2s1210).
- Added function prefix for max3191x.
- Removed unnecessary braces in ad7606 patch.
- Picked up additional trailers.
- Link to v2: https://lore.kernel.org/r/[email protected]Changes in v2:
- Renamed new function fromgpiods_multi_set_value_cansleep()togpiod_multi_set_value_cansleep()
- Fixed typo in name of replaced function in all commit messages.
- Picked up trailers.
- Link to v1: https://lore.kernel.org/r/[email protected]---
David Lechner (15):
gpiolib: addgpiod_multi_set_value_cansleep()
auxdisplay: seg-led-gpio: usegpiod_multi_set_value_cansleep
bus: ts-nbus: validate ts,data-gpios array size
bus: ts-nbus: usegpiod_multi_set_value_cansleep
bus: ts-nbus: usebitmap_get_value8()
gpio: max3191x: usegpiod_multi_set_value_cansleep
iio: adc: ad7606: usegpiod_multi_set_value_cansleep
iio: amplifiers: hmc425a: usegpiod_multi_set_value_cansleep
iio: resolver: ad2s1210: usegpiod_multi_set_value_cansleep
iio: resolver: ad2s1210: usebitmap_write
mmc:pwrseq_simple: usegpiod_multi_set_value_cansleep
mux: gpio: usegpiod_multi_set_value_cansleep
net: mdio: mux-gpio: usegpiod_multi_set_value_cansleep
phy: mapphone-mdm6600: usegpiod_multi_set_value_cansleep
ASoC: adau1701: usegpiod_multi_set_value_cansleepdrivers/auxdisplay/seg-led-gpio.c | 3 +-- drivers/bus/ts-nbus.c | 15 +++++++++------ drivers/gpio/gpio-max3191x.c | 18 +++++++----------- drivers/iio/adc/ad7606.c | 3 +-- drivers/iio/adc/ad7606_spi.c | 7 +++---- drivers/iio/amplifiers/hmc425a.c | 3 +-- drivers/iio/resolver/ad2s1210.c | 13 +++++-------- drivers/mmc/core/pwrseq_simple.c | 3 +-- drivers/mux/gpio.c | 4 +--- drivers/net/mdio/mdio-mux-gpio.c | 3 +-- drivers/phy/motorola/phy-mapphone-mdm6600.c | 4 +--- include/linux/gpio/consumer.h | 11 +++++++++++ sound/soc/codecs/adau1701.c | 4 +--- 13 files changed, 43 insertions(+), 48 deletions(-)---
base-commit:df4b2bbff898227db0c14264ac7edd634e79f755
change-id: 20250131-gpio-set-array-helper-bd4a328370d3Best regards,