rtc: rtc-v3020: use gpio_request_one()
PATCH 1/1 rtc: rtc-v3020: use gpio_request_one()
Using gpio_request_one() can make the code simpler because it can set the direction and initial value in one shot.
--- drivers/rtc/rtc-v3020.c | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-)
drivers/rtc/rtc-v3020.c +2 -3
@@ -125,11 +125,10 @@ static int v3020_gpio_map(struct v3020 *chip, struct platform_device *pdev, v3020_gpio[V3020_IO ].gpio = pdata->gpio_io;for (i =0 ; i <ARRAY_SIZE (v3020_gpio); i++) { - err =gpio_request (v3020_gpio[i].gpio, v3020_gpio[i].name); + err =gpio_request_one (v3020_gpio[i].gpio,GPIOF_OUT_INIT_HIGH , + v3020_gpio[i].name);if (err) goto err_request; - -gpio_direction_output (v3020_gpio[i].gpio,1 ); } chip->gpio = v3020_gpio;
Signature · 1 line
1.7.2.5
Quoted 2 lines · Jingoo Han
Using
gpio_request_one()can make the code simpler because it can set the direction and initial value in one shot.
If you are on this, then I think converting to gpio_request_array() would be even better.
Quoted 12 lines
Signed-off-by Jingoo Han <[email protected]>--- drivers/rtc/rtc-v3020.c | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-)drivers/rtc/rtc-v3020.c +0
-0@@ -125,11 +125,10 @@ static int v3020_gpio_map(struct v3020 *chip, struct platform_device *pdev, v3020_gpio[V3020_IO ].gpio = pdata->gpio_io;
drivers/rtc/rtc-v3020.c static int v3020_gpio_map(struct v3020 *chip, struct platform_device *pdev, · line 132
Quoted 10 lines
drivers/rtc/rtc-v3020.c +2
-3for (i =0 ; i <ARRAY_SIZE (v3020_gpio); i++) { - err =gpio_request (v3020_gpio[i].gpio, v3020_gpio[i].name); + err =gpio_request_one (v3020_gpio[i].gpio,GPIOF_OUT_INIT_HIGH , + v3020_gpio[i].name);if (err) goto err_request; - -gpio_direction_output (v3020_gpio[i].gpio,1 ); }
If you convert to gpio_request_array(), you can also drop the for loop.
Quoted 3 lines
drivers/rtc/rtc-v3020.c +0
-0chip->gpio = v3020_gpio;
Signature · 2 lines
Regards, Igor.
Quoted 7 lines · Igor Grinberg
Quoted 2 lines · Jingoo Han
Using
gpio_request_one()can make the code simpler because it can set the direction and initial value in one shot.If you are on this, then I think converting to
gpio_request_array()would be even better.
Hi Igor Grinberg,
OK, I see.
I will use gpio_request_array() and send v2 patch soon. Thank you for your comment.
Best regards,
Jingoo Han
Quoted 33 lines
Quoted 13 lines
Signed-off-by Jingoo Han <[email protected]>--- drivers/rtc/rtc-v3020.c | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-)drivers/rtc/rtc-v3020.c +0
-0@@ -125,11 +125,10 @@ static int v3020_gpio_map(struct v3020 *chip, struct platform_device *pdev, v3020_gpio[V3020_IO ].gpio = pdata->gpio_io;drivers/rtc/rtc-v3020.c static int v3020_gpio_map(struct v3020 *chip, struct platform_device *pdev, · line 132
Quoted 10 lines
drivers/rtc/rtc-v3020.c +2
-3for (i =0 ; i <ARRAY_SIZE (v3020_gpio); i++) { - err =gpio_request (v3020_gpio[i].gpio, v3020_gpio[i].name); + err =gpio_request_one (v3020_gpio[i].gpio,GPIOF_OUT_INIT_HIGH , + v3020_gpio[i].name);if (err) goto err_request; - -gpio_direction_output (v3020_gpio[i].gpio,1 ); }If you convert to
gpio_request_array(), you can also drop the for loop.drivers/rtc/rtc-v3020.c static int v3020_gpio_map(struct v3020 *chip, struct platform_device *pdev, · line 134
Quoted 3 lines
drivers/rtc/rtc-v3020.c +0
-0chip->gpio = v3020_gpio;--
Regards,
Igor.
PATCH v2 1/1 rtc: rtc-v3020: use gpio_request_array()
In reply to Jingoo HanUsing gpio_request_array()/gpio_free_array() can make the code simpler because it can set the direction and initial value in one shot and the for loop is unnecessary.
Also, struct v3020_gpio is removed, because the struct v3020_gpio is replaced with struct gpio.
---
Changes since v1:
- Replace gpio_request_one() with gpio_request_array()
drivers/rtc/rtc-v3020.c | 37 ++++++++++++------------------------- 1 files changed, 12 insertions(+), 25 deletions(-)
drivers/rtc/rtc-v3020.c +12 -25
@@ -49,18 +49,13 @@ struct v3020_chip_ops {#define V3020_RD 2#define V3020_IO 3 -struct v3020_gpio { -const char *name; -unsigned int gpio; -}; -struct v3020 {/* MMIO access */ void __iomem *ioaddress;int leftshift;/* GPIO access */ -struct v3020_gpio *gpio; +struct gpio *gpio;struct v3020_chip_ops *ops;
@@ -107,48 +102,40 @@ static struct v3020_chip_ops v3020_mmio_ops = { .write_bit = v3020_mmio_write_bit, }; -static struct v3020_gpio v3020_gpio[] = { - {"RTC CS" ,0 }, - {"RTC WR" ,0 }, - {"RTC RD" ,0 }, - {"RTC IO" ,0 }, +static struct gpio v3020_gpio[] = { + {0 ,GPIOF_OUT_INIT_HIGH ,"RTC CS" }, + {0 ,GPIOF_OUT_INIT_HIGH ,"RTC WR" }, + {0 ,GPIOF_OUT_INIT_HIGH ,"RTC RD" }, + {0 ,GPIOF_OUT_INIT_HIGH ,"RTC IO" }, };static int v3020_gpio_map (struct v3020 *chip,struct platform_device *pdev,struct v3020_platform_data *pdata) { -int i, err; +int err; v3020_gpio[V3020_CS ].gpio = pdata->gpio_cs; v3020_gpio[V3020_WR ].gpio = pdata->gpio_wr; v3020_gpio[V3020_RD ].gpio = pdata->gpio_rd; v3020_gpio[V3020_IO ].gpio = pdata->gpio_io; -for (i =0 ; i <ARRAY_SIZE (v3020_gpio); i++) { - err =gpio_request (v3020_gpio[i].gpio, v3020_gpio[i].name); -if (err) - goto err_request; - -gpio_direction_output (v3020_gpio[i].gpio,1 ); - } + err =gpio_request_array (v3020_gpio,ARRAY_SIZE (v3020_gpio)); +if (err) + goto err_request; chip->gpio = v3020_gpio;return 0 ; err_request: -while (--i >=0 ) -gpio_free (v3020_gpio[i].gpio); +gpio_free_array (v3020_gpio,ARRAY_SIZE (v3020_gpio));return err; }static void v3020_gpio_unmap (struct v3020 *chip) { -int i; - -for (i =0 ; i <ARRAY_SIZE (v3020_gpio); i++) -gpio_free (v3020_gpio[i].gpio); +gpio_free_array (v3020_gpio,ARRAY_SIZE (v3020_gpio)); }static void v3020_gpio_write_bit (struct v3020 *chip,unsigned char bit)
Re: [PATCH V2] rtc: rtc-v3020: use gpio_request_array()
Quoted 11 lines · Jingoo Han
Using gpio_request_array()/gpio_free_array() can make the code simpler because it can set the direction and initial value in one shot and the for loop is unnecessary.
Also, struct
v3020_gpiois removed, because the structv3020_gpiois replaced with struct gpio.Signed-off-by Jingoo Han <[email protected]>---
Changes since v1:
- Replacegpio_request_one()withgpio_request_array()
Thanks for addressing this!
It looks much better now, although one comment below.
Quoted 8 lines
drivers/rtc/rtc-v3020.c | 37 ++++++++++++------------------------- 1 files changed, 12 insertions(+), 25 deletions(-)drivers/rtc/rtc-v3020.c +0
-0
[...]
Quoted 36 lines
drivers/rtc/rtc-v3020.c +8
-13@@ -107,48 +102,40 @@ static struct v3020_chip_ops v3020_mmio_ops = { .write_bit = v3020_mmio_write_bit, }; -static struct v3020_gpio v3020_gpio[] = { - {"RTC CS" ,0 }, - {"RTC WR" ,0 }, - {"RTC RD" ,0 }, - {"RTC IO" ,0 }, +static struct gpio v3020_gpio[] = { + {0 ,GPIOF_OUT_INIT_HIGH ,"RTC CS" }, + {0 ,GPIOF_OUT_INIT_HIGH ,"RTC WR" }, + {0 ,GPIOF_OUT_INIT_HIGH ,"RTC RD" }, + {0 ,GPIOF_OUT_INIT_HIGH ,"RTC IO" }, };static int v3020_gpio_map (struct v3020 *chip,struct platform_device *pdev,struct v3020_platform_data *pdata) { -int i, err; +int err; v3020_gpio[V3020_CS ].gpio = pdata->gpio_cs; v3020_gpio[V3020_WR ].gpio = pdata->gpio_wr; v3020_gpio[V3020_RD ].gpio = pdata->gpio_rd; v3020_gpio[V3020_IO ].gpio = pdata->gpio_io; -for (i =0 ; i <ARRAY_SIZE (v3020_gpio); i++) { - err =gpio_request (v3020_gpio[i].gpio, v3020_gpio[i].name); -if (err) - goto err_request; - -gpio_direction_output (v3020_gpio[i].gpio,1 ); - } + err =gpio_request_array (v3020_gpio,ARRAY_SIZE (v3020_gpio)); +if (err)
drivers/rtc/rtc-v3020.c static struct v3020_chip_ops v3020_mmio_ops = { · line 131
Quoted 10 lines
drivers/rtc/rtc-v3020.c +2
-2+ goto err_request; chip->gpio = v3020_gpio;return 0 ; err_request: -while (--i >=0 ) -gpio_free (v3020_gpio[i].gpio); +gpio_free_array (v3020_gpio,ARRAY_SIZE (v3020_gpio));
Once you use the gpio_request_array(), you don't need to care about the error.
If gpio_request_array() fails, it does the roll back for you. So, you just need to return err and remove the whole err_request label.
Quoted 15 lines
drivers/rtc/rtc-v3020.c +1
-4return err; }static void v3020_gpio_unmap (struct v3020 *chip) { -int i; - -for (i =0 ; i <ARRAY_SIZE (v3020_gpio); i++) -gpio_free (v3020_gpio[i].gpio); +gpio_free_array (v3020_gpio,ARRAY_SIZE (v3020_gpio)); }static void v3020_gpio_write_bit (struct v3020 *chip,unsigned char bit)
Signature · 2 lines
Regards, Igor.
Re: [V2] rtc: rtc-v3020: use gpio_request_array()
In reply to Jingoo HanQuoted 7 lines · Jingoo Han
Using gpio_request_array()/gpio_free_array() can make the code simpler because it can set the direction and initial value in one shot and the for loop is unnecessary.
Also, struct
v3020_gpiois removed, because the structv3020_gpiois replaced with struct gpio.
Quoted 8 lines
Signed-off-by Jingoo Han <[email protected]>---
Changes since v1:
- Replacegpio_request_one()withgpio_request_array()drivers/rtc/rtc-v3020.c | 37 ++++++++++++------------------------- 1 files changed, 12 insertions(+), 25 deletions(-)
Applied with the change suggested by Igor, thanks.
Signature · 14 lines
Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.