Skip to contentSkip to conversation

video: exynos: Ensure definitions match prototypes

PATCH In review Mark Brown 3 participants 4 messages Jul 2, 2013 – Aug 30, 2013

Subsystems (3)
lore
Share & tools
lore

Mark Brown

author
#0 lore raw

PATCH 1/1 video: exynos: Ensure definitions match prototypes

From: Mark Brown <[email protected]>

Ensure that the definitions of functions match the prototypes used by other modules by including the header with the prototypes in the files with the definitions.

---
 drivers/video/exynos/exynos_mipi_dsi_lowlevel.c | 1 +
 1 file changed, 1 insertion(+)
drivers/video/exynos/exynos_mipi_dsi_lowlevel.c +1 -0
index 15c5abd..c148d06 100644
@@ -27,6 +27,7 @@
 #include <video/exynos_mipi_dsim.h>
 
 #include "exynos_mipi_dsi_regs.h"
+#include "exynos_mipi_dsi_lowlevel.h"
 
 void exynos_mipi_dsi_func_reset(struct mipi_dsim_device *dsim)
 {
Signature · 1 line
1.8.3.1
#1 lore raw
Quoted 11 lines

-----Original Message-----
From: [email protected] [mailto:linux-fbdev- [email protected]] On Behalf Of Mark Brown
Sent: Tuesday, July 02, 2013 8:27 PM
To: Tomi Valkeinen; Jingoo Han
Cc: [email protected]; [email protected]; [email protected]; Mark Brown
Subject: [PATCH] video: exynos: Ensure definitions match prototypes

Quoted 6 lines

From: Mark Brown <[email protected]>

Ensure that the definitions of functions match the prototypes used by other modules by including the header with the prototypes in the files with the definitions.

Is there some functions being used by other modules? And what problem can be incurred without this patch?

Thanks,
Inki Dae

Quoted 25 lines
---
 drivers/video/exynos/exynos_mipi_dsi_lowlevel.c | 1 +
 1 file changed, 1 insertion(+)
drivers/video/exynos/exynos_mipi_dsi_lowlevel.c +1 -1
index 15c5abd..c148d06 100644
@@ -27,6 +27,7 @@
 #include <video/exynos_mipi_dsim.h>
 
 #include "exynos_mipi_dsi_regs.h"
+#include "exynos_mipi_dsi_lowlevel.h"
 
 void exynos_mipi_dsi_func_reset(struct mipi_dsim_device *dsim)
 {
--

1.8.3.1

--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

author
#2 lore raw
Quoted 6 lines · Inki Dae
Quoted 3 lines

Ensure that the definitions of functions match the prototypes used by other modules by including the header with the prototypes in the files with the definitions.

Is there some functions being used by other modules? And what problem can be incurred without this patch?

Well, aside from it being basic good practice and allowing the compiler to check for errors in the prototypes this is also something that sparse warns about. There do seem to be references to the functions in other modules, in some cases this is every single function in the file.