video: backlight: adp5520: fix compiler warning in adp5520_show
Subsystems (3)
PATCH v2 1/1 video: backlight: adp5520: fix compiler warning in adp5520_show
while compiling with make W=1 (gcc gcc (GCC) 4.7.2 20121109 (Red Hat 4.7.2-8)) found the following warning
drivers/video/backlight/adp5520_bl.c: In function ‘adp5520_show’:drivers/video/backlight/adp5520_bl.c:146:6: warning: variable ‘error’ set but not used [-Wunused-but-set-variable]
fixed by checking the return value of the variable
--- drivers/video/backlight/adp5520_bl.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
drivers/video/backlight/adp5520_bl.c +5 -2
@@ -143,13 +143,16 @@ static int adp5520_bl_setup(struct backlight_device *bl)static ssize_t adp5520_show (struct device *dev,char *buf,int reg) {struct adp5520_bl *data =dev_get_drvdata (dev); -int error; +int ret;uint8_t reg_val;mutex_lock (&data->lock); - error =adp5520_read (data->master, reg, ®_val); + ret =adp5520_read (data->master, reg, ®_val);mutex_unlock (&data->lock); +if (ret <0 ) +return ret; +return sprintf (buf,"%u\n" , reg_val); }
Signature · 1 line
1.8.1.2
Quoted 11 lines · Devendra Naga
while compiling with make W=1 (gcc gcc (GCC) 4.7.2 20121109 (Red Hat 4.7.2-8)) found the following warning
drivers/video/backlight/adp5520_bl.c: In function ‘adp5520_show’:drivers/video/backlight/adp5520_bl.c:146:6: warning: variable ‘error’ set but not used [-Wunused-but- set-variable]fixed by checking the return value of the variable
Cc Jingoo Han <[email protected]>
Best regards,
Jingoo Han
Quoted 32 lines
Cc Michael Hennerich <[email protected]>Cc Richard Purdie <[email protected]>Signed-off-by Devendra Naga <[email protected]>--- drivers/video/backlight/adp5520_bl.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)drivers/video/backlight/adp5520_bl.c +5
-3@@ -143,13 +143,16 @@ static int adp5520_bl_setup(struct backlight_device *bl)static ssize_t adp5520_show (struct device *dev,char *buf,int reg) {struct adp5520_bl *data =dev_get_drvdata (dev); -int error; +int ret;uint8_t reg_val;mutex_lock (&data->lock); - error =adp5520_read (data->master, reg, ®_val); + ret =adp5520_read (data->master, reg, ®_val);mutex_unlock (&data->lock); +if (ret <0 ) +return ret; +return sprintf (buf,"%u\n" , reg_val); } --1.8.1.2