arm(64): dts: qcom: fix dtbs_check warnings for qcom,spmi-pmic.yaml
v2 cover arm(64): dts: qcom: fix dtbs_check warnings for qcom,spmi-pmic.yaml
Hi,
These patches fix all [1] warnings whilst running make dtbs_check DT_SCHEMA_FILES=qcom,spmi-pmic.yaml on both arm and arm64 qcom device trees.
[1]: There is still one warning left that was fixed by an earlier patch by someone else, which has not been picked up:
https://lore.kernel.org/all/[email protected]/
---
- Link to v1: https://lore.kernel.org/r/[email protected]
---
Rayyan Ansari (3):
arm64: dts: qcom: pmi8994: Add label to wled node
arm64: dts: qcom: pmi8950: Remove address from lpg node
ARM: dts: qcom: pma8084: add pon node
arch/arm/boot/dts/qcom/pma8084.dtsi | 15 ++++++++++----- arch/arm64/boot/dts/qcom/pmi8950.dtsi | 3 +-- arch/arm64/boot/dts/qcom/pmi8994.dtsi | 3 +++ 3 files changed, 14 insertions(+), 7 deletions(-)
---
base-commit: dee7f101b64219f512bb2f842227bd04c14efe30
change-id: 20240722-pmic-bindings-756df58afa15
Best regards,
Signature · 1 line
Rayyan Ansari <[email protected]>
PATCH v2 1/3 arm64: dts: qcom: pmi8994: Add label to wled node
Add a label, which is a required property, to the wled node.
--- arch/arm64/boot/dts/qcom/pmi8994.dtsi | 3 +++ 1 file changed, 3 insertions(+)
arch/arm64/boot/dts/qcom/pmi8994.dtsi +3 -0
@@ -57,8 +57,11 @@ pmi8994_wled: wled@d800 { interrupts = <0x3 0xd8 0x1 IRQ_TYPE_EDGE_RISING>, <0x3 0xd8 0x2 IRQ_TYPE_EDGE_RISING>; interrupt-names = "ovp", "short"; + label = "backlight"; + qcom,cabc; qcom,external-pfet; + status = "disabled"; }; };
Signature · 1 line
2.45.2
PATCH v2 2/3 arm64: dts: qcom: pmi8950: Remove address from lpg node
In reply to Rayyan AnsariRemove the address in both the reg property and node name to adhere to the bindings.
--- arch/arm64/boot/dts/qcom/pmi8950.dtsi | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
arch/arm64/boot/dts/qcom/pmi8950.dtsi +1 -2
@@ -84,9 +84,8 @@ pmic@3 { #address-cells = <1>; #size-cells = <0>; - pmi8950_pwm: pwm@b000 { + pmi8950_pwm: pwm { compatible = "qcom,pmi8950-pwm"; - reg = <0xb000 0x100>; #pwm-cells = <2>; status = "disabled";
Signature · 1 line
2.45.2
Re: [PATCH v2 2/3] arm64: dts: qcom: pmi8950: Remove address from lpg node
Quoted 5 lines · Rayyan Ansari
Remove the address in both the reg property and node name to adhere to the bindings.
Signed-off-by Rayyan Ansari <[email protected]>---
Konrad
PATCH v2 3/3 ARM: dts: qcom: pma8084: add pon node
In reply to Rayyan AnsariWrap existing pwrkey node inside a pon node, to conform to dt schema.
--- arch/arm/boot/dts/qcom/pma8084.dtsi | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-)
arch/arm/boot/dts/qcom/pma8084.dtsi +10 -5
@@ -19,12 +19,17 @@ rtc@6000 { interrupts = <0x0 0x61 0x1 IRQ_TYPE_EDGE_RISING>; }; - pwrkey@800 { - compatible = "qcom,pm8941-pwrkey"; + pon@800 { + compatible = "qcom,pm8941-pon"; reg = <0x800>; - interrupts = <0x0 0x8 0 IRQ_TYPE_EDGE_BOTH>; - debounce = <15625>; - bias-pull-up; + + pwrkey { + compatible = "qcom,pm8941-pwrkey"; + interrupts = <0x0 0x8 0 IRQ_TYPE_EDGE_BOTH>; + debounce = <15625>; + bias-pull-up; + linux,code = <KEY_POWER>; + }; }; pma8084_gpios: gpio@c000 {
Signature · 1 line
2.45.2
kernel test robot
build botRe: [PATCH v2 3/3] ARM: dts: qcom: pma8084: add pon node
kernel test robot noticed the following build errors:
Hi Rayyan,
kernel test robot noticed the following build errors:
[auto build test ERROR on dee7f101b64219f512bb2f842227bd04c14efe30]
url: https://github.com/intel-lab-lkp/linux/commits/Rayyan-Ansari/arm64-dts-qcom-pmi8994-Add-label-to-wled-node/20240723-175020 base: dee7f101b64219f512bb2f842227bd04c14efe30 patch link: https://lore.kernel.org/r/20240723-pmic-bindings-v2-3-e1cd614f8c4a%40linaro.org patch subject: [PATCH v2 3/3] ARM: dts: qcom: pma8084: add pon node config: arm-randconfig-051-20240723 (https://download.01.org/0day-ci/archive/20240724/[email protected]/config) compiler: arm-linux-gnueabi-gcc (GCC) 14.1.0 dtschema version: 2024.6.dev4+g23441a4 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240724/[email protected]/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
All errors (new ones prefixed by >>):
>> Error: arch/arm/boot/dts/qcom/pma8084.dtsi:31.19-20 syntax error
FATAL ERROR: Unable to parse input tree
Signature · 2 lines
0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
Re: [PATCH v2 3/3] ARM: dts: qcom: pma8084: add pon node
Quoted 15 lines · kernel test robot
Hi Rayyan,
kernel test robot noticed the following build errors:
[auto build test ERROR on
dee7f101b64219f512bb2f842227bd04c14efe30]url: https://github.com/intel-lab-lkp/linux/commits/Rayyan-Ansari/arm64-dts-qcom-pmi8994-Add-label-to-wled-node/20240723-175020 base: dee7f101b64219f512bb2f842227bd04c14efe30 patch link: https://lore.kernel.org/r/20240723-pmic-bindings-v2-3-e1cd614f8c4a%40linaro.org patch subject: [PATCH v2 3/3] ARM: dts: qcom: pma8084: add pon node config: arm-randconfig-051-20240723 (https://download.01.org/0day-ci/archive/20240724/[email protected]/config) compiler: arm-linux-gnueabi-gcc (GCC) 14.1.0 dtschema version: 2024.6.dev4+g23441a4 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240724/[email protected]/reproduce)
Quoted 8 lines
If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/All errors (new ones prefixed by >>):
Quoted 1 line
Quoted 1 line
Error: arch/arm/boot/dts/qcom/pma8084.dtsi:31.19-20 syntax error
Need #include <dt-bindings/input/linux-event-codes.h>
Konrad