backlight: l4f00242t03: check return value of regulator_enable()
Subsystems (2)
PATCH v2 1/1 backlight: l4f00242t03: check return value of regulator_enable()
The regulator_enable() was marked as as __must_check, therefore, the return value of regulator_enable() should be checked. Also, this patch checks return value of regulator_set_voltage().
Signed-off-by Jingoo Han <[email protected]>
---
Change since v1:
- Added regulator_disable() for IO regulator before returning
drivers/video/backlight/l4f00242t03.c | 29 ++++++++++++++++++++++++----- 1 files changed, 24 insertions(+), 5 deletions(-)
drivers/video/backlight/l4f00242t03.c +23 -4
@@ -51,14 +51,33 @@ static void l4f00242t03_lcd_init(struct spi_device *spi)struct l4f00242t03_pdata *pdata = spi->dev.platform_data;struct l4f00242t03_priv *priv =spi_get_drvdata (spi);const u16 cmd[] = {0x36 ,param (0 ),0x3A ,param (0x60 ) }; +int ret;dev_dbg (&spi->dev,"initializing LCD\n" ); -regulator_set_voltage (priv->io_reg,1800000 ,1800000 ); -regulator_enable (priv->io_reg); + ret =regulator_set_voltage (priv->io_reg,1800000 ,1800000 ); +if (ret) { +dev_err (&spi->dev,"failed to set the IO regulator voltage.\n" ); +return ; + } + ret =regulator_enable (priv->io_reg); +if (ret) { +dev_err (&spi->dev,"failed to enable the IO regulator.\n" ); +return ; + } -regulator_set_voltage (priv->core_reg,2800000 ,2800000 ); -regulator_enable (priv->core_reg); + ret =regulator_set_voltage (priv->core_reg,2800000 ,2800000 ); +if (ret) { +dev_err (&spi->dev,"failed to set the core regulator voltage.\n" ); +regulator_disable (priv->io_reg); +return ; + } + ret =regulator_enable (priv->core_reg); +if (ret) { +dev_err (&spi->dev,"failed to enable the core regulator.\n" ); +regulator_disable (priv->io_reg); +return ; + }l4f00242t03_reset (pdata->reset_gpio);
Signature · 1 line
1.7.2.5