rtc: rtc-s3c: Add BCD register initialization codes
Subsystems (2)
PATCH v3 3/3 rtc: rtc-s3c: Add BCD register initialization codes
From: Taekgyun Ko <[email protected]>
RTC needs to be initialized when BCD registers have invalid value.
---
Hi, Alessandro Zummo
Just moved the routine to support all Samsung SoCs' RTC. Is still your ack valid?
Changes since v2:
Moved chekcing BCD registers to support all Samsung SoCs as per Ben's comments.
drivers/rtc/rtc-s3c.c | 10 ++++++++++ 1 files changed, 10 insertions(+), 0 deletions(-)
drivers/rtc/rtc-s3c.c +10 -0
@@ -458,6 +458,7 @@ static int __devinit s3c_rtc_probe(struct platform_device *pdev) {struct rtc_device *rtc;struct resource *res; +unsigned int tmp, i;int ret;pr_debug ("%s: probe=%p\n" , __func__, pdev);
@@ -536,6 +537,15 @@ static int __devinit s3c_rtc_probe(struct platform_device *pdev) s3c_rtc_cpu_type =platform_get_device_id (pdev)->driver_data; +/* Check RTC Time */ + +for (i =S3C2410_RTCSEC ; i <=S3C2410_RTCYEAR ; i +=0x4 ) { + tmp =readb (s3c_rtc_base + i); + +if ((tmp &0xf ) >0x9 || ((tmp >>4 ) &0xf ) >0x9 ) +writeb (0 , s3c_rtc_base + i); + } +if (s3c_rtc_cpu_type ==TYPE_S3C64XX ) rtc->max_user_freq =32768 ;else
Signature · 1 line
1.6.2.5
PATCH v3 3/3 rtc: rtc-s3c: Add BCD register initialization codes
2010/7/29 Kukjin Kim <[email protected]>:
Quoted 11 lines
From: Taekgyun Ko <[email protected]>
RTC needs to be initialized when BCD registers have invalid value.
Signed-off-by Taekgyun Ko <[email protected]>Signed-off-by Kukjin Kim <[email protected]>Cc Ben Dooks <[email protected]>---
Hi, Alessandro Zummo
Just moved the routine to support all Samsung SoCs' RTC. Is still your ack valid?
Alessandro is busy, not every patch he can reviewed and acked, if nobody have any other suggestions about your patch, you can merge it. if you donot have specific git tree to merge it, you can get Andrew's help.
Quoted 43 lines
Changes since v2:
Moved chekcing BCD registers to support all Samsung SoCs as per Ben's comments.?drivers/rtc/rtc-s3c.c | ? 10 ++++++++++ ?1 files changed, 10 insertions(+), 0 deletions(-)
drivers/rtc/rtc-s3c.c +10
-0@@ -458,6 +458,7 @@ static int __devinit s3c_rtc_probe(struct platform_device *pdev) ?{ ? ? ? ?struct rtc_device *rtc; ? ? ? ?struct resource *res; + ? ? ? unsigned int tmp, i; ? ? ? ?int ret; ? ? ? ?pr_debug("%s: probe=%p\n", __func__, pdev);@@ -536,6 +537,15 @@ static int __devinit s3c_rtc_probe(struct platform_device *pdev) ? ? ? ?s3c_rtc_cpu_type = platform_get_device_id(pdev)->driver_data; + ? ? ? /* Check RTC Time */ + + ? ? ? for (i = S3C2410_RTCSEC; i <= S3C2410_RTCYEAR; i += 0x4) { + ? ? ? ? ? ? ? tmp = readb(s3c_rtc_base + i); + + ? ? ? ? ? ? ? if ((tmp & 0xf) > 0x9 || ((tmp >> 4) & 0xf) > 0x9) + ? ? ? ? ? ? ? ? ? ? ? writeb(0, s3c_rtc_base + i); + ? ? ? } + ? ? ? ?if (s3c_rtc_cpu_type == TYPE_S3C64XX) ? ? ? ? ? ? ? ?rtc->max_user_freq = 32768;? ? ? ?else
--
1.6.2.5--
You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
Signature · 10 lines
*linux-arm-kernel mailing list mail addr:linux-arm-kernel at lists.infradead.org you can subscribe by: http://lists.infradead.org/mailman/listinfo/linux-arm-kernel * linux-arm-NUC900 mailing list mail addr:NUC900 at googlegroups.com main web: https://groups.google.com/group/NUC900 you can subscribe it by sending me mail: mcuos.com at gmail.com
PATCH v3 3/3 rtc: rtc-s3c: Add BCD register initialization codes
Quoted 14 lines · Wan ZongShun
2010/7/29 Kukjin Kim <[email protected]>:
Quoted 11 lines
From: Taekgyun Ko <[email protected]>
RTC needs to be initialized when BCD registers have invalid value.
Signed-off-by Taekgyun Ko <[email protected]>Signed-off-by Kukjin Kim <[email protected]>Cc Ben Dooks <[email protected]>---
Hi, Alessandro Zummo
Just moved the routine to support all Samsung SoCs' RTC. Is still your ack valid?
Hi Wan,
Quoted 5 lines
Alessandro is busy, not every patch he can reviewed and acked, if nobody have any other suggestions about your patch, you can merge it. if you donot have specific git tree to merge it, you can get Andrew's help.
Thanks for your rapid response. ;-)
(snip)
Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.
PATCH v3 3/3 rtc: rtc-s3c: Add BCD register initialization codes
In reply to Kukjin KimQuoted 3 lines · On Thu, 29 Jul 2010 13:59:30 +0900 Kukjin Kim <[email protected]> wrote:
Hi, Alessandro Zummo
Just moved the routine to support all Samsung SoCs' RTC. Is still your ack valid?
yes, it is.
Signature · 6 lines
Best regards, Alessandro Zummo, Tower Technologies - Torino, Italy http://www.towertech.it
PATCH v3 3/3 rtc: rtc-s3c: Add BCD register initialization codes
Quoted 10 lines · Alessandro Zummo
Quoted 3 lines · On Thu, 29 Jul 2010 13:59:30 +0900 Kukjin Kim <[email protected]> wrote:
Hi, Alessandro Zummo
Just moved the routine to support all Samsung SoCs' RTC. Is still your ack valid?yes, it is.
Thanks for your ack.
And I applied it in my tree with your ack. :-)
Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.