Skip to contentSkip to conversation

ide-probe does not set removable flag for ide-floppy devices

PATCH In review Kevin P. Fleming 3 participants 3 messages Dec 13, 2001 – Dec 28, 2001

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ide-probe does not set removable flag for ide-floppy devices

Small patch, relative to 2.4.17-pre8, but should apply to any recent version

diff -urN -X dontdiff linux/drivers/ide/ide-probe.c linux-new/drivers/ide/ide-probe.c

drivers/ide/ide-probe.c Sun Dec 9 11:41:15 2001 renamed from drivers/ide/ide-probe.c Wed Dec 12 11:01:24 2001 +1 -0
@@ -122,6 +122,7 @@
       printk("cdrom or floppy?, assuming ");
      if (drive->media != ide_cdrom) {
       printk ("FLOPPY");
+      drive->removable = 1;
       break;
      }
     }
#1 lore raw

Queued for 2.4.18pre...

Thanks

Quoted 1 line · Kevin P. Fleming

Small patch, relative to 2.4.17-pre8, but should apply to any recent version

#2 lore raw
In reply to Kevin P. Fleming
Quoted 7 lines · Kevin P. Fleming

Small patch, relative to 2.4.17-pre8, but should apply to any recent version

diff -urN -X dontdiff linux/drivers/ide/ide-probe.c linux-new/drivers/ide/ide-probe.c

drivers/ide/ide-probe.c Sun Dec 9 11:41:15 2001 line 128

Quoted 7 lines
drivers/ide/ide-probe.c Sun Dec 9 11:41:15 2001 renamed from drivers/ide/ide-probe.c Wed Dec 12 11:01:24 2001 +1 -0
@@ -122,6 +122,7 @@
       printk("cdrom or floppy?, assuming ");
      if (drive->media != ide_cdrom) {
       printk ("FLOPPY");
+      drive->removable = 1;
       break;
      }
     }

<nitpick old mails time>
To me, this looks like it would make more sense to set this to 1 _before_ the switch statement, and set to 0 as necessary, as most of the cases look removable to me. Should cut out a few lines of code, and also mark things like ide-tape as removable in the process too. Or is this not desired behaviour for some reason ?

Dave.

Signature · 2 lines
Dave Jones.                    http://www.codemonkey.org.uk
SuSE Labs.