Skip to contentSkip to conversation

keypad memory map support

PATCH New 양진성 2 participants 5 messages Sep 5, 2009 – Sep 7, 2009

Subsystems (2)
lore
Share & tools
lore

양진성

author
#0 lore raw

PATCH 1/12 keypad memory map support

This patch introduces keypad memory map for new keypad driver. Also the new keypad driver will be provided to the mainline soon.

---
 arch/arm/mach-s3c6400/include/mach/map.h |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)
arch/arm/mach-s3c6400/include/mach/map.h +6 -0
index 5057d99..d935570 100644
@@ -65,6 +65,10 @@
 #define S3C_VA_VIC0		(S3C_VA_IRQ + 0x00)
 #define S3C_VA_VIC1		(S3C_VA_IRQ + 0x10000)
 
+/* keypad */
+#define S3C64XX_PA_KEYPAD	(0x7E00A000)
+#define S3C64XX_SZ_KEYPAD	SZ_4K
+
 /* compatibiltiy defines. */
 #define S3C_PA_TIMER		S3C64XX_PA_TIMER
 #define S3C_PA_HSMMC0		S3C64XX_PA_HSMMC0
@@ -75,5 +79,7 @@
 #define S3C_PA_FB		S3C64XX_PA_FB
 #define S3C_PA_USBHOST		S3C64XX_PA_USBHOST
 #define S3C_PA_USB_HSOTG	S3C64XX_PA_USB_HSOTG
+#define S3C_PA_KEYPAD		S3C64XX_PA_KEYPAD
+#define S3C_SZ_KEYPAD		S3C64XX_SZ_KEYPAD
 
 #endif /* __ASM_ARCH_6400_MAP_H */
Signature · 1 line
1.6.2.5
#1 lore raw

PATCH 1/12 keypad memory map support

Hi,

First, where's keypad driver source codes?
Second, why how many patches are needed? I think only two patch, one for keypad related, another is smdkc100 board specific.

Thank you,
Kyungmin Park

2009/9/5 ??? <[email protected]>:

Quoted 41 lines

This patch introduces keypad memory map for new keypad driver. Also the new keypad driver will be provided to the mainline soon.

---
?arch/arm/mach-s3c6400/include/mach/map.h | ? ?6 ++++++ ?1 files changed, 6 insertions(+), 0 deletions(-)

arch/arm/mach-s3c6400/include/mach/map.h +4 -0
index 5057d99..d935570 100644
@@ -65,6 +65,10 @@
 ?#define S3C_VA_VIC0 ? ? ? ? ? ?(S3C_VA_IRQ + 0x00)
 ?#define S3C_VA_VIC1 ? ? ? ? ? ?(S3C_VA_IRQ + 0x10000)
 
+/* keypad */
+#define S3C64XX_PA_KEYPAD ? ? ?(0x7E00A000)
+#define S3C64XX_SZ_KEYPAD ? ? ?SZ_4K
+

?/* compatibiltiy defines. */
?#define S3C_PA_TIMER ? ? ? ? ? S3C64XX_PA_TIMER
?#define S3C_PA_HSMMC0 ? ? ? ? ?S3C64XX_PA_HSMMC0

arch/arm/mach-s3c6400/include/mach/map.h +0 -0
@@ -75,5 +79,7 @@

?#define S3C_PA_FB ? ? ? ? ? ? ?S3C64XX_PA_FB ?#define S3C_PA_USBHOST ? ? ? ? S3C64XX_PA_USBHOST ?#define S3C_PA_USB_HSOTG ? ? ? S3C64XX_PA_USB_HSOTG

arch/arm/mach-s3c6400/include/mach/map.h +2 -0
+#define S3C_PA_KEYPAD ? ? ? ? ?S3C64XX_PA_KEYPAD
+#define S3C_SZ_KEYPAD ? ? ? ? ?S3C64XX_SZ_KEYPAD

?#endif /* __ASM_ARCH_6400_MAP_H */
--
1.6.2.5

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#2 lore raw

PATCH 1/12 keypad memory map support

Quoted 9 lines

-----Original Message-----
From: kyungmin78 at gmail.com [mailto:kyungmin78 at gmail.com] On Behalf Of Kyungmin Park
Sent: Monday, September 07, 2009 9:09 AM
To: ???
Cc: ben-linux at fluff.org; ???/AP???/E3/????; linux-arm- kernel at lists.infradead.org
Subject: Re: [PATCH 01/12] [ARM][S3C6410] keypad memory map support

Quoted 5 lines

Hi,

First, where's keypad driver source codes?
Second, why how many patches are needed? I think only two patch, one for keypad related, another is smdkc100 board specific.

I sent keypad source code to the linux-input mailing lists and Ben Dooks as cc.
I have to send keypad driver also to arm-linux as public? I'm not sure..
And, the reason why I sent many patches is that we should split all changes as change-set based.
Even though these changes are related just with single topic (keypad), the details should be published as individual change-set. Harald who is supporting our team's mainline work has recommended that.

Quoted 48 lines

Thank you,
Kyungmin Park

2009/9/5 ??? <[email protected]>:

arch/arm/mach-

Quoted 10 lines

This patch introduces keypad memory map for new keypad driver. Also the new keypad driver will be provided to the mainline soon.

---
 arch/arm/mach-s3c6400/include/mach/map.h |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)
arch/arm/mach- renamed from arch/arm/mach-s3c6400/include/mach/map.h +0 -0

s3c6400/include/mach/map.h

Quoted 31 lines

index 5057d99..d935570 100644

arch/arm/mach-s3c6400/include/mach/map.h +6 -1
@@ -65,6 +65,10 @@
 #define S3C_VA_VIC0            (S3C_VA_IRQ + 0x00)
 #define S3C_VA_VIC1            (S3C_VA_IRQ + 0x10000)
 
+/* keypad */
+#define S3C64XX_PA_KEYPAD      (0x7E00A000)
+#define S3C64XX_SZ_KEYPAD      SZ_4K
+
 /* compatibiltiy defines. */
 #define S3C_PA_TIMER           S3C64XX_PA_TIMER
 #define S3C_PA_HSMMC0          S3C64XX_PA_HSMMC0
@@ -75,5 +79,7 @@
 #define S3C_PA_FB              S3C64XX_PA_FB
 #define S3C_PA_USBHOST         S3C64XX_PA_USBHOST
 #define S3C_PA_USB_HSOTG       S3C64XX_PA_USB_HSOTG
+#define S3C_PA_KEYPAD          S3C64XX_PA_KEYPAD
+#define S3C_SZ_KEYPAD          S3C64XX_SZ_KEYPAD
 
 #endif /* __ASM_ARCH_6400_MAP_H */
--

1.6.2.5

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#3 lore raw

PATCH 1/12 keypad memory map support

Quoted 9 lines · Jinsung Yang
Quoted 9 lines

-----Original Message-----
From: kyungmin78 at gmail.com [mailto:kyungmin78 at gmail.com] On Behalf Of Kyungmin Park
Sent: Monday, September 07, 2009 9:09 AM
To: ???
Cc: ben-linux at fluff.org; ???/AP???/E3/????; linux-arm- kernel at lists.infradead.org
Subject: Re: [PATCH 01/12] [ARM][S3C6410] keypad memory map support

Quoted 7 lines
Quoted 5 lines

Hi,

First, where's keypad driver source codes?
Second, why how many patches are needed? I think only two patch, one for keypad related, another is smdkc100 board specific.

I sent keypad source code to the linux-input mailing lists and Ben Dooks as cc.

I see.

Quoted 1 line

I have to send keypad driver also to arm-linux as public? I'm not sure..

For who only subscribe the arm list. It's not problem to post two mailing list with same topic.
If only input patches are merged and arm doesn't, then what happens?

Quoted 2 lines

And, the reason why I sent many patches is that we should split all changes as change-set based.
Even though these changes are related just with single topic (keypad), the details should be published as individual change-set.

I agree Mark Brown's opinion from input mailing list. Please consider what's the concept of change-set vs change one.

Thank you,
Kyungmin Park

Quoted 52 lines

Harald who is supporting our team's mainline work has recommended that.

Quoted 48 lines

Thank you,
Kyungmin Park

2009/9/5 ??? <[email protected]>:

arch/arm/mach-

Quoted 10 lines

This patch introduces keypad memory map for new keypad driver. Also the new keypad driver will be provided to the mainline soon.

---
 arch/arm/mach-s3c6400/include/mach/map.h |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)
arch/arm/mach- renamed from arch/arm/mach-s3c6400/include/mach/map.h +0 -0

s3c6400/include/mach/map.h

Quoted 31 lines

index 5057d99..d935570 100644

arch/arm/mach-s3c6400/include/mach/map.h +6 -1
@@ -65,6 +65,10 @@
 #define S3C_VA_VIC0            (S3C_VA_IRQ + 0x00)
 #define S3C_VA_VIC1            (S3C_VA_IRQ + 0x10000)
 
+/* keypad */
+#define S3C64XX_PA_KEYPAD      (0x7E00A000)
+#define S3C64XX_SZ_KEYPAD      SZ_4K
+
 /* compatibiltiy defines. */
 #define S3C_PA_TIMER           S3C64XX_PA_TIMER
 #define S3C_PA_HSMMC0          S3C64XX_PA_HSMMC0
@@ -75,5 +79,7 @@
 #define S3C_PA_FB              S3C64XX_PA_FB
 #define S3C_PA_USBHOST         S3C64XX_PA_USBHOST
 #define S3C_PA_USB_HSOTG       S3C64XX_PA_USB_HSOTG
+#define S3C_PA_KEYPAD          S3C64XX_PA_KEYPAD
+#define S3C_SZ_KEYPAD          S3C64XX_SZ_KEYPAD
 
 #endif /* __ASM_ARCH_6400_MAP_H */
--

1.6.2.5

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#4 lore raw

PATCH 1/12 keypad memory map support

Quoted 3 lines

I agree Mark Brown's opinion from input mailing list. Please consider what's the concept of change-set vs change one.

I agree also with Mark's opinion.
I will submit again my driver as single patch file with any other fixes.

Best Regards
--
Jinsung, Yang <[email protected]>
AP Development Team
System LSI, Semiconductor Business
SAMSUNG Electronics Co., LTD