Input: s3c24xx_ts - Adds TYPE_S5PV210 into Samsung touchscreen driver
Subsystems (2)
PATCH v2 8/9 Input: s3c24xx_ts - Adds TYPE_S5PV210 into Samsung touchscreen driver
From: Naveen Krishna <[email protected]>
This patch adds TYPE_S5PV210 to the ID table in Samsung touchscreen driver. So, we can configure the driver based on the IP level changes.
--- drivers/input/touchscreen/Kconfig | 2 +- drivers/input/touchscreen/s3c2410_ts.c | 2 ++ 2 files changed, 3 insertions(+), 1 deletions(-)
drivers/input/touchscreen/Kconfig +1 -1
@@ -159,7 +159,7 @@ config TOUCHSCREEN_FUJITSU config TOUCHSCREEN_S3C2410 tristate "Samsung S3C2410 touchscreen input driver" - depends on ARCH_S3C2410 || ARCH_S3C64XX || ARCH_S5P6440 + depends on ARCH_S3C2410 || ARCH_S3C64XX || ARCH_S5P6440 || ARCH_S5PV210 select S3C_ADC help Say Y here if you have the s3c2410 touchscreen.
drivers/input/touchscreen/s3c2410_ts.c +2 -0
@@ -89,6 +89,7 @@ enum s3c_cpu_type {TYPE_S3C2410 ,TYPE_S3C2440 ,TYPE_S3C64XX ,/* S3C64XX, S5P64XX Series */ + TYPE_S5PV210, /* S5PV210 */ };/**
@@ -418,6 +419,7 @@ static struct platform_device_id s3cts_driver_ids[] = { { "s3c2410-ts", TYPE_S3C2410 }, { "s3c2440-ts", TYPE_S3C2440 }, { "s3c64xx-ts", TYPE_S3C64XX }, + { "s5pv210-ts", TYPE_S5PV210 }, { } };MODULE_DEVICE_TABLE (platform, s3cts_driver_ids);
Signature · 1 line
1.6.2.5
PATCH v2 8/9 Input: s3c24xx_ts - Adds TYPE_S5PV210 into Samsung touchscreen driver
Quoted 4 lines · Kukjin Kim
From: Naveen Krishna <[email protected]>
This patch adds
TYPE_S5PV210to the ID table in Samsung touchscreen driver. So, we can configure the driver based on the IP level changes.
Hmm, what changes are those? Would much prefer to see the changes with these additions.
Also, how about the 'FEAT' flags idea that was floated, it may help with adding future SoCs.
Quoted 47 lines
Signed-off-by Naveen Krishna Ch <[email protected]>Signed-off-by Kukjin Kim <[email protected]>--- drivers/input/touchscreen/Kconfig | 2 +- drivers/input/touchscreen/s3c2410_ts.c | 2 ++ 2 files changed, 3 insertions(+), 1 deletions(-)drivers/input/touchscreen/Kconfig +1
-1@@ -159,7 +159,7 @@ config TOUCHSCREEN_FUJITSU config TOUCHSCREEN_S3C2410 tristate "Samsung S3C2410 touchscreen input driver" - depends on ARCH_S3C2410 || ARCH_S3C64XX || ARCH_S5P6440 + depends on ARCH_S3C2410 || ARCH_S3C64XX || ARCH_S5P6440 || ARCH_S5PV210 select S3C_ADC help Say Y here if you have the s3c2410 touchscreen.drivers/input/touchscreen/s3c2410_ts.c +2
-0@@ -89,6 +89,7 @@ enum s3c_cpu_type {TYPE_S3C2410 ,TYPE_S3C2440 ,TYPE_S3C64XX ,/* S3C64XX, S5P64XX Series */ + TYPE_S5PV210, /* S5PV210 */ };/** @@ -418,6 +419,7 @@ static struct platform_device_id s3cts_driver_ids[] = { { "s3c2410-ts", TYPE_S3C2410 }, { "s3c2440-ts", TYPE_S3C2440 }, { "s3c64xx-ts", TYPE_S3C64XX }, + { "s5pv210-ts", TYPE_S5PV210 }, { } };MODULE_DEVICE_TABLE (platform, s3cts_driver_ids);Signature · 6 lines
1.6.2.5 -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Signature · 5 lines
-- Ben Q: What's a light-year? A: One-third less calories than a regular year.
PATCH v2 8/9 Input: s3c24xx_ts - Adds TYPE_S5PV210 into Samsung touchscreen driver
Quoted 5 lines · Ben Dooks
Quoted 3 lines · Kukjin Kim
From: Naveen Krishna <[email protected]>
This patch adds
TYPE_S5PV210to the ID table in Samsung touchscreen
driver.
Quoted 7 lines
Quoted 1 line
So, we can configure the driver based on the IP level changes.
Hmm, what changes are those? Would much prefer to see the changes with these additions.
Also, how about the 'FEAT' flags idea that was floated, it may help with adding future SoCs.
The coming 2 patches would fix these changes.
Quoted 9 lines
Review
Quoted 9 lines
Signed-off-by Naveen Krishna Ch <[email protected]>Signed-off-by Kukjin Kim <[email protected]>--- drivers/input/touchscreen/Kconfig | 2 +- drivers/input/touchscreen/s3c2410_ts.c | 2 ++ 2 files changed, 3 insertions(+), 1 deletions(-)(quoted diff) +0
-0
b/drivers/input/touchscreen/Kconfig
Quoted 25 lines
drivers/input/touchscreen/Kconfig config TOUCHSCREEN_FUJITSU · line 162
Quoted 9 lines
index c82c1e1..a90a5bb 100644
drivers/input/touchscreen/Kconfig +1
-1@@ -159,7 +159,7 @@ config TOUCHSCREEN_FUJITSU config TOUCHSCREEN_S3C2410 tristate "Samsung S3C2410 touchscreen input driver" - depends on ARCH_S3C2410 || ARCH_S3C64XX || ARCH_S5P6440 + depends on ARCH_S3C2410 || ARCH_S3C64XX || ARCH_S5P6440 ||
ARCH_S5PV210Review
Quoted 4 lines
drivers/input/touchscreen/Kconfig +0
-0select S3C_ADC help Say Y here if you have the s3c2410 touchscreen.(quoted diff) +0
-0
b/drivers/input/touchscreen/s3c2410_ts.cQuoted 10 lines
index 7e7d368..8a970ea 100644
drivers/input/touchscreen/s3c2410_ts.c +1
-0@@ -89,6 +89,7 @@ enum s3c_cpu_type {TYPE_S3C2410 ,TYPE_S3C2440 ,TYPE_S3C64XX ,/* S3C64XX, S5P64XX Series */ + TYPE_S5PV210, /* S5PV210 */ };
Quoted 2 lines
drivers/input/touchscreen/s3c2410_ts.c static struct platform_device_id s3cts_driver_ids[] =
Quoted 2 lines
drivers/input/touchscreen/s3c2410_ts.c +0
-0/** @@ -418,6 +419,7 @@ static struct platform_device_id s3cts_driver_ids[] =
{
Quoted 8 lines
drivers/input/touchscreen/s3c2410_ts.c static struct platform_device_id s3cts_driver_ids[] = {
Quoted 8 lines
drivers/input/touchscreen/s3c2410_ts.c +1
-1{ "s3c2410-ts", TYPE_S3C2410 }, { "s3c2440-ts", TYPE_S3C2440 }, { "s3c64xx-ts", TYPE_S3C64XX }, + { "s5pv210-ts", TYPE_S5PV210 }, { } };MODULE_DEVICE_TABLE (platform, s3cts_driver_ids); --
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.