support I2C for AST2700
v3 cover support I2C for AST2700
v1:
- support I2C for AST2700
v2:
- fix review issues and add reviewer suggestion
- update avocado test case for AST2700 I2C
- support i2c bus pool
v3:
- update commit messages and commit title
- update API to get the device irq
Jamin Lin (11):
hw/i2c/aspeed: Support discontinuous register memory region of I2C bus hw/i2c/aspeed: Introduce a new bus pool buffer attribute in
AspeedI2Cbus
hw/i2c/aspeed: Support discontinuous poll buffer memory region of I2C
bus
hw/i2c/aspeed: Introduce a new dma_dram_offset attribute in
AspeedI2Cbus
hw/i2c/aspeed: Add AST2700 support
hw/i2c/aspeed: Add support for Tx/Rx buffer 64 bit addresses hw/i2c/aspeed: Add support for 64 bit addresses aspeed/soc: Introduce a new API to get the device irq aspeed/soc: Support I2C for AST2700
aspeed: Add tmp105 in i2c bus 0 for AST2700 machine_aspeed.py: Update to test I2C for AST2700
hw/arm/aspeed.c | 10 ++ hw/arm/aspeed_ast27x0.c | 45 +++++ hw/i2c/aspeed_i2c.c | 310 ++++++++++++++++++++++++++++---- include/hw/i2c/aspeed_i2c.h | 28 ++- tests/avocado/machine_aspeed.py | 16 ++ 5 files changed, 362 insertions(+), 47 deletions(-)
Signature · 1 line
2.34.1
PATCH v3 2/11 hw/i2c/aspeed: Introduce a new bus pool buffer attribute in AspeedI2Cbus
According to the datasheet of ASPEED SOCs,
each I2C bus has their own pool buffer since AST2500. Only AST2400 utilized a pool buffer share to all I2C bus. Besides, using a share pool buffer only support pool buffer memory regions are continuous for all I2C bus.
To make this model more readable and support discontinuous bus pool buffer memory regions, changes to introduce a new bus pool buffer attribute in AspeedI2Cbus and new memops. So, it does not need to calculate
the pool buffer offset for different I2C bus.
Introduce a new has_share_pool class attribute in AspeedI2CClass and use it to create either a share pool buffer or bus pool buffers in aspeed_i2c_realize. Update each pull buffer size to 0x10 for AST2500 and 0x20 for AST2600 and AST1030.
Incrementing the version of aspeed_i2c_bus_vmstate to 6.
--- hw/i2c/aspeed_i2c.c | 131 +++++++++++++++++++++++++++++++----- include/hw/i2c/aspeed_i2c.h | 4 ++ 2 files changed, 117 insertions(+), 18 deletions(-)
hw/i2c/aspeed_i2c.c +113 -18
@@ -941,12 +941,48 @@ static const MemoryRegionOps aspeed_i2c_share_pool_ops = { }, }; +static uint64_t aspeed_i2c_bus_pool_read (void *opaque,hwaddr offset, +unsigned size) +{ +AspeedI2CBus *s = opaque; +uint64_t ret =0 ; +int i; + +for (i =0 ; i < size; i++) { + ret |= (uint64_t ) s->pool[offset + i] << (8 * i); + } + +return ret; +} + +static void aspeed_i2c_bus_pool_write (void *opaque,hwaddr offset, +uint64_t value,unsigned size) +{ +AspeedI2CBus *s = opaque; +int i; + +for (i =0 ; i < size; i++) { + s->pool[offset + i] = (value >> (8 * i)) &0xFF ; + } +} + +static const MemoryRegionOps aspeed_i2c_bus_pool_ops = { + .read = aspeed_i2c_bus_pool_read, + .write = aspeed_i2c_bus_pool_write, + .endianness =DEVICE_LITTLE_ENDIAN , + .valid = { + .min_access_size =1 , + .max_access_size =4 , + }, +}; +static const VMStateDescription aspeed_i2c_bus_vmstate = { .name =TYPE_ASPEED_I2C , - .version_id =5 , - .minimum_version_id =5 , + .version_id =6 , + .minimum_version_id =6 , .fields = (const VMStateField []) {VMSTATE_UINT32_ARRAY (regs, AspeedI2CBus,ASPEED_I2C_NEW_NUM_REG ), +VMSTATE_UINT8_ARRAY (pool, AspeedI2CBus,ASPEED_I2C_BUS_POOL_SIZE ),VMSTATE_END_OF_LIST () } };
@@ -996,7 +1032,21 @@ static void aspeed_i2c_instance_init(Object *obj)* 0x140 ... 0x17F: Device 5 * 0x180 ... 0x1BF: Device 6 * 0x1C0 ... 0x1FF: Device 7 -* 0x200 ... 0x2FF: Buffer Pool (AST2500 unused in linux driver) +* 0x200 ... 0x20F: Device 1 buffer (AST2500 unused in linux driver) +* 0x210 ... 0x21F: Device 2 buffer +* 0x220 ... 0x22F: Device 3 buffer +* 0x230 ... 0x23F: Device 4 buffer +* 0x240 ... 0x24F: Device 5 buffer +* 0x250 ... 0x25F: Device 6 buffer +* 0x260 ... 0x26F: Device 7 buffer +* 0x270 ... 0x27F: Device 8 buffer +* 0x280 ... 0x28F: Device 9 buffer +* 0x290 ... 0x29F: Device 10 buffer +* 0x2A0 ... 0x2AF: Device 11 buffer +* 0x2B0 ... 0x2BF: Device 12 buffer +* 0x2C0 ... 0x2CF: Device 13 buffer +* 0x2D0 ... 0x2DF: Device 14 buffer +* 0x2E0 ... 0x2FF: Reserved * 0x300 ... 0x33F: Device 8 * 0x340 ... 0x37F: Device 9 * 0x380 ... 0x3BF: Device 10
@@ -1005,6 +1055,41 @@ static void aspeed_i2c_instance_init(Object *obj)* 0x440 ... 0x47F: Device 13 * 0x480 ... 0x4BF: Device 14 * 0x800 ... 0xFFF: Buffer Pool (AST2400 unused in linux driver) +* +* Address Definitions (AST2600 and AST1030) +* 0x000 ... 0x07F: Global Register +* 0x080 ... 0x0FF: Device 1 +* 0x100 ... 0x17F: Device 2 +* 0x180 ... 0x1FF: Device 3 +* 0x200 ... 0x27F: Device 4 +* 0x280 ... 0x2FF: Device 5 +* 0x300 ... 0x37F: Device 6 +* 0x380 ... 0x3FF: Device 7 +* 0x400 ... 0x47F: Device 8 +* 0x480 ... 0x4FF: Device 9 +* 0x500 ... 0x57F: Device 10 +* 0x580 ... 0x5FF: Device 11 +* 0x600 ... 0x67F: Device 12 +* 0x680 ... 0x6FF: Device 13 +* 0x700 ... 0x77F: Device 14 +* 0x780 ... 0x7FF: Device 15 (15 and 16 unused in AST1030) +* 0x800 ... 0x87F: Device 16 +* 0xC00 ... 0xC1F: Device 1 buffer +* 0xC20 ... 0xC3F: Device 2 buffer +* 0xC40 ... 0xC5F: Device 3 buffer +* 0xC60 ... 0xC7F: Device 4 buffer +* 0xC80 ... 0xC9F: Device 5 buffer +* 0xCA0 ... 0xCBF: Device 6 buffer +* 0xCC0 ... 0xCDF: Device 7 buffer +* 0xCE0 ... 0xCFF: Device 8 buffer +* 0xD00 ... 0xD1F: Device 9 buffer +* 0xD20 ... 0xD3F: Device 10 buffer +* 0xD40 ... 0xD5F: Device 11 buffer +* 0xD60 ... 0xD7F: Device 12 buffer +* 0xD80 ... 0xD9F: Device 13 buffer +* 0xDA0 ... 0xDBF: Device 14 buffer +* 0xDC0 ... 0xDDF: Device 15 buffer (15 and 16 unused in AST1030) +* 0xDE0 ... 0xDFF: Device 16 buffer */ static void aspeed_i2c_realize (DeviceState *dev,Error **errp) {
@@ -1039,10 +1124,19 @@ static void aspeed_i2c_realize(DeviceState *dev, Error **errp) &s->busses[i].mr); } -memory_region_init_io (&s->pool_iomem,OBJECT (s), - &aspeed_i2c_share_pool_ops, s, -"aspeed.i2c-share-pool" , aic->pool_size); -memory_region_add_subregion (&s->iomem, aic->pool_base, &s->pool_iomem); +if (aic->has_share_pool) { +memory_region_init_io (&s->pool_iomem,OBJECT (s), + &aspeed_i2c_share_pool_ops, s, +"aspeed.i2c-share-pool" , aic->pool_size); +memory_region_add_subregion (&s->iomem, aic->pool_base, + &s->pool_iomem); + }else { +for (i =0 ; i < aic->num_busses; i++) { +memory_region_add_subregion (&s->iomem, + aic->pool_base + (aic->pool_size * i), + &s->busses[i].mr_pool); + } + }if (aic->has_dma) {if (!s->dram_mr) {
@@ -1218,6 +1312,7 @@ static void aspeed_i2c_bus_realize(DeviceState *dev, Error **errp)AspeedI2CBus *s =ASPEED_I2C_BUS (dev);AspeedI2CClass *aic; g_autofree char *name = g_strdup_printf(TYPE_ASPEED_I2C_BUS ".%d", s->id); + g_autofree char *pool_name = g_strdup_printf("%s.pool", name);if (!s->controller) {error_setg (errp,TYPE_ASPEED_I2C_BUS ": 'controller' link not set" );
@@ -1235,6 +1330,10 @@ static void aspeed_i2c_bus_realize(DeviceState *dev, Error **errp)memory_region_init_io (&s->mr,OBJECT (s), &aspeed_i2c_bus_ops, s, name, aic->reg_size);sysbus_init_mmio (SYS_BUS_DEVICE (dev), &s->mr); + +memory_region_init_io (&s->mr_pool,OBJECT (s), &aspeed_i2c_bus_pool_ops, + s, pool_name, aic->pool_size); +sysbus_init_mmio (SYS_BUS_DEVICE (dev), &s->mr_pool); }static Property aspeed_i2c_bus_properties[] = {
@@ -1287,6 +1386,7 @@ static void aspeed_2400_i2c_class_init(ObjectClass *klass, void *data) aic->reg_size =0x40 ; aic->gap =7 ; aic->bus_get_irq = aspeed_2400_i2c_bus_get_irq; + aic->has_share_pool = true; aic->pool_size =0x800 ; aic->pool_base =0x800 ; aic->bus_pool_base = aspeed_2400_i2c_bus_pool_base;
@@ -1306,7 +1406,7 @@ static qemu_irq aspeed_2500_i2c_bus_get_irq(AspeedI2CBus *bus)static uint8_t *aspeed_2500_i2c_bus_pool_base (AspeedI2CBus *bus) { -return &bus->controller->share_pool[bus->id *0x10 ]; +return bus->pool; }static void aspeed_2500_i2c_class_init (ObjectClass *klass,void *data)
@@ -1320,7 +1420,7 @@ static void aspeed_2500_i2c_class_init(ObjectClass *klass, void *data) aic->reg_size =0x40 ; aic->gap =7 ; aic->bus_get_irq = aspeed_2500_i2c_bus_get_irq; - aic->pool_size =0x100 ; + aic->pool_size =0x10 ; aic->pool_base =0x200 ; aic->bus_pool_base = aspeed_2500_i2c_bus_pool_base; aic->check_sram = true;
@@ -1339,11 +1439,6 @@ static qemu_irq aspeed_2600_i2c_bus_get_irq(AspeedI2CBus *bus)return bus->irq; } -static uint8_t *aspeed_2600_i2c_bus_pool_base (AspeedI2CBus *bus) -{ -return &bus->controller->share_pool[bus->id *0x20 ]; -} -static void aspeed_2600_i2c_class_init (ObjectClass *klass,void *data) {DeviceClass *dc =DEVICE_CLASS (klass);
@@ -1355,9 +1450,9 @@ static void aspeed_2600_i2c_class_init(ObjectClass *klass, void *data) aic->reg_size =0x80 ; aic->gap =-1 ;/* no gap */ aic->bus_get_irq = aspeed_2600_i2c_bus_get_irq; - aic->pool_size =0x200 ; + aic->pool_size =0x20 ; aic->pool_base =0xC00 ; - aic->bus_pool_base = aspeed_2600_i2c_bus_pool_base; + aic->bus_pool_base = aspeed_2500_i2c_bus_pool_base; aic->has_dma = true; aic->mem_size =0x1000 ; }
@@ -1379,9 +1474,9 @@ static void aspeed_1030_i2c_class_init(ObjectClass *klass, void *data) aic->reg_size =0x80 ; aic->gap =-1 ;/* no gap */ aic->bus_get_irq = aspeed_2600_i2c_bus_get_irq; - aic->pool_size =0x200 ; + aic->pool_size =0x20 ; aic->pool_base =0xC00 ; - aic->bus_pool_base = aspeed_2600_i2c_bus_pool_base; + aic->bus_pool_base = aspeed_2500_i2c_bus_pool_base; aic->has_dma = true; aic->mem_size =0x10000 ; }
include/hw/i2c/aspeed_i2c.h +4 -0
@@ -35,6 +35,7 @@ OBJECT_DECLARE_TYPE(AspeedI2CState, AspeedI2CClass, ASPEED_I2C)#define ASPEED_I2C_NR_BUSSES 16#define ASPEED_I2C_SHARE_POOL_SIZE 0x800 +#define ASPEED_I2C_BUS_POOL_SIZE 0x20#define ASPEED_I2C_OLD_NUM_REG 11#define ASPEED_I2C_NEW_NUM_REG 22
@@ -239,12 +240,14 @@ struct AspeedI2CBus {I2CSlave *slave;MemoryRegion mr; +MemoryRegion mr_pool;I2CBus *bus;uint8_t id;qemu_irq irq;uint32_t regs[ASPEED_I2C_NEW_NUM_REG ]; +uint8_t pool[ASPEED_I2C_BUS_POOL_SIZE ]; };struct AspeedI2CState {
@@ -284,6 +287,7 @@ struct AspeedI2CClass {uint8_t *(*bus_pool_base)(AspeedI2CBus *);bool check_sram;bool has_dma; +bool has_share_pool;uint64_t mem_size; };
Signature · 1 line
2.34.1
PATCH v3 4/11 hw/i2c/aspeed: Introduce a new dma_dram_offset attribute in AspeedI2Cbus
In reply to Jamin Lin viaThe "Current DMA Operating Address Status(0x50)" register of I2C new mode has been removed in AST2700.
This register is used for debugging and it is a read only register.
To support AST2700 DMA mode, introduce a new dma_dram_offset class attribute in AspeedI2Cbus to save the current DMA operating address.
ASPEED AST2700 SOC is a 64 bits quad core CPUs (Cortex-a35) And the base address of dram is "0x4 00000000" which is 64bits address.
Set the dma_dram_offset data type to uint64_t for
64 bits dram address DMA support.
Both "DMA Mode Buffer Address Register(I2CD24 old mode)" and
"DMA Operating Address Status (I2CC50 new mode)" are used for showing the low part dram offset bits [31:0], so change to read/write both register bits [31:0] in bus register read/write functions.
The aspeed_i2c_bus_vmstate is changed again and version is not increased because it was done earlier in the same series.
--- hw/i2c/aspeed_i2c.c | 51 +++++++++++++++++++++++-------------- include/hw/i2c/aspeed_i2c.h | 9 +------ 2 files changed, 33 insertions(+), 27 deletions(-)
hw/i2c/aspeed_i2c.c +32 -19
@@ -114,7 +114,10 @@ static uint64_t aspeed_i2c_bus_old_read(AspeedI2CBus *bus, hwaddr offset,if (!aic->has_dma) {qemu_log_mask (LOG_GUEST_ERROR ,"%s: No DMA support\n" , __func__); value =-1 ; +break ; } + + value =extract64 (bus->dma_dram_offset,0 ,32 );break ;case A_I2CD_DMA_LEN :if (!aic->has_dma) {
@@ -150,9 +153,7 @@ static uint64_t aspeed_i2c_bus_new_read(AspeedI2CBus *bus, hwaddr offset,case A_I2CM_DMA_TX_ADDR :case A_I2CM_DMA_RX_ADDR :case A_I2CM_DMA_LEN_STS : -case A_I2CC_DMA_ADDR :case A_I2CC_DMA_LEN : -case A_I2CS_DEV_ADDR :case A_I2CS_DMA_RX_ADDR :case A_I2CS_DMA_LEN :
@@ -161,6 +162,9 @@ static uint64_t aspeed_i2c_bus_new_read(AspeedI2CBus *bus, hwaddr offset,case A_I2CS_DMA_LEN_STS :/* Value is already set, don't do anything. */ break ; +case A_I2CC_DMA_ADDR : + value =extract64 (bus->dma_dram_offset,0 ,32 ); +break ;case A_I2CS_INTR_STS :break ;case A_I2CM_CMD :
@@ -210,18 +214,18 @@ static int aspeed_i2c_dma_read(AspeedI2CBus *bus, uint8_t *data) {MemTxResult result;AspeedI2CState *s = bus->controller; -uint32_t reg_dma_addr =aspeed_i2c_bus_dma_addr_offset (bus);uint32_t reg_dma_len =aspeed_i2c_bus_dma_len_offset (bus); - result =address_space_read (&s->dram_as, bus->regs[reg_dma_addr], + result =address_space_read (&s->dram_as, bus->dma_dram_offset,MEMTXATTRS_UNSPECIFIED , data,1 );if (result !=MEMTX_OK ) { -qemu_log_mask (LOG_GUEST_ERROR ,"%s: DRAM read failed @%08x\n" , - __func__, bus->regs[reg_dma_addr]); +qemu_log_mask (LOG_GUEST_ERROR , +"%s: DRAM read failed @%" PRIx64"\n" , + __func__, bus->dma_dram_offset);return -1 ; } - bus->regs[reg_dma_addr]++; + bus->dma_dram_offset++; bus->regs[reg_dma_len]--;return 0 ; }
@@ -291,7 +295,6 @@ static void aspeed_i2c_bus_recv(AspeedI2CBus *bus)uint32_t reg_pool_ctrl =aspeed_i2c_bus_pool_ctrl_offset (bus);uint32_t reg_byte_buf =aspeed_i2c_bus_byte_buf_offset (bus);uint32_t reg_dma_len =aspeed_i2c_bus_dma_len_offset (bus); -uint32_t reg_dma_addr =aspeed_i2c_bus_dma_addr_offset (bus);int pool_rx_count =SHARED_ARRAY_FIELD_EX32 (bus->regs, reg_pool_ctrl,RX_SIZE ) +1 ;
@@ -323,14 +326,17 @@ static void aspeed_i2c_bus_recv(AspeedI2CBus *bus) data =i2c_recv (bus->bus);trace_aspeed_i2c_bus_recv ("DMA" , bus->regs[reg_dma_len], bus->regs[reg_dma_len], data); - result =address_space_write (&s->dram_as, bus->regs[reg_dma_addr], + + result =address_space_write (&s->dram_as, bus->dma_dram_offset,MEMTXATTRS_UNSPECIFIED , &data,1 );if (result !=MEMTX_OK ) { -qemu_log_mask (LOG_GUEST_ERROR ,"%s: DRAM write failed @%08x\n" , - __func__, bus->regs[reg_dma_addr]); +qemu_log_mask (LOG_GUEST_ERROR , +"%s: DRAM write failed @%" PRIx64"\n" , + __func__, bus->dma_dram_offset);return ; } - bus->regs[reg_dma_addr]++; + + bus->dma_dram_offset++; bus->regs[reg_dma_len]--;/* In new mode, keep track of how many bytes we RXed */ if (aspeed_i2c_is_new_mode (bus->controller)) {
@@ -636,14 +642,18 @@ static void aspeed_i2c_bus_new_write(AspeedI2CBus *bus, hwaddr offset,case A_I2CM_DMA_TX_ADDR : bus->regs[R_I2CM_DMA_TX_ADDR ] =FIELD_EX32 (value,I2CM_DMA_TX_ADDR ,ADDR ); - bus->regs[R_I2CC_DMA_ADDR ] =FIELD_EX32 (value,I2CM_DMA_TX_ADDR ,ADDR ); + bus->dma_dram_offset = +deposit64 (bus->dma_dram_offset,0 ,32 , +FIELD_EX32 (value,I2CM_DMA_TX_ADDR ,ADDR )); bus->regs[R_I2CC_DMA_LEN ] =ARRAY_FIELD_EX32 (bus->regs,I2CM_DMA_LEN ,TX_BUF_LEN ) +1 ;break ;case A_I2CM_DMA_RX_ADDR : bus->regs[R_I2CM_DMA_RX_ADDR ] =FIELD_EX32 (value,I2CM_DMA_RX_ADDR ,ADDR ); - bus->regs[R_I2CC_DMA_ADDR ] =FIELD_EX32 (value,I2CM_DMA_RX_ADDR ,ADDR ); + bus->dma_dram_offset = +deposit64 (bus->dma_dram_offset,0 ,32 , +FIELD_EX32 (value,I2CM_DMA_RX_ADDR ,ADDR )); bus->regs[R_I2CC_DMA_LEN ] =ARRAY_FIELD_EX32 (bus->regs,I2CM_DMA_LEN ,RX_BUF_LEN ) +1 ;break ;
@@ -811,7 +821,8 @@ static void aspeed_i2c_bus_old_write(AspeedI2CBus *bus, hwaddr offset,break ; } - bus->regs[R_I2CD_DMA_ADDR ] = value &0x3ffffffc ; + bus->dma_dram_offset =deposit64 (bus->dma_dram_offset,0 ,32 , + value &0x3ffffffc );break ;case A_I2CD_DMA_LEN :
@@ -983,6 +994,7 @@ static const VMStateDescription aspeed_i2c_bus_vmstate = { .fields = (const VMStateField[]) {VMSTATE_UINT32_ARRAY (regs, AspeedI2CBus,ASPEED_I2C_NEW_NUM_REG ),VMSTATE_UINT8_ARRAY (pool, AspeedI2CBus,ASPEED_I2C_BUS_POOL_SIZE ), +VMSTATE_UINT64 (dma_dram_offset, AspeedI2CBus),VMSTATE_END_OF_LIST () } };
@@ -1188,8 +1200,9 @@ static int aspeed_i2c_bus_new_slave_event(AspeedI2CBus *bus,return -1 ; }ARRAY_FIELD_DP32 (bus->regs,I2CS_DMA_LEN_STS ,RX_LEN ,0 ); - bus->regs[R_I2CC_DMA_ADDR ] = -ARRAY_FIELD_EX32 (bus->regs,I2CS_DMA_RX_ADDR ,ADDR ); + bus->dma_dram_offset = +deposit64 (bus->dma_dram_offset,0 ,32 , +ARRAY_FIELD_EX32 (bus->regs,I2CS_DMA_RX_ADDR ,ADDR )); bus->regs[R_I2CC_DMA_LEN ] =ARRAY_FIELD_EX32 (bus->regs,I2CS_DMA_LEN ,RX_BUF_LEN ) +1 ;i2c_ack (bus->bus);
@@ -1255,10 +1268,10 @@ static int aspeed_i2c_bus_slave_event(I2CSlave *slave, enum i2c_event event)static void aspeed_i2c_bus_new_slave_send_async (AspeedI2CBus *bus,uint8_t data) {assert (address_space_write (&bus->controller->dram_as, - bus->regs[R_I2CC_DMA_ADDR ], + bus->dma_dram_offset,MEMTXATTRS_UNSPECIFIED , &data,1 ) ==MEMTX_OK ); - bus->regs[R_I2CC_DMA_ADDR ]++; + bus->dma_dram_offset++; bus->regs[R_I2CC_DMA_LEN ]--;ARRAY_FIELD_DP32 (bus->regs,I2CS_DMA_LEN_STS ,RX_LEN ,ARRAY_FIELD_EX32 (bus->regs,I2CS_DMA_LEN_STS ,RX_LEN ) +1 );
include/hw/i2c/aspeed_i2c.h +1 -8
@@ -248,6 +248,7 @@ struct AspeedI2CBus {uint32_t regs[ASPEED_I2C_NEW_NUM_REG ];uint8_t pool[ASPEED_I2C_BUS_POOL_SIZE ]; +uint64_t dma_dram_offset; };struct AspeedI2CState {
@@ -369,14 +370,6 @@ static inline uint32_t aspeed_i2c_bus_dma_len_offset(AspeedI2CBus *bus)return R_I2CD_DMA_LEN ; } -static inline uint32_t aspeed_i2c_bus_dma_addr_offset (AspeedI2CBus *bus) -{ -if (aspeed_i2c_is_new_mode (bus->controller)) { -return R_I2CC_DMA_ADDR ; - } -return R_I2CD_DMA_ADDR ; -} -static inline bool aspeed_i2c_bus_is_master (AspeedI2CBus *bus) { return SHARED_ARRAY_FIELD_EX32(bus->regs, aspeed_i2c_bus_ctrl_offset(bus),
Signature · 1 line
2.34.1
PATCH v3 1/11 hw/i2c/aspeed: Support discontinuous register memory region of I2C bus
In reply to Jamin Lin viaIt only support continuous register memory region for all I2C bus. However, the register address of all I2c bus are discontinuous for AST2700.
Ex: the register address of I2C bus for ast2700 as following. 0x100 - 0x17F: Device 00x200 - 0x27F: Device 10x300 - 0x37F: Device 20x400 - 0x47F: Device 30x500 - 0x57F: Device 40x600 - 0x67F: Device 50x700 - 0x77F: Device 60x800 - 0x87F: Device 70x900 - 0x97F: Device 80xA00 - 0xA7F: Device 90xB00 - 0xB7F: Device 100xC00 - 0xC7F: Device 110xD00 - 0xD7F: Device 120xE00 - 0xE7F: Device 130xF00 – 0xF7F: Device 140x1000 – 0x107F: Device 15
Introduce a new class attribute to make user set each I2C bus gap size. Update formula to create all I2C bus register memory regions.
--- hw/i2c/aspeed_i2c.c | 3 ++- include/hw/i2c/aspeed_i2c.h | 1 + 2 files changed, 3 insertions(+), 1 deletion(-)
hw/i2c/aspeed_i2c.c +2 -1
@@ -1012,6 +1012,7 @@ static void aspeed_i2c_realize(DeviceState *dev, Error **errp)SysBusDevice *sbd =SYS_BUS_DEVICE (dev);AspeedI2CState *s =ASPEED_I2C (dev);AspeedI2CClass *aic =ASPEED_I2C_GET_CLASS (s); +uint32_t reg_offset = aic->reg_size + aic->reg_gap_size;sysbus_init_irq (sbd, &s->irq); memory_region_init_io(&s->iomem, OBJECT(s), &aspeed_i2c_ctrl_ops, s,
@@ -1034,7 +1035,7 @@ static void aspeed_i2c_realize(DeviceState *dev, Error **errp)return ; } -memory_region_add_subregion (&s->iomem, aic->reg_size * (i + offset), +memory_region_add_subregion (&s->iomem, reg_offset * (i + offset), &s->busses[i].mr); }
include/hw/i2c/aspeed_i2c.h +1 -0
@@ -275,6 +275,7 @@ struct AspeedI2CClass {uint8_t num_busses;uint8_t reg_size; +uint32_t reg_gap_size;uint8_t gap;qemu_irq (*bus_get_irq)(AspeedI2CBus *);
Signature · 1 line
2.34.1
PATCH v3 3/11 hw/i2c/aspeed: Support discontinuous poll buffer memory region of I2C bus
In reply to Jamin Lin viaIt only support continuous pool buffer memory region for all I2C bus. However, the pool buffer address of all I2c bus are discontinuous for AST2700.
Ex: the pool buffer address of I2C bus for ast2700 as following. 0x1A0 - 0x1BF: Device 0 buffer0x2A0 - 0x2BF: Device 1 buffer0x3A0 - 0x3BF: Device 2 buffer0x4A0 - 0x4BF: Device 3 buffer0x5A0 - 0x5BF: Device 4 buffer0x6A0 - 0x6BF: Device 5 buffer0x7A0 - 0x7BF: Device 6 buffer0x8A0 - 0x8BF: Device 7 buffer0x9A0 - 0x9BF: Device 8 buffer0xAA0 - 0xABF: Device 9 buffer0xBA0 - 0xBBF: Device 10 buffer0xCA0 - 0xCBF: Device 11 buffer0xDA0 - 0xDBF: Device 12 buffer0xEA0 - 0xEBF: Device 13 buffer0xFA0 – 0xFBF: Device 14 buffer0x10A0 – 0x10BF: Device 15 buffer
Introduce a new class attribute to make user set each I2C bus pool buffer gap size. Update formula to create all I2C bus pool buffer memory regions.
--- hw/i2c/aspeed_i2c.c | 3 ++- include/hw/i2c/aspeed_i2c.h | 1 + 2 files changed, 3 insertions(+), 1 deletion(-)
hw/i2c/aspeed_i2c.c +2 -1
@@ -1098,6 +1098,7 @@ static void aspeed_i2c_realize(DeviceState *dev, Error **errp)AspeedI2CState *s =ASPEED_I2C (dev);AspeedI2CClass *aic =ASPEED_I2C_GET_CLASS (s);uint32_t reg_offset = aic->reg_size + aic->reg_gap_size; +uint32_t pool_offset = aic->pool_size + aic->pool_gap_size;sysbus_init_irq (sbd, &s->irq); memory_region_init_io(&s->iomem, OBJECT(s), &aspeed_i2c_ctrl_ops, s,
@@ -1133,7 +1134,7 @@ static void aspeed_i2c_realize(DeviceState *dev, Error **errp) }else {for (i =0 ; i < aic->num_busses; i++) {memory_region_add_subregion (&s->iomem, - aic->pool_base + (aic->pool_size * i), + aic->pool_base + (pool_offset * i), &s->busses[i].mr_pool); } }
include/hw/i2c/aspeed_i2c.h +1 -0
@@ -284,6 +284,7 @@ struct AspeedI2CClass {uint64_t pool_size;hwaddr pool_base; +uint32_t pool_gap_size;uint8_t *(*bus_pool_base)(AspeedI2CBus *);bool check_sram;bool has_dma;
Signature · 1 line
2.34.1
PATCH v3 5/11 hw/i2c/aspeed: Add AST2700 support
In reply to Jamin Lin viaIntroduce a new ast2700 class to support AST2700. The I2C bus register memory regions and
I2C bus pool buffer memory regions are discontinuous and they do not back compatible AST2600.
Add a new ast2700 i2c class init function to match the address of I2C bus register and pool buffer from the datasheet.
An I2C controller registers owns 8KB address space.
--- hw/i2c/aspeed_i2c.c | 62 +++++++++++++++++++++++++++++++++++++ include/hw/i2c/aspeed_i2c.h | 1 + 2 files changed, 63 insertions(+)
hw/i2c/aspeed_i2c.c +62 -0
@@ -1102,6 +1102,41 @@ static void aspeed_i2c_instance_init(Object *obj)* 0xDA0 ... 0xDBF: Device 14 buffer * 0xDC0 ... 0xDDF: Device 15 buffer (15 and 16 unused in AST1030) * 0xDE0 ... 0xDFF: Device 16 buffer +* +* Address Definitions (AST2700) +* 0x000 ... 0x0FF: Global Register +* 0x100 ... 0x17F: Device 0 +* 0x1A0 ... 0x1BF: Device 0 buffer +* 0x200 ... 0x27F: Device 1 +* 0x2A0 ... 0x2BF: Device 1 buffer +* 0x300 ... 0x37F: Device 2 +* 0x3A0 ... 0x3BF: Device 2 buffer +* 0x400 ... 0x47F: Device 3 +* 0x4A0 ... 0x4BF: Device 3 buffer +* 0x500 ... 0x57F: Device 4 +* 0x5A0 ... 0x5BF: Device 4 buffer +* 0x600 ... 0x67F: Device 5 +* 0x6A0 ... 0x6BF: Device 5 buffer +* 0x700 ... 0x77F: Device 6 +* 0x7A0 ... 0x7BF: Device 6 buffer +* 0x800 ... 0x87F: Device 7 +* 0x8A0 ... 0x8BF: Device 7 buffer +* 0x900 ... 0x97F: Device 8 +* 0x9A0 ... 0x9BF: Device 8 buffer +* 0xA00 ... 0xA7F: Device 9 +* 0xAA0 ... 0xABF: Device 9 buffer +* 0xB00 ... 0xB7F: Device 10 +* 0xBA0 ... 0xBBF: Device 10 buffer +* 0xC00 ... 0xC7F: Device 11 +* 0xCA0 ... 0xCBF: Device 11 buffer +* 0xD00 ... 0xD7F: Device 12 +* 0xDA0 ... 0xDBF: Device 12 buffer +* 0xE00 ... 0xE7F: Device 13 +* 0xEA0 ... 0xEBF: Device 13 buffer +* 0xF00 ... 0xF7F: Device 14 +* 0xFA0 ... 0xFBF: Device 14 buffer +* 0x1000 ... 0x107F: Device 15 +* 0x10A0 ... 0x10BF: Device 15 buffer */ static void aspeed_i2c_realize (DeviceState *dev,Error **errp) {
@@ -1501,6 +1536,32 @@ static const TypeInfo aspeed_1030_i2c_info = { .class_init = aspeed_1030_i2c_class_init, }; +static void aspeed_2700_i2c_class_init (ObjectClass *klass,void *data) +{ +DeviceClass *dc =DEVICE_CLASS (klass); +AspeedI2CClass *aic =ASPEED_I2C_CLASS (klass); + + dc->desc ="ASPEED 2700 I2C Controller" ; + + aic->num_busses =16 ; + aic->reg_size =0x80 ; + aic->reg_gap_size =0x80 ; + aic->gap =-1 ;/* no gap */ + aic->bus_get_irq = aspeed_2600_i2c_bus_get_irq; + aic->pool_size =0x20 ; + aic->pool_gap_size =0xe0 ; + aic->pool_base =0x1a0 ; + aic->bus_pool_base = aspeed_2500_i2c_bus_pool_base; + aic->has_dma = true; + aic->mem_size =0x2000 ; +} + +static const TypeInfo aspeed_2700_i2c_info = { + .name =TYPE_ASPEED_2700_I2C , + .parent =TYPE_ASPEED_I2C , + .class_init = aspeed_2700_i2c_class_init, +}; +static void aspeed_i2c_register_types (void ) {type_register_static (&aspeed_i2c_bus_info);
@@ -1510,6 +1571,7 @@ static void aspeed_i2c_register_types(void)type_register_static (&aspeed_2500_i2c_info);type_register_static (&aspeed_2600_i2c_info);type_register_static (&aspeed_1030_i2c_info); +type_register_static (&aspeed_2700_i2c_info); }type_init (aspeed_i2c_register_types)
include/hw/i2c/aspeed_i2c.h +1 -0
@@ -31,6 +31,7 @@#define TYPE_ASPEED_2500_I2C TYPE_ASPEED_I2C "-ast2500"#define TYPE_ASPEED_2600_I2C TYPE_ASPEED_I2C "-ast2600"#define TYPE_ASPEED_1030_I2C TYPE_ASPEED_I2C "-ast1030" +#define TYPE_ASPEED_2700_I2C TYPE_ASPEED_I2C "-ast2700" OBJECT_DECLARE_TYPE(AspeedI2CState, AspeedI2CClass, ASPEED_I2C)#define ASPEED_I2C_NR_BUSSES 16
Signature · 1 line
2.34.1
PATCH v3 6/11 hw/i2c/aspeed: Add support for Tx/Rx buffer 64 bit addresses
In reply to Jamin Lin viaASPEED AST2700 SOC is a 64 bits quad core CPUs (Cortex-a35) and the base address of dram is "0x4 00000000" which is 64bits address.
It has "Master DMA Mode Tx Buffer Base Address[39:32](0x60)" and "Master DMA Mode Rx Buffer Base Address[39:32](0x64)" registers to save the high part physical address of Tx/Rx buffer address for master mode.
It has "Slave DMA Mode Tx Buffer Base Address[39:32](0x68)" and "Slave DMA Mode Rx Buffer Base Address[39:32](0x6C)" registers to save the high part physical address of Tx/Rx buffer address for slave mode.
Ex: Tx buffer address for master mode [39:0]
The "Master DMA Mode Tx Buffer Base Address[39:32](0x60)" bits [7:0] which corresponds the bits [39:32] of the 64 bits address of the Tx buffer address.
The "Master DMA Mode Tx Buffer Base Address(0x30)" bits [31:0] which corresponds the bits [31:0] of the 64 bits address
of the Tx buffer address.
Introduce a new has_dma64 class attribute and new registers for the new mode to support DMA 64 bits dram address.
Update new mode register number to 28.
The aspeed_i2c_bus_vmstate is changed again and
version is not increased because it was done earlier in the same series.
--- hw/i2c/aspeed_i2c.c | 48 +++++++++++++++++++++++++++++++++++++ include/hw/i2c/aspeed_i2c.h | 12 +++++++++- 2 files changed, 59 insertions(+), 1 deletion(-)
hw/i2c/aspeed_i2c.c +48 -0
@@ -140,6 +140,7 @@ static uint64_t aspeed_i2c_bus_old_read(AspeedI2CBus *bus, hwaddr offset,static uint64_t aspeed_i2c_bus_new_read (AspeedI2CBus *bus,hwaddr offset,unsigned size) { +AspeedI2CClass *aic =ASPEED_I2C_GET_CLASS (bus->controller);uint64_t value = bus->regs[offset /sizeof (*bus->regs)];switch (offset) {
@@ -170,6 +171,16 @@ static uint64_t aspeed_i2c_bus_new_read(AspeedI2CBus *bus, hwaddr offset,case A_I2CM_CMD : value =SHARED_FIELD_DP32 (value,BUS_BUSY_STS ,i2c_bus_busy (bus->bus));break ; +case A_I2CM_DMA_TX_ADDR_HI : +case A_I2CM_DMA_RX_ADDR_HI : +case A_I2CS_DMA_TX_ADDR_HI : +case A_I2CS_DMA_RX_ADDR_HI : +if (!aic->has_dma64) { +qemu_log_mask (LOG_GUEST_ERROR ,"%s: No DMA 64 bits support\n" , + __func__); + value =-1 ; + } +break ;default :qemu_log_mask (LOG_GUEST_ERROR ,"%s: Bad offset 0x%" HWADDR_PRIx"\n" , __func__, offset);
@@ -731,6 +742,42 @@ static void aspeed_i2c_bus_new_write(AspeedI2CBus *bus, hwaddr offset,qemu_log_mask (LOG_UNIMP ,"%s: Slave mode DMA TX is not implemented\n" , __func__);break ; + +case A_I2CM_DMA_TX_ADDR_HI : +if (!aic->has_dma64) { +qemu_log_mask (LOG_GUEST_ERROR ,"%s: No DMA 64 bits support\n" , + __func__); +break ; + } + bus->regs[R_I2CM_DMA_TX_ADDR_HI ] =FIELD_EX32 (value, +I2CM_DMA_TX_ADDR_HI , +ADDR_HI ); +break ; +case A_I2CM_DMA_RX_ADDR_HI : +if (!aic->has_dma64) { +qemu_log_mask (LOG_GUEST_ERROR ,"%s: No DMA 64 bits support\n" , + __func__); +break ; + } + bus->regs[R_I2CM_DMA_RX_ADDR_HI ] =FIELD_EX32 (value, +I2CM_DMA_RX_ADDR_HI , +ADDR_HI ); +break ; +case A_I2CS_DMA_TX_ADDR_HI : +qemu_log_mask (LOG_UNIMP , +"%s: Slave mode DMA TX Addr high is not implemented\n" , + __func__); +break ; +case A_I2CS_DMA_RX_ADDR_HI : +if (!aic->has_dma64) { +qemu_log_mask (LOG_GUEST_ERROR ,"%s: No DMA 64 bits support\n" , + __func__); +break ; + } + bus->regs[R_I2CS_DMA_RX_ADDR_HI ] =FIELD_EX32 (value, +I2CS_DMA_RX_ADDR_HI , +ADDR_HI ); +break ;default :qemu_log_mask (LOG_GUEST_ERROR ,"%s: Bad offset 0x%" HWADDR_PRIx"\n" , __func__, offset);
@@ -1554,6 +1601,7 @@ static void aspeed_2700_i2c_class_init(ObjectClass *klass, void *data) aic->bus_pool_base = aspeed_2500_i2c_bus_pool_base; aic->has_dma = true; aic->mem_size =0x2000 ; + aic->has_dma64 = true; }static const TypeInfo aspeed_2700_i2c_info = {
include/hw/i2c/aspeed_i2c.h +11 -1
@@ -38,7 +38,7 @@ OBJECT_DECLARE_TYPE(AspeedI2CState, AspeedI2CClass, ASPEED_I2C)#define ASPEED_I2C_SHARE_POOL_SIZE 0x800#define ASPEED_I2C_BUS_POOL_SIZE 0x20#define ASPEED_I2C_OLD_NUM_REG 11 -#define ASPEED_I2C_NEW_NUM_REG 22 +#define ASPEED_I2C_NEW_NUM_REG 28#define A_I2CD_M_STOP_CMD BIT(5)#define A_I2CD_M_RX_CMD BIT(3)
@@ -227,6 +227,15 @@ REG32(I2CS_DMA_LEN_STS, 0x4c) FIELD(I2CS_DMA_LEN_STS, TX_LEN, 0, 13) REG32(I2CC_DMA_ADDR, 0x50)REG32 (I2CC_DMA_LEN ,0x54 ) +/* DMA 64bits */ +REG32(I2CM_DMA_TX_ADDR_HI, 0x60) + FIELD(I2CM_DMA_TX_ADDR_HI, ADDR_HI, 0, 7) +REG32(I2CM_DMA_RX_ADDR_HI, 0x64) + FIELD(I2CM_DMA_RX_ADDR_HI, ADDR_HI, 0, 7) +REG32(I2CS_DMA_TX_ADDR_HI, 0x68) + FIELD(I2CS_DMA_TX_ADDR_HI, ADDR_HI, 0, 7) +REG32(I2CS_DMA_RX_ADDR_HI, 0x6c) + FIELD(I2CS_DMA_RX_ADDR_HI, ADDR_HI, 0, 7)struct AspeedI2CState ;
@@ -292,6 +301,7 @@ struct AspeedI2CClass {bool has_dma;bool has_share_pool;uint64_t mem_size; +bool has_dma64; };static inline bool aspeed_i2c_is_new_mode (AspeedI2CState *s)
Signature · 1 line
2.34.1
PATCH v3 8/11 aspeed/soc: Introduce a new API to get the device irq
In reply to Jamin Lin viaCurrently, users can set the INTC mapping table with enumerated device id and device irq to get the INTC orgate input pins. However, some devices use the continuous source numbers in the same INTC orgate. To reduce the enumerated device id definition, create a new API to get the INTC orgate input pin
if users only provide the device id with its bus number index.
--- hw/arm/aspeed_ast27x0.c | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+)
hw/arm/aspeed_ast27x0.c +21 -0
@@ -193,6 +193,27 @@ static qemu_irq aspeed_soc_ast2700_get_irq(AspeedSoCState *s, int dev)return qdev_get_gpio_in (DEVICE (&a->gic), sc->irqmap[dev]); } +static qemu_irq aspeed_soc_ast2700_get_irq_index (AspeedSoCState *s,int dev, +int index) +{ +Aspeed27x0SoCState *a =ASPEED27X0_SOC (s); +AspeedSoCClass *sc =ASPEED_SOC_GET_CLASS (s); +int i; + +for (i =0 ; i <ARRAY_SIZE (aspeed_soc_ast2700_gic_intcmap); i++) { +if (sc->irqmap[dev] == aspeed_soc_ast2700_gic_intcmap[i].irq) { +assert (aspeed_soc_ast2700_gic_intcmap[i].ptr); +return qdev_get_gpio_in (DEVICE (&a->intc.orgates[i]), + aspeed_soc_ast2700_gic_intcmap[i].ptr[dev] + index); + } + } + +/* +* Invalid orgate index, device irq should be 128 to 136. +*/ +g_assert_not_reached (); +} +static uint64_t aspeed_ram_capacity_read (void *opaque,hwaddr addr,unsigned int size) {
Signature · 1 line
2.34.1
Re: [SPAM] [PATCH v3 08/11] aspeed/soc: Introduce a new API to get the device irq
Quoted 8 lines · Jamin Lin
Currently, users can set the INTC mapping table with enumerated device id and device irq to get the INTC orgate input pins. However, some devices use the continuous source numbers in the same INTC orgate. To reduce the enumerated device id definition, create a new API to get the INTC orgate input pin
if users only provide the device id with its bus number index.Signed-off-by Jamin Lin <[email protected]>
Thanks,
C.
Quoted 36 lines
--- hw/arm/aspeed_ast27x0.c | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+)hw/arm/aspeed_ast27x0.c +21
-0@@ -193,6 +193,27 @@ static qemu_irq aspeed_soc_ast2700_get_irq(AspeedSoCState *s, int dev)return qdev_get_gpio_in (DEVICE (&a->gic), sc->irqmap[dev]); } +static qemu_irq aspeed_soc_ast2700_get_irq_index (AspeedSoCState *s,int dev, +int index) +{ +Aspeed27x0SoCState *a =ASPEED27X0_SOC (s); +AspeedSoCClass *sc =ASPEED_SOC_GET_CLASS (s); +int i; + +for (i =0 ; i <ARRAY_SIZE (aspeed_soc_ast2700_gic_intcmap); i++) { +if (sc->irqmap[dev] == aspeed_soc_ast2700_gic_intcmap[i].irq) { +assert (aspeed_soc_ast2700_gic_intcmap[i].ptr); +return qdev_get_gpio_in (DEVICE (&a->intc.orgates[i]), + aspeed_soc_ast2700_gic_intcmap[i].ptr[dev] + index); + } + } + +/* +* Invalid orgate index, device irq should be 128 to 136. +*/ +g_assert_not_reached (); +} +static uint64_t aspeed_ram_capacity_read (void *opaque,hwaddr addr,unsigned int size) {
PATCH v3 10/11 aspeed: Add tmp105 in i2c bus 0 for AST2700
In reply to Jamin Lin viaASPEED SDK add lm75 in i2c bus 0 for AST2700. LM75 is compatible with TMP105 driver.
Introduce a new i2c init function and
add tmp105 device model in i2c bus 0.
--- hw/arm/aspeed.c | 10 ++++++++++ 1 file changed, 10 insertions(+)
hw/arm/aspeed.c +10 -0
@@ -1650,6 +1650,15 @@ static void aspeed_minibmc_machine_ast1030_evb_class_init(ObjectClass *oc, }#ifdef TARGET_AARCH64 +static void ast2700_evb_i2c_init (AspeedMachineState *bmc) +{ +AspeedSoCState *soc = bmc->soc; + +/* LM75 is compatible with TMP105 driver */ +i2c_slave_create_simple (aspeed_i2c_get_bus (&soc->i2c,0 ), +TYPE_TMP105 ,0x4d ); +} +static void aspeed_machine_ast2700_evb_class_init (ObjectClass *oc,void *data) {MachineClass *mc =MACHINE_CLASS (oc);
@@ -1664,6 +1673,7 @@ static void aspeed_machine_ast2700_evb_class_init(ObjectClass *oc, void *data) amc->num_cs =2 ; amc->macs_mask =ASPEED_MAC0_ON |ASPEED_MAC1_ON |ASPEED_MAC2_ON ; amc->uart_default =ASPEED_DEV_UART12 ; + amc->i2c_init = ast2700_evb_i2c_init; mc->default_ram_size =1 * GiB;aspeed_machine_class_init_cpus_defaults (mc); }
Signature · 1 line
2.34.1
PATCH v3 11/11 machine_aspeed.py: Update to test I2C for AST2700
In reply to Jamin Lin viaUpdate test case to test lm75 temperature sensor.
--- tests/avocado/machine_aspeed.py | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)
tests/avocado/machine_aspeed.py +16 -0
@@ -433,9 +433,25 @@ def test_aarch64_ast2700_evb_sdk_v09_02(self): f'loader,addr=0x430000000,cpu-num={i}') self.vm.add_args('-smp', str(num_cpu)) + self.vm.add_args('-device', + 'tmp105,bus=aspeed.i2c.bus.1,address=0x4d,id=tmp-test') self.do_test_aarch64_aspeed_sdk_start(image_dir + 'image-bmc') self.wait_for_console_pattern('nodistro.0 ast2700-default ttyS12') + self.ssh_connect('root', '0penBmc', False) + self.ssh_command('dmesg -c > /dev/null') + + self.ssh_command_output_contains( + 'echo lm75 0x4d > /sys/class/i2c-dev/i2c-1/device/new_device ' + '&& dmesg -c', + 'i2c i2c-1: new_device: Instantiated device lm75 at 0x4d'); + + self.ssh_command_output_contains( + 'cat /sys/class/hwmon/hwmon20/temp1_input', '0') + self.vm.cmd('qom-set', path='/machine/peripheral/tmp-test', + property='temperature', value=18000) + self.ssh_command_output_contains( + 'cat /sys/class/hwmon/hwmon20/temp1_input', '18000') class AST2x00MachineMMC(QemuSystemTest):
Signature · 1 line
2.34.1
PATCH v3 7/11 hw/i2c/aspeed: Add support for 64 bit addresses
In reply to Jamin Lin viaASPEED AST2700 SOC is a 64 bits quad core CPUs (Cortex-a35) and the base address of dram is "0x4 00000000" which is 64bits address.
The AST2700 support the maximum DRAM size is 8 GB. The DRAM physical address range is from "0x4_0000_0000" to "0x5_FFFF_FFFF".
The DRAM offset range is from "0x0_0000_0000" to "0x1_FFFF_FFFF" and it is enough to use bits [33:0] saving the dram offset.
Therefore, save the high part physical address bit[1:0] of Tx/Rx buffer address as dma_dram_offset bit[33:32]. It does not need to decrease the dram physical high part address for DMA operation.
(high part physical address bit[7:0] – 4)
--- hw/i2c/aspeed_i2c.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+)
hw/i2c/aspeed_i2c.c +14 -0
@@ -743,6 +743,14 @@ static void aspeed_i2c_bus_new_write(AspeedI2CBus *bus, hwaddr offset, __func__);break ; +/* +* The AST2700 support the maximum DRAM size is 8 GB. +* The DRAM offset range is from 0x0_0000_0000 to +* 0x1_FFFF_FFFF and it is enough to use bits [33:0] +* saving the dram offset. +* Therefore, save the high part physical address bit[1:0] +* of Tx/Rx buffer address as dma_dram_offset bit[33:32]. +*/ case A_I2CM_DMA_TX_ADDR_HI :if (!aic->has_dma64) { qemu_log_mask(LOG_GUEST_ERROR, "%s: No DMA 64 bits support\n",
@@ -752,6 +760,8 @@ static void aspeed_i2c_bus_new_write(AspeedI2CBus *bus, hwaddr offset, bus->regs[R_I2CM_DMA_TX_ADDR_HI ] =FIELD_EX32 (value,I2CM_DMA_TX_ADDR_HI ,ADDR_HI ); + bus->dma_dram_offset =deposit64 (bus->dma_dram_offset,32 ,32 , +extract32 (value,0 ,2 ));break ;case A_I2CM_DMA_RX_ADDR_HI :if (!aic->has_dma64) {
@@ -762,6 +772,8 @@ static void aspeed_i2c_bus_new_write(AspeedI2CBus *bus, hwaddr offset, bus->regs[R_I2CM_DMA_RX_ADDR_HI ] =FIELD_EX32 (value,I2CM_DMA_RX_ADDR_HI ,ADDR_HI ); + bus->dma_dram_offset =deposit64 (bus->dma_dram_offset,32 ,32 , +extract32 (value,0 ,2 ));break ;case A_I2CS_DMA_TX_ADDR_HI : qemu_log_mask(LOG_UNIMP,
@@ -777,6 +789,8 @@ static void aspeed_i2c_bus_new_write(AspeedI2CBus *bus, hwaddr offset, bus->regs[R_I2CS_DMA_RX_ADDR_HI ] =FIELD_EX32 (value,I2CS_DMA_RX_ADDR_HI ,ADDR_HI ); + bus->dma_dram_offset =deposit64 (bus->dma_dram_offset,32 ,32 , +extract32 (value,0 ,2 ));break ;default : qemu_log_mask(LOG_GUEST_ERROR, "%s: Bad offset 0x%" HWADDR_PRIx "\n",
Signature · 1 line
2.34.1
PATCH v3 9/11 aspeed/soc: Support I2C for AST2700
In reply to Jamin Lin viaAdd I2C model for AST2700 I2C support.
The I2C controller registers base address is start at 0x14C0_F000 and its address space is 0x2000.
The AST2700 I2C controller has one source INTC per bus. I2C buses interrupt are connected to GICINT130_INTC from bit 0 to bit 15.
I2C bus 0 is connected to GICINT130_INTC at bit 0. I2C bus 15 is connected to GICINT130_INTC at bit 15.
--- hw/arm/aspeed_ast27x0.c | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+)
hw/arm/aspeed_ast27x0.c +24 -0
@@ -61,6 +61,7 @@ static const hwaddr aspeed_soc_ast2700_memmap[] = { [ASPEED_GIC_DIST] = 0x12200000, [ASPEED_GIC_REDIST] = 0x12280000, [ASPEED_DEV_ADC] = 0x14C00000, + [ASPEED_DEV_I2C] = 0x14C0F000, };#define AST2700_MAX_IRQ 288
@@ -369,6 +370,9 @@ static void aspeed_soc_ast2700_init(Object *obj)snprintf (typename,sizeof (typename),"aspeed.adc-%s" , socname);object_initialize_child (obj,"adc" , &s->adc, typename); + +snprintf (typename,sizeof (typename),"aspeed.i2c-%s" , socname); +object_initialize_child (obj,"i2c" , &s->i2c, typename); }/*
@@ -452,6 +456,7 @@ static void aspeed_soc_ast2700_realize(DeviceState *dev, Error **errp)AspeedSoCClass *sc =ASPEED_SOC_GET_CLASS (s);AspeedINTCClass *ic =ASPEED_INTC_GET_CLASS (&a->intc); g_autofree char *sram_name = NULL; +qemu_irq irq;/* Default boot region (SPI memory or ROMs) */ memory_region_init(&s->spi_boot_container, OBJECT(s),
@@ -634,6 +639,25 @@ static void aspeed_soc_ast2700_realize(DeviceState *dev, Error **errp)sysbus_connect_irq (SYS_BUS_DEVICE (&s->adc),0 ,aspeed_soc_get_irq (s,ASPEED_DEV_ADC )); +/* I2C */ +object_property_set_link (OBJECT (&s->i2c),"dram" ,OBJECT (s->dram_mr), + &error_abort); +if (!sysbus_realize (SYS_BUS_DEVICE (&s->i2c), errp)) { +return ; + } +aspeed_mmio_map (s,SYS_BUS_DEVICE (&s->i2c),0 , sc->memmap[ASPEED_DEV_I2C ]); +for (i =0 ; i <ASPEED_I2C_GET_CLASS (&s->i2c)->num_busses; i++) { +/* +* The AST2700 I2C controller has one source INTC per bus. +* I2C buses interrupt are connected to GICINT130_INTC +* from bit 0 to bit 15. +* I2C bus 0 is connected to GICINT130_INTC at bit 0. +* I2C bus 15 is connected to GICINT130_INTC at bit 15. +*/ + irq =aspeed_soc_ast2700_get_irq_index (s,ASPEED_DEV_I2C , i); +sysbus_connect_irq (SYS_BUS_DEVICE (&s->i2c.busses[i]),0 , irq); + } +create_unimplemented_device ("ast2700.dpmcu" ,0x11000000 ,0x40000 );create_unimplemented_device ("ast2700.iomem0" ,0x12000000 ,0x01000000 );create_unimplemented_device ("ast2700.iomem1" ,0x14000000 ,0x01000000 );
Signature · 1 line
2.34.1
Re: [SPAM] [PATCH v3 09/11] aspeed/soc: Support I2C for AST2700
Quoted 11 lines · Jamin Lin
Add I2C model for AST2700 I2C support.
The I2C controller registers base address is start at 0x14C0_F000 and its address space is0x2000.The AST2700 I2C controller has one source INTC per bus. I2C buses interrupt are connected to
GICINT130_INTCfrom bit 0 to bit 15.
I2C bus 0 is connected toGICINT130_INTCat bit 0. I2C bus 15 is connected toGICINT130_INTCat bit 15.Signed-off-by Jamin Lin <[email protected]>
Thanks,
C.
Quoted 60 lines
--- hw/arm/aspeed_ast27x0.c | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+)hw/arm/aspeed_ast27x0.c +24
-0@@ -61,6 +61,7 @@ static const hwaddr aspeed_soc_ast2700_memmap[] = { [ASPEED_GIC_DIST] = 0x12200000, [ASPEED_GIC_REDIST] = 0x12280000, [ASPEED_DEV_ADC] = 0x14C00000, + [ASPEED_DEV_I2C] = 0x14C0F000, };#define AST2700_MAX_IRQ 288@@ -369,6 +370,9 @@ static void aspeed_soc_ast2700_init(Object *obj)snprintf (typename,sizeof (typename),"aspeed.adc-%s" , socname);object_initialize_child (obj,"adc" , &s->adc, typename); + +snprintf (typename,sizeof (typename),"aspeed.i2c-%s" , socname); +object_initialize_child (obj,"i2c" , &s->i2c, typename); }/* @@ -452,6 +456,7 @@ static void aspeed_soc_ast2700_realize(DeviceState *dev, Error **errp)AspeedSoCClass *sc =ASPEED_SOC_GET_CLASS (s);AspeedINTCClass *ic =ASPEED_INTC_GET_CLASS (&a->intc); g_autofree char *sram_name = NULL; +qemu_irq irq;/* Default boot region (SPI memory or ROMs) */ memory_region_init(&s->spi_boot_container, OBJECT(s),@@ -634,6 +639,25 @@ static void aspeed_soc_ast2700_realize(DeviceState *dev, Error **errp)sysbus_connect_irq (SYS_BUS_DEVICE (&s->adc),0 ,aspeed_soc_get_irq (s,ASPEED_DEV_ADC )); +/* I2C */ +object_property_set_link (OBJECT (&s->i2c),"dram" ,OBJECT (s->dram_mr), + &error_abort); +if (!sysbus_realize (SYS_BUS_DEVICE (&s->i2c), errp)) { +return ; + } +aspeed_mmio_map (s,SYS_BUS_DEVICE (&s->i2c),0 , sc->memmap[ASPEED_DEV_I2C ]); +for (i =0 ; i <ASPEED_I2C_GET_CLASS (&s->i2c)->num_busses; i++) { +/* +* The AST2700 I2C controller has one source INTC per bus. +* I2C buses interrupt are connected to GICINT130_INTC +* from bit 0 to bit 15. +* I2C bus 0 is connected to GICINT130_INTC at bit 0. +* I2C bus 15 is connected to GICINT130_INTC at bit 15. +*/ + irq =aspeed_soc_ast2700_get_irq_index (s,ASPEED_DEV_I2C , i); +sysbus_connect_irq (SYS_BUS_DEVICE (&s->i2c.busses[i]),0 , irq); + } +create_unimplemented_device ("ast2700.dpmcu" ,0x11000000 ,0x40000 );create_unimplemented_device ("ast2700.iomem0" ,0x12000000 ,0x01000000 );create_unimplemented_device ("ast2700.iomem1" ,0x14000000 ,0x01000000 );
Cédric Le Goater
AppliedQuoted 28 lines · Jamin Lin
v1:
- support I2C for AST2700v2:
- fix review issues and add reviewer suggestion
- update avocado test case for AST2700 I2C
- support i2c bus poolv3:
- update commit messages and commit title
- update API to get the device irqJamin Lin (11):
hw/i2c/aspeed: Support discontinuous register memory region of I2C bus hw/i2c/aspeed: Introduce a new bus pool buffer attribute in
AspeedI2Cbus
hw/i2c/aspeed: Support discontinuous poll buffer memory region of I2C
bus
hw/i2c/aspeed: Introduce a newdma_dram_offsetattribute in
AspeedI2Cbus
hw/i2c/aspeed: Add AST2700 support
hw/i2c/aspeed: Add support for Tx/Rx buffer 64 bit addresses hw/i2c/aspeed: Add support for 64 bit addresses aspeed/soc: Introduce a new API to get the device irq aspeed/soc: Support I2C for AST2700
aspeed: Add tmp105 in i2c bus 0 for AST2700machine_aspeed.py: Update to test I2C for AST2700
Quoted 7 lines
hw/arm/aspeed.c | 10 ++ hw/arm/aspeed_ast27x0.c | 45 +++++ hw/i2c/aspeed_i2c.c | 310 ++++++++++++++++++++++++++++---- include/hw/i2c/aspeed_i2c.h | 28 ++- tests/avocado/machine_aspeed.py | 16 ++ 5 files changed, 362 insertions(+), 47 deletions(-)
Applied to aspeed-next.
Thanks,
C.
Hi Cedric,
Quoted 42 lines
Subject: Re: [SPAM] [PATCH v3 00/11] support I2C for AST2700
Quoted 28 lines · Jamin Lin
v1:
- support I2C for AST2700v2:
- fix review issues and add reviewer suggestion
- update avocado test case for AST2700 I2C
- support i2c bus poolv3:
- update commit messages and commit title
- update API to get the device irqJamin Lin (11):
hw/i2c/aspeed: Support discontinuous register memory region of I2C bus hw/i2c/aspeed: Introduce a new bus pool buffer attribute in
AspeedI2Cbus
hw/i2c/aspeed: Support discontinuous poll buffer memory region of I2C
bus
hw/i2c/aspeed: Introduce a newdma_dram_offsetattribute in
AspeedI2Cbus
hw/i2c/aspeed: Add AST2700 support
hw/i2c/aspeed: Add support for Tx/Rx buffer 64 bit addresses hw/i2c/aspeed: Add support for 64 bit addresses aspeed/soc: Introduce a new API to get the device irq aspeed/soc: Support I2C for AST2700
aspeed: Add tmp105 in i2c bus 0 for AST2700machine_aspeed.py: Update to test I2C for AST2700Quoted 3 lines
hw/arm/aspeed.c | 10 ++ hw/arm/aspeed_ast27x0.c | 45 +++++ hw/i2c/aspeed_i2c.c | 310++++++++++++++++++++++++++++----
Quoted 4 lines
include/hw/i2c/aspeed_i2c.h | 28 ++- tests/avocado/machine_aspeed.py | 16 ++ 5 files changed, 362 insertions(+), 47 deletions(-)
Quoted 4 lines
Applied to aspeed-next.
Thanks,
Thanks for your kindly support.
Just want you to know that I and Troy are working on the following tasks for AST2700.
1. Support boot from bootmcu(riscv32) instead of u-boot(Cortex-A35)
2. Support GPIO.
After we finish above tasks, we will upstream QEMU and send our patches. Thanks-Jamin
Quoted 2 lines
C.
Hello Jamin,
Quoted 2 lines
Just want you to know that I and Troy are working on the following tasks for AST2700.
1. Support boot from bootmcu(riscv32) instead of u-boot(Cortex-A35)
Oh nice. This is a good topic for heterogeneous machines !
Quoted 3 lines
2. Support GPIO.
After we finish above tasks, we will upstream QEMU and send our patches.
There is also this issue we discussed privately on SPI write transactions failing on the AST27000. It looked related to aspeed_smc_do_snoop() but we don't have a good fix yet.
When time permits, could you please open a gitlab issue with your findings and logs, so that we don't forget.
Thanks,
C.
Hi Cedric,
Quoted 15 lines
Subject: Re: [SPAM] [PATCH v3 00/11] support I2C for AST2700
Hello Jamin,
Quoted 1 line
Just want you to know that I and Troy are working on the following tasks for
AST2700.
Quoted 1 line
1. Support boot from bootmcu(riscv32) instead of u-boot(Cortex-A35)
Oh nice. This is a good topic for heterogeneous machines !
Quoted 3 lines
2. Support GPIO.
After we finish above tasks, we will upstream QEMU and send our patches.
Quoted 7 lines
There is also this issue we discussed privately on SPI write transactions failing on the AST27000. It looked related to
aspeed_smc_do_snoop()but we don't have a good fix yet.When time permits, could you please open a gitlab issue with your findings and logs, so that we don't forget.
Thanks for reminding.
Okay. I will open an issue here, https://gitlab.com/qemu-project/qemu/-/issues
Thanks-Jamin
Quoted 5 lines
Thanks,
C.
Hi Cedric,
Quoted 24 lines
Subject: RE: [SPAM] [PATCH v3 00/11] support I2C for AST2700
Hi Cedric,
Quoted 20 lines
Subject: Re: [SPAM] [PATCH v3 00/11] support I2C for AST2700
Hello Jamin,
Quoted 2 lines
Just want you to know that I and Troy are working on the following tasks for
AST2700.
Quoted 1 line
1. Support boot from bootmcu(riscv32) instead of u-boot(Cortex-A35)
Oh nice. This is a good topic for heterogeneous machines !
Quoted 3 lines
2. Support GPIO.
After we finish above tasks, we will upstream QEMU and send our patches.
There is also this issue we discussed privately on SPI write transactions failing on the AST27000. It looked related to
aspeed_smc_do_snoop()but we don't have a good fix yet.
Quoted 8 lines
Quoted 3 lines
When time permits, could you please open a gitlab issue with your findings and logs, so that we don't forget.
Thanks for reminding.
Okay. I will open an issue here, https://gitlab.com/qemu-project/qemu/-/issues
Thanks-JaminQuoted 1 line
Sorry, Due to my PTO. I will open an new issue and send a patch to fix this issue, soon. Thanks-Jamin
Quoted 4 lines
Quoted 4 lines
Thanks,
C.
Hi Cédric,
Quoted 7 lines · Cédric Le Goater
Hello Jamin,
Quoted 2 lines
Just want you to know that I and Troy are working on the following tasks for AST2700.
1. Support boot from bootmcu(riscv32) instead of u-boot(Cortex-A35)Oh nice. This is a good topic for heterogeneous machines !
The basic model for bootmcu(risc-v) is working now, but we're looking for a way to integrate sram/mmio/dram together. The ivshmem requires PCI, it might be too complicate for our use case. There is an ivshmem-flat probably more sutiable for us.
[PATCH 0/4] Add ivshmem-flat device - Gustavo Romero (kernel.org)
https://lore.kernel.org/qemu-devel/[email protected]/
Quoted 10 lines
Quoted 4 lines
2. Support GPIO.
After we finish above tasks, we will upstream QEMU and send our patches.
There is also this issue we discussed privately on SPI write transactions failing on the AST27000. It looked related to
aspeed_smc_do_snoop()but we don't have a good fix yet.
Quoted 9 lines
When time permits, could you please open a gitlab issue with your findings and logs, so that we don't forget.
Thanks,
C.
Thanks,
Troy Lee
Hello,
Quoted 4 lines · Troy Lee
Hi Cédric,
Quoted 1 line · Cédric Le Goater
Quoted 8 lines
Quoted 6 lines
Hello Jamin,
Quoted 2 lines
Just want you to know that I and Troy are working on the following tasks for AST2700.
1. Support boot from bootmcu(riscv32) instead of u-boot(Cortex-A35)Oh nice. This is a good topic for heterogeneous machines !
The basic model for bootmcu(risc-v) is working now,
May be send that first.
Quoted 2 lines
but we're looking for a way
to integrate sram/mmio/dram together.
Unfortunately, QEMU is not yet ready for heterogeneous architectures.
Quoted 6 lines
The ivshmem requires PCI, it might be
too complicate for our use case. There is an ivshmem-flat probably more sutiable for us.[PATCH 0/4] Add ivshmem-flat device - Gustavo Romero (kernel.org)
https://lore.kernel.org/qemu-devel/[email protected]/
I lack expertise in that area. Adding Gustavo.
Thanks,
C.