Skip to contentSkip to conversation

interface: remove twice phy information

PATCH In review Alexander Aring 2 participants 4 messages Jan 20, 2015 IEEE 802.15.4

lore
Share & tools
lore

Alexander Aring

author maintainer
#0 lore raw

PATCH v2 1/2 interface: remove twice phy information

The phy information is already shown in a previous printout and this code seems that it was never be functional.

---
 src/interface.c | 2 --
 1 file changed, 2 deletions(-)
src/interface.c +0 -2
index 095753b..904b96e 100644
@@ -212,8 +212,6 @@ static int print_iface_handler(struct nl_msg *msg, void *arg)
 		       le16toh(nla_get_u16(tb_msg[NL802154_ATTR_PAN_ID])));
 	if (tb_msg[NL802154_ATTR_IFTYPE])
 		printf("%s\ttype %s\n", indent, iftype_name(nla_get_u32(tb_msg[NL802154_ATTR_IFTYPE])));
-	if (!wpan_phy && tb_msg[NL802154_ATTR_WPAN_PHY])
-		printf("%s\twpan_phy %d\n", indent, nla_get_u32(tb_msg[NL802154_ATTR_WPAN_PHY]));
 	if (tb_msg[NL802154_ATTR_MAX_FRAME_RETRIES])
 		printf("%s\tmax_frame_retries %d\n", indent, nla_get_s8(tb_msg[NL802154_ATTR_MAX_FRAME_RETRIES]));
 	if (tb_msg[NL802154_ATTR_MIN_BE])
Signature · 1 line
2.2.2
author maintainer
#1 lore raw

PATCH v2 2/2 info: remove unused features argument

This patch removes an unused argument string for the phy information call. This is copied from the original iw tool. If we need really such argument then we can add this later again.

---
 src/info.c | 4 ----
 1 file changed, 4 deletions(-)
src/info.c +0 -4
index 83f2e3e..e155470 100644
@@ -94,10 +94,6 @@ static int handle_info(struct nl802154_state *state,
 		       int argc, char **argv,
 		       enum id_input id)
 {
-	char *feat_args[] = { "features", "-q" };
-
-	handle_cmd(state, CIB_NONE, 2, feat_args);
-
 	nl_cb_set(cb, NL_CB_VALID, NL_CB_CUSTOM, print_phy_handler, NULL);
 
 	return 0;
Signature · 1 line
2.2.2
Reviewed-by on v2 2/2
#2 lore raw

Re: [PATCHv2 wpan-tools 2/2] info: remove unused features argument

Hello.

Quoted 15 lines · Alexander Aring

This patch removes an unused argument string for the phy information call. This is copied from the original iw tool. If we need really such argument then we can add this later again.

---
  src/info.c | 4 ----
  1 file changed, 4 deletions(-)
src/info.c +0 -0
index 83f2e3e..e155470 100644

src/info.c static int handle_info(struct nl802154_state *state, · line 99

Quoted 10 lines
src/info.c +0 -4
@@ -94,10 +94,6 @@ static int handle_info(struct nl802154_state *state,
  		       int argc, char **argv,
  		       enum id_input id)
  {
-	char *feat_args[] = { "features", "-q" };
-
-	handle_cmd(state, CIB_NONE, 2, feat_args);
-
  	nl_cb_set(cb, NL_CB_VALID, NL_CB_CUSTOM, print_phy_handler, NULL);
 
  	return 0;

regards
Stefan Schmidt

Reviewed-by on v2 1/2
#3 lore raw
In reply to Alexander Aring

Hello.

Quoted 21 lines · Alexander Aring

The phy information is already shown in a previous printout and this code seems that it was never be functional.

---
  src/interface.c | 2 --
  1 file changed, 2 deletions(-)
src/interface.c +0 -2
index 095753b..904b96e 100644
@@ -212,8 +212,6 @@ static int print_iface_handler(struct nl_msg *msg,
 void *arg)
 
 le16toh(nla_get_u16(tb_msg[NL802154_ATTR_PAN_ID])));
  	if (tb_msg[NL802154_ATTR_IFTYPE])
  		printf("%s\ttype %s\n", indent,
 iftype_name(nla_get_u32(tb_msg[NL802154_ATTR_IFTYPE])));
-	if (!wpan_phy && tb_msg[NL802154_ATTR_WPAN_PHY])
-		printf("%s\twpan_phy %d\n", indent,
Quoted 6 lines

nla_get_u32(tb_msg[NL802154_ATTR_WPAN_PHY]));
if (tb_msg[NL802154_ATTR_MAX_FRAME_RETRIES])
printf("%s\tmax_frame_retries %d\n", indent,
nla_get_s8(tb_msg[NL802154_ATTR_MAX_FRAME_RETRIES]));
if (tb_msg[NL802154_ATTR_MIN_BE])

regards
Stefan Schmidt