support for new board
Subsystems (4)
PATCH 1/1 support for new board
Hi there
I would like to add support for a new board.
Below is the Patch.
Thanks.
---------------------------------------
From 84ee8bc7b927ca9f88870a6a2f73906bb9492698 Mon Sep 17 00:00:00 2001
From: Claudio Hediger <[email protected]>
Date: Mon, 24 Jun 2019 12:39:51 +0200
Subject: [PATCH] added eval1a board
--- arch/arm/boot/dts/Makefile | 4 +- arch/arm/boot/dts/imx6ull-dtb-eval1a.dts | 168 +++++++++++++++ arch/arm/configs/eval1a_defconfig | 259 +++++++++++++++++++++++ 3 files changed, 430 insertions(+), 1 deletion(-) create mode 100644 arch/arm/boot/dts/imx6ull-dtb-eval1a.dts create mode 100644 arch/arm/configs/eval1a_defconfig
arch/arm/boot/dts/Makefile +3 -1
@@ -580,7 +580,9 @@ dtb-$(CONFIG_SOC_IMX6UL) += \ imx6ull-14x14-evk.dtb \ imx6ull-colibri-eval-v3.dtb \ imx6ull-colibri-wifi-eval-v3.dtb \ - imx6ulz-14x14-evk.dtb + imx6ulz-14x14-evk.dtb \ + imx6ull-dtb-eval1a.dtb + dtb-$(CONFIG_SOC_IMX7D) += \ imx7d-cl-som-imx7.dtb \ imx7d-colibri-emmc-eval-v3.dtb \
(quoted diff) +0 -0
b/arch/arm/boot/dts/imx6ull-dtb-eval1a.dts
new file mode 100644
index 000000000000..e549ef90816f
arch/arm/boot/dts/imx6ull-dtb-eval1a.dts new file +80 -0
80 lines not on this page · raw message
0x1b0b0
+ MX6UL_PAD_ENET1_RX_ER__ENET1_RX_ER0x1b0b0
+ MX6UL_PAD_ENET1_RX_DATA0__ENET1_RDATA000x1b0b0
+ MX6UL_PAD_ENET1_RX_DATA1__ENET1_RDATA010x1b0b0
+ MX6UL_PAD_ENET1_TX_EN__ENET1_TX_EN0x1b0b0
+ MX6UL_PAD_ENET1_TX_DATA0__ENET1_TDATA000x1b0b0
+ MX6UL_PAD_ENET1_TX_DATA1__ENET1_TDATA010x1b0b0
+ MX6UL_PAD_ENET1_TX_CLK__ENET1_REF_CLK10x4001b031
+ MX6UL_PAD_GPIO1_IO07__ENET1_MDC0x1b0b0
+ MX6UL_PAD_GPIO1_IO06__ENET1_MDIO0x1b0b0
+ >;
+ };
+
+ pinctrl_uart1: uart1grp {
+ fsl,pins = <
+ MX6UL_PAD_UART1_TX_DATA__UART1_DCE_TX0x1b0b1
+ MX6UL_PAD_UART1_RX_DATA__UART1_DCE_RX0x1b0b1
+ >;
+ };
+
+ pinctrl_uart2: uart2grp {
+ fsl,pins = <
+ MX6UL_PAD_UART2_TX_DATA__UART2_DCE_TX0x1b0b1
+ MX6UL_PAD_UART2_RX_DATA__UART2_DCE_RX0x1b0b1
+ MX6UL_PAD_UART3_RX_DATA__UART2_DCE_RTS0x1b0b1
+ MX6UL_PAD_UART3_TX_DATA__UART2_DCE_CTS0x1b0b1
+ >;
+ };
+
+ pinctrl_uart2dte: uart2dtegrp {
+ fsl,pins = <
+ MX6UL_PAD_UART2_TX_DATA__UART2_DTE_RX0x1b0b1
+ MX6UL_PAD_UART2_RX_DATA__UART2_DTE_TX0x1b0b1
+ MX6UL_PAD_UART3_RX_DATA__UART2_DTE_CTS0x1b0b1
+ MX6UL_PAD_UART3_TX_DATA__UART2_DTE_RTS0x1b0b1
+ >;
+ };
+
+ pinctrl_usdhc1: usdhc1grp {
+ fsl,pins = <
+ MX6UL_PAD_SD1_CMD__USDHC1_CMD 0x17059
+ MX6UL_PAD_SD1_CLK__USDHC1_CLK 0x10071
+ MX6UL_PAD_SD1_DATA0__USDHC1_DATA0 0x17059
+ MX6UL_PAD_SD1_DATA1__USDHC1_DATA1 0x17059
+ MX6UL_PAD_SD1_DATA2__USDHC1_DATA2 0x17059
+ MX6UL_PAD_SD1_DATA3__USDHC1_DATA3 0x17059
+ >;
+ };
+
+ pinctrl_wdog: wdoggrp {
+ fsl,pins = <
+ MX6UL_PAD_LCD_RESET__WDOG1_WDOG_ANY0x30b0
+ >;
+ };
+ };
+};
+
+
+&uart1 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_uart1>;
+ status = "okay";
+};
+
+&uart2 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_uart2>;
+ fsl,uart-has-rtscts;
+ /* for DTE mode, add below change */
+ /* fsl,dte-mode; */
+ /* pinctrl-0 = <&pinctrl_uart2dte>; */
+ status = "okay";
+};
+
+&usdhc1 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_usdhc1>;
+ //cd-gpios = <&gpio1 19 GPIO_ACTIVE_LOW>;
+ keep-power-in-suspend;
+ enable-sdio-wakeup;
+ status = "okay";
+};
+
+&wdog1 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_wdog>;
+ fsl,wdog_b;
+};
(quoted diff) +0 -0
b/arch/arm/configs/eval1a_defconfig
new file mode 100644
index 000000000000..2ce2aa870515
arch/arm/configs/eval1a_defconfig new file +259 -0
259 lines not on this page · raw message
Signature · 8 lines
2.17.1 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Quoted 4 lines · On Mon, Jun 24, 2019 at 01:11:20PM +0200, [email protected] wrote:
Hi there
I would like to add support for a new board. Below is the Patch.
Hi Claudio
Please take a read of
https://www.kernel.org/doc/html/latest/process/submitting-patches.html
Your email has the wrong format. You a missing a Signed-off-by, etc.
Quoted 20 lines
---------------------------------------
Quoted 1 line
From
84ee8bc7b927ca9f88870a6a2f73906bb9492698Mon Sep 17 00:00:00 2001From: Claudio Hediger <[email protected]>
Date: Mon, 24 Jun 2019 12:39:51 +0200
Subject: [PATCH] added eval1a board--- arch/arm/boot/dts/Makefile | 4 +- arch/arm/boot/dts/imx6ull-dtb-eval1a.dts | 168 +++++++++++++++ arch/arm/configs/eval1a_defconfig | 259 +++++++++++++++++++++++ 3 files changed, 430 insertions(+), 1 deletion(-) create mode 100644 arch/arm/boot/dts/imx6ull-dtb-eval1a.dts create mode 100644 arch/arm/configs/eval1a_defconfigarch/arm/boot/dts/Makefile +0
-0
arch/arm/boot/dts/Makefile dtb-$(CONFIG_SOC_IMX6UL) += \ · line 584
Quoted 6 lines
arch/arm/boot/dts/Makefile +2
-1@@ -580,7 +580,9 @@ dtb-$(CONFIG_SOC_IMX6UL) += \ imx6ull-14x14-evk.dtb \ imx6ull-colibri-eval-v3.dtb \ imx6ull-colibri-wifi-eval-v3.dtb \ - imx6ulz-14x14-evk.dtb + imx6ulz-14x14-evk.dtb \ + imx6ull-dtb-eval1a.dtb
These files are listed in alphabetical order. There is also a space/tab problem. The -dtb- also looks a bit odd. I can see it getting mixed up with Device Tree Binary. Maybe -databyte- would be better?
Quoted 11 lines
arch/arm/boot/dts/Makefile +1
-0+ dtb-$(CONFIG_SOC_IMX7D) += \ imx7d-cl-som-imx7.dtb \ imx7d-colibri-emmc-eval-v3.dtb \arch/arm/boot/dts/imx6ull-dtb-eval1a.dts new file +0
-0
arch/arm/boot/dts/imx6ull-dtb-eval1a.dts line 6
Quoted 6 lines
arch/arm/boot/dts/imx6ull-dtb-eval1a.dts new file +6
-0@@ -0,0 +1,168 @@ +/* + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as + * published by the Free Software Foundation. + */
Please add an SPDX line, and skip this text.
arch/arm/boot/dts/imx6ull-dtb-eval1a.dts line 14
Quoted 8 lines
arch/arm/boot/dts/imx6ull-dtb-eval1a.dts new file +8
-0+ +/dts-v1/; + +#include "imx6ull.dtsi" + +/ { + model = "Databyte imx6 Evalboard 1A"; + compatible = "databyte,eval1a", "fsl,imx6ull";
databyte needs adding to Documentation/devicetree/bindings/vendor-prefixes.yaml
arch/arm/boot/dts/imx6ull-dtb-eval1a.dts line 65
Quoted 13 lines
arch/arm/boot/dts/imx6ull-dtb-eval1a.dts new file +13
-0+&fec1 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_enet1>; + phy-mode = "rmii"; + phy-handle = <ðphy0>; + status = "okay"; + + mdio { + #address-cells = <1>; + #size-cells = <0>; + + ethphy0: ethernet-phy@2 { + compatible = "ethernet-phy-ieee802.3-c22";
This compatible is not required.
arch/arm/boot/dts/imx6ull-dtb-eval1a.dts line 75
Quoted 10 lines
arch/arm/boot/dts/imx6ull-dtb-eval1a.dts new file +10
-0+ reg = <2>; + }; + }; +}; + + + +&iomuxc { + pinctrl-names = "default"; + //pinctrl-0 = <&pinctrl_hog_1>;
Please avoid commented out code.
Quoted 8 lines
arch/arm/boot/dts/imx6ull-dtb-eval1a.dts new file +5
-0+ eval1a { + + pinctrl_enet1: enet1grp { + fsl,pins = < + MX6UL_PAD_ENET1_RX_EN__ENET1_RX_EN
0x1b0b0arch/arm/boot/dts/imx6ull-dtb-eval1a.dts new file +1
-0+ MX6UL_PAD_ENET1_RX_ER__ENET1_RX_ER
0x1b0b0
It looks like your mailer has corrupted this patch. Try using 'git send-email'
arch/arm/configs/eval1a_defconfig
Quoted 2 lines
arch/arm/configs/eval1a_defconfig +0
-0
defconfig's have not been added for years.
Andrew
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Hi Andrew
Thank you very much for your suggestions and your answer.
I'm very sorry for the missing signed-off line.
I will add they as soon as I have made corrections to the patch as proposed by you.
One questions about defconfig.
You wrote, that defconfigs have not been added since years. So what would be the right way today?
Thanks
Regards
Claudio
-----Ursprüngliche Nachricht-----
Von: Andrew Lunn <[email protected]>
Gesendet: Montag, 24. Juni 2019 19:12
An: [email protected]
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]
Betreff: Re: [Patch] support for new board
Quoted 4 lines · On Mon, Jun 24, 2019 at 01:11:20PM +0200, [email protected] wrote:
Hi there
I would like to add support for a new board. Below is the Patch.
Hi Claudio
Please take a read of
https://www.kernel.org/doc/html/latest/process/submitting-patches.html
Your email has the wrong format. You a missing a Signed-off-by, etc.
Quoted 21 lines
---------------------------------------
Quoted 2 lines
From
84ee8bc7b927ca9f88870a6a2f73906bb9492698Mon Sep 17 00:00:00 2001From: Claudio Hediger <[email protected]>
Date: Mon, 24 Jun 2019 12:39:51 +0200
Subject: [PATCH] added eval1a board--- arch/arm/boot/dts/Makefile | 4 +- arch/arm/boot/dts/imx6ull-dtb-eval1a.dts | 168 +++++++++++++++ arch/arm/configs/eval1a_defconfig | 259 +++++++++++++++++++++++ 3 files changed, 430 insertions(+), 1 deletion(-) create mode 100644 arch/arm/boot/dts/imx6ull-dtb-eval1a.dts create mode 100644 arch/arm/configs/eval1a_defconfigarch/arm/boot/dts/Makefile +0
-0
arch/arm/boot/dts/Makefile dtb-$(CONFIG_SOC_IMX6UL) += \ · line 584
Quoted 6 lines
arch/arm/boot/dts/Makefile +2
-1@@ -580,7 +580,9 @@ dtb-$(CONFIG_SOC_IMX6UL) += \ imx6ull-14x14-evk.dtb \ imx6ull-colibri-eval-v3.dtb \ imx6ull-colibri-wifi-eval-v3.dtb \ - imx6ulz-14x14-evk.dtb + imx6ulz-14x14-evk.dtb \ + imx6ull-dtb-eval1a.dtb
These files are listed in alphabetical order. There is also a space/tab problem. The -dtb- also looks a bit odd. I can see it getting mixed up with Device Tree Binary. Maybe -databyte- would be better?
Quoted 11 lines
arch/arm/boot/dts/Makefile +1
-0+ dtb-$(CONFIG_SOC_IMX7D) += \ imx7d-cl-som-imx7.dtb \ imx7d-colibri-emmc-eval-v3.dtb \arch/arm/boot/dts/imx6ull-dtb-eval1a.dts new file +0
-0
arch/arm/boot/dts/imx6ull-dtb-eval1a.dts line 7
Quoted 7 lines
arch/arm/boot/dts/imx6ull-dtb-eval1a.dts new file +7
-0@@ -0,0 +1,168 @@ +/* + * + * This program is free software; you can redistribute it and/or +modify + * it under the terms of the GNU General Public License version 2 as + * published by the Free Software Foundation. + */
Please add an SPDX line, and skip this text.
arch/arm/boot/dts/imx6ull-dtb-eval1a.dts line 14
Quoted 8 lines
arch/arm/boot/dts/imx6ull-dtb-eval1a.dts new file +8
-0+ +/dts-v1/; + +#include "imx6ull.dtsi" + +/ { + model = "Databyte imx6 Evalboard 1A"; + compatible = "databyte,eval1a", "fsl,imx6ull";
databyte needs adding to Documentation/devicetree/bindings/vendor-prefixes.yaml
arch/arm/boot/dts/imx6ull-dtb-eval1a.dts line 65
Quoted 13 lines
arch/arm/boot/dts/imx6ull-dtb-eval1a.dts new file +13
-0+&fec1 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_enet1>; + phy-mode = "rmii"; + phy-handle = <ðphy0>; + status = "okay"; + + mdio { + #address-cells = <1>; + #size-cells = <0>; + + ethphy0: ethernet-phy@2 { + compatible = "ethernet-phy-ieee802.3-c22";
This compatible is not required.
arch/arm/boot/dts/imx6ull-dtb-eval1a.dts line 75
Quoted 10 lines
arch/arm/boot/dts/imx6ull-dtb-eval1a.dts new file +10
-0+ reg = <2>; + }; + }; +}; + + + +&iomuxc { + pinctrl-names = "default"; + //pinctrl-0 = <&pinctrl_hog_1>;
Please avoid commented out code.
Quoted 8 lines
arch/arm/boot/dts/imx6ull-dtb-eval1a.dts new file +5
-0+ eval1a { + + pinctrl_enet1: enet1grp { + fsl,pins = < + MX6UL_PAD_ENET1_RX_EN__ENET1_RX_EN
0x1b0b0arch/arm/boot/dts/imx6ull-dtb-eval1a.dts new file +1
-0+ MX6UL_PAD_ENET1_RX_ER__ENET1_RX_ER
0x1b0b0
It looks like your mailer has corrupted this patch. Try using 'git send-email'
arch/arm/configs/eval1a_defconfig
Quoted 2 lines
arch/arm/configs/eval1a_defconfig +0
-0
defconfig's have not been added for years.
Andrew
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Hello Claudio,
Quoted 8 lines · On Mon, Jun 24, 2019 at 08:51:09PM +0200, [email protected] wrote:
Thank you very much for your suggestions and your answer.
I'm very sorry for the missing signed-off line.
I will add they as soon as I have made corrections to the patch as proposed by you.One questions about defconfig.
You wrote, that defconfigs have not been added since years. So what would be the right way today?
Just enable all the stuff you need in imx_v6_v7_defconfig and/or multi_v7_defconfig.
Best regards
Uwe
Signature · 7 lines
Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel