x86: fix cpu hotplug with secure boot
cover x86: fix cpu hotplug with secure boot
v1:
- fix typos and some phrases (Laszlo)
- add unplug check (Laszlo)
- redo AML scan logic to avoid race when adding multiple CPUs
CPU hotplug with Secure Boot was not really supported and firmware wasn't aware of hotplugged CPUs (which might lead to guest crashes). During 4.2 we introduced locked SMI handler RAM arrea to make sure that guest OS wasn't able to inject its own SMI handler and OVMF added initial CPU hotplug support.
This series is QEMU part of that support which lets QMVF tell QEMU that CPU hotplug with SMI broadcast enabled is supported so that QEMU would be able to prevent hotplug in case it's not supported and trigger SMI on hotplug when it's necessary.
Igor Mammedov (6):
x86: lpc9: let firmware negotiate 'CPU hotplug with SMI' features
x86: cphp: prevent guest crash on CPU hotplug when broadcast SMI is in
use
x86: cpuhp: refuse cpu hot-unplug request earlier if not supported
tests: acpi: mark to be changed tables in
bios-tables-test-allowed-diff
x68: acpi: trigger SMI before scanning for hotplugged CPUs
tests: acpi: update acpi blobs with new AML
include/hw/acpi/cpu.h | 1 + include/hw/i386/ich9.h | 4 +++ hw/acpi/cpu.c | 50 ++++++++++++++++++++++++++++-- hw/acpi/ich9.c | 23 +++++++++++++- hw/i386/acpi-build.c | 35 ++++++++++++++++++++- hw/i386/pc.c | 16 +++++++++- hw/isa/lpc_ich9.c | 15 +++++++++ tests/data/acpi/pc/DSDT | Bin 4934 -> 4973 bytes tests/data/acpi/pc/DSDT.acpihmat | Bin 6258 -> 6297 bytes tests/data/acpi/pc/DSDT.bridge | Bin 6793 -> 6832 bytes tests/data/acpi/pc/DSDT.cphp | Bin 5397 -> 5436 bytes tests/data/acpi/pc/DSDT.dimmpxm | Bin 6587 -> 6626 bytes tests/data/acpi/pc/DSDT.ipmikcs | Bin 5006 -> 5045 bytes tests/data/acpi/pc/DSDT.memhp | Bin 6293 -> 6332 bytes tests/data/acpi/pc/DSDT.numamem | Bin 4940 -> 4979 bytes tests/data/acpi/q35/DSDT | Bin 7678 -> 7717 bytes tests/data/acpi/q35/DSDT.acpihmat | Bin 9002 -> 9041 bytes tests/data/acpi/q35/DSDT.bridge | Bin 7695 -> 7734 bytes tests/data/acpi/q35/DSDT.cphp | Bin 8141 -> 8180 bytes tests/data/acpi/q35/DSDT.dimmpxm | Bin 9331 -> 9370 bytes tests/data/acpi/q35/DSDT.ipmibt | Bin 7753 -> 7792 bytes tests/data/acpi/q35/DSDT.memhp | Bin 9037 -> 9076 bytes tests/data/acpi/q35/DSDT.mmio64 | Bin 8808 -> 8847 bytes tests/data/acpi/q35/DSDT.numamem | Bin 7684 -> 7723 bytes tests/data/acpi/q35/DSDT.tis | Bin 8283 -> 8322 bytes 25 files changed, 139 insertions(+), 5 deletions(-)
Signature · 1 line
2.26.2
PATCH 1/6 x86: lpc9: let firmware negotiate 'CPU hotplug with SMI' features
It will allow firmware to notify QEMU that firmware requires SMI being triggered on CPU hot[un]plug, so that it would be able to account for hotplugged CPU and relocate it to new SMM base and/or safely remove CPU on unplug.
Using negotiated features, follow up patches will insert SMI upcall into AML code, to make sure that firmware processes hotplug before guest OS would attempt to use new CPU.
--- include/hw/i386/ich9.h | 2 ++ hw/i386/pc.c | 5 ++++- hw/isa/lpc_ich9.c | 12 ++++++++++++ 3 files changed, 18 insertions(+), 1 deletion(-)
include/hw/i386/ich9.h +2 -0
@@ -247,5 +247,7 @@ typedef struct ICH9LPCState {/* bit positions used in fw_cfg SMI feature negotiation */ #define ICH9_LPC_SMI_F_BROADCAST_BIT 0 +#define ICH9_LPC_SMI_F_CPU_HOTPLUG_BIT 1 +#define ICH9_LPC_SMI_F_CPU_HOT_UNPLUG_BIT 2#endif /* HW_ICH9_H */
hw/i386/pc.c +4 -1
@@ -97,7 +97,10 @@#include "fw_cfg.h" #include "trace.h" -GlobalProperty pc_compat_5_0[] = {}; +GlobalProperty pc_compat_5_0[] = { + {"ICH9-LPC" ,"x-smi-cpu-hotplug" ,"off" }, + {"ICH9-LPC" ,"x-smi-cpu-hotunplug" ,"off" }, +};const size_t pc_compat_5_0_len =G_N_ELEMENTS (pc_compat_5_0);GlobalProperty pc_compat_4_2[] = {
hw/isa/lpc_ich9.c +12 -0
@@ -373,6 +373,14 @@ static void smi_features_ok_callback(void *opaque)/* guest requests invalid features, leave @features_ok at zero */ return ; } +if (!(guest_features &BIT_ULL (ICH9_LPC_SMI_F_BROADCAST_BIT )) && + guest_features & (BIT_ULL (ICH9_LPC_SMI_F_CPU_HOTPLUG_BIT ) | +BIT_ULL (ICH9_LPC_SMI_F_CPU_HOT_UNPLUG_BIT ))) { +/* cpu hot-[un]plug with SMI requires SMI broadcast, +* leave @features_ok at zero +*/ +return ; + }/* valid feature subset requested, lock it down, report success */ lpc->smi_negotiated_features = guest_features;
@@ -747,6 +755,10 @@ static Property ich9_lpc_properties[] = {DEFINE_PROP_BOOL ("noreboot" , ICH9LPCState, pin_strap.spkr_hi, true),DEFINE_PROP_BIT64 ("x-smi-broadcast" , ICH9LPCState, smi_host_features,ICH9_LPC_SMI_F_BROADCAST_BIT , true), +DEFINE_PROP_BIT64 ("x-smi-cpu-hotplug" , ICH9LPCState, smi_host_features, +ICH9_LPC_SMI_F_CPU_HOTPLUG_BIT , true), +DEFINE_PROP_BIT64 ("x-smi-cpu-hotunplug" , ICH9LPCState, smi_host_features, +ICH9_LPC_SMI_F_CPU_HOT_UNPLUG_BIT , true), DEFINE_PROP_END_OF_LIST(), };
Signature · 1 line
2.26.2
Re: [PATCH 1/6] x86: lpc9: let firmware negotiate 'CPU hotplug with SMI' features
Quoted 65 lines · Igor Mammedov
It will allow firmware to notify QEMU that firmware requires SMI being triggered on CPU hot[un]plug, so that it would be able to account for hotplugged CPU and relocate it to new SMM base and/or safely remove CPU on unplug.
Using negotiated features, follow up patches will insert SMI upcall into AML code, to make sure that firmware processes hotplug before guest OS would attempt to use new CPU.
Signed-off-by Igor Mammedov <[email protected]>--- include/hw/i386/ich9.h | 2 ++ hw/i386/pc.c | 5 ++++- hw/isa/lpc_ich9.c | 12 ++++++++++++ 3 files changed, 18 insertions(+), 1 deletion(-)include/hw/i386/ich9.h +2
-0@@ -247,5 +247,7 @@ typedef struct ICH9LPCState {/* bit positions used in fw_cfg SMI feature negotiation */ #define ICH9_LPC_SMI_F_BROADCAST_BIT 0 +#define ICH9_LPC_SMI_F_CPU_HOTPLUG_BIT 1 +#define ICH9_LPC_SMI_F_CPU_HOT_UNPLUG_BIT 2#endif /* HW_ICH9_H */ hw/i386/pc.c +4
-1@@ -97,7 +97,10 @@#include "fw_cfg.h" #include "trace.h" -GlobalProperty pc_compat_5_0[] = {}; +GlobalProperty pc_compat_5_0[] = { + {"ICH9-LPC" ,"x-smi-cpu-hotplug" ,"off" }, + {"ICH9-LPC" ,"x-smi-cpu-hotunplug" ,"off" }, +};const size_t pc_compat_5_0_len =G_N_ELEMENTS (pc_compat_5_0);GlobalProperty pc_compat_4_2[] = {hw/isa/lpc_ich9.c +8
-0@@ -373,6 +373,14 @@ static void smi_features_ok_callback(void *opaque)/* guest requests invalid features, leave @features_ok at zero */ return ; } +if (!(guest_features &BIT_ULL (ICH9_LPC_SMI_F_BROADCAST_BIT )) && + guest_features & (BIT_ULL (ICH9_LPC_SMI_F_CPU_HOTPLUG_BIT ) | +BIT_ULL (ICH9_LPC_SMI_F_CPU_HOT_UNPLUG_BIT ))) { +/* cpu hot-[un]plug with SMI requires SMI broadcast, +* leave @features_ok at zero +*/ +return ; + }/* valid feature subset requested, lock it down, report success */ lpc->smi_negotiated_features = guest_features;
hw/isa/lpc_ich9.c static Property ich9_lpc_properties[] = { · line 764
Quoted 10 lines
hw/isa/lpc_ich9.c +4
-0@@ -747,6 +755,10 @@ static Property ich9_lpc_properties[] = {DEFINE_PROP_BOOL ("noreboot" , ICH9LPCState, pin_strap.spkr_hi, true),DEFINE_PROP_BIT64 ("x-smi-broadcast" , ICH9LPCState, smi_host_features,ICH9_LPC_SMI_F_BROADCAST_BIT , true), +DEFINE_PROP_BIT64 ("x-smi-cpu-hotplug" , ICH9LPCState, smi_host_features, +ICH9_LPC_SMI_F_CPU_HOTPLUG_BIT , true), +DEFINE_PROP_BIT64 ("x-smi-cpu-hotunplug" , ICH9LPCState, smi_host_features, +ICH9_LPC_SMI_F_CPU_HOT_UNPLUG_BIT , true), DEFINE_PROP_END_OF_LIST(), };
(1) I think that, at this time, the default value for "x-smi-cpu-hotunplug" should be false. Accordingly, the "x-smi-cpu-hotunplug" compat property should be dropped.
The reason is that in this series, QEMU won't actually learn to handle CPU hot-unplug with SMI. We shouldn't advertize support for it.
We should only recognize the feature, so that the QMP command can rely on it for rejecting hot-unplug attempts. If (later) we have a more advanced OVMF binary with unplug support (so that OVMF would try to negotiate unplug), but the user runs it on QEMU-5.1 (or more precisely with an 5.1 machine type), which will support plug, but not unplug, then QEMU should reject the device_del QMP command.
In brief, we need both properties because we want both device_add and device_del to fail gracefully, but the default values (and accordingly the compat properties) should reflect the actual feature support. So unplug should default to false at this point.
Thanks,
Laszlo
Laszlo Ersek
Reviewed-byRe: [PATCH 1/6] x86: lpc9: let firmware negotiate 'CPU hotplug with SMI' features
Quoted 91 lines · Laszlo Ersek
Quoted 65 lines · Igor Mammedov
It will allow firmware to notify QEMU that firmware requires SMI being triggered on CPU hot[un]plug, so that it would be able to account for hotplugged CPU and relocate it to new SMM base and/or safely remove CPU on unplug.
Using negotiated features, follow up patches will insert SMI upcall into AML code, to make sure that firmware processes hotplug before guest OS would attempt to use new CPU.
Signed-off-by Igor Mammedov <[email protected]>--- include/hw/i386/ich9.h | 2 ++ hw/i386/pc.c | 5 ++++- hw/isa/lpc_ich9.c | 12 ++++++++++++ 3 files changed, 18 insertions(+), 1 deletion(-)include/hw/i386/ich9.h +2
-0@@ -247,5 +247,7 @@ typedef struct ICH9LPCState {/* bit positions used in fw_cfg SMI feature negotiation */ #define ICH9_LPC_SMI_F_BROADCAST_BIT 0 +#define ICH9_LPC_SMI_F_CPU_HOTPLUG_BIT 1 +#define ICH9_LPC_SMI_F_CPU_HOT_UNPLUG_BIT 2#endif /* HW_ICH9_H */ hw/i386/pc.c +4
-1@@ -97,7 +97,10 @@#include "fw_cfg.h" #include "trace.h" -GlobalProperty pc_compat_5_0[] = {}; +GlobalProperty pc_compat_5_0[] = { + {"ICH9-LPC" ,"x-smi-cpu-hotplug" ,"off" }, + {"ICH9-LPC" ,"x-smi-cpu-hotunplug" ,"off" }, +};const size_t pc_compat_5_0_len =G_N_ELEMENTS (pc_compat_5_0);GlobalProperty pc_compat_4_2[] = {hw/isa/lpc_ich9.c +8
-0@@ -373,6 +373,14 @@ static void smi_features_ok_callback(void *opaque)/* guest requests invalid features, leave @features_ok at zero */ return ; } +if (!(guest_features &BIT_ULL (ICH9_LPC_SMI_F_BROADCAST_BIT )) && + guest_features & (BIT_ULL (ICH9_LPC_SMI_F_CPU_HOTPLUG_BIT ) | +BIT_ULL (ICH9_LPC_SMI_F_CPU_HOT_UNPLUG_BIT ))) { +/* cpu hot-[un]plug with SMI requires SMI broadcast, +* leave @features_ok at zero +*/ +return ; + }/* valid feature subset requested, lock it down, report success */ lpc->smi_negotiated_features = guest_features;hw/isa/lpc_ich9.c static Property ich9_lpc_properties[] = { · line 764
Quoted 10 lines
hw/isa/lpc_ich9.c +4
-0@@ -747,6 +755,10 @@ static Property ich9_lpc_properties[] = {DEFINE_PROP_BOOL ("noreboot" , ICH9LPCState, pin_strap.spkr_hi, true),DEFINE_PROP_BIT64 ("x-smi-broadcast" , ICH9LPCState, smi_host_features,ICH9_LPC_SMI_F_BROADCAST_BIT , true), +DEFINE_PROP_BIT64 ("x-smi-cpu-hotplug" , ICH9LPCState, smi_host_features, +ICH9_LPC_SMI_F_CPU_HOTPLUG_BIT , true), +DEFINE_PROP_BIT64 ("x-smi-cpu-hotunplug" , ICH9LPCState, smi_host_features, +ICH9_LPC_SMI_F_CPU_HOT_UNPLUG_BIT , true), DEFINE_PROP_END_OF_LIST(), };(1) I think that, at this time, the default value for "x-smi-cpu-hotunplug" should be false. Accordingly, the "x-smi-cpu-hotunplug" compat property should be dropped.
The reason is that in this series, QEMU won't actually learn to handle CPU hot-unplug with SMI. We shouldn't advertize support for it.
We should only recognize the feature, so that the QMP command can rely on it for rejecting hot-unplug attempts. If (later) we have a more advanced OVMF binary with unplug support (so that OVMF would try to negotiate unplug), but the user runs it on QEMU-5.1 (or more precisely with an 5.1 machine type), which will support plug, but not unplug, then QEMU should reject the
device_delQMP command.
Quoted 4 lines
In brief, we need both properties because we want both
device_addanddevice_delto fail gracefully, but the default values (and accordingly the compat properties) should reflect the actual feature support. So unplug should default to false at this point.
With (1) updated:
PATCH 2/6 x86: cphp: prevent guest crash on CPU hotplug when broadcast SMI is in use
In reply to Igor MammedovThere were reports of guest crash on CPU hotplug, when using q35 machine type and OVMF with SMM, due to hotplugged CPU trying to process SMI at default SMI handler location without it being relocated by firmware first.
Fix it by refusing hotplug if firmware hasn't negotiated CPU hotplug with SMI support while SMI broadcast is in use.
---
v1:
fix typos an use suggested wording in commit and error msg s/secure boot/smm/; s/hotplug SMI/hotplug with SMI/
(Laszlo Ersek <[email protected]>)
--- hw/acpi/ich9.c | 12 +++++++++++- hw/i386/pc.c | 11 +++++++++++ 2 files changed, 22 insertions(+), 1 deletion(-)
hw/acpi/ich9.c +11 -1
@@ -408,10 +408,20 @@ void ich9_pm_device_pre_plug_cb(HotplugHandler *hotplug_dev, DeviceState *dev,ICH9LPCState *lpc =ICH9_LPC_DEVICE (hotplug_dev);if (object_dynamic_cast (OBJECT (dev),TYPE_PC_DIMM ) && - !lpc->pm.acpi_memory_hotplug.is_enabled) + !lpc->pm.acpi_memory_hotplug.is_enabled) {error_setg (errp,"memory hotplug is not enabled: %s.memory-hotplug-support " "is not set" ,object_get_typename (OBJECT (lpc))); + }else if (object_dynamic_cast (OBJECT (dev),TYPE_CPU )) { +uint64_t negotiated = lpc->smi_negotiated_features; + +if (negotiated &BIT_ULL (ICH9_LPC_SMI_F_BROADCAST_BIT ) && + !(negotiated &BIT_ULL (ICH9_LPC_SMI_F_CPU_HOTPLUG_BIT ))) { +error_setg (errp,"cpu hotplug with SMI wasn't enabled by firmware" ); +error_append_hint (errp,"update machine type to newer than 5.1 " +"and firmware that suppors CPU hotplug with SMM" ); + } + } } void ich9_pm_device_plug_cb(HotplugHandler *hotplug_dev, DeviceState *dev,
hw/i386/pc.c +11 -0
@@ -1497,6 +1497,17 @@ static void pc_cpu_pre_plug(HotplugHandler *hotplug_dev,return ; } +if (pcms->acpi_dev) { +Error *local_err =NULL ; + +hotplug_handler_pre_plug (HOTPLUG_HANDLER (pcms->acpi_dev), dev, + &local_err); +if (local_err) { +error_propagate (errp, local_err); +return ; + } + } +init_topo_info (&topo_info, x86ms); env->nr_dies = x86ms->smp_dies;
Signature · 1 line
2.26.2
Re: [PATCH 2/6] x86: cphp: prevent guest crash on CPU hotplug when broadcast SMI is in use
Quoted 57 lines · Igor Mammedov
There were reports of guest crash on CPU hotplug, when using q35 machine type and OVMF with SMM, due to hotplugged CPU trying to process SMI at default SMI handler location without it being relocated by firmware first.
Fix it by refusing hotplug if firmware hasn't negotiated CPU hotplug with SMI support while SMI broadcast is in use.
Signed-off-by Igor Mammedov <[email protected]>---
v1:
fix typos an use suggested wording in commit and error msg s/secure boot/smm/; s/hotplug SMI/hotplug with SMI/
(Laszlo Ersek <[email protected]>)--- hw/acpi/ich9.c | 12 +++++++++++- hw/i386/pc.c | 11 +++++++++++ 2 files changed, 22 insertions(+), 1 deletion(-)hw/acpi/ich9.c +11
-1@@ -408,10 +408,20 @@ void ich9_pm_device_pre_plug_cb(HotplugHandler *hotplug_dev, DeviceState *dev,ICH9LPCState *lpc =ICH9_LPC_DEVICE (hotplug_dev);if (object_dynamic_cast (OBJECT (dev),TYPE_PC_DIMM ) && - !lpc->pm.acpi_memory_hotplug.is_enabled) + !lpc->pm.acpi_memory_hotplug.is_enabled) {error_setg (errp,"memory hotplug is not enabled: %s.memory-hotplug-support " "is not set" ,object_get_typename (OBJECT (lpc))); + }else if (object_dynamic_cast (OBJECT (dev),TYPE_CPU )) { +uint64_t negotiated = lpc->smi_negotiated_features; + +if (negotiated &BIT_ULL (ICH9_LPC_SMI_F_BROADCAST_BIT ) && + !(negotiated &BIT_ULL (ICH9_LPC_SMI_F_CPU_HOTPLUG_BIT ))) { +error_setg (errp,"cpu hotplug with SMI wasn't enabled by firmware" ); +error_append_hint (errp,"update machine type to newer than 5.1 " +"and firmware that suppors CPU hotplug with SMM" ); + } + } } void ich9_pm_device_plug_cb(HotplugHandler *hotplug_dev, DeviceState *dev,hw/i386/pc.c +4
-0@@ -1497,6 +1497,17 @@ static void pc_cpu_pre_plug(HotplugHandler *hotplug_dev,return ; } +if (pcms->acpi_dev) { +Error *local_err =NULL ; + + hotplug_handler_pre_plug(HOTPLUG_HANDLER(pcms->acpi_dev), dev,
hw/i386/pc.c static void pc_cpu_pre_plug(HotplugHandler *hotplug_dev, · line 1513
Quoted 10 lines
hw/i386/pc.c +7
-0+ &local_err); +if (local_err) { +error_propagate (errp, local_err); +return ; + } + } +init_topo_info (&topo_info, x86ms); env->nr_dies = x86ms->smp_dies;
PATCH 3/6 x86: cpuhp: refuse cpu hot-unplug request earlier if not supported
In reply to Igor MammedovCPU hot-unplug with SMM requires firmware participation to prevent guest crash (i.e. CPU can be removed only after OS _and_ firmware were prepared for th action).
Previous patches introduced ICH9_LPC_SMI_F_CPU_HOT_UNPLUG_BIT feature bit, which is advertised by firmware when it has support for CPU hot-unplug. Use it to check if guest is able to handle unplug and make device_del fail gracefully if hot-unplug feature hasn't been negotiated.
--- hw/acpi/ich9.c | 11 +++++++++++ 1 file changed, 11 insertions(+)
hw/acpi/ich9.c +11 -0
@@ -460,6 +460,17 @@ void ich9_pm_device_unplug_request_cb(HotplugHandler *hotplug_dev, errp); }else if (object_dynamic_cast (OBJECT (dev),TYPE_CPU ) && !lpc->pm.cpu_hotplug_legacy) { +uint64_t negotiated = lpc->smi_negotiated_features; + +if (negotiated &BIT_ULL (ICH9_LPC_SMI_F_BROADCAST_BIT ) && + !(negotiated &BIT_ULL (ICH9_LPC_SMI_F_CPU_HOT_UNPLUG_BIT ))) { +error_setg (errp,"cpu hot-unplug with SMI wasn't enabled " +"by firmware" ); +error_append_hint (errp,"update machine type to newer than 5.1 " +"and firmware that suppors CPU hot-unplug with SMM" ); +return ; + } +acpi_cpu_unplug_request_cb (hotplug_dev, &lpc->pm.cpuhp_state, dev, errp); }else {
Signature · 1 line
2.26.2
Re: [PATCH 3/6] x86: cpuhp: refuse cpu hot-unplug request earlier if not supported
Quoted 3 lines · Igor Mammedov
CPU hot-unplug with SMM requires firmware participation to prevent guest crash (i.e. CPU can be removed only after OS _and_ firmware were prepared for th action).
(1) s/th action/the action/
Quoted 17 lines
Previous patches introduced
ICH9_LPC_SMI_F_CPU_HOT_UNPLUG_BITfeature bit, which is advertised by firmware when it has support for CPU hot-unplug. Use it to check if guest is able to handle unplug and makedevice_delfail gracefully if hot-unplug feature hasn't been negotiated.Signed-off-by Igor Mammedov <[email protected]>--- hw/acpi/ich9.c | 11 +++++++++++ 1 file changed, 11 insertions(+)hw/acpi/ich9.c +0
-0@@ -460,6 +460,17 @@ void ich9_pm_device_unplug_request_cb(HotplugHandler *hotplug_dev, errp);
hw/acpi/ich9.c void ich9_pm_device_unplug_request_cb(HotplugHandler *hotplug_dev, · line 470
Quoted 10 lines
hw/acpi/ich9.c +8
-0}else if (object_dynamic_cast (OBJECT (dev),TYPE_CPU ) && !lpc->pm.cpu_hotplug_legacy) { +uint64_t negotiated = lpc->smi_negotiated_features; + +if (negotiated &BIT_ULL (ICH9_LPC_SMI_F_BROADCAST_BIT ) && + !(negotiated &BIT_ULL (ICH9_LPC_SMI_F_CPU_HOT_UNPLUG_BIT ))) { +error_setg (errp,"cpu hot-unplug with SMI wasn't enabled " +"by firmware" ); +error_append_hint (errp,"update machine type to newer than 5.1 " +"and firmware that suppors CPU hot-unplug with SMM" );
(2) I think the "machine type to newer than 5.1" reference should be removed at this point. (Similarly to how "x-smi-cpu-hotunplug" should default to "false" at this point in time, in patch#1.) We don't know when hot-unplug will work; we only know that it doesn't work now.
We could say something like
error_append_hint(errp, "update machine type to a version having "
"x-smi-cpu-hotunplug=on and firmware that " "suppors CPU hot-unplug with SMM");
hw/acpi/ich9.c void ich9_pm_device_unplug_request_cb(HotplugHandler *hotplug_dev, · line 476
Quoted 7 lines
hw/acpi/ich9.c +3
-0+return ; + } +acpi_cpu_unplug_request_cb (hotplug_dev, &lpc->pm.cpuhp_state, dev, errp); }else {
These superficial comments aside, the patch works for me:
and with (1) and (2) fixed:
Thanks
Laszlo
PATCH 4/6 tests: acpi: mark to be changed tables in bios-tables-test-allowed-diff
In reply to Igor Mammedov... to let tests pass until binary blobs are updated with new AML
--- tests/qtest/bios-tables-test-allowed-diff.h | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+)
tests/qtest/bios-tables-test-allowed-diff.h +19 -0
@@ -1 +1,20 @@/* List of comma-separated changed AML files to ignore */ +"tests/data/acpi/pc/DSDT" , +"tests/data/acpi/q35/DSDT" , +"tests/data/acpi/q35/DSDT.tis" , +"tests/data/acpi/q35/DSDT.bridge" , +"tests/data/acpi/q35/DSDT.mmio64" , +"tests/data/acpi/q35/DSDT.ipmibt" , +"tests/data/acpi/q35/DSDT.cphp" , +"tests/data/acpi/q35/DSDT.memhp" , +"tests/data/acpi/q35/DSDT.numamem" , +"tests/data/acpi/q35/DSDT.dimmpxm" , +"tests/data/acpi/q35/DSDT.acpihmat" , +"tests/data/acpi/pc/DSDT.bridge" , +"tests/data/acpi/pc/DSDT.ipmikcs" , +"tests/data/acpi/pc/DSDT.cphp" , +"tests/data/acpi/pc/DSDT.memhp" , +"tests/data/acpi/pc/DSDT.numamem" , +"tests/data/acpi/pc/DSDT.dimmpxm" , +"tests/data/acpi/pc/DSDT.acpihmat" , +"tests/data/acpi/pc/DSDT.acpihmat",
Signature · 1 line
2.26.2
PATCH 5/6 x68: acpi: trigger SMI before scanning for hotplugged CPUs
In reply to Igor MammedovIn case firmware has negotiated CPU hotplug SMI feature, generate AML to describe SMI IO port region and send SMI to firmware on each CPU hotplug SCI in case new CPUs were htplugged.
Since new CPUs can be hotplugged while CPU_SCAN_METHOD is running we can't send SMI before new CPUs are fetched from QEMU as it could cause sending Notify to a CPU that firmware hasn't seen yet. So fetch new CPUs into local cache first and then send SMI and after that sends Notify events to cached CPUs. This should ensure that Notify is sent only to CPUs which were processed by firmware first.
Any CPUs that were hotplugged after caching will be process by the next CPU_SCAN_METHOD, when pending SCI is handled.
---
v1:
- make sure that Notify is sent only to CPUs seen by FW
- (Laszlo Ersek <[email protected]>)
- use macro instead of x-smi-negotiated-features
- style fixes
- reserve whole SMI block (0xB2, 0xB3)
v0:
- s/aml_string/aml_eisaid/
/fixes Windows BSOD, on nonsense value/ (Laszlo Ersek <[email protected]>)
- put SMI device under PCI0 like the rest of hotplug IO port
- do not generate SMI AML if CPU hotplug SMI feature hasn't been negotiated
--- include/hw/acpi/cpu.h | 1 + include/hw/i386/ich9.h | 2 ++ hw/acpi/cpu.c | 50 ++++++++++++++++++++++++++++++++++++++++-- hw/i386/acpi-build.c | 35 ++++++++++++++++++++++++++++- hw/isa/lpc_ich9.c | 3 +++ 5 files changed, 88 insertions(+), 3 deletions(-)
include/hw/acpi/cpu.h +1 -0
@@ -50,6 +50,7 @@ void cpu_hotplug_hw_init(MemoryRegion *as, Object *owner,typedef struct CPUHotplugFeatures {bool acpi_1_compatible;bool has_legacy_cphp; +const char *smi_path; }CPUHotplugFeatures ; void build_cpus_aml(Aml *table, MachineState *machine, CPUHotplugFeatures opts,
include/hw/i386/ich9.h +2 -0
@@ -245,6 +245,8 @@ typedef struct ICH9LPCState {#define ICH9_SMB_HST_D1 0x06#define ICH9_SMB_HOST_BLOCK_DB 0x07 +#define ICH9_LPC_SMI_NEGOTIATED_FEAT_PROP "x-smi-negotiated-features" +/* bit positions used in fw_cfg SMI feature negotiation */ #define ICH9_LPC_SMI_F_BROADCAST_BIT 0#define ICH9_LPC_SMI_F_CPU_HOTPLUG_BIT 1
hw/acpi/cpu.c +48 -2
82 lines not on this page · raw message
hw/i386/acpi-build.c +34 -1
@@ -95,6 +95,7 @@ typedef struct AcpiPmInfo {bool s3_disabled;bool s4_disabled;bool pcihp_bridge_en; +bool smi_on_cpuhp;uint8_t s4_val;AcpiFadtData fadt;uint16_t cpu_hp_io_base;
@@ -194,6 +195,7 @@ static void acpi_get_pm_info(MachineState *machine, AcpiPmInfo *pm) pm->cpu_hp_io_base =0 ; pm->pcihp_io_base =0 ; pm->pcihp_io_len =0 ; + pm->smi_on_cpuhp = false;assert (obj);init_common_fadt_data (machine, obj, &pm->fadt);
@@ -207,12 +209,16 @@ static void acpi_get_pm_info(MachineState *machine, AcpiPmInfo *pm)object_property_get_uint (obj,ACPI_PCIHP_IO_LEN_PROP ,NULL ); }if (lpc) { +uint64_t smi_features =object_property_get_uint (lpc, +ICH9_LPC_SMI_NEGOTIATED_FEAT_PROP ,NULL );struct AcpiGenericAddress r = { .space_id =AML_AS_SYSTEM_IO , .bit_width =8 , .address =ICH9_RST_CNT_IOPORT }; pm->fadt.reset_reg = r; pm->fadt.reset_val =0xf ; pm->fadt.flags |=1 <<ACPI_FADT_F_RESET_REG_SUP ; pm->cpu_hp_io_base =ICH9_CPU_HOTPLUG_IO_BASE ; + pm->smi_on_cpuhp = + !!(smi_features &BIT_ULL (ICH9_LPC_SMI_F_CPU_HOTPLUG_BIT )); }/* The above need not be conditional on machine type because the reset port
@@ -1515,6 +1521,32 @@ build_dsdt(GArray *table_data, BIOSLinker *linker,aml_append (dev,aml_name_decl ("_UID" ,aml_int (1 )));aml_append (dev,build_q35_osc_method ());aml_append (sb_scope, dev); + +if (pm->smi_on_cpuhp) { +/* reserve SMI block resources, IO ports 0xB2, 0xB3 */ + dev =aml_device ("PCI0.SMI0" ); +aml_append (dev,aml_name_decl ("_HID" ,aml_eisaid ("PNP0A06" ))); +aml_append (dev,aml_name_decl ("_UID" ,aml_string ("SMI resources" ))); + crs =aml_resource_template (); +aml_append (crs, +aml_io ( +AML_DECODE16 , +ACPI_PORT_SMI_CMD , +ACPI_PORT_SMI_CMD , +1 , +2 ) + ); +aml_append (dev,aml_name_decl ("_CRS" , crs)); +aml_append (dev,aml_operation_region ("SMIR" ,AML_SYSTEM_IO , +aml_int (ACPI_PORT_SMI_CMD ),2 )); + field =aml_field ("SMIR" ,AML_BYTE_ACC ,AML_NOLOCK , +AML_WRITE_AS_ZEROS ); +aml_append (field,aml_named_field ("SMIC" ,8 )); +aml_append (field,aml_reserved_field (8 )); +aml_append (dev, field); +aml_append (sb_scope, dev); + } +aml_append (dsdt, sb_scope);build_hpet_aml (dsdt);
@@ -1530,7 +1562,8 @@ build_dsdt(GArray *table_data, BIOSLinker *linker,build_legacy_cpu_hotplug_aml (dsdt, machine, pm->cpu_hp_io_base); }else {CPUHotplugFeatures opts = { - .acpi_1_compatible = true, .has_legacy_cphp = true + .acpi_1_compatible = true, .has_legacy_cphp = true, + .smi_path = pm->smi_on_cpuhp ?"\\_SB.PCI0.SMI0.SMIC" :NULL , };build_cpus_aml (dsdt, machine, opts, pm->cpu_hp_io_base,"\\_SB.PCI0" ,"\\_GPE._E02" );
hw/isa/lpc_ich9.c +3 -0
@@ -646,6 +646,9 @@ static void ich9_lpc_initfn(Object *obj) &acpi_enable_cmd, OBJ_PROP_FLAG_READ);object_property_add_uint8_ptr (OBJECT (lpc),ACPI_PM_PROP_ACPI_DISABLE_CMD , &acpi_disable_cmd,OBJ_PROP_FLAG_READ ); +object_property_add_uint64_ptr (obj,ICH9_LPC_SMI_NEGOTIATED_FEAT_PROP , + &lpc->smi_negotiated_features, +OBJ_PROP_FLAG_READ );ich9_pm_add_properties (obj, &lpc->pm); }
Signature · 1 line
2.26.2
Re: [PATCH 5/6] x68: acpi: trigger SMI before scanning for hotplugged CPUs
Quoted 3 lines · Igor Mammedov
In case firmware has negotiated CPU hotplug SMI feature, generate AML to describe SMI IO port region and send SMI to firmware on each CPU hotplug SCI in case new CPUs were htplugged.
(1) s/htplugged/hotplugged/
Quoted 9 lines
Since new CPUs can be hotplugged while
CPU_SCAN_METHODis running we can't send SMI before new CPUs are fetched from QEMU as it could cause sending Notify to a CPU that firmware hasn't seen yet. So fetch new CPUs into local cache first and then send SMI and after that sends Notify events to cached CPUs. This should ensure that Notify is sent only to CPUs which were processed by firmware first.
Any CPUs that were hotplugged after caching will be process
(2) s/will be process/will be processed/
Quoted 1 line
by the next
CPU_SCAN_METHOD, when pending SCI is handled.
(3) I think that the subject ("trigger SMI before scanning") may no longer apply, because we do scan before triggering the SMI.
Quoted 131 lines
Signed-off-by Igor Mammedov <[email protected]>---
v1:
- make sure that Notify is sent only to CPUs seen by FW- (Laszlo Ersek <[email protected]>)
- use macro instead of x-smi-negotiated-features
- style fixes
- reserve whole SMI block (0xB2,0xB3)
v0:
- s/aml_string/aml_eisaid/
/fixes Windows BSOD, on nonsense value/ (Laszlo Ersek <[email protected]>)
- put SMI device under PCI0 like the rest of hotplug IO port
- do not generate SMI AML if CPU hotplug SMI feature hasn't been negotiatedSigned-off-by Igor Mammedov <[email protected]>--- include/hw/acpi/cpu.h | 1 + include/hw/i386/ich9.h | 2 ++ hw/acpi/cpu.c | 50 ++++++++++++++++++++++++++++++++++++++++-- hw/i386/acpi-build.c | 35 ++++++++++++++++++++++++++++- hw/isa/lpc_ich9.c | 3 +++ 5 files changed, 88 insertions(+), 3 deletions(-)include/hw/acpi/cpu.h +1
-0@@ -50,6 +50,7 @@ void cpu_hotplug_hw_init(MemoryRegion *as, Object *owner,typedef struct CPUHotplugFeatures {bool acpi_1_compatible;bool has_legacy_cphp; +const char *smi_path; }CPUHotplugFeatures ; void build_cpus_aml(Aml *table, MachineState *machine, CPUHotplugFeatures opts,include/hw/i386/ich9.h +2
-0@@ -245,6 +245,8 @@ typedef struct ICH9LPCState {#define ICH9_SMB_HST_D1 0x06#define ICH9_SMB_HOST_BLOCK_DB 0x07 +#define ICH9_LPC_SMI_NEGOTIATED_FEAT_PROP "x-smi-negotiated-features" +/* bit positions used in fw_cfg SMI feature negotiation */ #define ICH9_LPC_SMI_F_BROADCAST_BIT 0#define ICH9_LPC_SMI_F_CPU_HOTPLUG_BIT 1hw/acpi/cpu.c +41
-2@@ -14,6 +14,8 @@#define ACPI_CPU_CMD_DATA_OFFSET_RW 8#define ACPI_CPU_CMD_DATA2_OFFSET_R 0 +#define OVMF_CPUHP_SMI_CMD 4 +enum {CPHP_GET_NEXT_CPU_WITH_EVENT_CMD =0 ,CPHP_OST_EVENT_CMD =1 ,@@ -321,6 +323,7 @@ const VMStateDescription vmstate_cpu_hotplug = {#define CPU_NOTIFY_METHOD "CTFY"#define CPU_EJECT_METHOD "CEJ0"#define CPU_OST_METHOD "COST" +#define CPU_ADDED_LIST "CNEW"#define CPU_ENABLED "CPEN"#define CPU_SELECTOR "CSEL"@@ -471,8 +474,27 @@ void build_cpus_aml(Aml *table, MachineState *machine, CPUHotplugFeatures opts,Aml *dev_chk =aml_int (1 );Aml *eject_req =aml_int (3 );Aml *next_cpu_cmd =aml_int (CPHP_GET_NEXT_CPU_WITH_EVENT_CMD ); +Aml *num_added_cpus =aml_local (1 ); +Aml *cpu_idx =aml_local (2 ); +Aml *new_cpus =aml_name (CPU_ADDED_LIST );aml_append (method,aml_acquire (ctrl_lock,0xFFFF )); + +/* use named package as old Windows don't support it in local var */ +if (arch_ids->len <=256 ) { +/* For compatibility with Windows Server 2008 (max 256 cpus), +* use ACPI1.0 PackageOp which can cache max 255 elements. +* Which is fine for 256 CPUs VM. Max 255 can be hotplugged, +* sice at least one CPU must be already present. +*/ +aml_append (method,aml_name_decl (CPU_ADDED_LIST , +aml_package (arch_ids->len))); + }else { +aml_append (method,aml_name_decl (CPU_ADDED_LIST , +aml_varpackage (arch_ids->len))); + } + +aml_append (method,aml_store (zero, num_added_cpus));aml_append (method,aml_store (one, has_event)); while_ctx =aml_while (aml_equal (has_event, one)); {@@ -483,8 +505,10 @@ void build_cpus_aml(Aml *table, MachineState *machine, CPUHotplugFeatures opts,aml_append (while_ctx,aml_store (next_cpu_cmd, cpu_cmd)); ifctx =aml_if (aml_equal (ins_evt, one)); { -aml_append (ifctx, -aml_call2 (CPU_NOTIFY_METHOD , cpu_data, dev_chk)); +/* cache added CPUs to Notify/Wakeup later */ +aml_append (ifctx,aml_store (cpu_data, +aml_index (new_cpus, num_added_cpus))); +aml_append (ifctx,aml_increment (num_added_cpus));aml_append (ifctx,aml_store (one, ins_evt));aml_append (ifctx,aml_store (one, has_event)); }@@ -501,6 +525,28 @@ void build_cpus_aml(Aml *table, MachineState *machine, CPUHotplugFeatures opts,aml_append (while_ctx, else_ctx); }aml_append (method, while_ctx); + +/* in case FW negotiated ICH9_LPC_SMI_F_CPU_HOTPLUG_BIT, +* make upcall to FW, so it can pull in new CPUs before +* OS is notified and wakes them up */ +if (opts.smi_path) { + ifctx =aml_if (aml_lnot (aml_equal (num_added_cpus, zero))); + { +aml_append (ifctx,aml_store (aml_int (OVMF_CPUHP_SMI_CMD ), +aml_name ("%s" , opts.smi_path))); + } +aml_append (method, ifctx); + } + +aml_append (method,aml_store (zero, cpu_idx)); + while_ctx =aml_while (aml_lless (cpu_idx, num_added_cpus));
hw/acpi/cpu.c void build_cpus_aml(Aml *table, MachineState *machine, CPUHotplugFeatures opts, · line 552
Quoted 10 lines
hw/acpi/cpu.c +7
-0+ { +aml_append (while_ctx,aml_call2 (CPU_NOTIFY_METHOD , +aml_derefof (aml_index (new_cpus, cpu_idx)), dev_chk)); +aml_append (while_ctx,aml_increment (cpu_idx)); + } +aml_append (method, while_ctx); +aml_append (method,aml_release (ctrl_lock)); }aml_append (cpus_dev, method);
(4) This version addresses all my requests from the previous version, but the above method changes unfortunately break the hot-plugging of a single CPU even.
Here's the decompiled method (using a topology with 4 possible CPUs):
1 Method (CSCN, 0, Serialized)
2 {
3 Acquire (\_SB.PCI0.PRES.CPLK, 0xFFFF)
4 Name (CNEW, Package (0x04){})
5 Local1 = Zero
6 Local0 = One
7 While ((Local0 == One))
8 {
9 Local0 = Zero
10 \_SB.PCI0.PRES.CCMD = Zero
11 If ((\_SB.PCI0.PRES.CINS == One))
12 {
13 CNEW [Local1] = \_SB.PCI0.PRES.CDAT
14 Local1++
15 \_SB.PCI0.PRES.CINS = One
16 Local0 = One
17 }
18 ElseIf ((\_SB.PCI0.PRES.CRMV == One))
19 {
20 CTFY (\_SB.PCI0.PRES.CDAT, 0x03)
21 \_SB.PCI0.PRES.CRMV = One
22 Local0 = One
23 }
24 }
25
26 If ((Local1 != Zero))
27 {
28 \_SB.PCI0.SMI0.SMIC = 0x04
29 }
30
31 Local2 = Zero
32 While ((Local2 < Local1))
33 {
34 CTFY (DerefOf (CNEW [Local2]), One)
35 Local2++
36 }
37
38 Release (\_SB.PCI0.PRES.CPLK)
39 }The problem is on line 15. When you write 1 to \_SB.PCI0.PRES.CINS, the following happens (quoting "docs/specs/acpi_cpu_hotplug.txt"):
Quoted 9 lines
write access:
offset:
[...]
[0x4] CPU device control fields: (1 byte access)
bits:
0: [...]
1: if set to 1 clears device insert event, set by OSPM
after it has emitted device check event for the selected CPU device
Because of this, by the time the SMI is raised on line 28, the firmware will see no pending events.
The scanning (= collection into the package) has to be implemented such that the pending events never change.
This is possible to do; the firmware already does it. The idea is to advance the "get next CPU with event" command by manually incrementing the CPU selector past the CPU that has a pending event, rather than by clearing the events for the currently selected CPU. Here's the pseudo-code:
bool scan;
uint32_t current_selector;
uint32_t pending_selector;
uint32_t event_count;
uint32_t plug_count;
uint32_t event;
scan = true;
current_selector = 0;
event_count = 0;
plug_count = 0;
while (scan) {
scan = false;
/* the "get next CPU with pending event" command starts scanning
* at the currently selected CPU, *inclusive*
*/
CSEL = current_selector;
CCMD = 0;
pending_selector = CDAT;
/* the "get next CPU with pending event" command may cause the
* current selector to wrap around; in which case we're done
*/
if (pending_selector >= current_selector) {
current_selector = pending_selector;
/* if there's no pending event for the currently selected
* CPU, we're done
*/
if (CINS) {
/* record INSERT event for currently selected CPU, and
* continue scanning
*/
CNEW[event_count] = current_selector;
CEVT[event_count] = 1;
event_count++;
plug_count++;
scan = true;
} else if (CRMV) {
/* record REMOVE event for currently selected CPU, and
* continue scanning
*/
CNEW[event_count] = current_selector;
CEVT[event_count] = 3;
event_count++;
scan = true;
}
if (scan) {
scan = false;
/* advance past this CPU manually (as we must not clear
* events pending for this CPU)
*/
current_selector++;
if (current_selector < possible_cpu_count) {
scan = true;
}
}
}
}
/* raise "hotplug SMI" now if at least one INSERT event has been
* collected
*/
if (plug_count > 0) {
SMIC = 0x04;
}
/* notify the OS about all events, and clear pending events (same
* order as before)
*/
event = 0;
while (event < event_count) {
CTFY(CNEW[event], CEVT[event]);
CSEL = CNEW[event];
if (CEVT[event] == 1) {
CINS = 1;
} else if (CEVT[event] == 3) {
CRMV = 1;
}
event++;
}Thanks
Laszlo
PATCH 6/6 tests: acpi: update acpi blobs with new AML
In reply to Igor MammedovUpdate CPU hotplug AML with following changes
@@ -2917,6 +2917,8 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPCDSDT", 0x00000001)
Method (CSCN, 0, Serialized)
{
Acquire (\_SB.PCI0.PRES.CPLK, 0xFFFF)
+ Name (CNEW, Package (0x01){})
+ Local1 = Zero
Local0 = One
While ((Local0 == One))
{
@@ -2924,7 +2926,8 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPCDSDT", 0x00000001)
\_SB.PCI0.PRES.CCMD = Zero
If ((\_SB.PCI0.PRES.CINS == One))
{
- CTFY (\_SB.PCI0.PRES.CDAT, One)
+ CNEW [Local1] = \_SB.PCI0.PRES.CDAT
+ Local1++
\_SB.PCI0.PRES.CINS = One
Local0 = One
}
@@ -2936,6 +2939,13 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPCDSDT", 0x00000001)
}
}+ Local2 = Zero
+ While ((Local2 < Local1))
+ {+ CTFY (DerefOf (CNEW [Local2]), One)
+ Local2++
+ }
+
Release (\_SB.PCI0.PRES.CPLK)
}--- tests/qtest/bios-tables-test-allowed-diff.h | 19 ------------------- tests/data/acpi/pc/DSDT | Bin 4934 -> 4973 bytes tests/data/acpi/pc/DSDT.acpihmat | Bin 6258 -> 6297 bytes tests/data/acpi/pc/DSDT.bridge | Bin 6793 -> 6832 bytes tests/data/acpi/pc/DSDT.cphp | Bin 5397 -> 5436 bytes tests/data/acpi/pc/DSDT.dimmpxm | Bin 6587 -> 6626 bytes tests/data/acpi/pc/DSDT.ipmikcs | Bin 5006 -> 5045 bytes tests/data/acpi/pc/DSDT.memhp | Bin 6293 -> 6332 bytes tests/data/acpi/pc/DSDT.numamem | Bin 4940 -> 4979 bytes tests/data/acpi/q35/DSDT | Bin 7678 -> 7717 bytes tests/data/acpi/q35/DSDT.acpihmat | Bin 9002 -> 9041 bytes tests/data/acpi/q35/DSDT.bridge | Bin 7695 -> 7734 bytes tests/data/acpi/q35/DSDT.cphp | Bin 8141 -> 8180 bytes tests/data/acpi/q35/DSDT.dimmpxm | Bin 9331 -> 9370 bytes tests/data/acpi/q35/DSDT.ipmibt | Bin 7753 -> 7792 bytes tests/data/acpi/q35/DSDT.memhp | Bin 9037 -> 9076 bytes tests/data/acpi/q35/DSDT.mmio64 | Bin 8808 -> 8847 bytes tests/data/acpi/q35/DSDT.numamem | Bin 7684 -> 7723 bytes tests/data/acpi/q35/DSDT.tis | Bin 8283 -> 8322 bytes 19 files changed, 19 deletions(-)
tests/qtest/bios-tables-test-allowed-diff.h +0 -19
@@ -1,20 +1 @@/* List of comma-separated changed AML files to ignore */ -"tests/data/acpi/pc/DSDT" , -"tests/data/acpi/q35/DSDT" , -"tests/data/acpi/q35/DSDT.tis" , -"tests/data/acpi/q35/DSDT.bridge" , -"tests/data/acpi/q35/DSDT.mmio64" , -"tests/data/acpi/q35/DSDT.ipmibt" , -"tests/data/acpi/q35/DSDT.cphp" , -"tests/data/acpi/q35/DSDT.memhp" , -"tests/data/acpi/q35/DSDT.numamem" , -"tests/data/acpi/q35/DSDT.dimmpxm" , -"tests/data/acpi/q35/DSDT.acpihmat" , -"tests/data/acpi/pc/DSDT.bridge" , -"tests/data/acpi/pc/DSDT.ipmikcs" , -"tests/data/acpi/pc/DSDT.cphp" , -"tests/data/acpi/pc/DSDT.memhp" , -"tests/data/acpi/pc/DSDT.numamem" , -"tests/data/acpi/pc/DSDT.dimmpxm" , -"tests/data/acpi/pc/DSDT.acpihmat" , -"tests/data/acpi/pc/DSDT.acpihmat",
tests/data/acpi/pc/DSDT binary +0 -0
tests/data/acpi/pc/DSDT.acpihmat binary +0 -0
tests/data/acpi/pc/DSDT.bridge binary +0 -0
tests/data/acpi/pc/DSDT.cphp binary +0 -0
tests/data/acpi/pc/DSDT.dimmpxm binary +0 -0
tests/data/acpi/pc/DSDT.ipmikcs binary +0 -0
tests/data/acpi/pc/DSDT.memhp binary +0 -0
tests/data/acpi/pc/DSDT.numamem binary +0 -0
tests/data/acpi/q35/DSDT binary +0 -0
tests/data/acpi/q35/DSDT.acpihmat binary +0 -0
tests/data/acpi/q35/DSDT.bridge binary +0 -0
tests/data/acpi/q35/DSDT.cphp binary +0 -0
tests/data/acpi/q35/DSDT.dimmpxm binary +0 -0
tests/data/acpi/q35/DSDT.ipmibt binary +0 -0
tests/data/acpi/q35/DSDT.memhp binary +0 -0
tests/data/acpi/q35/DSDT.mmio64 binary +0 -0
tests/data/acpi/q35/DSDT.numamem binary +0 -0
tests/data/acpi/q35/DSDT.tis binary +0 -0
Signature · 1 line
2.26.2