Skip to contentSkip to conversation

16-bit NAND support

PATCH New Zhang 3 participants 5 messages Nov 2, 2004 – Apr 3, 2005

lore
Share & tools
lore

Zhang

#0 lore raw

PATCH 1/1 16-bit NAND support

Hi,

This is a patch to add 16-bit NAND support to u-boot. It doesn't change any existing 8-bit NAND code so it shouldn't affect any existing boards that have 8-bit chips. I tested it in 2 TI OMAP boards, one using software to access chip, the other one using hardware NAND controller.

Regards,
Jian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: nand16.patch
Type: application/octet-stream
Size: 14481 bytes
Desc: nand16.patch
Url : http://lists.denx.de/pipermail/u-boot/attachments/20041102/dfae27fd/attachment.obj
-------------- next part --------------
A non-text attachment was scrubbed...
Name: CHANGELOG
Type: application/octet-stream
Size: 163 bytes
Desc: CHANGELOG
Url : http://lists.denx.de/pipermail/u-boot/attachments/20041102/dfae27fd/attachment-0001.obj

#1 lore raw

PATCH 1/1 16-bit NAND support

Quoted 4 lines · In message <[email protected]> you…

This is a patch to add 16-bit NAND support to u-boot. It doesn't change any existing 8-bit NAND code so it shouldn't affect any existing boards that have 8-bit chips. I tested it in 2 TI OMAP boards, one using

Did you actually _check_ if it has impact on exiting boards? Impact on parameters like code size, for example?

Best regards,

Wolfgang Denk

Signature · 4 lines
See us @ Embedded/Electronica Munich, Nov 09 - 12, Hall A.6 Booth 513
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"The one charm of marriage is that it makes a  life  of  deception  a
neccessity."                                            - Oscar Wilde
#2 lore raw

PATCH 1/1 16-bit NAND support

In reply to Zhang

Hi,
I have applied ur patch to my u-boot1.1.1 code and one error is
generated.The log is shown below.can any one please tell me what can be the problem.And also pls tell me how do I select that whether I m going to use 8bit Nand flash or 16bit Nand flash.Is there any CONFIG variable is required to define.I m working on a 16bit Nand flash from the Samsung.

patching file include/linux/mtd/nand.h
patching file include/linux/mtd/nand_ids.h
patching file common/cmd_nand.c
Hunk #2 FAILED at 23.
Hunk #3 succeeded at 390 (offset -4 lines).
Hunk #5 succeeded at 710 (offset -4 lines).
Hunk #7 succeeded at 863 (offset -4 lines).
Hunk #9 succeeded at 983 (offset -4 lines).
Hunk #11 succeeded at 1043 (offset -4 lines).
Hunk #13 succeeded at 1144 (offset -4 lines).
Hunk #15 succeeded at 1222 (offset -4 lines).
Hunk #17 succeeded at 1303 (offset -4 lines).
Hunk #19 succeeded at 1374 (offset -4 lines).
Hunk #21 succeeded at 1466 (offset -4 lines).
1 out of 22 hunks FAILED -- saving rejects to file common/cmd_nand.c.rej

Bye

-----Original Message-----
From: [email protected] [mailto:u-boot-users-admin at lists.sourceforge.net] On Behalf Of Zhang, Jian
Sent: Wednesday, November 03, 2004 3:52 AM
To: u-boot-users at lists.sourceforge.net
Cc: Zhang, Jian; Johnson, Steve-OMAP
Subject: [U-Boot-Users] [PATCH] 16-bit NAND support

Hi,

This is a patch to add 16-bit NAND support to u-boot. It doesn't change any existing 8-bit NAND code so it shouldn't affect any existing boards that have 8-bit chips. I tested it in 2 TI OMAP boards, one using software to access chip, the other one using hardware NAND controller.

Regards,
Jian

#3 lore raw

PATCH 1/1 16-bit NAND support

Quoted 3 lines · In message <[email protected]> you wrote:

I have applied ur patch to my u-boot1.1.1 code and one error is
generated.The log is shown below.can any one please tell me what can be

Please use current code (top of CVS).

Best regards,

Wolfgang Denk

Signature · 6 lines
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
That Microsoft, the Trabant of the operating  system  world,  may  be
glancing  over the Berlin Wall at the Audis and BMWs and Mercedes. In
their own universe Trabants and Ladas were mainstream too...
                                                   -- Evan Leibovitch
#4 lore raw

PATCH 1/1 16-bit NAND support

In reply to Zhang
Quoted 5 lines · In message <[email protected]> you…

This is a patch to add 16-bit NAND support to u-boot. It doesn't change any existing 8-bit NAND code so it shouldn't affect any existing boards that have 8-bit chips. I tested it in 2 TI OMAP boards, one using software to access chip, the other one using hardware NAND controller.

Added, thanks.

Please don't forget the CHANGELOG entry, and _please_ stick to the Coding Style!

Best regards,

Wolfgang Denk

Signature · 3 lines
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
8 Catfish                                               = 1 Octo-puss