Skip to contentSkip to conversation

media: v4l2-fh: define v4l2_fh struct regardless of condition

PATCH New 김승철 1 participant 1 message Mar 20, 2020 1 message not in the archive Media (V4L/DVB)

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): CGME20200320095559epcas2p2732ccb391573ba99e2dd08d6c50a18f2@epcas2p2.samsung.com

김승철

author
#1 lore raw

PATCH 1/1 media: v4l2-fh: define v4l2_fh struct regardless of condition

v4l2_fh struct define differently by CONFIG_V4L2_MEM2MEM_DEV. If some vendors use CONFIG_V4L2_MEM2MEM_DEV by module, it can make the mismatch of v4l2_fh sturct.

By the mismatch, the following error occurs.
===============================

[    7.533506] v4l2_mem2mem: disagrees about version of symbol video_devdata
[    7.533594] v4l2_mem2mem: Unknown symbol video_devdata (err -22)
[    7.535319] v4l2_mem2mem: disagrees about version of symbol
v4l2_event_pending
[    7.542532] v4l2_mem2mem: Unknown symbol v4l2_event_pending (err -22)

===============================

So v4l2_fh struct is modified to does not have dependency for CONFIG_V4L2_MEM2MEM_DEV.

---
 include/media/v4l2-fh.h | 2 --
 1 file changed, 2 deletions(-)
include/media/v4l2-fh.h +0 -2
index 53b4dbb..b5b3e00 100644
@@ -53,9 +53,7 @@ struct v4l2_fh {
 	unsigned int		navailable;
 	u32			sequence;
 
-#if IS_ENABLED(CONFIG_V4L2_MEM2MEM_DEV)
 	struct v4l2_m2m_ctx	*m2m_ctx;
-#endif
 };
 
 /**
Signature · 1 line
2.7.4