tools/libxl: fix setting altp2m param broken by 1e9bc407cf0
PATCH v2 1/1 tools/libxl: fix setting altp2m param broken by 1e9bc407cf0
The patch 1e9bc407cf0 mistakenly converted the altp2m config option to a boolean. This is incorrect and breaks external-only usecases of altp2m that is set with a value of 2.
---
v2: just convert bool to unsigned int
--- tools/libxl/libxl_x86.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/libxl/libxl_x86.c +1 -1
@@ -391,7 +391,7 @@ static int hvm_set_conf_params(libxl__gc *gc, uint32_t domid,libxl_ctx *ctx =libxl__gc_owner (gc);xc_interface *xch = ctx->xch;int ret =ERROR_FAIL ; -bool altp2m = info->altp2m; +unsigned int altp2m = info->altp2m;switch (info->type) {case LIBXL_DOMAIN_TYPE_HVM :
Signature · 1 line
2.26.2
Quoted 5 lines · Tamas K Lengyel
The patch
1e9bc407cf0mistakenly converted the altp2m config option to a boolean. This is incorrect and breaks external-only usecases of altp2m that is set with a value of 2.Signed-off-by Tamas K Lengyel <[email protected]>
Sorry for breaking it to begin with.
Ian Jackson
Acked-byAndrew Cooper writes ("Re: [PATCH v2 for-4.14] tools/libxl: fix setting altp2m param broken by 1e9bc407cf0"):
Quoted 10 lines · Tamas K Lengyel
Quoted 5 lines
The patch
1e9bc407cf0mistakenly converted the altp2m config option to a boolean. This is incorrect and breaks external-only usecases of altp2m that is set with a value of 2.Signed-off-by Tamas K Lengyel <[email protected]>Reviewed-by Andrew Cooper <[email protected]>Sorry for breaking it to begin with.
and pushed.
Quoted 9 lines · Ian Jackson
Andrew Cooper writes ("Re: [PATCH v2 for-4.14]
tools/libxl: fix setting altp2m param broken by1e9bc407cf0"):Quoted 7 lines · Tamas K Lengyel
Quoted 5 lines
The patch
1e9bc407cf0mistakenly converted the altp2m config option to a boolean. This is incorrect and breaks external-only usecases of altp2m that is set with a value of 2.Signed-off-by Tamas K Lengyel <[email protected]>
Quoted 7 lines
Quoted 3 lines
Reviewed-by Andrew Cooper <[email protected]>Sorry for breaking it to begin with.
Acked-by Ian Jackson <[email protected]>and pushed.
Thanks for the fast turn around.
Tamas