Skip to contentSkip to conversation

tools/libxl: fix setting altp2m param broken by 1e9bc407cf0

PATCH In review Tamas K Lengyel 3 participants 4 messages May 29, 2020

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 tools/libxl: fix setting altp2m param broken by 1e9bc407cf0

The patch 1e9bc407cf0 mistakenly converted the altp2m config option to a boolean. This is incorrect and breaks external-only usecases of altp2m that is set with a value of 2.

---
v2: just convert bool to unsigned int

---
 tools/libxl/libxl_x86.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/libxl/libxl_x86.c +1 -1
index f8bc828e62..e57f63282e 100644
@@ -391,7 +391,7 @@ static int hvm_set_conf_params(libxl__gc *gc, uint32_t domid,
     libxl_ctx *ctx = libxl__gc_owner(gc);
     xc_interface *xch = ctx->xch;
     int ret = ERROR_FAIL;
-    bool altp2m = info->altp2m;
+    unsigned int altp2m = info->altp2m;
 
     switch(info->type) {
     case LIBXL_DOMAIN_TYPE_HVM:
Signature · 1 line
2.26.2
Acked-by
#2 lore raw

Andrew Cooper writes ("Re: [PATCH v2 for-4.14] tools/libxl: fix setting altp2m param broken by 1e9bc407cf0"):

Quoted 10 lines · Tamas K Lengyel
Quoted 5 lines

The patch 1e9bc407cf0 mistakenly converted the altp2m config option to a boolean. This is incorrect and breaks external-only usecases of altp2m that is set with a value of 2.

Sorry for breaking it to begin with.

and pushed.

#3 lore raw
Quoted 9 lines · Ian Jackson

Andrew Cooper writes ("Re: [PATCH v2 for-4.14] tools/libxl: fix setting altp2m param broken by 1e9bc407cf0"):

Quoted 7 lines · Tamas K Lengyel
Quoted 5 lines

The patch 1e9bc407cf0 mistakenly converted the altp2m config option to a boolean. This is incorrect and breaks external-only usecases of altp2m that is set with a value of 2.

Quoted 7 lines
Quoted 3 lines

Sorry for breaking it to begin with.

and pushed.

Thanks for the fast turn around.

Tamas