Skip to contentSkip to conversation

sDMA descriptor autoloading feature

PATCH Superseded Venkatraman S 4 participants 5 messages Apr 29, 2010 – Aug 27, 2010 MMC, SD and SDIO

lore
Share & tools
lore
#0 lore raw

v8 cover sDMA descriptor autoloading feature

This patch series is the introduction of new sDMA feature: descriptor
autoloading (v8) and it's adoption by the OMAP HSMMC driver.

The previous version (v7) was blocked on achieving proper interrupt
syncronisation
between the MMC and DMA callback in the HSMMC driver.
Thanks to Adrian Hunter's patch, https://patchwork.kernel.org/patch/94670/
this has been cleaned up.

Current version is based on for-next branch + Adrian Hunter's interrupt syncronisation patch
(https://patchwork.kernel.org/patch/94670)

Changes since v7:
* Removed the 'fix race condition between DMA and HSMMC callback'
part of the series
* Added memory barries in start and resume sglist transfer for cpu
buffer syncronization
* Cleanup and comments

This has been tested on OMAP3430, OMAP3630 and OMAP4430 SDP for MMC file transfer and as boot file system.

Venkatraman S:
sDMA: descriptor autoloading feature
MMC: omap hsmmc adoption of descriptor autoloading feature

 arch/arm/plat-omap/dma.c              |  289 ++++++++++++++++++++++++++++++++-
 arch/arm/plat-omap/include/plat/dma.h |  170 +++++++++++++++++++
 drivers/mmc/host/omap_hsmmc.c         |  148 ++++++++++++++---
 3 files changed, 583 insertions(+), 24 deletions(-)
#1 lore raw

v8 cover sDMA descriptor autoloading feature

Quoted 33 lines

-----Original Message-----
From: svenkatr at gmail.com [mailto:svenkatr at gmail.com] On Behalf Of Venkatraman S
Sent: Thursday, April 29, 2010 12:35 PM
To: linux-omap at vger.kernel.org; linux-mmc at vger.kernel.org; linux-arm- kernel at lists.infradead.org
Cc: Madhusudhan Chikkature; Tony Lindgren; Adrian Hunter; Santosh Shilimkar
Subject: [PATCH v8 0/2] sDMA descriptor autoloading feature

This patch series is the introduction of new sDMA feature: descriptor
autoloading (v8) and it's adoption by the OMAP HSMMC driver.

The previous version (v7) was blocked on achieving proper interrupt
syncronisation
between the MMC and DMA callback in the HSMMC driver.
Thanks to Adrian Hunter's patch,
https://patchwork.kernel.org/patch/94670/
this has been cleaned up.

Current version is based on for-next branch + Adrian Hunter's interrupt syncronisation patch
(https://patchwork.kernel.org/patch/94670)

Changes since v7:
* Removed the 'fix race condition between DMA and HSMMC callback'
part of the series
* Added memory barries in start and resume sglist transfer for cpu
buffer syncronization
* Cleanup and comments

Quoted 3 lines

This has been tested on OMAP3430, OMAP3630 and OMAP4430 SDP for MMC file transfer and as boot file system.

The HSMMC driver changes look good to me. I can ACK that but am not a DMA expert to review your changes to the DMA driver.

Quoted 9 lines

Venkatraman S:
sDMA: descriptor autoloading feature
MMC: omap hsmmc adoption of descriptor autoloading feature

 arch/arm/plat-omap/dma.c              |  289
++++++++++++++++++++++++++++++++-
 arch/arm/plat-omap/include/plat/dma.h |  170 +++++++++++++++++++
 drivers/mmc/host/omap_hsmmc.c         |  148 ++++++++++++++---
 3 files changed, 583 insertions(+), 24 deletions(-)
#2 lore raw

v8 cover sDMA descriptor autoloading feature

Quoted 31 lines · Madhusudhan
Quoted 31 lines

-----Original Message-----
From: svenkatr at gmail.com [mailto:svenkatr at gmail.com] On Behalf Of Venkatraman S
Sent: Thursday, April 29, 2010 12:35 PM
To: linux-omap at vger.kernel.org; linux-mmc at vger.kernel.org; linux-arm- kernel at lists.infradead.org
Cc: Madhusudhan Chikkature; Tony Lindgren; Adrian Hunter; Santosh Shilimkar
Subject: [PATCH v8 0/2] sDMA descriptor autoloading feature

? ? This patch series is the introduction of new sDMA feature: descriptor autoloading (v8) and it's adoption by the OMAP HSMMC driver.

? ?The previous version (v7) was blocked on achieving proper interrupt syncronisation
between the MMC and DMA callback in the HSMMC driver.
? Thanks to Adrian Hunter's patch,
https://patchwork.kernel.org/patch/94670/
this has been cleaned up.

Current version is based on for-next branch + Adrian Hunter's interrupt syncronisation patch
(https://patchwork.kernel.org/patch/94670)

Changes since v7:
? * Removed the 'fix race condition between DMA and HSMMC callback' part of the series
? * Added memory barries in start and resume sglist transfer for cpu buffer syncronization
? * Cleanup and comments

Quoted 7 lines
Quoted 3 lines

This has been tested on OMAP3430, OMAP3630 and OMAP4430 SDP for MMC file transfer and as boot file system.

The HSMMC driver changes look good to me. I can ACK that but am not a DMA expert to review your changes to the DMA driver.

Thanks. Can you please add your acked-by to 2/2 of this series so that patchworks can pick it up.

Regards,
Venkat.

#3 lore raw

v8 cover sDMA descriptor autoloading feature

Quoted 8 lines

-----Original Message-----
From: svenkatr at gmail.com [mailto:svenkatr at gmail.com] On Behalf Of S, Venkatraman
Sent: Wednesday, May 05, 2010 10:09 AM
To: Chikkature Rajashekar, Madhusudhan
Cc: linux-omap at vger.kernel.org; linux-mmc at vger.kernel.org; linux-arm-kernel at lists.infradead.org; Tony Lindgren; Adrian Hunter; Shilimkar, Santosh
Subject: Re: [PATCH v8 0/2] sDMA descriptor autoloading feature

Quoted 39 lines
Quoted 38 lines · Madhusudhan
Quoted 31 lines

-----Original Message-----
From: svenkatr at gmail.com [mailto:svenkatr at gmail.com] On Behalf Of Venkatraman S
Sent: Thursday, April 29, 2010 12:35 PM
To: linux-omap at vger.kernel.org; linux-mmc at vger.kernel.org; linux-arm- kernel at lists.infradead.org
Cc: Madhusudhan Chikkature; Tony Lindgren; Adrian Hunter; Santosh Shilimkar
Subject: [PATCH v8 0/2] sDMA descriptor autoloading feature

? ? This patch series is the introduction of new sDMA feature: descriptor autoloading (v8) and it's adoption by the OMAP HSMMC driver.

? ?The previous version (v7) was blocked on achieving proper interrupt syncronisation
between the MMC and DMA callback in the HSMMC driver.
? Thanks to Adrian Hunter's patch,
https://patchwork.kernel.org/patch/94670/
this has been cleaned up.

Current version is based on for-next branch + Adrian Hunter's interrupt syncronisation patch
(https://patchwork.kernel.org/patch/94670)

Changes since v7:
? * Removed the 'fix race condition between DMA and HSMMC callback' part of the series
? * Added memory barries in start and resume sglist transfer for cpu buffer syncronization
? * Cleanup and comments

Quoted 3 lines

This has been tested on OMAP3430, OMAP3630 and OMAP4430 SDP for MMC file transfer and as boot file system.

The HSMMC driver changes look good to me. I can ACK that but am not a DMA expert to review your changes to the DMA driver.

Venkat,
Sorry for late comments on your series.

#4 lore raw

v8 cover sDMA descriptor autoloading feature

In reply to Venkatraman S

Hi Venkatraman,

Quoted 20 lines · Venkatraman S

This patch series is the introduction of new sDMA feature: descriptor
autoloading (v8) and it's adoption by the OMAP HSMMC driver.

The previous version (v7) was blocked on achieving proper interrupt
syncronisation
between the MMC and DMA callback in the HSMMC driver.
Thanks to Adrian Hunter's patch, https://patchwork.kernel.org/patch/94670/
this has been cleaned up.

Current version is based on for-next branch + Adrian Hunter's interrupt syncronisation patch
(https://patchwork.kernel.org/patch/94670)

Changes since v7:
* Removed the 'fix race condition between DMA and HSMMC callback'
part of the series
* Added memory barries in start and resume sglist transfer for cpu
buffer syncronization
* Cleanup and comments

Quoted 2 lines

This has been tested on OMAP3430, OMAP3630 and OMAP4430 SDP for MMC file transfer and as boot file system.

The comments on this patchset were positive apart from some stylistic changes -- would you like to resubmit a new patch?

Thanks,

Signature · 2 lines
Chris Ball   <[email protected]>   <http://printf.net/>
One Laptop Per Child