Skip to contentSkip to conversation

nvme: set NCC and NIC effects for NS mgmt and attach

PATCH In review Tokunori Ikegami 2 participants 3 messages Apr 18 – Apr 22 NVMe

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 nvme: set NCC and NIC effects for NS mgmt and attach

This is to make sure scan_work done for the commands.

---
 drivers/nvme/host/core.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/nvme/host/core.c +3 -1
index 1f973d88c830..1ed1fc866f3f 100644
@@ -3448,8 +3448,10 @@ static int nvme_init_effects_log(struct nvme_ctrl *ctrl,
 
 static void nvme_init_known_nvm_effects(struct nvme_ctrl *ctrl)
 {
-	struct nvme_effects_log	*log = ctrl->effects;
+	struct nvme_effects_log *log = ctrl->effects;
 
+	log->acs[nvme_admin_ns_mgmt] |= cpu_to_le32(NVME_CMD_EFFECTS_NCC);
+	log->acs[nvme_admin_ns_attach] |= cpu_to_le32(NVME_CMD_EFFECTS_NIC);
 	log->acs[nvme_admin_format_nvm] |= cpu_to_le32(NVME_CMD_EFFECTS_LBCC |
 						NVME_CMD_EFFECTS_NCC |
 						NVME_CMD_EFFECTS_CSE_MASK);
Signature · 1 line
2.51.0
#1 lore raw
Quoted 1 line · Tokunori Ikegami

This is to make sure scan_work done for the commands.

The subject here looks mistleading and the commit message is way to spare.

#2 lore raw
Quoted 2 lines · Christoph Hellwig

The subject here looks mistleading and the commit message is way to spare.

I will do update the commit subject and message. Thank you.