Skip to contentSkip to conversation

ARM: dts: Explicitly set dr_mode on exynos5250-snow

PATCH New Sjoerd Simons 3 participants 3 messages Nov 14, 2014 – Nov 16, 2014

Subsystems (2)
Device tree bindings Arm Samsung Exynos
lore
Share & tools
lore

Sjoerd Simons

author
#0 lore raw

PATCH 1/1 ARM: dts: Explicitly set dr_mode on exynos5250-snow

Explicitly set the dr_mode for the dwc3 controller on the Snow board to host mode. This is required to ensure the controller is initialized in the right mode if the kernel is build with USB gadget support.

Signed-off-by Sjoerd Simons <[email protected]>
---
 arch/arm/boot/dts/exynos5250-snow.dts | 4 ++++
 arch/arm/boot/dts/exynos5250.dtsi     | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)
arch/arm/boot/dts/exynos5250-snow.dts +4 -0
index e51fcef..60429ad 100644
@@ -624,4 +624,8 @@
 	num-cs = <1>;
 };
 
+&usbdrd_dwc3 {
+	dr_mode = "host";
+};
+
 #include "cros-ec-keyboard.dtsi"
arch/arm/boot/dts/exynos5250.dtsi +1 -1
index f21b9aa..d55c1a2 100644
@@ -555,7 +555,7 @@
 		#size-cells = <1>;
 		ranges;
 
-		dwc3 {
+		usbdrd_dwc3: dwc3 {
 			compatible = "synopsys,dwc3";
 			reg = <0x12000000 0x10000>;
 			interrupts = <0 72 0>;
Signature · 1 line
2.1.3
#1 lore raw

PATCH 1/1 ARM: dts: Explicitly set dr_mode on exynos5250-snow

Hello Sjoerd,

Quoted 4 lines · Sjoerd Simons

Explicitly set the dr_mode for the dwc3 controller on the Snow board to host mode. This is required to ensure the controller is initialized in the right mode if the kernel is build with USB gadget support.

The patch looks good to me.

Reviewed-by Javier Martinez Canillas <[email protected]>

Kukjin,

I think $subject is -rc material since this issue is seen after commit 508423b ("ARM: exynos_defconfig: enable USB gadget support") which landed in 3.18.

Best regards,
Javier

#2 lore raw

PATCH 1/1 ARM: dts: Explicitly set dr_mode on exynos5250-snow

Quoted 3 lines · Javier Martinez Canillas

Hello Sjoerd,

Hi,

Quoted 9 lines
Quoted 4 lines · Sjoerd Simons

Explicitly set the dr_mode for the dwc3 controller on the Snow board to host mode. This is required to ensure the controller is initialized in the right mode if the kernel is build with USB gadget support.

The patch looks good to me.

Quoted 8 lines
Reviewed-by Javier Martinez Canillas <[email protected]>

Kukjin,

I think $subject is -rc material since this issue is seen after commit 508423b ("ARM: exynos_defconfig: enable USB gadget support") which landed in 3.18.

Yeah, you're right. I'll queue this into -fixes for 3.18.

Thanks,
Kukjin