ARM: Samsung: Don't use the mach/gpio.h directly
Subsystems (2)
PATCH 2/3 ARM: Samsung: Don't use the mach/gpio.h directly
Use the linux/gpio.h. also fix the build error since new C preprocessor directives.
--- arch/arm/plat-samsung/gpiolib.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/plat-samsung/gpiolib.c +1 -1
@@ -18,7 +18,7 @@#include <linux/kernel.h> #include <linux/irq.h> #include <linux/io.h> -#include <mach/gpio.h> +#include <linux/gpio.h> #include <plat/gpio-core.h> #include <plat/gpio-cfg.h> #include <plat/gpio-cfg-helpers.h>
Signature · 1 line
1.5.3.3
PATCH 2/3 ARM: Samsung: Don't use the mach/gpio.h directly
Quoted 2 lines · Kyungmin Park
Use the
linux/gpio.h. also fix the build error since new C preprocessor
directives.
Cc'ed Ben Dooks.
Review
Quoted 7 lines
Signed-off-by Kyungmin Park <[email protected]>--- arch/arm/plat-samsung/gpiolib.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)(quoted diff) +0
-0
b/arch/arm/plat-samsung/gpiolib.c
arch/arm/plat-samsung/gpiolib.c line 21
Quoted 9 lines
index 8a8ba8b..c354089 100644
arch/arm/plat-samsung/gpiolib.c +1
-1@@ -18,7 +18,7 @@#include <linux/kernel.h> #include <linux/irq.h> #include <linux/io.h> -#include <mach/gpio.h> +#include <linux/gpio.h>
Only here?
If required, should be fixed all.
And...as I said, then I will fix...
arch/arm/plat-samsung/gpiolib.c
Quoted 4 lines
arch/arm/plat-samsung/gpiolib.c +0
-1#include <plat/gpio-core.h> #include <plat/gpio-cfg.h> #include <plat/gpio-cfg-helpers.h> --
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.
PATCH 2/3 ARM: Samsung: Don't use the mach/gpio.h directly
Quoted 14 lines · Kukjin Kim
Quoted 2 lines · Kyungmin Park
Use the
linux/gpio.h. also fix the build error since new C preprocessordirectives.
Cc'ed Ben Dooks.
Review
Quoted 7 lines
Signed-off-by Kyungmin Park <[email protected]>---
?arch/arm/plat-samsung/gpiolib.c | ? ?2 +-
?1 files changed, 1 insertions(+), 1 deletions(-)(quoted diff) +0
-0
b/arch/arm/plat-samsung/gpiolib.c
Quoted 11 lines
arch/arm/plat-samsung/gpiolib.c line 21
Quoted 9 lines
index 8a8ba8b..c354089 100644
arch/arm/plat-samsung/gpiolib.c +0
-0@@ -18,7 +18,7 @@?#include <
linux/kernel.h>
?#include <linux/irq.h>
?#include <linux/io.h>arch/arm/plat-samsung/gpiolib.c +1
-1-#include <mach/gpio.h> +#include <linux/gpio.h> Only here?
No a lots of places.
Quoted 3 lines
If required, should be fixed all.
And...as I said, then I will fix...
No problem.
Quoted 20 lines
Quoted 5 lines
?#include <
plat/gpio-core.h>
?#include <plat/gpio-cfg.h>
?#include <plat/gpio-cfg-helpers.h>
--Thanks.
Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd._______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
PATCH 2/3 ARM: Samsung: Don't use the mach/gpio.h directly
In reply to Kyungmin ParkQuoted 3 lines · Kyungmin Park
Use the
linux/gpio.h. also fix the build error since new C preprocessor directives.Signed-off-by Kyungmin Park <[email protected]>
Quoted 17 lines
--- arch/arm/plat-samsung/gpiolib.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)arch/arm/plat-samsung/gpiolib.c +1
-1@@ -18,7 +18,7 @@#include <linux/kernel.h> #include <linux/irq.h> #include <linux/io.h> -#include <mach/gpio.h> +#include <linux/gpio.h> #include <plat/gpio-core.h> #include <plat/gpio-cfg.h> #include <plat/gpio-cfg-helpers.h>
PATCH 2/3 ARM: Samsung: Don't use the mach/gpio.h directly
Quoted 3 lines · Ben Dooks
Quoted 1 line · Kyungmin Park
Use the
linux/gpio.h. also fix the build error since new C preprocessor
directives.
Quoted 3 lines
Quoted 2 lines
Signed-off-by Kyungmin Park <[email protected]>Acked-by Ben Dooks <[email protected]>
Ok...will apply this into my tree.
Quoted 5 lines
Review
Quoted 5 lines
--- arch/arm/plat-samsung/gpiolib.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)(quoted diff) +0
-0
b/arch/arm/plat-samsung/gpiolib.c
Quoted 4 lines
Quoted 4 lines
index 8a8ba8b..c354089 100644
arch/arm/plat-samsung/gpiolib.c +0
-0@@ -18,7 +18,7 @@
Quoted 8 lines
arch/arm/plat-samsung/gpiolib.c line 24
Quoted 8 lines
arch/arm/plat-samsung/gpiolib.c +1
-1#include <linux/kernel.h> #include <linux/irq.h> #include <linux/io.h> -#include <mach/gpio.h> +#include <linux/gpio.h> #include <plat/gpio-core.h> #include <plat/gpio-cfg.h> #include <plat/gpio-cfg-helpers.h>
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.