Revert "arm: config: fix default console only to specify the device"
A message that is not in the archive (sent off-list or not yet received): CGME20181120055439epcas1p460e750af3671334317b1c14cdb4abf99@epcas1p4.samsung.com
PATCH 1/1 Revert "arm: config: fix default console only to specify the device"
This reverts commit 232ed3ca534708527a9515c7c41bc3542949525c.
In exynos boards, ${console} is used to set bootargs but it sets without "console=", so CONFIG_DEFAULT_CONSOLE for these boards is designated with "console=" but it is removed. So revert the commit.
References for using ${console} in
board/samsung/common/bootscripts/autoboot.cmd
board/samsung/common/bootscripts/bootzimg.cmd
--- include/configs/odroid.h | 4 ++-- include/configs/odroid_xu3.h | 4 ++-- include/configs/s5p_goni.h | 4 ++-- include/configs/s5pc210_universal.h | 4 ++-- include/configs/trats.h | 4 ++-- include/configs/trats2.h | 4 ++-- 6 files changed, 12 insertions(+), 12 deletions(-)
include/configs/odroid.h +2 -2
@@ -40,7 +40,7 @@/* Console configuration */ #define CONFIG_BOOTCOMMAND "run distro_bootcmd ; run autoboot" -#define CONFIG_DEFAULT_CONSOLE "ttySAC1,115200n8" +#define CONFIG_DEFAULT_CONSOLE "console=ttySAC1,115200n8\0"#define CONFIG_SYS_INIT_SP_ADDR (CONFIG_SYS_LOAD_ADDR \ - GENERATED_GBL_DATA_SIZE)
@@ -157,7 +157,7 @@"elif test -e mmc 0 uImage; then; " \"run boot_uimg;" \"fi;\0" \ -"console=" CONFIG_DEFAULT_CONSOLE "\0" \ +"console=" CONFIG_DEFAULT_CONSOLE \"mmcbootdev=0\0" \"mmcbootpart=1\0" \"mmcrootdev=0\0" \
include/configs/odroid_xu3.h +2 -2
@@ -30,7 +30,7 @@#define CONFIG_SYS_INIT_SP_ADDR (CONFIG_SYS_LOAD_ADDR - 0x1000000) -#define CONFIG_DEFAULT_CONSOLE "ttySAC2,115200n8" +#define CONFIG_DEFAULT_CONSOLE "console=ttySAC2,115200n8\0"/* USB */ #define CONFIG_USB_EHCI_EXYNOS
@@ -99,7 +99,7 @@MEM_LAYOUT_ENV_SETTINGS \ BOOTENV \"rootfstype=ext4\0" \ -"console=" CONFIG_DEFAULT_CONSOLE "\0" \ +"console=" CONFIG_DEFAULT_CONSOLE \"fdtfile=exynos5422-odroidxu3.dtb\0" \"boardname=odroidxu3\0" \"mmcbootdev=0\0" \
include/configs/s5p_goni.h +2 -2
@@ -87,7 +87,7 @@#define CONFIG_BOOTCOMMAND "run mmcboot" -#define CONFIG_DEFAULT_CONSOLE "ttySAC2,115200n8" +#define CONFIG_DEFAULT_CONSOLE "console=ttySAC2,115200n8\0"#define CONFIG_RAMDISK_BOOT "root=/dev/ram0 rw rootfstype=ext4" \ " ${console} ${meminfo}"
@@ -134,7 +134,7 @@"bootchart=set opts init=/sbin/bootchartd; run bootcmd\0" \"verify=n\0" \"rootfstype=ext4\0" \ -"console=" CONFIG_DEFAULT_CONSOLE "\0" \ +"console=" CONFIG_DEFAULT_CONSOLE \"meminfo=mem=80M mem=256M at 0x40000000 mem=128M at 0x50000000\0" \"loaduimage=ext4load mmc ${mmcdev}:${mmcbootpart} 0x30007FC0 uImage\0" \"mmcdev=0\0" \
include/configs/s5pc210_universal.h +2 -2
@@ -27,7 +27,7 @@/* Console configuration */ #define CONFIG_BOOTCOMMAND "run mmcboot" -#define CONFIG_DEFAULT_CONSOLE "ttySAC1,115200n8" +#define CONFIG_DEFAULT_CONSOLE "console=ttySAC1,115200n8\0"#define CONFIG_SYS_INIT_SP_ADDR (CONFIG_SYS_LOAD_ADDR \ - GENERATED_GBL_DATA_SIZE)
@@ -108,7 +108,7 @@"mmcoops=mmc read 0 0x40000000 0x40 8; md 0x40000000 0x400\0" \"verify=n\0" \"rootfstype=ext4\0" \ -"console=" CONFIG_DEFAULT_CONSOLE "\0" \ +"console=" CONFIG_DEFAULT_CONSOLE \"mtdparts=" CONFIG_MTDPARTS_DEFAULT \"mbrparts=" MBRPARTS_DEFAULT \"meminfo=crashkernel=32M at 0x50000000\0" \
include/configs/trats.h +2 -2
@@ -36,7 +36,7 @@#define CONFIG_MACH_TYPE MACH_TYPE_TRATS#define CONFIG_BOOTCOMMAND "run autoboot" -#define CONFIG_DEFAULT_CONSOLE "ttySAC2,115200n8" +#define CONFIG_DEFAULT_CONSOLE "console=ttySAC2,115200n8\0"#define CONFIG_SYS_INIT_SP_ADDR (CONFIG_SYS_LOAD_ADDR \ - GENERATED_GBL_DATA_SIZE)
@@ -120,7 +120,7 @@"mmcoops=mmc read 0 0x40000000 0x40 8; md 0x40000000 0x400\0" \"verify=n\0" \"rootfstype=ext4\0" \ -"console=" CONFIG_DEFAULT_CONSOLE "\0" \ +"console=" CONFIG_DEFAULT_CONSOLE \"meminfo=crashkernel=32M at 0x50000000\0" \"nfsroot=/nfsroot/arm\0" \"bootblock=" CONFIG_BOOTBLOCK "\0" \
include/configs/trats2.h +2 -2
@@ -34,7 +34,7 @@/* Console configuration */ #define CONFIG_BOOTCOMMAND "run autoboot" -#define CONFIG_DEFAULT_CONSOLE "ttySAC2,115200n8" +#define CONFIG_DEFAULT_CONSOLE "console=ttySAC2,115200n8\0"#define CONFIG_SYS_INIT_SP_ADDR (CONFIG_SYS_LOAD_ADDR \ - GENERATED_GBL_DATA_SIZE)
@@ -103,7 +103,7 @@"boottrace=setenv opts initcall_debug; run bootcmd\0" \"verify=n\0" \"rootfstype=ext4\0" \ -"console=" CONFIG_DEFAULT_CONSOLE "\0" \ +"console=" CONFIG_DEFAULT_CONSOLE \"kernelname=uImage\0" \"loaduimage=ext4load mmc ${mmcdev}:${mmcbootpart} 0x40007FC0 " \"${kernelname}\0" \
Signature · 1 line
2.19.1
PATCH 1/1 Revert "arm: config: fix default console only to specify the device"
Hi,
Quoted 145 lines · Seung-Woo Kim
This reverts commit
232ed3ca534708527a9515c7c41bc3542949525c.In exynos boards, ${console} is used to set bootargs but it sets without "console=", so
CONFIG_DEFAULT_CONSOLEfor these boards is designated with "console=" but it is removed. So revert the commit.References for using ${console} in
board/samsung/common/bootscripts/autoboot.cmd
board/samsung/common/bootscripts/bootzimg.cmdSigned-off-by Seung-Woo Kim <[email protected]>--- include/configs/odroid.h | 4 ++-- include/configs/odroid_xu3.h | 4 ++-- include/configs/s5p_goni.h | 4 ++-- include/configs/s5pc210_universal.h | 4 ++-- include/configs/trats.h | 4 ++-- include/configs/trats2.h | 4 ++-- 6 files changed, 12 insertions(+), 12 deletions(-)include/configs/odroid.h +2
-2@@ -40,7 +40,7 @@/* Console configuration */ #define CONFIG_BOOTCOMMAND "run distro_bootcmd ; run autoboot" -#define CONFIG_DEFAULT_CONSOLE "ttySAC1,115200n8" +#define CONFIG_DEFAULT_CONSOLE "console=ttySAC1,115200n8\0"#define CONFIG_SYS_INIT_SP_ADDR (CONFIG_SYS_LOAD_ADDR \ - GENERATED_GBL_DATA_SIZE)@@ -157,7 +157,7 @@"elif test -e mmc 0 uImage; then; " \"run boot_uimg;" \"fi;\0" \ -"console=" CONFIG_DEFAULT_CONSOLE "\0" \ +"console=" CONFIG_DEFAULT_CONSOLE \"mmcbootdev=0\0" \"mmcbootpart=1\0" \"mmcrootdev=0\0" \include/configs/odroid_xu3.h +2
-2@@ -30,7 +30,7 @@#define CONFIG_SYS_INIT_SP_ADDR (CONFIG_SYS_LOAD_ADDR - 0x1000000) -#define CONFIG_DEFAULT_CONSOLE "ttySAC2,115200n8" +#define CONFIG_DEFAULT_CONSOLE "console=ttySAC2,115200n8\0"/* USB */ #define CONFIG_USB_EHCI_EXYNOS @@ -99,7 +99,7 @@MEM_LAYOUT_ENV_SETTINGS \ BOOTENV \"rootfstype=ext4\0" \ -"console=" CONFIG_DEFAULT_CONSOLE "\0" \ +"console=" CONFIG_DEFAULT_CONSOLE \"fdtfile=exynos5422-odroidxu3.dtb\0" \"boardname=odroidxu3\0" \"mmcbootdev=0\0" \include/configs/s5p_goni.h +2
-2@@ -87,7 +87,7 @@#define CONFIG_BOOTCOMMAND "run mmcboot" -#define CONFIG_DEFAULT_CONSOLE "ttySAC2,115200n8" +#define CONFIG_DEFAULT_CONSOLE "console=ttySAC2,115200n8\0"#define CONFIG_RAMDISK_BOOT "root=/dev/ram0 rw rootfstype=ext4" \ " ${console} ${meminfo}"@@ -134,7 +134,7 @@"bootchart=set opts init=/sbin/bootchartd; run bootcmd\0" \"verify=n\0" \"rootfstype=ext4\0" \ -"console=" CONFIG_DEFAULT_CONSOLE "\0" \ +"console=" CONFIG_DEFAULT_CONSOLE \"meminfo=mem=80M mem=256M at 0x40000000 mem=128M at 0x50000000\0" \"loaduimage=ext4load mmc ${mmcdev}:${mmcbootpart} 0x30007FC0 uImage\0" \"mmcdev=0\0" \include/configs/s5pc210_universal.h +2
-2@@ -27,7 +27,7 @@/* Console configuration */ #define CONFIG_BOOTCOMMAND "run mmcboot" -#define CONFIG_DEFAULT_CONSOLE "ttySAC1,115200n8" +#define CONFIG_DEFAULT_CONSOLE "console=ttySAC1,115200n8\0"#define CONFIG_SYS_INIT_SP_ADDR (CONFIG_SYS_LOAD_ADDR \ - GENERATED_GBL_DATA_SIZE)@@ -108,7 +108,7 @@"mmcoops=mmc read 0 0x40000000 0x40 8; md 0x40000000 0x400\0" \"verify=n\0" \"rootfstype=ext4\0" \ -"console=" CONFIG_DEFAULT_CONSOLE "\0" \ +"console=" CONFIG_DEFAULT_CONSOLE \"mtdparts=" CONFIG_MTDPARTS_DEFAULT \"mbrparts=" MBRPARTS_DEFAULT \"meminfo=crashkernel=32M at 0x50000000\0" \include/configs/trats.h +2
-2@@ -36,7 +36,7 @@#define CONFIG_MACH_TYPE MACH_TYPE_TRATS#define CONFIG_BOOTCOMMAND "run autoboot" -#define CONFIG_DEFAULT_CONSOLE "ttySAC2,115200n8" +#define CONFIG_DEFAULT_CONSOLE "console=ttySAC2,115200n8\0"#define CONFIG_SYS_INIT_SP_ADDR (CONFIG_SYS_LOAD_ADDR \ - GENERATED_GBL_DATA_SIZE)@@ -120,7 +120,7 @@"mmcoops=mmc read 0 0x40000000 0x40 8; md 0x40000000 0x400\0" \"verify=n\0" \"rootfstype=ext4\0" \ -"console=" CONFIG_DEFAULT_CONSOLE "\0" \ +"console=" CONFIG_DEFAULT_CONSOLE \"meminfo=crashkernel=32M at 0x50000000\0" \"nfsroot=/nfsroot/arm\0" \"bootblock=" CONFIG_BOOTBLOCK "\0" \include/configs/trats2.h +1
-1@@ -34,7 +34,7 @@/* Console configuration */ #define CONFIG_BOOTCOMMAND "run autoboot" -#define CONFIG_DEFAULT_CONSOLE "ttySAC2,115200n8" +#define CONFIG_DEFAULT_CONSOLE "console=ttySAC2,115200n8\0"#define CONFIG_SYS_INIT_SP_ADDR (CONFIG_SYS_LOAD_ADDR \ - GENERATED_GBL_DATA_SIZE)
include/configs/trats2.h line 109
Quoted 8 lines
include/configs/trats2.h +1
-1@@ -103,7 +103,7 @@"boottrace=setenv opts initcall_debug; run bootcmd\0" \"verify=n\0" \"rootfstype=ext4\0" \ -"console=" CONFIG_DEFAULT_CONSOLE "\0" \ +"console=" CONFIG_DEFAULT_CONSOLE \"kernelname=uImage\0" \"loaduimage=ext4load mmc ${mmcdev}:${mmcbootpart} 0x40007FC0 " \"${kernelname}\0" \
I agree with that we did not consider about side effect of this patch. So, applied to u-boot-samsung.
@ Dongjin Kim,
I'm sorry to revert your patch because you missed some boards and scripts. Please check and send new patch.
Thanks,
Minkyu Kang.
PATCH 1/1 Revert "arm: config: fix default console only to specify the device"
In reply to Seung-Woo KimHi Seung-Woo,
Quoted 154 lines · Seung-Woo Kim
This reverts commit
232ed3ca534708527a9515c7c41bc3542949525c.In exynos boards, ${console} is used to set bootargs but it sets without "console=", so
CONFIG_DEFAULT_CONSOLEfor these boards is designated with "console=" but it is removed. So revert the commit.References for using ${console} in
board/samsung/common/bootscripts/autoboot.cmd
board/samsung/common/bootscripts/bootzimg.cmdSigned-off-by Seung-Woo Kim <[email protected]>--- include/configs/odroid.h | 4 ++-- include/configs/odroid_xu3.h | 4 ++-- include/configs/s5p_goni.h | 4 ++-- include/configs/s5pc210_universal.h | 4 ++-- include/configs/trats.h | 4 ++-- include/configs/trats2.h | 4 ++-- 6 files changed, 12 insertions(+), 12 deletions(-)include/configs/odroid.h +2
-2@@ -40,7 +40,7 @@/* Console configuration */ #define CONFIG_BOOTCOMMAND "run distro_bootcmd ; run autoboot" -#define CONFIG_DEFAULT_CONSOLE "ttySAC1,115200n8" +#define CONFIG_DEFAULT_CONSOLE "console=ttySAC1,115200n8\0"#define CONFIG_SYS_INIT_SP_ADDR (CONFIG_SYS_LOAD_ADDR \ - GENERATED_GBL_DATA_SIZE)@@ -157,7 +157,7 @@"elif test -e mmc 0 uImage; then; " \"run boot_uimg;" \"fi;\0" \ -"console=" CONFIG_DEFAULT_CONSOLE "\0" \ +"console=" CONFIG_DEFAULT_CONSOLE \"mmcbootdev=0\0" \"mmcbootpart=1\0" \"mmcrootdev=0\0" \include/configs/odroid_xu3.h +2
-2@@ -30,7 +30,7 @@#define CONFIG_SYS_INIT_SP_ADDR (CONFIG_SYS_LOAD_ADDR - 0x1000000) -#define CONFIG_DEFAULT_CONSOLE "ttySAC2,115200n8" +#define CONFIG_DEFAULT_CONSOLE "console=ttySAC2,115200n8\0"/* USB */ #define CONFIG_USB_EHCI_EXYNOS @@ -99,7 +99,7 @@MEM_LAYOUT_ENV_SETTINGS \ BOOTENV \"rootfstype=ext4\0" \ -"console=" CONFIG_DEFAULT_CONSOLE "\0" \ +"console=" CONFIG_DEFAULT_CONSOLE \"fdtfile=exynos5422-odroidxu3.dtb\0" \"boardname=odroidxu3\0" \"mmcbootdev=0\0" \include/configs/s5p_goni.h +2
-2@@ -87,7 +87,7 @@#define CONFIG_BOOTCOMMAND "run mmcboot" -#define CONFIG_DEFAULT_CONSOLE "ttySAC2,115200n8" +#define CONFIG_DEFAULT_CONSOLE "console=ttySAC2,115200n8\0"#define CONFIG_RAMDISK_BOOT "root=/dev/ram0 rw rootfstype=ext4" \ " ${console} ${meminfo}"@@ -134,7 +134,7 @@"bootchart=set opts init=/sbin/bootchartd; run bootcmd\0" \"verify=n\0" \"rootfstype=ext4\0" \ -"console=" CONFIG_DEFAULT_CONSOLE "\0" \ +"console=" CONFIG_DEFAULT_CONSOLE \"meminfo=mem=80M mem=256M at 0x40000000 mem=128M at 0x50000000\0" \"loaduimage=ext4load mmc ${mmcdev}:${mmcbootpart} 0x30007FC0 uImage\0" \"mmcdev=0\0" \include/configs/s5pc210_universal.h +2
-2@@ -27,7 +27,7 @@/* Console configuration */ #define CONFIG_BOOTCOMMAND "run mmcboot" -#define CONFIG_DEFAULT_CONSOLE "ttySAC1,115200n8" +#define CONFIG_DEFAULT_CONSOLE "console=ttySAC1,115200n8\0"#define CONFIG_SYS_INIT_SP_ADDR (CONFIG_SYS_LOAD_ADDR \ - GENERATED_GBL_DATA_SIZE)@@ -108,7 +108,7 @@"mmcoops=mmc read 0 0x40000000 0x40 8; md 0x40000000 0x400\0" \"verify=n\0" \"rootfstype=ext4\0" \ -"console=" CONFIG_DEFAULT_CONSOLE "\0" \ +"console=" CONFIG_DEFAULT_CONSOLE \"mtdparts=" CONFIG_MTDPARTS_DEFAULT \"mbrparts=" MBRPARTS_DEFAULT \"meminfo=crashkernel=32M at 0x50000000\0" \include/configs/trats.h +2
-2@@ -36,7 +36,7 @@#define CONFIG_MACH_TYPE MACH_TYPE_TRATS#define CONFIG_BOOTCOMMAND "run autoboot" -#define CONFIG_DEFAULT_CONSOLE "ttySAC2,115200n8" +#define CONFIG_DEFAULT_CONSOLE "console=ttySAC2,115200n8\0"#define CONFIG_SYS_INIT_SP_ADDR (CONFIG_SYS_LOAD_ADDR \ - GENERATED_GBL_DATA_SIZE)@@ -120,7 +120,7 @@"mmcoops=mmc read 0 0x40000000 0x40 8; md 0x40000000 0x400\0" \"verify=n\0" \"rootfstype=ext4\0" \ -"console=" CONFIG_DEFAULT_CONSOLE "\0" \ +"console=" CONFIG_DEFAULT_CONSOLE \"meminfo=crashkernel=32M at 0x50000000\0" \"nfsroot=/nfsroot/arm\0" \"bootblock=" CONFIG_BOOTBLOCK "\0" \include/configs/trats2.h +2
-3@@ -34,7 +34,7 @@/* Console configuration */ #define CONFIG_BOOTCOMMAND "run autoboot" -#define CONFIG_DEFAULT_CONSOLE "ttySAC2,115200n8" +#define CONFIG_DEFAULT_CONSOLE "console=ttySAC2,115200n8\0"#define CONFIG_SYS_INIT_SP_ADDR (CONFIG_SYS_LOAD_ADDR \ - GENERATED_GBL_DATA_SIZE)@@ -103,7 +103,7 @@"boottrace=setenv opts initcall_debug; run bootcmd\0" \"verify=n\0" \"rootfstype=ext4\0" \ -"console=" CONFIG_DEFAULT_CONSOLE "\0" \ +"console=" CONFIG_DEFAULT_CONSOLE \"kernelname=uImage\0" \"loaduimage=ext4load mmc ${mmcdev}:${mmcbootpart} 0x40007FC0 " \"${kernelname}\0" \ --
Quoted 1 line
2.19.1
This revert commit breaks the booting of the Odroid U3 using latest u-boot on ArchLinux.
I have just tried to install archlinux on sdcard and update the latest kernel after compiling the latest u-boot and upgrade.
It fails to boot up at-least their is not console output on the serial port.
[0] https://www.spinics.net/lists/arm-kernel/msg713918.html
I shared the my input on above link.
Can your verify this from your side.
Best Regards
-Anand
PATCH 1/1 Revert "arm: config: fix default console only to specify the device"
Hello Anand,
Quoted 53 lines
-----Original Message-----
From: Anand Moon [mailto:linux.amoon at gmail.com]
Sent: Monday, March 25, 2019 3:45 PM
To: Seung-Woo Kim
Cc: U-Boot Mailing List; Lukasz Majewski
Subject: Re: [U-Boot] [PATCH] Revert "arm: config: fix default console only to specify the device"Hi Seung-Woo,
Quoted 43 lines · Seung-Woo Kim
This reverts commit
232ed3ca534708527a9515c7c41bc3542949525c.In exynos boards, ${console} is used to set bootargs but it sets without "console=", so
CONFIG_DEFAULT_CONSOLEfor these boards is designated with "console=" but it is removed. So revert the commit.References for using ${console} in
board/samsung/common/bootscripts/autoboot.cmd
board/samsung/common/bootscripts/bootzimg.cmdSigned-off-by Seung-Woo Kim <[email protected]>--- include/configs/odroid.h | 4 ++-- include/configs/odroid_xu3.h | 4 ++-- include/configs/s5p_goni.h | 4 ++-- include/configs/s5pc210_universal.h | 4 ++-- include/configs/trats.h | 4 ++-- include/configs/trats2.h | 4 ++-- 6 files changed, 12 insertions(+), 12 deletions(-)include/configs/odroid.h +2
-2@@ -40,7 +40,7 @@/* Console configuration */ #define CONFIG_BOOTCOMMAND "run distro_bootcmd ; run autoboot" -#define CONFIG_DEFAULT_CONSOLE "ttySAC1,115200n8" +#define CONFIG_DEFAULT_CONSOLE "console=ttySAC1,115200n8\0"#define CONFIG_SYS_INIT_SP_ADDR (CONFIG_SYS_LOAD_ADDR \ - GENERATED_GBL_DATA_SIZE)@@ -157,7 +157,7 @@"elif test -e mmc 0 uImage; then; " \"run boot_uimg;" \"fi;\0" \ -"console=" CONFIG_DEFAULT_CONSOLE "\0" \ +"console=" CONFIG_DEFAULT_CONSOLE \"mmcbootdev=0\0" \"mmcbootpart=1\0" \"mmcrootdev=0\0" \
<...>
Quoted 9 lines
Quoted 2 lines
--
2.19.1This revert commit breaks the booting of the Odroid U3 using latest u-boot on ArchLinux.
I have just tried to install archlinux on sdcard and update the latest kernel after compiling the latest u-boot and upgrade.
It fails to boot up at-least their is not console output on the serial port.
Quoted 4 lines
[0] https://www.spinics.net/lists/arm-kernel/msg713918.html
I shared the my input on above link.
Can your verify this from your side.
In my case, it works fine for booting mainline kernel at least. Can you try after "env default -a; saveenv; reset;" command from u-boot prompt? When I cleared env, console in env is "console=console=ttySAC1,115200n8". Please refer below my system console log from odroud-u3.
U-Boot 2019.04-rc4-00051-ge7134b9714 (Mar 26 2019 - 13:00:45 +0900)
CPU: Exynos4412 @ 1 GHz Model: Odroid based on Exynos4412 Type: u3 DRAM: 2 GiB LDO20 at VDDQ_EMMC_1.8V: set 1800000 uV; enabling LDO22 at VDDQ_EMMC_2.8V: set 2800000 uV; enabling LDO21 at TFLASH_2.8V: set 2800000 uV; enabling MMC: sdhci at 12530000 - probe failed: -19
Loading Environment from MMC... OK
Net: No ethernet found. Hit any key to stop autoboot: 0
Odroid #
Odroid #
Odroid # printenv
arch=arm
autoboot=if test -e mmc 0 boot.scr; then; run boot_script; elif test -e mmc 0 Image.itb; then; run boot_fit;elif test -e mmc 0 zImage; then; run boot_zimg;elif test -e mmc 0 uImage; then; run boot_uimg;fi; <...>
console=console=ttySAC1,115200n8
<...>
Environment size: 4657/16380 bytes
Odroid # run autoboot
55205 bytes read in 4 ms (13.2 MiB/s)
8556752 bytes read in 299 ms (27.3 MiB/s)
Kernel image @ 0x41000000 [ 0x000000 - 0x8290d0 ]
## Flattened Device Tree blob at 40800000
Booting using the fdt blob at 0x40800000
Loading Device Tree to 4ffef000, end 4ffff7a4 ... OK
Starting kernel ...
[ 0.000000] Booting Linux on physical CPU 0xa00
Best Regards,
- Seung-Woo Kim
Quoted 3 lines
Best Regards
-Anand
PATCH 1/1 Revert "arm: config: fix default console only to specify the device"
Hi Seung-Woo Kim,
Quoted 109 lines · Seung-Woo Kim
Hello Anand,
Quoted 53 lines
-----Original Message-----
From: Anand Moon [mailto:linux.amoon at gmail.com]
Sent: Monday, March 25, 2019 3:45 PM
To: Seung-Woo Kim
Cc: U-Boot Mailing List; Lukasz Majewski
Subject: Re: [U-Boot] [PATCH] Revert "arm: config: fix default console only to specify the device"Hi Seung-Woo,
Quoted 43 lines · Seung-Woo Kim
This reverts commit
232ed3ca534708527a9515c7c41bc3542949525c.In exynos boards, ${console} is used to set bootargs but it sets without "console=", so
CONFIG_DEFAULT_CONSOLEfor these boards is designated with "console=" but it is removed. So revert the commit.References for using ${console} in
board/samsung/common/bootscripts/autoboot.cmd
board/samsung/common/bootscripts/bootzimg.cmdSigned-off-by Seung-Woo Kim <[email protected]>--- include/configs/odroid.h | 4 ++-- include/configs/odroid_xu3.h | 4 ++-- include/configs/s5p_goni.h | 4 ++-- include/configs/s5pc210_universal.h | 4 ++-- include/configs/trats.h | 4 ++-- include/configs/trats2.h | 4 ++-- 6 files changed, 12 insertions(+), 12 deletions(-)include/configs/odroid.h +2
-2@@ -40,7 +40,7 @@/* Console configuration */ #define CONFIG_BOOTCOMMAND "run distro_bootcmd ; run autoboot" -#define CONFIG_DEFAULT_CONSOLE "ttySAC1,115200n8" +#define CONFIG_DEFAULT_CONSOLE "console=ttySAC1,115200n8\0"#define CONFIG_SYS_INIT_SP_ADDR (CONFIG_SYS_LOAD_ADDR \ - GENERATED_GBL_DATA_SIZE)@@ -157,7 +157,7 @@"elif test -e mmc 0 uImage; then; " \"run boot_uimg;" \"fi;\0" \ -"console=" CONFIG_DEFAULT_CONSOLE "\0" \ +"console=" CONFIG_DEFAULT_CONSOLE \"mmcbootdev=0\0" \"mmcbootpart=1\0" \"mmcrootdev=0\0" \<...>
Quoted 9 lines
Quoted 2 lines
--
2.19.1This revert commit breaks the booting of the Odroid U3 using latest u-boot on ArchLinux.
I have just tried to install archlinux on sdcard and update the latest kernel after compiling the latest u-boot and upgrade.
It fails to boot up at-least their is not console output on the serial port.Quoted 4 lines
[0] https://www.spinics.net/lists/arm-kernel/msg713918.html
I shared the my input on above link.
Can your verify this from your side.In my case, it works fine for booting mainline kernel at least. Can you try after "env default -a; saveenv; reset;" command from u-boot prompt? When I cleared env, console in env is "console=console=ttySAC1,115200n8". Please refer below my system console log from odroud-u3.
U-Boot 2019.04-rc4-00051-ge7134b9714 (Mar 26 2019 - 13:00:45 +0900)
CPU: Exynos4412 @ 1 GHz Model: Odroid based on Exynos4412 Type: u3 DRAM: 2 GiB LDO20 at VDDQ_EMMC_1.8V: set 1800000 uV; enabling LDO22 at VDDQ_EMMC_2.8V: set 2800000 uV; enabling LDO21 at TFLASH_2.8V: set 2800000 uV; enabling MMC: sdhci at 12530000 - probe failed: -19Loading Environment from MMC... OK
Net: No ethernet found. Hit any key to stop autoboot: 0Odroid #
Odroid #
Odroid # printenv
arch=arm
autoboot=if test -e mmc 0 boot.scr; then; runboot_script; elif test -e mmc 0 Image.itb; then; run boot_fit;elif test -e mmc 0 zImage; then; run boot_zimg;elif test -e mmc 0 uImage; then; run boot_uimg;fi; <...>
console=console=ttySAC1,115200n8
<...>
Environment size: 4657/16380 bytes
Odroid # run autoboot
55205 bytes read in 4 ms (13.2 MiB/s)
8556752 bytes read in 299 ms (27.3 MiB/s)
Kernel image @0x41000000[0x000000-0x8290d0]
## Flattened Device Tree blob at 40800000
Booting using the fdt blob at0x40800000
Loading Device Tree to4ffef000, end4ffff7a4... OK
Quoted 7 lines
Starting kernel ...
[ 0.000000] Booting Linux on physical CPU 0xa00Best Regards,
- Seung-Woo Kim
Thanks for your testing.
I will check this again at my end.
Best Regards
-Anand