Skip to contentSkip to conversation

ARM: dts: disable MDMA1 node for Exynos5420

PATCH New Seungwon Jeon 3 participants 3 messages Apr 22, 2014

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 ARM: dts: disable MDMA1 node for Exynos5420

This change places MDMA1 in disabled node for Exynos5420. If MDMA1 region is configured with secure mode, it makes the boot failure with the following on smdk5420 board. ("Unhandled fault: imprecise external abort (0x1406) at 0x00000000") Thus, arndale-octa board don't need to do the same thing anymore.

---
Note: This patch comes from "[PATCH] ARM: dts: disable MDMA1 node for smdk5420 board"

 arch/arm/boot/dts/exynos5420-arndale-octa.dts |   12 ------------
 arch/arm/boot/dts/exynos5420.dtsi             |    7 +++++++
 2 files changed, 7 insertions(+), 12 deletions(-)
arch/arm/boot/dts/exynos5420-arndale-octa.dts +0 -12
index 80a3bf4..896a2a6 100644
@@ -364,16 +364,4 @@
 			gpio-key,wakeup;
 		};
 	};
-
-	amba {
-		mdma1: mdma at 11C10000 {
-			/*
-			 * MDMA1 can support both secure and non-secure
-			 * AXI transactions. When this is enabled in the kernel
-			 * for boards that run in secure mode, we are getting
-			 * imprecise external aborts causing the kernel to oops.
-			 */
-			status = "disabled";
-		};
-	};
 };
arch/arm/boot/dts/exynos5420.dtsi +7 -0
index c3a9a66..97cbcdd 100644
@@ -336,6 +336,13 @@
 			#dma-cells = <1>;
 			#dma-channels = <8>;
 			#dma-requests = <1>;
+			/*
+			 * MDMA1 can support both secure and non-secure
+			 * AXI transactions. When this is enabled in the kernel
+			 * for boards that run in secure mode, we are getting
+			 * imprecise external aborts causing the kernel to oops.
+			 */
+			status = "disabled";
 		};
 	};
 
Signature · 1 line
1.7.0.4
#1 lore raw

PATCH v2 1/1 ARM: dts: disable MDMA1 node for Exynos5420

Quoted 7 lines · Seungwon Jeon

This change places MDMA1 in disabled node for Exynos5420. If MDMA1 region is configured with secure mode, it makes the boot failure with the following on smdk5420 board. ("Unhandled fault: imprecise external abort (0x1406) at 0x00000000") Thus, arndale-octa board don't need to do the same thing anymore.

I've had some problem applying it (wrong EOL?). Not sure if it's my email client. In any case, I've manually fixed the rejects and tested it in my Arndale Octa. It works for me so

#2 lore raw

PATCH v2 1/1 ARM: dts: disable MDMA1 node for Exynos5420

Quoted 11 lines · Javi Merino
Quoted 7 lines · Seungwon Jeon

This change places MDMA1 in disabled node for Exynos5420. If MDMA1 region is configured with secure mode, it makes the boot failure with the following on smdk5420 board. ("Unhandled fault: imprecise external abort (0x1406) at 0x00000000") Thus, arndale-octa board don't need to do the same thing anymore.

I've had some problem applying it (wrong EOL?). Not sure if it's my

Probably, it is due to Seungwon's e-mail client ;-)

Quoted 4 lines

email client. In any case, I've manually fixed the rejects and tested it in my Arndale Octa. It works for me so

Anyway, thanks for your test.

I will apply but I'm not sure this is critical bug or not for smdk5420...

Thanks,
Kukjin