Skip to contentSkip to conversation

ARM: lpc32xx: remove unused header file mach/irqs.h

PATCH New Vladimir Zapolskiy 3 participants 5 messages Sep 8, 2016

Subsystems (3)
Arm (32-bit) Arm sub-architectures Arm/LPC32XX SoC support
lore
Share & tools
lore

Vladimir Zapolskiy

author maintainer
#0 lore raw

PATCH 1/2 ARM: lpc32xx: remove unused header file mach/irqs.h

The removed LPC32xx mach/irqs.h file is not included in any source code, function declaration lpc32xx_init_irq() is also unused, remove them as leftovers after switching to a new interrupt controller driver.

Signed-off-by Vladimir Zapolskiy <[email protected]>
---
 arch/arm/mach-lpc32xx/common.h            |   1 -
 arch/arm/mach-lpc32xx/include/mach/irqs.h | 117 ------------------------------
 2 files changed, 118 deletions(-)
 delete mode 100644 arch/arm/mach-lpc32xx/include/mach/irqs.h
arch/arm/mach-lpc32xx/common.h +0 -1
index 30c9e64..02575c2 100644
@@ -24,7 +24,6 @@
 /*
  * Other arch specific structures and functions
  */
-extern void __init lpc32xx_init_irq(void);
 extern void __init lpc32xx_map_io(void);
 extern void __init lpc32xx_serial_init(void);
arch/arm/mach-lpc32xx/include/mach/irqs.h deleted +0 -117

117 lines not on this page · raw message

Signature · 1 line
2.8.1
author maintainer
#1 lore raw

PATCH 2/2 ARM: lpc32xx: remove unused header file clock.h

The removed clock.h file is a leftover after moving the platform to a common clock framework driver, it contains unused "struct clk" definition, which under circumstances may coalesce with a generic "struct clk" declaration for clock consumers. Also remove useless include of the removed local file from a single source file mach-lpc32xx/pm.c.

Signed-off-by Vladimir Zapolskiy <[email protected]>
---
 arch/arm/mach-lpc32xx/clock.h | 38 --------------------------------------
 arch/arm/mach-lpc32xx/pm.c    |  1 -
 2 files changed, 39 deletions(-)
 delete mode 100644 arch/arm/mach-lpc32xx/clock.h
arch/arm/mach-lpc32xx/clock.h deleted +0 -38
deleted file mode 100644
index c0a8434..0000000
@@ -1,38 +0,0 @@
-/*
- * arch/arm/mach-lpc32xx/clock.h
- *
- * Author: Kevin Wells <[email protected]>
- *
- * Copyright (C) 2010 NXP Semiconductors
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- */
-
-#ifndef __LPC32XX_CLOCK_H
-#define __LPC32XX_CLOCK_H
-
-struct clk {
-	struct list_head node;
-	struct clk *parent;
-	u32 rate;
-	u32 usecount;
-
-	int (*set_rate) (struct clk *, unsigned long);
-	unsigned long (*round_rate) (struct clk *, unsigned long);
-	unsigned long (*get_rate) (struct clk *clk);
-	int (*enable) (struct clk *, int);
-
-	/* Register address and bit mask for simple clocks */
-	void __iomem *enable_reg;
-	u32 enable_mask;
-};
-
-#endif
arch/arm/mach-lpc32xx/pm.c +0 -1
index 207e812..6247157 100644
@@ -73,7 +73,6 @@
 #include <mach/hardware.h>
 #include <mach/platform.h>
 #include "common.h"
-#include "clock.h"
 
 #define TEMP_IRAM_AREA  IO_ADDRESS(LPC32XX_IRAM_BASE)
Signature · 1 line
2.8.1
#2 lore raw

PATCH 2/2 ARM: lpc32xx: remove unused header file clock.h

Quoted 1 line · Vladimir Zapolskiy

The removed clock.h file is a leftover after moving the platform to a

common

Quoted 2 lines

clock framework driver, it contains unused "struct clk" definition, which under circumstances may coalesce with a generic "struct

clk"

Quoted 1 line

declaration for clock consumers. Also remove useless include of the

removed

Quoted 8 lines

local file from a single source file mach-lpc32xx/pm.c.

Signed-off-by Vladimir Zapolskiy <[email protected]>
---
 arch/arm/mach-lpc32xx/clock.h | 38 --------------------------------------
 arch/arm/mach-lpc32xx/pm.c    |  1 -
 2 files changed, 39 deletions(-)
 delete mode 100644 arch/arm/mach-lpc32xx/clock.h

...

Acked-by Sylvain Lemieux <[email protected]>
#3 lore raw

PATCH 1/2 ARM: lpc32xx: remove unused header file mach/irqs.h

In reply to Vladimir Zapolskiy
Quoted 6 lines · CEST Vladimir Zapolskiy

The removed LPC32xx mach/irqs.h file is not included in any source code, function declaration lpc32xx_init_irq() is also unused, remove them as leftovers after switching to a new interrupt controller driver.

Signed-off-by Vladimir Zapolskiy <[email protected]>

Good catch!

Both patches

Acked-by Arnd Bergmann <[email protected]>
#4 lore raw

PATCH 1/2 ARM: lpc32xx: remove unused header file mach/irqs.h

In reply to Vladimir Zapolskiy
Quoted 2 lines · Vladimir Zapolskiy

The removed LPC32xx mach/irqs.h file is not included in any source code, function declaration lpc32xx_init_irq() is also unused, remove them as

leftovers

Quoted 6 lines

after switching to a new interrupt controller driver.

Signed-off-by Vladimir Zapolskiy <[email protected]>
---
 arch/arm/mach-lpc32xx/common.h            |   1 -
 arch/arm/mach-lpc32xx/include/mach/irqs.h | 117

------------------------------

Quoted 3 lines
 2 files changed, 118 deletions(-)
 delete mode 100644 arch/arm/mach-lpc32xx/include/mach/irqs.h

...

Acked-by Sylvain Lemieux <[email protected]>