Skip to contentSkip to conversation

2.4.0-prerelease-ac4: i810_audio.c: Alternate VRA fix

PATCH In review Anwar Payyoorayil 3 participants 3 messages Jan 3, 2001 – Jan 27, 2001

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 2.4.0-prerelease-ac4: i810_audio.c: Alternate VRA fix

Alan -

Based on your suggestion, I looked again, and found that even though the kernel sets VRA, the bit is lost when the driver unnecessarily resets the CODEC. The patch below removes the unnecessary resetting of the CODEC. Nothing seems to be lost by removing the resetting, and the driver in 2.2 series (where VRA works fine) does not do this reset.

If we find that somebody needs this reset, we can move the VRA enabling code after the codec reset code.

Anwar.

Patch against 2.4.0-prerelease-ac4

drivers/sound/i810_audio.c Sat Feb 3 01:26:54 2001 renamed from drivers/sound/i810_audio.c.ac4 Sat Feb 3 01:26:31 2001 +0 -6
@@ -1898,11 +1898,6 @@
        pci_dev->driver_data = card;
        pci_dev->dma_mask = I810_DMA_MASK;
 
-//     printk("resetting codec?\n");
-       outl(0, card->iobase + GLOB_CNT);
-       udelay(500);
-//     printk("bringing it back?\n");
-       outl(1<<1, card->iobase + GLOB_CNT);
        return 0;
 }
-

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
Please read the FAQ at http://www.tux.org/lkml/

#1 lore raw
Quoted 2 lines

If we find that somebody needs this reset, we can move the VRA enabling code after the codec reset code.

Thanks. That now all makes sense
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
Please read the FAQ at http://www.tux.org/lkml/

#2 lore raw

Linux 2.4 hangs on PowerBook 150(m68k)

In reply to Anwar Payyoorayil

Linux 2.4.0 hangs in my PowerBook 150(m68030 without fpu, 8Mb ram, 122Mb HD quantum IDE, adb keyboard and mouse) when it is loading the adb driver(after the scsi driver load).
The 2.2 boot normally, but I can't acess keyboard nor mouse because it does not have adb support...

Thanks
Rafael Diniz
Brazil
=================================================
Conectiva Linux 6.0 (2.2.17) XFree86-4.0.1
PII 233mhz 96Mb ram
SB16, USR56k, S3 VirgeDX/GX 4Mb, CD creative48X
HDa 10Gb Quantum HDb 4.1Gb Fujitsu
MSX2.0 256k MegaRam 256k Mapper 128k Vram
MSX is the future
=================================================
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
Please read the FAQ at http://www.tux.org/lkml/