arm64: dts: k3-j72*: correct compatible for syscon entries
Subsystems (2)
PATCH 1/1 arm64: dts: k3-j72*: correct compatible for syscon entries
Add missing ti,j721e-system-controller to bus defines in mcu/wakeup domains to avoid the following similar warnings from dt-schema checks:
arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dtb: syscon@40f00000: compatible: ['syscon', 'simple-mfd'] is too short'
--- arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi | 2 +- arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi | 2 +- arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)
arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi +1 -1
@@ -35,7 +35,7 @@ k3_reset: reset-controller { }; mcu_conf: syscon@40f00000 { - compatible = "syscon", "simple-mfd"; + compatible = "ti,j721e-system-controller", "syscon", "simple-mfd"; reg = <0x00 0x40f00000 0x00 0x20000>; #address-cells = <1>; #size-cells = <1>;
arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi +1 -1
@@ -35,7 +35,7 @@ k3_reset: reset-controller { }; mcu_conf: syscon@40f00000 { - compatible = "syscon", "simple-mfd"; + compatible = "ti,j721e-system-controller", "syscon", "simple-mfd"; reg = <0x0 0x40f00000 0x0 0x20000>; #address-cells = <1>; #size-cells = <1>;
arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi +1 -1
@@ -69,7 +69,7 @@ wkup_gpio_intr: interrupt-controller@42200000 { }; mcu_conf: syscon@40f00000 { - compatible = "syscon", "simple-mfd"; + compatible = "ti,j721e-system-controller", "syscon", "simple-mfd"; reg = <0x0 0x40f00000 0x0 0x20000>; #address-cells = <1>; #size-cells = <1>;
Signature · 1 line
2.38.0.rc0.52.gdda7228a83
Quoted 17 lines · Matt Ranostay
Add missing ti,j721e-system-controller to bus defines in mcu/wakeup domains to avoid the following similar warnings from dt-schema checks:
arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dtb: syscon@40f00000: compatible: ['syscon', 'simple-mfd'] is too short'Signed-off-by Matt Ranostay <[email protected]>--- arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi | 2 +- arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi | 2 +- arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi +0
-0
arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi k3_reset: reset-controller { · line 38
Quoted 5 lines
arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi +1
-1@@ -35,7 +35,7 @@ k3_reset: reset-controller { }; mcu_conf: syscon@40f00000 { - compatible = "syscon", "simple-mfd"; + compatible = "ti,j721e-system-controller", "syscon", "simple-mfd";
That's a different SoC, so probably you should use dedicated compatible here.
Quoted 21 lines
arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi +0
-0reg = <0x00 0x40f00000 0x00 0x20000>; #address-cells = <1>; #size-cells = <1>;arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi +1
-1@@ -35,7 +35,7 @@ k3_reset: reset-controller { }; mcu_conf: syscon@40f00000 { - compatible = "syscon", "simple-mfd"; + compatible = "ti,j721e-system-controller", "syscon", "simple-mfd"; reg = <0x0 0x40f00000 0x0 0x20000>; #address-cells = <1>; #size-cells = <1>;arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi +0
-0
arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi wkup_gpio_intr: interrupt-controller@42200000 { · line 72
Quoted 5 lines
arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi +1
-1@@ -69,7 +69,7 @@ wkup_gpio_intr: interrupt-controller@42200000 { }; mcu_conf: syscon@40f00000 { - compatible = "syscon", "simple-mfd"; + compatible = "ti,j721e-system-controller", "syscon", "simple-mfd";
Here as wekk - it's a j721s2?
arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi wkup_gpio_intr: interrupt-controller@42200000 { · line 75
Quoted 3 lines
arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi +0
-0reg = <0x0 0x40f00000 0x0 0x20000>; #address-cells = <1>; #size-cells = <1>;
Best regards,
Krzysztof
Quoted 20 lines · Krzysztof Kozlowski
Quoted 19 lines · Matt Ranostay
Add missing ti,j721e-system-controller to bus defines in mcu/wakeup domains to avoid the following similar warnings from dt-schema checks:
arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dtb: syscon@40f00000: compatible: ['syscon', 'simple-mfd'] is too short'Signed-off-by Matt Ranostay <[email protected]>--- arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi | 2 +- arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi | 2 +- arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi +0
-0@@ -35,7 +35,7 @@ k3_reset: reset-controller { };
Quoted 6 lines
arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi k3_reset: reset-controller { · line 38
Quoted 3 lines
arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi +1
-1mcu_conf: syscon@40f00000 { - compatible = "syscon", "simple-mfd"; + compatible = "ti,j721e-system-controller", "syscon", "simple-mfd";That's a different SoC, so probably you should use dedicated compatible here.
Since there isn't any notable difference between these platforms for the simple-mfd controller I'm thinking it maybe makes sense to have a ti,generic-system-controller compatible. Thoughts?
- Matt
Quoted 37 lines
Quoted 22 lines
arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi +0
-0reg = <0x00 0x40f00000 0x00 0x20000>; #address-cells = <1>; #size-cells = <1>;arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi +1
-1@@ -35,7 +35,7 @@ k3_reset: reset-controller { }; mcu_conf: syscon@40f00000 { - compatible = "syscon", "simple-mfd"; + compatible = "ti,j721e-system-controller", "syscon", "simple-mfd"; reg = <0x0 0x40f00000 0x0 0x20000>; #address-cells = <1>; #size-cells = <1>;arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi +0
-0arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi wkup_gpio_intr: interrupt-controller@42200000 { · line 72
Quoted 5 lines
arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi +1
-1@@ -69,7 +69,7 @@ wkup_gpio_intr: interrupt-controller@42200000 { }; mcu_conf: syscon@40f00000 { - compatible = "syscon", "simple-mfd"; + compatible = "ti,j721e-system-controller", "syscon", "simple-mfd";Here as wekk - it's a j721s2?
arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi wkup_gpio_intr: interrupt-controller@42200000 { · line 75
Quoted 3 lines
arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi +0
-0reg = <0x0 0x40f00000 0x0 0x20000>; #address-cells = <1>; #size-cells = <1>;Best regards,
Krzysztof
Quoted 28 lines · Matt Ranostay
Quoted 20 lines · Krzysztof Kozlowski
Quoted 19 lines · Matt Ranostay
Add missing ti,j721e-system-controller to bus defines in mcu/wakeup domains to avoid the following similar warnings from dt-schema checks:
arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dtb: syscon@40f00000: compatible: ['syscon', 'simple-mfd'] is too short'Signed-off-by Matt Ranostay <[email protected]>--- arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi | 2 +- arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi | 2 +- arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi +0
-0@@ -35,7 +35,7 @@ k3_reset: reset-controller { };Quoted 6 lines
arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi k3_reset: reset-controller { · line 38
Quoted 3 lines
arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi +1
-1mcu_conf: syscon@40f00000 { - compatible = "syscon", "simple-mfd"; + compatible = "ti,j721e-system-controller", "syscon", "simple-mfd";That's a different SoC, so probably you should use dedicated compatible here.
Quoted 3 lines
Since there isn't any notable difference between these platforms for the simple-mfd controller I'm thinking it maybe makes sense to have a ti,generic-system-controller compatible. Thoughts?
Compatibles should be specific unless you and TI guarantee that chosen one compatible will cover all future hardware from now till 100 years...
Best regards,
Krzysztof